From patchwork Fri Feb 28 16:54:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A736CC282D2 for ; Fri, 28 Feb 2025 16:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE2C56B009D; Fri, 28 Feb 2025 11:55:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E096B009B; Fri, 28 Feb 2025 11:55:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6EFD280001; Fri, 28 Feb 2025 11:55:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 906456B009A for ; Fri, 28 Feb 2025 11:55:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C355780EED for ; Fri, 28 Feb 2025 16:55:15 +0000 (UTC) X-FDA: 83169953790.10.E2EA6B0 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf12.hostedemail.com (Postfix) with ESMTP id 222AD4000B for ; Fri, 28 Feb 2025 16:54:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VrBo4sPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761699; a=rsa-sha256; cv=none; b=J3gEqQWOnRLFCFeHzwhOLEmSpg9dRNK32PzcYjCBbUesKyzUp4PVjXE/sC3O9FqKFrY+DQ 9Hij32D8MxW5IkZ054y32Cp6pUb0FBrwfhDBcC1iU+5J0hgHnsdnza52UZgJj79OjTGi98 V04c0fn8LUNhjtB5OnGKEJ5UjzNPSNw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VrBo4sPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=1qG3zmXsQuAy3O8EuLFy6gDMX9WVgL72Qoj6jzbLjML1ojCvYxGJCr9WQA1iFm18DOdLGA TF6pzy0oU+aaILheLONtZK7mvgtSjAxPg5Bg4b3KG3gkJvF4/miqqQ1z8mP3QdSEYWCe5h jPIGUHd6dISOa6YP7ZzwVB49Uxu+rLA= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4398e841963so15730895e9.3 for ; Fri, 28 Feb 2025 08:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761698; x=1741366498; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=VrBo4sPOiZjOG0BVaD0xaUFaffR3991c/1Yy+dP03+RZhB0to3Z7NnC/n+8p31Mdna PFkukbYqdbLr7/QBicigYQkpdaJl9b98nbAubCZxGDhz0+/NLmaKB4xcDuvgiLrMFFA9 vi/EjT/xR9mr2wxtT+lQWJfh33k4GRnuNYoA0vsRJwbW/qNI5JkNbZ0izUisy1Onxk9k NpCgatG0UKXYGcTgAx9cSOGkYe1iBm4v6nvXfxmwxA2ONKQrdiIs5JHLSK3cqNs5e3pG 6gJoSJFImlJdB4+PRGQ2vor1mNVk5XPpMS0gjNLlL0sWJ2Ua0kDytr/it0YcV7gazU9J m08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761698; x=1741366498; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=TyQMgf7RJP/k9lL4TQMRcJYVgvzGOfEHESf57WNLSnv1Q3mbrwcee9HBUW6A4zWuRP +mr2oShTr7XY61CoLUV11sMqLe7lOmxj3v5JAVUGqW8Xqk4L7i6/IGiJWfURfyx+zXSY gkgR89+k0k3cyk11V4aXTMTKAT6pCHHCTPe9Vf5OqGlIkRiGoJWagssxumhIp3iBpZY4 T9eWmQk/od+7Q5eg9TKbgc42agUJRnFspEtSLpZ5+eun4lNKuv6UFNRiSc+0lYl88TF2 mSGg8gVt548JBYS/BP2/We+vziIKj16hJsqyR9oCT5dv9rIFkYMP+SUJZScypZ9V8GCb 7aJw== X-Forwarded-Encrypted: i=1; AJvYcCUR04tTUcg8aVEvhd65AynDV1LYo729RLFPXXfaB+SyWaknl21a3r17EJ5z+gfGmu+EG38lMq32YA==@kvack.org X-Gm-Message-State: AOJu0Yy2qZCmiFwgyZORJT/0gzA1tto6sgzLaF8E4Bv9GBxF327LGBDS bW4PIfkSAlJpb82UHeD3D1HNNaEN0g5FjPzmKVRerzwSBTHfqG1CLhEgHfVNMw6eOaZhnDKep9I ZypeSvg1paQ== X-Google-Smtp-Source: AGHT+IHicUU5z+iWE2KYovQO/NyD9BP+fwXrc9YK1TI1vNtv7VrgMEVzfL9fF+5H0fCQp7q+fQoKvN3hnL1mpQ== X-Received: from wmgg6.prod.google.com ([2002:a05:600d:6:b0:439:67c6:5642]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a47:b0:439:969e:d80f with SMTP id 5b1f17b1804b1-43ba6773869mr38269205e9.31.1740761697834; Fri, 28 Feb 2025 08:54:57 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:49 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-1-958e3b6f0203@google.com> Subject: [PATCH v3 01/10] selftests/mm: Report errno when things fail in gup_longterm From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 222AD4000B X-Stat-Signature: 5an9b7psioa6au4re6adz3h4ky3f5gir X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740761698-398039 X-HE-Meta: U2FsdGVkX186ifZqY6kjZFOHfihSPRn4Mh8tQhohFci9Cx/a16eQo4prsNOrzT1rupBykptDaielc5ag7Sw+lj/YdjROlFKPzJhEG4YD3GD/fkm8gC8Cp3QYgXFEd+Z4kHyrtknIGr5sh6CuI8dEeuJoonKBBXVgu2KdcCWh8Og3Milf3sHgBFII/GPpYDko9znJt1MtMd3vymIwQZuSQ95wfrsVyWs4HknlVUr7D4zlF85nXk7bcGYEGLq0Xtgv4VGS/zPbeJe8X0ZzkQaIZxf4lzRWQxWNKy1kuSmS21drNKE2rYbLDKAXWvBpW7nzb4RdiIzulbw+YxEqTsOPeJQ0ZZx7zcs8NchfE0mxvfwsaMwDYRpvP4CA7t9XI+f7Qj3Ekd6KrWohjXI9I1l9XMqDN4lqd1AtAs1FtrBSq0qQMgNAgpi91nDrhbpxURQMCGcEdywn1jONBNslA6/8UCEEZhqQSGlWIb57bqcu7ZyorC/rtcHEWklK0Vev/PP7egq9FbmOPNKh2GMs/Tp8HbOwzC3I0M7+L7TDSQLkVPTSGVr2PBST5QFhizX53JWQl/92EZxbJhgXqG+579irxJ0E9P794qeSi5x9xQW1V83Z8b2bC2JphcVYJ6WfceGYFcr6rzZQ1+Z/D7qyp5y/12gzU6oqh2/I+omT3T/kqmPwsopbtMZqd2TLysAHoNXN9Qz/WJwZp4GTEsTgDVDQc+BpAGoe8yYxR/EoFoalMluSeJI5XF9n0aWCYDzHY/MuM7TipkGaVI3kZBUELq1EoO7ICpE8+bHJICvEzIEPuhtlO+F8LHejgExn/wHGIn7B/X822Bg4xcsL1Ed1B7QDcr2bnpbDgIBHrmamwICoQplmzbcXn00rFEFed4BzT7S1I4aF9TP4FEY2Iq4p5f5dNTpbbt0fEXFFMtw2APEwS0ATljdKKPpyHzTg0A7mLscnma7/fiMZbe5R8ASSqRk jryblwHn ww9Ldx6nwMMy9eDTzdRMHNTtFk75xfbSjGqV9XAKsZarijC/iW68ickUHJIYwWAB1fJDiNWCHmnGOAOVpPikL3lKrQULknG8rFzqbywezBLnQRgpiCjwkF8W+KcAoLzGMBcaZHlbYNxPQFg3Rvq+/TEM/6PeFv0lLbdhXtUs8IrtJ2avG/pBN6NJRDyunb7xrs6YDPHcOJnUr3WJgz6a154F65PxFHRuvAjGSoduYGGMZP5cFYUR4me6oLbRvM6e8CX46ACgu7rzTyVd9/RcAu1bez4Vg5W9BMmcVvG+fwYf3W+pBI+yXcnh72FqFibZr4IdemyZ2nzNFPGOJKuP3CLPIYtyms2uPUPbzyzWZ0/mSschMcD4Dlfe8AFqXjnABaVrARfpUUvyqHoduWXmrIKFnAKysj8CMIzM5HaxpGhN3DoFWfYLmQI7zGMDjbN2y766rMmQ8DCpm5a2kBA0i6FNJ47KdFB0cFE99Ruvy1jbBc7D38/r555LbTjYE9AQVkm7KPLpAet4RSnM+tLw61LNvpCdy++x4lnWRm7WMIwSCkYgM2wd3bSiIExMA5wg8C2ySoiW1grkTA3IN8xvVcMaAASC1eEJsYR3/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.010599, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/gup_longterm.c | 37 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..879e9e4e8cce8127656fabe098abf7db5f6c5e23 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%s)\n", strerror(errno)); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,20 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%s)\n", + strerror(errno)); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%s)\n", + strerror(errno)); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", + strerror(errno)); break; } /* @@ -215,13 +218,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%s)\n", + strerror(errno)); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%s)\n", + strerror(errno)); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +254,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%s)\n", strerror(errno)); return; } @@ -266,13 +271,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%s)\n", strerror(errno)); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%s)\n", strerror(errno)); goto close; } @@ -290,12 +295,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%s)\n", strerror(errno)); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%s)\n", strerror(errno)); goto close; } @@ -317,7 +322,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%s)\n", strerror(errno)); return; }