From patchwork Fri Feb 28 07:58:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 13995828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA5BC19776 for ; Fri, 28 Feb 2025 07:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B391A280003; Fri, 28 Feb 2025 02:58:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC172280002; Fri, 28 Feb 2025 02:58:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B032280003; Fri, 28 Feb 2025 02:58:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7CB8C280002 for ; Fri, 28 Feb 2025 02:58:46 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A35AC046B for ; Fri, 28 Feb 2025 07:58:46 +0000 (UTC) X-FDA: 83168601852.24.A7AE72A Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf12.hostedemail.com (Postfix) with ESMTP id 56E9F4000B for ; Fri, 28 Feb 2025 07:58:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a4goRKM7; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740729524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BK/lHOWMvSnS+WIRroS9/stVhRR6z5AG9NC04iFYhYg=; b=HgfcmrkARNjKIX8BVsNo37sKgU6RUsc8F+wvXru4lrrozmaFx1bD7/PY+ELqlYimUie/Cx JPom4Ubjhnqu3Y4Sjxulk7qQldzIkhNYePMdeyz31A+MTHAme5kbkJXOEfvR3OVNL5BQ/S 6hzvir+y+Kry/ssdLzjdbMxUgvlFgog= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740729524; a=rsa-sha256; cv=none; b=Igy1nBjsX6bEHLmnevRJlILHsbFGGYYrAjdI725EAr1ehmyFUiNgAGoRLTT/v3vqxdrTBk GKxTHyru2y6I32B9U1vnLk7LXlVoJnONdeFC4BVOyFg2qRxFr4TFPIwwzBbS9iRFn5EZkD /BWmhf/VgX+BYDUkdmZfOk2VNfqBDFU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a4goRKM7; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740729521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BK/lHOWMvSnS+WIRroS9/stVhRR6z5AG9NC04iFYhYg=; b=a4goRKM7J4ZIFDTPgn+GjDlc39QJ1F7e412TgXrydAts3sFCMK9dW4A0cowefVceam44tp K3tH5jwmqqjoQI8//8jeZpIbMkvjfX4T0xF1SsSOoa542AKlyodxF5cSdAiGkuD8KaGpJn j3xB5Zl+kCBqKe9Kkn2PM8DhkM1po7Y= From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: [PATCH 3/3] page_counter: reduce struct page_counter size Date: Thu, 27 Feb 2025 23:58:08 -0800 Message-ID: <20250228075808.207484-4-shakeel.butt@linux.dev> In-Reply-To: <20250228075808.207484-1-shakeel.butt@linux.dev> References: <20250228075808.207484-1-shakeel.butt@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 6gq4hgtq7uf9e1zgwx16posrendiujmz X-Rspamd-Queue-Id: 56E9F4000B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740729524-526781 X-HE-Meta: U2FsdGVkX18onp5uAtbIRu/8u60CJl0uud2oCqz9LnXymrgDMrk1y1W0jjyxv+e314+IohQodHFgUBS63D7zhvRcnxm8DyhGFl26pNsEoZ1h7/Kp55Pb6qMn+VRCQNkLs8qB3hGBedn1cGoB7FzmcXZPMb8FjdDbs+CWwZUm72K0xLMedY9MwCI7+MgYQvlEFOqSIFs1VsTRw1mwmpwy6eA//JYbTJJRSQYcxGApljgPt5Bo4dzMEoir3ywYrH7KqoOluwUr5ybthOPKDmh5LmYfdQMGwN4Rjr6jL0ZH0aHAusCxov/3M/7VOMiTVRp9pK9AHgOlkkCfa4m/NidOHHKUNcZeY9yyxXr/CI2R8NWHUxKDvtJdo6//Y+UIKMGga6ilDSHMfOKEN2Kqt70ZHrvhdqS/ySg7kMYPUuDuB0L4K5WKF6TEe3fMYKkYafrstaYzQ34c0axWwc/aa6Dn8L3Ih+UVtxbvP/EONyWwfeBEiK9qQHJF09pNFvLmlmvozlDmlgXJSKgUAeplAytumTSn3hHo4XT31g8QYutHaW7CX5Of2xzYEzsa925FKYwO7T0xU0ODUOXC9VxL8hu74Nq8+CIDiPX9K+K5/unMogdyxpkkWqldAPAfVuEp0C0QGzAUxIqXaNZ9kxmGQiRh3MGPiVYXoyL4Z0oL3dJLe5dnwDWDrfJTNcSIKD/f1cqkwNJvgLAECZHo9lIXR2q/5csZSQWMfRferrlns8IyfnwH+0SQGWiIfTjlyne2z6/MYJDYGD03XhZKHHK4a7HFrLUdN2avU6mfBvJbMYYYVNYwu5HxhzQkLCGOWvR/PDgd6nsHlQuqV86vkCzRO8M9w/lkPeRGA1DHXsWZ7peFQogvhQAAXKiRAMmADpvqWcwjpsR25fzpT64mNNP5cTX2gEpkN+zd7CQud1TGjog5s0FdoxIeNKzbh8vUXQUx1S3XN9jeDXtLCGscuO0equu mvK/G0/7 n6bFJ97+nrvsz0OHOzt4WmjQbvXVjulcAOEInUwuZAuifT6ViL3s4j1h2xorkMs7GD+y/AleheDESbWh49qaho09oyLJMSAh/ug2hx3/9a3fDUAMyT/aMpA4ng6AXGX3lDVKPZNdRPuLtACR4T2VaEPxCOYCxVeCm6F3L5PpJlTggcPWS/ANe3/xmDfAO8Fe1Fxv1Pyf5QFLmTYT8NRXcb8muPEbDzf3uD/D1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The struct page_counter has explicit padding for better cache alignment. The commit c6f53ed8f213a ("mm, memcg: cg2 memory{.swap,}.peak write handlers") added a field to the struct page_counter and accidently increased its size. Let's move the failcnt field which is v1-only field to the same cacheline of usage to reduce the size of struct page_counter. Signed-off-by: Shakeel Butt --- include/linux/page_counter.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h index e4bd8fd427be..d649b6bbbc87 100644 --- a/include/linux/page_counter.h +++ b/include/linux/page_counter.h @@ -9,10 +9,12 @@ struct page_counter { /* - * Make sure 'usage' does not share cacheline with any other field. The - * memcg->memory.usage is a hot member of struct mem_cgroup. + * Make sure 'usage' does not share cacheline with any other field in + * v2. The memcg->memory.usage is a hot member of struct mem_cgroup. */ atomic_long_t usage; + unsigned long failcnt; /* v1-only field */ + CACHELINE_PADDING(_pad1_); /* effective memory.min and memory.min usage tracking */ @@ -28,7 +30,6 @@ struct page_counter { unsigned long watermark; /* Latest cg2 reset watermark */ unsigned long local_watermark; - unsigned long failcnt; /* v1-only field */ /* Keep all the read most fields in a separete cacheline. */ CACHELINE_PADDING(_pad2_);