From patchwork Fri Feb 28 10:00:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sridhar, Kanchana P" X-Patchwork-Id: 13996093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AD1C19776 for ; Fri, 28 Feb 2025 10:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCE52280006; Fri, 28 Feb 2025 05:00:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2E37280002; Fri, 28 Feb 2025 05:00:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA75280006; Fri, 28 Feb 2025 05:00:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 87300280002 for ; Fri, 28 Feb 2025 05:00:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3BC211A0156 for ; Fri, 28 Feb 2025 10:00:32 +0000 (UTC) X-FDA: 83168908704.23.C9BBCCD Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf27.hostedemail.com (Postfix) with ESMTP id 479D140009 for ; Fri, 28 Feb 2025 10:00:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iha7GWEP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740736829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7zn2qvfvOLCDp2F8MXE3i6nl8YZve4VX5u9OSi+jXs=; b=YPQS1xOE/jdOtGTvgwZF8vU4kerd152IU3f4OcuHsGskvHxugGGQN1UDGu11VxBeRwtiIa bUvh8PjRiBvNcPecZAmWgoBZ72sDvDaetq9P0SnS7kl9wCdUbO5bYwh3ekSdsJlfFKFrVt kJ9VmNKcO/VPfpPljZczMX2dUvH6adM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iha7GWEP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740736829; a=rsa-sha256; cv=none; b=4Uz4/gSziZrvLxqHkQstsTj4gTixbxfkVs1IVtUBvAsXQ01N3Zz+jEA8o1BSR8IhvvbOXG E+xyRMYtHovSZpLQe+yMZbI/u9CVpI5HVeiJnQ49uRqdZAQPkdyrsPvrPr7NTHs0wLIn6J KIX+/tLDYqBRVDlhE/hIjFW+Pgd+Afg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740736829; x=1772272829; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8AO2hJSnLaCRd/8HtMcdHOYwB/zSpBOSifH5FW9w0Ms=; b=iha7GWEPuGjBRnaJSSWT3MSnuImMMVUjyny+DP9qFU7e6TIDW3xEv/hn BTeGtXpl1QIvLdPRWT3CdxTSaPYdUbJuC5AteaGjMGf02cPRhgb6bg7LC maLmslw826zLHZ9AvWtP/V1YZreu2Zaue1TRTrvHS0fsov7j9jR0+dztS TVsTB1crMmRc6gXlnmKqSm1tQHVsMtQtR0R8NzSR5PfabJ9yEJXLkxikC tAudo/rXzUQEb3T2oekHidtAhUYihkeGaIG/OodHp8y1MHpkyHei6Ain+ h7VllME3NiEAid8Gk+7q5dWJhmVAYynzB5tuburw+6b5NGewT+UxwViRq w==; X-CSE-ConnectionGUID: I4de1aUiQDqHOIhHjgSSuA== X-CSE-MsgGUID: 5FemGjv3T4GCloae4WNRIw== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="40902591" X-IronPort-AV: E=Sophos;i="6.13,322,1732608000"; d="scan'208";a="40902591" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 02:00:26 -0800 X-CSE-ConnectionGUID: +uREVyviRsCit8ekE1F3AQ== X-CSE-MsgGUID: PZ6fGJj+QYaoQWJo3S6Pwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,322,1732608000"; d="scan'208";a="117325698" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 28 Feb 2025 02:00:26 -0800 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v7 03/15] crypto: iaa - Add an acomp_req flag CRYPTO_ACOMP_REQ_POLL to enable async mode. Date: Fri, 28 Feb 2025 02:00:12 -0800 Message-Id: <20250228100024.332528-4-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250228100024.332528-1-kanchana.p.sridhar@intel.com> References: <20250228100024.332528-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 479D140009 X-Rspam-User: X-Stat-Signature: q93gp6d7kh554ahmie1tn9yf1g58mw8r X-HE-Tag: 1740736829-559184 X-HE-Meta: U2FsdGVkX1/xGTh2qS87ejUJksqwBsOVZ2y209M3Ank40TTsvvokRVRJwXvIRqXB/6u8y8YmG99qJ55P6BqN/VMv+V+kyyBOnjBP15QPRJV2mFXGeQcrIyrUtAIDWSivQjo4dJISQpOL6nKv7Gr+lkRoFE7WnKlS/BwZR0VykhwEZND0oe4APDrARrAaKlECJOyqSwzUyhiaXWx+8BIlm0c9beyNSEFGQxV+mfWBn003cmk5v0XwA3Y5In5IyzN85WE11DBWKyRLrwDEGLijOz6aOI/11bY3k3QECl9ZrgaCMjySiXR+PuYgK/XZakOIw+yz3QfgiP8Wn5t5e3NT2374tRNiJZvS2VLmbfS6CduD+QmxBt6rd3JvoCJ3HyJC35C9yG4I7rxvrN9UEUpGOzo0o7+Jg5kGMNZg3R2TfcLZxaH/64Ki1sYnIZaOaR9yAv2vx0BAGo2mP8Iy8A7KHz6rVQ+gT31GkVaGjJ0+a9Dn+El/reYW3X3pEN4z8SCK8fSEidpTe8q7uv1tVqFZreLI7dL5kEiYg5RAL8iNtgEFvoZr1QaIbmcE+ZZhsa2EfiDWeHOGjCgvEfcq+e2TLBcxKu60ld/X9ZT/jnwbQaffuYkYJvq3PIseFmqu9MhyG/sqpwgzyIBuvsBYvoiV0514tWOZMhbZK0JKr/hBL+No3ajcaVO6UECdXrGad6bWoEX/nkxAl31Ubz8fpje2hj114j1tjRp5jxmIvG6N7Np/6/fSre1m98TOn7YAG3j2TJlMcUFAqA+dHOqDoC1iQXoWEGPZ4/iaqHN/fMjB0WFBM8Bu+s9u7vvT6nrTDQiAs6FaWeFzz3yDIqPIbpMRuJpSlpTmtHDDi4BpHWWmBoqtI4B8FmWuInNbUYbQ8wNFRUiMGTN+2i7RDSqY+1T4+v4G69PAlT41hrbWwFZpT4GfGileoRtKASGGtC8s/N3F7ep7uce+ZDckc4MrGrD WqvAl7de wW8mnTTdjQLT7rkvkccl285dTbB+m3Efa6enZmWJIeHP9IJJj76b0qcERMg/CqkGB04/7TR6g+z1Dse1e7umuMDlWEqXX6h39MUwki1QO+mWfGyKH6+0bZFkpJyr13TugBAgHfv1eoAbxTtSCU3eKIEalaWSCJ4ekE0LKb3pyxskCyZjUN3m9OjTgGZcCMm4tkptkUFMNsTxKeN44aShYuxTO8Q26nKq3JeOTSYveRLJ3cD0boq3WceiqN+nh54HNSVklfFYtkYZyPhQsCjz36q2KrDAQcb6vBtID X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If the iaa_crypto driver has async_mode set to true, and use_irq set to false, it can still be forced to use synchronous mode by turning off the CRYPTO_ACOMP_REQ_POLL flag in req->flags. In other words, all three of the following need to be true for a request to be processed in fully async poll mode: 1) async_mode should be "true" 2) use_irq should be "false" 3) req->flags & CRYPTO_ACOMP_REQ_POLL should be "true" Suggested-by: Herbert Xu Signed-off-by: Kanchana P Sridhar --- drivers/crypto/intel/iaa/iaa_crypto_main.c | 11 ++++++++++- include/crypto/acompress.h | 5 +++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c index c3776b0de51d..d7983ab3c34a 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -1520,6 +1520,10 @@ static int iaa_comp_acompress(struct acomp_req *req) return -EINVAL; } + /* If the caller has requested no polling, disable async. */ + if (!(req->flags & CRYPTO_ACOMP_REQ_POLL)) + disable_async = true; + cpu = get_cpu(); wq = wq_table_next_wq(cpu); put_cpu(); @@ -1712,6 +1716,7 @@ static int iaa_comp_adecompress(struct acomp_req *req) { struct crypto_tfm *tfm = req->base.tfm; dma_addr_t src_addr, dst_addr; + bool disable_async = false; int nr_sgs, cpu, ret = 0; struct iaa_wq *iaa_wq; struct device *dev; @@ -1727,6 +1732,10 @@ static int iaa_comp_adecompress(struct acomp_req *req) return -EINVAL; } + /* If the caller has requested no polling, disable async. */ + if (!(req->flags & CRYPTO_ACOMP_REQ_POLL)) + disable_async = true; + if (!req->dst) return iaa_comp_adecompress_alloc_dest(req); @@ -1775,7 +1784,7 @@ static int iaa_comp_adecompress(struct acomp_req *req) req->dst, req->dlen, sg_dma_len(req->dst)); ret = iaa_decompress(tfm, req, wq, src_addr, req->slen, - dst_addr, &req->dlen, false); + dst_addr, &req->dlen, disable_async); if (ret == -EINPROGRESS) return ret; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index 147f184b6bea..afadf84f236d 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -14,6 +14,11 @@ #include #define CRYPTO_ACOMP_ALLOC_OUTPUT 0x00000001 +/* + * If set, the driver must have a way to submit the req, then + * poll its completion status for success/error. + */ +#define CRYPTO_ACOMP_REQ_POLL 0x00000002 #define CRYPTO_ACOMP_DST_MAX 131072 /**