From patchwork Fri Feb 28 10:00:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sridhar, Kanchana P" X-Patchwork-Id: 13996095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE573C19776 for ; Fri, 28 Feb 2025 10:00:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0742B280002; Fri, 28 Feb 2025 05:00:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3BEA280007; Fri, 28 Feb 2025 05:00:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCE4F280009; Fri, 28 Feb 2025 05:00:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8FEA7280007 for ; Fri, 28 Feb 2025 05:00:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3C39CB1587 for ; Fri, 28 Feb 2025 10:00:34 +0000 (UTC) X-FDA: 83168908788.22.D2D6773 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf08.hostedemail.com (Postfix) with ESMTP id C8B77160004 for ; Fri, 28 Feb 2025 10:00:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UARSm8FE; spf=pass (imf08.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740736832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2PQLRexpGdYT5Ec1XymA/Aac1BcRmmLQuyWuqoDnPs8=; b=b4B006EvuIDdcxjMnSLWblB1ugE9RPsMVI961+4d+rCaW4s+q4jHw2dD/IralD1eyIE0wY G5dGfDFApWvYkN6ROagGbIzy+o9GTbGv/42vcwKvsl6w51x08yXW1myAePaAV7tGBjC2At NdHuzughjnfDSRomf8t++IiuIthgpbo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UARSm8FE; spf=pass (imf08.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740736832; a=rsa-sha256; cv=none; b=3zg4MbiZE4pDfMR4VwOBMrRjWGbLghbroEz7tkesRAgnN0SDV/pKjkfu9VPFIUmRKDjusZ 53O4arErQOO97rBaCUqGFt25uebthDlURq7NDnSC9x/U1lnzDu2hEE3RQEP2Fo6OqDJvHv ESKgFMHy3X81AsG7EPU7+WXvOwjt5aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740736832; x=1772272832; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VRzCnyQyEfhyAHvAPp33ZwaL6nzqmuQ9xsZtH/mrvjQ=; b=UARSm8FE2/4m3wkpWq8xcISL/SFT0hJg4Nh+r0iEKbRpdKTcyw6nAWKx 7XVip2LU36NuwHRruOBKDa8IaI3va9qZSG1IbFfMVvQX9udJ/rtxt3XYe GoziUxvJcchHMGJYL4SKvorc1yfthflbLUpovclYBnclHIAgxdKVd1UT6 +CmRmTH4+hRCUaYroc1DLAdKtv0mv6VDJZMc1q5ozW4Xv25XzjK5AaEzm 7Mf5HH7YoWK4W09PYIgD0B/glb252k/6JSYIgAXqsPBXsNHyqrsfpUJeW YmTZzmOfuDe5wbVWj0G4/QhEyZpS6EUeggvxM6ejL/uQv7NmUTzgjo4VV A==; X-CSE-ConnectionGUID: nVRrpbWERjekMWC+diptCg== X-CSE-MsgGUID: Fpda5ki+Tp+wEsJ76Bm/hQ== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="40902618" X-IronPort-AV: E=Sophos;i="6.13,322,1732608000"; d="scan'208";a="40902618" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 02:00:26 -0800 X-CSE-ConnectionGUID: X0/nNyTWS0ykGFG2AYIKDA== X-CSE-MsgGUID: uQLjgsO6REGaSnplKdf3iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,322,1732608000"; d="scan'208";a="117325713" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 28 Feb 2025 02:00:26 -0800 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v7 05/15] crypto: iaa - Enable async mode and make it the default. Date: Fri, 28 Feb 2025 02:00:14 -0800 Message-Id: <20250228100024.332528-6-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250228100024.332528-1-kanchana.p.sridhar@intel.com> References: <20250228100024.332528-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C8B77160004 X-Stat-Signature: 5g8kfqrqp899maowqta1akzcozjbn5qa X-HE-Tag: 1740736831-415522 X-HE-Meta: U2FsdGVkX18KLsBY+wx9jUCuGKr7j45gvab+V+CGAm7xbUsqUHYswKEhEiHCfm8uN+D/ImrNd2po6qfhpm0OlE8UKRx0/SkDy3dr4o1qO5yB0gCNSmj7ibJQ/JmPDSQybvCm0yY7c+aPJ74wTHA+AJmWJzjWX2Jm+29rmhGSP+GyBp7zdrIndyZ73IRmZjxnZm9d0ZxHYqmE8sYEwRwZ935Mwgp8RgtNCca6X3FYZlPyfzQyBWr567dBgOVLav8SwHDjgnQA2R7CzuzrAmeeEmS06ExDLRX0VmTvCq/iqw6o1GlQAfH54DACbHkMHJHFrlxXG5sUEVhZj5quTe9hNAPdNk3270E/3Q6uHjgKTGivrCMk16Llogb3Fca5agbirttr53uiLT4ii+9OJa32joNM65DTTiK6WkA+kn/tUYdbkpjqiym+PRJxYMFjC2OOJYK45Z+f+ZQBBXnfxa5RMnCXUJyAEKJ0jwdXXIHzAPJSUAB7EHnupnx3Gm6Q8vw6jDpPD6Epb3ytg5poYaF0nk22AXZ5udyo9FkdMK1e/L55gBLsnKaiFCsyXHhjjHuGMx3Uq4UcnOM6KWV+mywpUL1PxkRpWaRytr0KhTDQN6JDeP2A1xF68cR0/SwzDDQNc41Nb5gd0gMhDrYFla0Ec0XLYExGKHnYcSe3yDx8AsvofBIkd/JISn3CwD3u3VBXFhHVxFnNntJ2E0oYmd8vlz5tnMwjXku8eO51OKKbTu+szHjj53DOfgblMyLFigNFlnivN/WAj5kZV3p/n5nPW5MO09ao9XEys5Lka9N6hxX/6oYmGupbUZ4o0hh0L6bBcrx+EFpVc97AbayqdfGOtisvlSz61j4mk4yTVQtUk9xQxm/Y+aeXoUfNxRuv1/zaZ9ecEjrqFx5e9Z4epu4QKdHYH/zIsGCOLi+9Rg8yslfeNftcpFupVUhvq7RsjIoBlyXLHbjqkx/cAr/zMiO kFB1k8tI IToQnujCcoG7KdaE/mMl3kAXr/YjEyB4pLMmJ2ouZxrO+osrXNxYwgtIgvkIRi3tUoui1PqQKxF851WoU38LMa4LgFKftw9ymwE3afjGVAzGf09uDuimQUD/Ogow/TDVTru/rCS97oVXltLabsCKcltrcNOc38ZkvgmYzNUs6jcFu+m5NzPUE/l08cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch enables the 'async' sync_mode in the driver. Further, it sets the default sync_mode to 'async', which makes it easier for IAA hardware acceleration in the iaa_crypto driver to be loaded by default in the most efficient/recommended 'async' mode for parallel compressions/decompressions, namely, asynchronous submission of descriptors, followed by polling for job completions with or without request chaining. Earlier, the "sync" mode used to be the default. This way, anyone who wants to use IAA for zswap/zram can do so after building the kernel, and without having to go through these steps to use async mode: 1) disable all the IAA device/wq bindings that happen at boot time 2) rmmod iaa_crypto 3) modprobe iaa_crypto 4) echo async > /sys/bus/dsa/drivers/crypto/sync_mode 5) re-run initialization of the IAA devices and wqs Signed-off-by: Kanchana P Sridhar --- Documentation/driver-api/crypto/iaa/iaa-crypto.rst | 11 ++--------- drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++-- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst index 8e50b900d51c..782da5230fcd 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -272,7 +272,7 @@ The available attributes are: echo async_irq > /sys/bus/dsa/drivers/crypto/sync_mode Async mode without interrupts (caller must poll) can be enabled by - writing 'async' to it (please see Caveat):: + writing 'async' to it:: echo async > /sys/bus/dsa/drivers/crypto/sync_mode @@ -281,14 +281,7 @@ The available attributes are: echo sync > /sys/bus/dsa/drivers/crypto/sync_mode - The default mode is 'sync'. - - Caveat: since the only mechanism that iaa_crypto currently implements - for async polling without interrupts is via the 'sync' mode as - described earlier, writing 'async' to - '/sys/bus/dsa/drivers/crypto/sync_mode' will internally enable the - 'sync' mode. This is to ensure correct iaa_crypto behavior until true - async polling without interrupts is enabled in iaa_crypto. + The default mode is 'async'. .. _iaa_default_config: diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c index a9800b8f3575..4dac4852c113 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -153,7 +153,7 @@ static DRIVER_ATTR_RW(verify_compress); */ /* Use async mode */ -static bool async_mode; +static bool async_mode = true; /* Use interrupts */ static bool use_irq; @@ -173,7 +173,7 @@ static int set_iaa_sync_mode(const char *name) async_mode = false; use_irq = false; } else if (sysfs_streq(name, "async")) { - async_mode = false; + async_mode = true; use_irq = false; } else if (sysfs_streq(name, "async_irq")) { async_mode = true;