From patchwork Fri Feb 28 12:13:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13996316 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB27C19776 for ; Fri, 28 Feb 2025 12:14:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2752280003; Fri, 28 Feb 2025 07:14:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E264280001; Fri, 28 Feb 2025 07:14:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87766280003; Fri, 28 Feb 2025 07:14:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 67E7B280001 for ; Fri, 28 Feb 2025 07:14:03 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D77AC099C for ; Fri, 28 Feb 2025 12:14:03 +0000 (UTC) X-FDA: 83169245166.01.6F1A8D7 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 3816440012 for ; Fri, 28 Feb 2025 12:14:00 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dQoNOboe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740744841; a=rsa-sha256; cv=none; b=8JbSELhdRAf4SgJ0wrfo4658dB4ObGkk4E2BqcDJfQQ3FnDEl8C7RXeWHxmlpFXPitzG4T AowvFRHdjAXpwquFkDiZkys9m3/2dzu9zgyg12iU4ayoW4crPDELrSdt19cky9QcRAKLOE I2wjvvKeNDVF1gAf7RGKSyKISh7AZ8A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dQoNOboe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740744841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=pkAygyolNUDpTR2GUn/c3jGDRfvql77S9asYrw4dJlg=; b=OmrXzTtnLDdlC7r+zmNF1hw9kXqpenocbgRCl749XyD86DmhYMsoAMJSMa8lET7By7wW58 hTLF+TprAEQS3TC29kUbN1TQge8SvnyfidXo0AHEpdpPFJDwQetsGWuUlikpTnbbMbGEsG yFu+mBbnHISYzzenCC2vITNBDW6gX0E= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-548409cd2a8so2084382e87.3 for ; Fri, 28 Feb 2025 04:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740744839; x=1741349639; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pkAygyolNUDpTR2GUn/c3jGDRfvql77S9asYrw4dJlg=; b=dQoNOboevwNeP6zrt4/parUcn46CQga5dleJtuelaJ6uvBGbvMXFLTrWVpwC25rCN3 xHhUjSueQGsm5DgIHWiczroJZN4JUh8RCtCGXtM0q6sd68HtbNLmBqHxZqJ+ioBwvtkA 7Z7MT3Cb3BcnBHsUdqEVW26KkBkOzFWtWj1S/3qQBSTHwc51wIN/oC14KjlB2mXcZHkc fiPvRMlrDQYbGKLUkobTgiMoaOA9kuThEXexTcsHY338StGOx5u5v0fO/UCn/Rw+Nhr8 smQPrc6uvA5/jQWiM96T0IjYv3aS82npvBc4iN9OKYPybOPI84J3gNuPc8Fo/t5tzk0g JXjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740744839; x=1741349639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pkAygyolNUDpTR2GUn/c3jGDRfvql77S9asYrw4dJlg=; b=j7AGwzVNNpmHFGjIpL4HLCgKwlxzzP6qpt/n7T9ynIAVLBNZjizkhb2utJsHqxAu6z f+sqQhlnIqG5AIixXANn1gQ6cW3vGQ/XbLU0tZ7B4/oauLqL4rz/+LxUMS92eM6+vlgZ tbghSZ+rINlWI77Y5A2aVH02Ch0HiBTZ9NzgP7WRl7DYyn+JHVVFlTgmm8W/KaT91SkK 7GMTdEZMTAT9YePY/MavZjOBqYwt4guZZXLah3x22r1PuKLN6LmOUti2ZHwacjHTsC09 PV866RUuwWla3nDshPW+t4qB2Mo397+hf2T0yy7dQT0CGpdCwoKbOuUI3mn1L88SzlnE l/+A== X-Gm-Message-State: AOJu0YwSL4Tjy/ejsoUYl3FvWVDLjfB0k+XTXr3b6deZTF6s2x+uOQ9W P6yM6RvFOuQ5coZsVWTahnmc4P06lkv7dlfmhl9CKQnBAg1bSzIqFPtMLA== X-Gm-Gg: ASbGncsEoB6ISStWpjaXwF2cA5ke8rSYoJeYo3jKB2BeIDPwKlYIvD4h6Fi5WHS1ByY rrQ6w1yaVeya7S6dGVtL3a/l3jFQqt23dAGeMqy9uelqrMg5EXxGlWHgw6CxSuoQqx41EMMQ5OA +6RbucIFwSWctNZBomnVAL1vV0vtbevHG+JUg72/GApg4e7p9RBlH7UwhjbhG0NR91YnCPAggzD B+B5QxjoxGuu2VJleyZHq2q/fb75dwQUWstcacKZ5tdKC/B0hjrTq05qBF6DUqhYZRGP2NBAEiT kA3218zcHfNmS13DHwTBwA== X-Google-Smtp-Source: AGHT+IEE5Sgq0pD0++96L3Rw5rUNxBxVx36PbQHqHNZ8eGIdUS/xL5nATldx2m3megBQRV1h9xxkCw== X-Received: by 2002:a05:6512:3b11:b0:549:3be2:bfa3 with SMTP id 2adb3069b0e04-5494c320bfcmr1209187e87.30.1740744838853; Fri, 28 Feb 2025 04:13:58 -0800 (PST) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549443ccfb7sm466768e87.230.2025.02.28.04.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 04:13:58 -0800 (PST) From: "Uladzislau Rezki (Sony)" To: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka Cc: RCU , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Uladzislau Rezki , Oleksiy Avramchenko , Keith Busch Subject: [PATCH v1 1/2] kunit, slub: Add test_kfree_rcu_wq_destroy use case Date: Fri, 28 Feb 2025 13:13:55 +0100 Message-Id: <20250228121356.336871-1-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3816440012 X-Stat-Signature: aa1feh41fg8euqcic6gkbiqx8h7r1ogr X-HE-Tag: 1740744840-219736 X-HE-Meta: U2FsdGVkX1/sUoP0U8IY1SgGT4aDTEs3SMoqIhedQ/FMrMK6fHNlTrNTCgmMvL2EqhMeXUihwhXUwQ5yGvquBdnOaqM3c8G25+seW56W/TUjGNWcUFwHkxW5Nowo8B26rVUmn0GtIBmkn4wbGjNLNPf+ri65YTg6kEl9TimOBDM2hnI6SN5DhxafD4583u0SDO/SnPWePcYvkMi8l+dZFGCGxDttPAfBn9/S8UyeZEbZpOHPTUsVVt2tJ0LmB8G7Mgez0AxvXtMLdj6H81Cr40rmRx4OZcBkOuLJkyV/P9BlP8IgfOFXIzABtHOdrmQXS0x9DkDrePw0myvIUVZZDI4HpBvLl8xFxax+tJXiYuzvblM7fBcGgDqZ+3h5WfC2qJH1OzO3CVCIkrJrORW2UJVOjQAin8DlCF14x8svBdRrwi/wxiDLQfsbM+NnCXkd+Ye+sC9BFSGfHyr0e89Y8MFOFU99J3X4ynhdnmU5pFOkifqFTCm/dX1163xI900bj6a65uI/6/yU2pTA0rmcS6LUSVTaWitj4oosx/ZfCKI4fcD3lQNfqQnc173/as9z4EEEzNAkysAT6oHS8gJ7WYpnBQyNulPoHEzrZVsweAqcAk0WCH3QlDzcNC0BGlkaeBYFJTjCrdnssNZ6ikbhZhs0Q9LV3/TojCUZ6Qbb1q7BonRlVC8+Exsh5onzeUj4P3cCAIoTtSQNvJrkUNfFUHsz1SbQ/+MLiEYhhHBncssz+J/f31QspWF8H5MixA08KlIfIJWXkrrPl7LCVrDnbs3l/DtLBde6ULgKq2PKxcCjEQbnOh507Ziod+1bmChiwLX/Ns20TMNLY6bcxrYJkRD6yyNk0gFCJtblFvVmflRnZo8Gzu7AtXnqQ0qDakAnB8u/EwbdaLVcB7NGX8GTzZm9uHQp6rPJq5UMnaZs1zWS+cBMwDj4bsjX1YG7NoVa66hOr92SdugyjIj7QbO CvSb7cK0 Jll+997XsDGbwiD5dMXD9FHatIEmdgaBL3Z1QS//jvpkYMm+I1i2LZiFmDYOiV6BBjvL/Ru9c5DIZTyRKPzw5543sCyKpG9/ySN6FbnoTwdlL4P9W8ks8PzXmenvouhbHapS8RkjYNum9UIm1b1dV1dPT/Ag8TbJYCv8HsobRlhpRsekIme+Z87VY14jZU+ICRsnCfIigrwUao6o7UwlPUuewJNTIIgieLeALUqoNQibfH8K/8xi7xWhcg7QnLYAu6NY00pWn5PxLOeoB8pjzzKIo2u5m/1NaYEGw3VPbbgzgUAbfgIafGqr9POx/t24913x1/H5EAd/S1F50LxBm0o9Se03iYiha7I1qMVRYRswJtMivVrwGD0OwufFwHHMU0WwiyYhmmTvwaczoYaW+QWN0yQKY1i5DM3zRSDcZItDvf1Cp84VAWsogBm2/0uz4ALaDNBrK8mMG1zQPZZrh2oGuAa2OT+4AFGXGzR6AdBRIc4XD5EsoCApidXkAUeKyeIkNcA28f7bJzJU2pHQQaCv2Rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a test_kfree_rcu_wq_destroy test to verify a kmem_cache_destroy() from a workqueue context. The problem is that, before destroying any cache the kvfree_rcu_barrier() is invoked to guarantee that in-flight freed objects are flushed. The _barrier() function queues and flushes its own internal workers which might conflict with a workqueue type a kmem-cache gets destroyed from. One example is when a WQ_MEM_RECLAIM workqueue is flushing !WQ_MEM_RECLAIM events which leads to a kernel splat. See the check_flush_dependency() in the workqueue.c file. If this test does not emits any kernel warning, it is passed. Reviewed-by: Keith Busch Co-developed-by: Vlastimil Babka Signed-off-by: Uladzislau Rezki (Sony) --- lib/slub_kunit.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c index f11691315c2f..d47c472b0520 100644 --- a/lib/slub_kunit.c +++ b/lib/slub_kunit.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "../mm/slab.h" static struct kunit_resource resource; @@ -181,6 +182,63 @@ static void test_kfree_rcu(struct kunit *test) KUNIT_EXPECT_EQ(test, 0, slab_errors); } +struct cache_destroy_work { + struct work_struct work; + struct kmem_cache *s; +}; + +static void cache_destroy_workfn(struct work_struct *w) +{ + struct cache_destroy_work *cdw; + + cdw = container_of(w, struct cache_destroy_work, work); + kmem_cache_destroy(cdw->s); +} + +#define KMEM_CACHE_DESTROY_NR 10 + +static void test_kfree_rcu_wq_destroy(struct kunit *test) +{ + struct test_kfree_rcu_struct *p; + struct cache_destroy_work cdw; + struct workqueue_struct *wq; + struct kmem_cache *s; + unsigned int delay; + int i; + + if (IS_BUILTIN(CONFIG_SLUB_KUNIT_TEST)) + kunit_skip(test, "can't do kfree_rcu() when test is built-in"); + + INIT_WORK_ONSTACK(&cdw.work, cache_destroy_workfn); + wq = alloc_workqueue("test_kfree_rcu_destroy_wq", + WQ_HIGHPRI | WQ_UNBOUND | WQ_MEM_RECLAIM, 0); + + if (!wq) + kunit_skip(test, "failed to alloc wq"); + + for (i = 0; i < KMEM_CACHE_DESTROY_NR; i++) { + s = test_kmem_cache_create("TestSlub_kfree_rcu_wq_destroy", + sizeof(struct test_kfree_rcu_struct), + SLAB_NO_MERGE); + + if (!s) + kunit_skip(test, "failed to create cache"); + + delay = get_random_u8(); + p = kmem_cache_alloc(s, GFP_KERNEL); + kfree_rcu(p, rcu); + + cdw.s = s; + + msleep(delay); + queue_work(wq, &cdw.work); + flush_work(&cdw.work); + } + + destroy_workqueue(wq); + KUNIT_EXPECT_EQ(test, 0, slab_errors); +} + static void test_leak_destroy(struct kunit *test) { struct kmem_cache *s = test_kmem_cache_create("TestSlub_leak_destroy", @@ -254,6 +312,7 @@ static struct kunit_case test_cases[] = { KUNIT_CASE(test_clobber_redzone_free), KUNIT_CASE(test_kmalloc_redzone_access), KUNIT_CASE(test_kfree_rcu), + KUNIT_CASE(test_kfree_rcu_wq_destroy), KUNIT_CASE(test_leak_destroy), KUNIT_CASE(test_krealloc_redzone_zeroing), {}