From patchwork Fri Feb 28 18:29:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank van der Linden X-Patchwork-Id: 13996912 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BB2C282D0 for ; Fri, 28 Feb 2025 18:30:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9FDF28000F; Fri, 28 Feb 2025 13:30:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C50D2280001; Fri, 28 Feb 2025 13:30:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA2AC28000F; Fri, 28 Feb 2025 13:30:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A2FF280001 for ; Fri, 28 Feb 2025 13:30:13 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 48F5C1C91F9 for ; Fri, 28 Feb 2025 18:30:13 +0000 (UTC) X-FDA: 83170193106.28.CF97916 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf24.hostedemail.com (Postfix) with ESMTP id 6836E18000F for ; Fri, 28 Feb 2025 18:30:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ylVR/JYE"; spf=pass (imf24.hostedemail.com: domain of 3sgDCZwQKCAEgwemhpphmf.dpnmjovy-nnlwbdl.psh@flex--fvdl.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3sgDCZwQKCAEgwemhpphmf.dpnmjovy-nnlwbdl.psh@flex--fvdl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740767411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8BnmSyjAWl8KyXjU3dkeSbWxZ2sVLeXlaOuN4oJvYMc=; b=vXAoTmB19aqLUEFQ0t1cbvuL5wk+or43CMKyo/EUsrEhzef/kAM2pmezietMPsgg4ktKg9 v0pzNnWKbMx7YYal7LXlvSRoutsUQLL6TnT/m4gr7V8C8tXKHRSFvW6zXBT9lZYVdfAz31 +nbf8jeOUPrVvY35a0s3Svbh1buAmLs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="ylVR/JYE"; spf=pass (imf24.hostedemail.com: domain of 3sgDCZwQKCAEgwemhpphmf.dpnmjovy-nnlwbdl.psh@flex--fvdl.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3sgDCZwQKCAEgwemhpphmf.dpnmjovy-nnlwbdl.psh@flex--fvdl.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740767411; a=rsa-sha256; cv=none; b=zSShYzPI3BUtDgKct0Rs9dc/Bzv84VMXlEdQJMJSiYIAUpa1sOXUMfsZTVWvYqWVkVTxvd U5GpAqEeNMTqb2AENzWRvYYirpS3vc8rOWhnpjqezNRPiiecRGQU4HzTYsuNCITpr0FHrF 06ruXuO9pjQpRihEqoJtBETasirj9Nc= Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2fecd603bb8so831649a91.3 for ; Fri, 28 Feb 2025 10:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740767410; x=1741372210; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8BnmSyjAWl8KyXjU3dkeSbWxZ2sVLeXlaOuN4oJvYMc=; b=ylVR/JYEAWF1zFszu/kUue7CAjUPoYs47yC5qej+Vp6nO0QKbsS6nwVlc9LRnLYP65 kapjvKLJQBVPZJ+lKZcTqYbnQTRSWwgxTP9FHRjA/GsoLsRw22uzX+Q8clGeQP+JZdho 6T4qETSRIipUpN7yr0/uYAAS+5RZ2/T5MtalkaAsLnjGEAjNrZWCJhl//1g8pzacD7wJ 1fHr1zuX9caoAMHVh/HDl1DRpqDndj8kIxS5J3zpgIO8+Ka+4lXqM9Sw7L2LPQzvZAyI O9D+Ua9gRJm3ZWYAHGnGCcFK96vUc5kAuxbH3cwXBi+pE33kl4tu/cyHwo13Em9ClAPU lyeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740767410; x=1741372210; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8BnmSyjAWl8KyXjU3dkeSbWxZ2sVLeXlaOuN4oJvYMc=; b=RsmCF0mJDQLiEY+AYZ/tyRE3C7mnrmcBZnW3Rhp3Wq8rSPfFk0iF6pwJd7RjfTPsC+ nltXNen2egGrOV0KdXgkLs0LlbYwCA4cEFXxd6M03il8vseLmyFyOsfI/C+o6Sx0letE eL4f8bhPlIV8OVh6qk3o4L9q90qmKlO/Gc2XFj6/MKf8O51WZrzFkbGTasassX3k7hqb PVG7XI/1+jRySLk6Ko5YxFLiXG9XXEPyutbmxaiKMGGB9dTjUON9OInHOg0edFTcNsMz BJrdX2Zu7bNbHIT1XcEL82+ui0PK4As8GKOHH8EkytP4+MtxsTPJDZhNY9/sPKHgqSPz Y/9w== X-Forwarded-Encrypted: i=1; AJvYcCWB+aVCL+32Vzp3184GJAuAy4zPbAr+DdcybgjvcKGKvnsam2mp+2di/NDh1Wtu1GcmVi2FUSpkbA==@kvack.org X-Gm-Message-State: AOJu0YzQEmF3ojwMxOR/9KgJX2bQpaR0pj9LQ22OnmCw2THqvdG+/Fxn uY479Rch3Iz37ScfA2Dd8mDg2nMesCX4ovbsO+Czjh20IZ4RjcwG3mEzWlKgRRv+/POHbw== X-Google-Smtp-Source: AGHT+IHkA2l5A4sRrVBTdd/1UDvjktTBUXrR2r60wNN+pEhOugKCAuRSJ2vy2XoSkO7SYrkW3vFR2Pm+ X-Received: from pgmm31.prod.google.com ([2002:a05:6a02:551f:b0:ad5:52c1:c4d0]) (user=fvdl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:1595:b0:1ee:d6a7:e341 with SMTP id adf61e73a8af0-1f2f4e45091mr9004502637.30.1740767410238; Fri, 28 Feb 2025 10:30:10 -0800 (PST) Date: Fri, 28 Feb 2025 18:29:14 +0000 In-Reply-To: <20250228182928.2645936-1-fvdl@google.com> Mime-Version: 1.0 References: <20250228182928.2645936-1-fvdl@google.com> X-Mailer: git-send-email 2.48.1.711.g2feabab25a-goog Message-ID: <20250228182928.2645936-14-fvdl@google.com> Subject: [PATCH v5 13/27] mm/hugetlb: check bootmem pages for zone intersections From: Frank van der Linden To: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev, ziy@nvidia.com, david@redhat.com, Frank van der Linden X-Rspam-User: X-Stat-Signature: izpd6qy6unjg6egr3cs9ynstjo9gy4f3 X-Rspamd-Queue-Id: 6836E18000F X-Rspamd-Server: rspam07 X-HE-Tag: 1740767411-512818 X-HE-Meta: U2FsdGVkX19LFl6pPYeIn7c5jPHzBP24MeBGM4P83wan/YSeExq07a3QQg9yGJY1vZnQ2ctsbYSCqcC8BYH0+e/yCN5a1C/mtwfufS85l0SgS950SIqcnpNYCt9sKNxzOZpaY4TJYaFDNWXXkkSoWqjp8h3hpoA0VE0JEVEYZnOoF7nNu8YTqxLUBfSS+0avR6KNtmiOAVM/LTaqe/fw61j+70xygG4756b342tZn9U9hyAB8ArVmKF8SeTDNE7czka2RMSaaHMTaXwcKXCNF4Bd8srxrVwPYKfNOURIBpJfsrzfvaTnulKS1ef0bqUDyWXmfPG7FPl6uXTfFTwMyaiZv2IKH3tD+csKTj7YKeSfnEUXKRmU3SFpFXCGqbSv0lWak15fkAMK306E0Sz4V1Vbv9JJqu0SbUxtDBuaGTOV4IOb11rA/Oo5r0lJjrSu7PPRTK3CLbKj4Vs5BopI7ze8DJ3SzP+Q9lr/blSk2GHpqKpvgJqMWeOxeNRF/g9hjeNf2mXHTHWci5j4li8WncnhrUKViNzEKOJvOxaZDyO41gqkj5Ijt2WpNQ7trmOSSF8j/EJ6itTt+K3HaWwwrq9hJw5q2Q6VmiKXtmxNgvGTmzT+yQimFdmBKMhQF7wDASKpPCXwqZ2/cskv1MLUj1rzZn7dRMd4EeTCNAnZWm8SzGY9erBMw64QsziofZIBXu/VXA9EcUt/6xkX0C5zJtplr1wavLfLsGCddB+UBRz1lN647bVQ9bkOs3oxt+qVadhpxAK0cSktUdbpvwEJ034hN+bYxGLZfJAoI46XUR0+Cmo/ZL9XHLash+b4hNGqJjfpcEmlPQ05RtMZhnSH6kRClAdqfpxau/8KY0QE/sO865WrccHC1JAu9c9sUzPK/FmFo2lOs7dYwcwUM0DrjbHRpn9MDvg/ilNh92cJ9TYPi5dCrjsFgLmZ9s4ZcyqylG7+sv4ct5k+qTWtlH2 KY7FBCZO UXfjqQWkOecGxETDmnarJebrvZv+jzQqpGP4Ns/sZJtsb7ClSLXvwVCHapbnvQlrOab+bsyAkjtVkk/qB5TEdg4DGEJUUnLnlnBHpd+4xqacXX8Zr40O+DEJEz+TYNOtdtsQiuwQ03Ka++l9KoxCA12xKSKkZzhtPuPlR+pfglX/MDynbNeYy5CeFUDhK4cIOU3EhcRMs73vFb5iTX4zR4jwVy4Ce/9/T75Q5DrC4031joMttHdYKmSNmmzjzydY0KYST9tHyisQ93Nd0XE9qxYa1nqHks57liQR6+38y+ZF4JwYDUXhtQqYh9gO468nFcgyP1P2bqcsNQnsHwMA5NB/x9VZSkUzrBwXTh75TBxn8W2bhtDZb7wepqZoI5Al5ahlVoOV9rwTkgfBdAn2CxAmK1CaW2r60U2L+5X2hUuuNDw9uUGg192T1YwJEy6iUqA/K1slUe/Cp3m0Q8y0bcvvag9bljRgDaZ5ZHc9mdaTwklBJdB4LqVv4fVWAHikZ6yTJJ9kkkA21N1PvuIFWC2fpDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Bootmem hugetlb pages are allocated using memblock, which isn't (and mostly can't be) aware of zones. So, they may end up crossing zone boundaries. This would create confusion, a hugetlb page that is part of multiple zones is bad. Worse, HVO might then end up stealthily re-assigning pages to a different zone when a hugetlb page is freed, since the tail page structures beyond the first vmemmap page would inherit the zone of the first page structures. While the chance of this happening is low, you can definitely create a configuration where this happens (especially using ZONE_MOVABLE). To avoid this issue, check if bootmem hugetlb pages intersect with multiple zones during the gather phase, and discard them, handing them to the page allocator, if they do. Record the number of invalid bootmem pages per node and subtract them from the number of available pages at the end, making it easier to do these checks in multiple places later on. Signed-off-by: Frank van der Linden --- mm/hugetlb.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++-- mm/internal.h | 2 ++ mm/mm_init.c | 25 +++++++++++++++++++++ 3 files changed, 86 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 19a7a795a388..f9704a0e62de 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -62,6 +62,7 @@ static unsigned long hugetlb_cma_size_in_node[MAX_NUMNODES] __initdata; static unsigned long hugetlb_cma_size __initdata; __initdata struct list_head huge_boot_pages[MAX_NUMNODES]; +static unsigned long hstate_boot_nrinvalid[HUGE_MAX_HSTATE] __initdata; /* * Due to ordering constraints across the init code for various @@ -3304,6 +3305,44 @@ static void __init prep_and_add_bootmem_folios(struct hstate *h, } } +static bool __init hugetlb_bootmem_page_zones_valid(int nid, + struct huge_bootmem_page *m) +{ + unsigned long start_pfn; + bool valid; + + start_pfn = virt_to_phys(m) >> PAGE_SHIFT; + + valid = !pfn_range_intersects_zones(nid, start_pfn, + pages_per_huge_page(m->hstate)); + if (!valid) + hstate_boot_nrinvalid[hstate_index(m->hstate)]++; + + return valid; +} + +/* + * Free a bootmem page that was found to be invalid (intersecting with + * multiple zones). + * + * Since it intersects with multiple zones, we can't just do a free + * operation on all pages at once, but instead have to walk all + * pages, freeing them one by one. + */ +static void __init hugetlb_bootmem_free_invalid_page(int nid, struct page *page, + struct hstate *h) +{ + unsigned long npages = pages_per_huge_page(h); + unsigned long pfn; + + while (npages--) { + pfn = page_to_pfn(page); + __init_reserved_page_zone(pfn, nid); + free_reserved_page(page); + page++; + } +} + /* * Put bootmem huge pages into the standard lists after mem_map is up. * Note: This only applies to gigantic (order > MAX_PAGE_ORDER) pages. @@ -3311,14 +3350,25 @@ static void __init prep_and_add_bootmem_folios(struct hstate *h, static void __init gather_bootmem_prealloc_node(unsigned long nid) { LIST_HEAD(folio_list); - struct huge_bootmem_page *m; + struct huge_bootmem_page *m, *tm; struct hstate *h = NULL, *prev_h = NULL; - list_for_each_entry(m, &huge_boot_pages[nid], list) { + list_for_each_entry_safe(m, tm, &huge_boot_pages[nid], list) { struct page *page = virt_to_page(m); struct folio *folio = (void *)page; h = m->hstate; + if (!hugetlb_bootmem_page_zones_valid(nid, m)) { + /* + * Can't use this page. Initialize the + * page structures if that hasn't already + * been done, and give them to the page + * allocator. + */ + hugetlb_bootmem_free_invalid_page(nid, page, h); + continue; + } + /* * It is possible to have multiple huge page sizes (hstates) * in this list. If so, process each size separately. @@ -3590,13 +3640,20 @@ static void __init hugetlb_init_hstates(void) static void __init report_hugepages(void) { struct hstate *h; + unsigned long nrinvalid; for_each_hstate(h) { char buf[32]; + nrinvalid = hstate_boot_nrinvalid[hstate_index(h)]; + h->max_huge_pages -= nrinvalid; + string_get_size(huge_page_size(h), 1, STRING_UNITS_2, buf, 32); pr_info("HugeTLB: registered %s page size, pre-allocated %ld pages\n", buf, h->free_huge_pages); + if (nrinvalid) + pr_info("HugeTLB: %s page size: %lu invalid page%s discarded\n", + buf, nrinvalid, nrinvalid > 1 ? "s" : ""); pr_info("HugeTLB: %d KiB vmemmap can be freed for a %s page\n", hugetlb_vmemmap_optimizable_size(h) / SZ_1K, buf); } diff --git a/mm/internal.h b/mm/internal.h index 57662141930e..63fda9bb9426 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -658,6 +658,8 @@ static inline struct page *pageblock_pfn_to_page(unsigned long start_pfn, } void set_zone_contiguous(struct zone *zone); +bool pfn_range_intersects_zones(int nid, unsigned long start_pfn, + unsigned long nr_pages); static inline void clear_zone_contiguous(struct zone *zone) { diff --git a/mm/mm_init.c b/mm/mm_init.c index 925ed6564572..f7d5b4fe1ae9 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2287,6 +2287,31 @@ void set_zone_contiguous(struct zone *zone) zone->contiguous = true; } +/* + * Check if a PFN range intersects multiple zones on one or more + * NUMA nodes. Specify the @nid argument if it is known that this + * PFN range is on one node, NUMA_NO_NODE otherwise. + */ +bool pfn_range_intersects_zones(int nid, unsigned long start_pfn, + unsigned long nr_pages) +{ + struct zone *zone, *izone = NULL; + + for_each_zone(zone) { + if (nid != NUMA_NO_NODE && zone_to_nid(zone) != nid) + continue; + + if (zone_intersects(zone, start_pfn, nr_pages)) { + if (izone != NULL) + return true; + izone = zone; + } + + } + + return false; +} + static void __init mem_init_print_info(void); void __init page_alloc_init_late(void) {