From patchwork Fri Feb 28 22:03:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13997208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACAC1C282C5 for ; Fri, 28 Feb 2025 22:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C555A280005; Fri, 28 Feb 2025 17:03:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE145280001; Fri, 28 Feb 2025 17:03:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0838280005; Fri, 28 Feb 2025 17:03:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 847D4280001 for ; Fri, 28 Feb 2025 17:03:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 410241C98B0 for ; Fri, 28 Feb 2025 22:03:37 +0000 (UTC) X-FDA: 83170730874.30.F8E992A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id A7055C0002 for ; Fri, 28 Feb 2025 22:03:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="e/FphRjd"; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740780215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QzvYG+cEAjM9AbEQ23ogKHWCItSVRW1Cs0pAW4+BkAY=; b=8SjR0Pna1i5G/CIR12d8Xisxnk19WDDTEvnOoMpWqUbvzSm4m/rrxtqFmMWDCFV2dK+yCA /nNtTHf8WCNsVUVfjtnO6hYamAZ0zYyonqF1VLE2Q0jLMAPLz9EkCsJbBqVm5u8H3VCkKQ wmQUBaay5tLD+yCEbqzbPcAQOdRPWso= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="e/FphRjd"; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740780215; a=rsa-sha256; cv=none; b=pvaZhPUEbFC+zyEvqoKQ3oNHuJjTOmbUP2Ba/ksOfLHLAQlZH9kgOdXmeKcDbfCiieuDiX 2FToAwvJQ8bDBJonwOkB7vmHNH9Ywo5IjF0TZVaVd2J9akAiv5c8EmwNndNCOxbeWJ1PD9 f7dR3keRuVvnSAmX2wwwH6y/ewM5KFg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 29B155C5D3F; Fri, 28 Feb 2025 22:01:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96286C4AF09; Fri, 28 Feb 2025 22:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740780214; bh=oYTrlxmiR5BNoFrioFop/hpnftvDsKcm3PmL/H0/UqA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e/FphRjdGqDtr0R0HIkMrG187LEe7z469tMGPI07zZ54hj1kb7AgXUVnoFoTGPK7I tgnafQKOapIxO1YQszMqW1Y0QlZtSphOc/TYJdCb6hut5LvcL2v1DC/gASdD+9KVhv 9GWkNI9qH12ebwRByk2InerJEWBorZDbo0vHUnAO8X2kGYozCZZSPzyOMAiWHOfzCl AMwVQEXD7G2+ui63OTvUeghCyhujwrf7KtfkPX5J3EDroNetug/pRduK9yNplTXyn6 gFAJRK3rsetI3uZ+h7WGbC/XtbLbIzmCcnrSbtSZFQodT+Xrc/zICc3Zuk5OdYlAmk 5Rd2++9FJieEA== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 3/8] mm/damon/sysfs: implement intervals tuning goal directory Date: Fri, 28 Feb 2025 14:03:23 -0800 Message-Id: <20250228220328.49438-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250228220328.49438-1-sj@kernel.org> References: <20250228220328.49438-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: bmoyt11t4mi7od9smdjkhyd8aqe5ct8e X-Rspamd-Queue-Id: A7055C0002 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740780215-612207 X-HE-Meta: U2FsdGVkX19FgOOP53FDdHByHYcUQNmQrA5Pn9FfzqraMelkTvqUqIlJp59azjLjMM2+pJeUqLxOstb9d/QdKEq6ifovBM8HBkqyFRjVi4YVxaQawN2Z4K5wkGwGive3akJU64JX2vNLo1CCFKNN7WElmCcGzq0BpZDCyHxBiF0kHnWEg5/O3DLqUwSV/38OGtOsgbhiY2bXiB0WCvCoYGhEioL+Bz6+SvYHnNE8fyfZWb6RBokTn3nPzTjfFZP4heLb5KQXyB+XRDAflq8UTVeG5elRi2i3gu6X1SBdsGCnWpQBjg4aWrAZn/+otvthdC1R5ersXMJv0cYPYgtiusBO8PAoXg4yDcBTQOPyzKw2B4bKDS0kgDJQXAfciQ5gjl9afCaQpAJVROyXWhk3XbkVephXTLx5TK6W98thA2gjeEmyi03DdjkQYih92IP5/PZi0eu6N3mQCeaFo4bSFryDPXZ5yCKzJMMP56/AOjLniinpbNJz6vfbwPnmCjssVt1hCSv7JdxlHTOum4UBl9vyZDKJvl1i6k3GZthjj5ZBDl/4J15aJOiwxu0+hafM85hQbtmeFkiWS25DeP2klIgI7zBLqmqMhEhsxHfX52S4KbI+Tiv90QQpDGlZ1VaT30FYrrLpnT114RKFtTAHzECDuDsXi4Zr6UqCoXzU0Qdldyu1LqB8jyU7qBt0epw6wYX2hvwNF5DwagX9LcetkNM3C3wusWLDYKkBEg3Uk2Rt0h3pQIr+a9P7OXRXUTOeaoV3jbKDDf/MzU1Cx6hnuKyf0eJwMmyJQusMGMzUP1hcJhX0cLp4zmMGb0XPjGekLxzDQBdi4AP36d6uiYRlCzoCnVkXjiCXovIMADcAK96hKH/rybExt5toowXVlpMGP3tp8CsnpI6wa1R03PtKl1wPMbhEYX7KUsJAolPFISkA98pkcgVR7JiLb0aYEDSAyEZ6T4l1aPy0wnS0qSU 8gb/FQpx tMzSUcWrj2SXu/+72N5LA82F51fmQg3d0DuS9/Qzh7fY7Pa97LfWrvuwekK3JcCQTFRZPLwz0K02qTlJeX3TjrGPoyJ2U2fFhfk9Zi5iQ0D+9ZLiG9vzvTpQrl7Sn/1sdZCYAO9VMfsJLeHwiJ+aNq7vHINSr+igmMeO/tjwkLIbtFeGY4VSYFnjP2KWwnbK1PSMg8XoVIBBpusOhuSXrT7SY28/NzYMyPPMLS108E+QffCI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement DAMON sysfs interface directory and its files for setting DAMON sampling and aggregation intervals auto-tuning goal. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 189 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 189 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index deeab04d3b46..a772060300b4 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -408,6 +408,164 @@ static const struct kobj_type damon_sysfs_targets_ktype = { .default_groups = damon_sysfs_targets_groups, }; +/* + * intervals goal directory + */ + +struct damon_sysfs_intervals_goal { + struct kobject kobj; + unsigned long access_bp; + unsigned long aggrs; + unsigned long min_sample_us; + unsigned long max_sample_us; +}; + +static struct damon_sysfs_intervals_goal *damon_sysfs_intervals_goal_alloc( + unsigned long access_bp, unsigned long aggrs, + unsigned long min_sample_us, unsigned long max_sample_us) +{ + struct damon_sysfs_intervals_goal *goal = kmalloc(sizeof(*goal), + GFP_KERNEL); + + if (!goal) + return NULL; + + goal->kobj = (struct kobject){}; + goal->access_bp = access_bp; + goal->aggrs = aggrs; + goal->min_sample_us = min_sample_us; + goal->max_sample_us = max_sample_us; + return goal; +} + +static ssize_t access_bp_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->access_bp); +} + +static ssize_t access_bp_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->access_bp = nr; + return count; +} + +static ssize_t aggrs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->aggrs); +} + +static ssize_t aggrs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->aggrs = nr; + return count; +} + +static ssize_t min_sample_us_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->min_sample_us); +} + +static ssize_t min_sample_us_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->min_sample_us = nr; + return count; +} + +static ssize_t max_sample_us_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->max_sample_us); +} + +static ssize_t max_sample_us_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->max_sample_us = nr; + return count; +} + +static void damon_sysfs_intervals_goal_release(struct kobject *kobj) +{ + kfree(container_of(kobj, struct damon_sysfs_intervals_goal, kobj)); +} + +static struct kobj_attribute damon_sysfs_intervals_goal_access_bp_attr = + __ATTR_RW_MODE(access_bp, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_aggrs_attr = + __ATTR_RW_MODE(aggrs, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_min_sample_us_attr = + __ATTR_RW_MODE(min_sample_us, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_max_sample_us_attr = + __ATTR_RW_MODE(max_sample_us, 0600); + +static struct attribute *damon_sysfs_intervals_goal_attrs[] = { + &damon_sysfs_intervals_goal_access_bp_attr.attr, + &damon_sysfs_intervals_goal_aggrs_attr.attr, + &damon_sysfs_intervals_goal_min_sample_us_attr.attr, + &damon_sysfs_intervals_goal_max_sample_us_attr.attr, + NULL, +}; +ATTRIBUTE_GROUPS(damon_sysfs_intervals_goal); + +static const struct kobj_type damon_sysfs_intervals_goal_ktype = { + .release = damon_sysfs_intervals_goal_release, + .sysfs_ops = &kobj_sysfs_ops, + .default_groups = damon_sysfs_intervals_goal_groups, +}; + /* * intervals directory */ @@ -417,6 +575,7 @@ struct damon_sysfs_intervals { unsigned long sample_us; unsigned long aggr_us; unsigned long update_us; + struct damon_sysfs_intervals_goal *intervals_goal; }; static struct damon_sysfs_intervals *damon_sysfs_intervals_alloc( @@ -436,6 +595,32 @@ static struct damon_sysfs_intervals *damon_sysfs_intervals_alloc( return intervals; } +static int damon_sysfs_intervals_add_dirs(struct damon_sysfs_intervals *intervals) +{ + struct damon_sysfs_intervals_goal *goal; + int err; + + goal = damon_sysfs_intervals_goal_alloc(0, 0, 0, 0); + if (!goal) + return -ENOMEM; + + err = kobject_init_and_add(&goal->kobj, + &damon_sysfs_intervals_goal_ktype, &intervals->kobj, + "intervals_goal"); + if (err) { + kobject_put(&goal->kobj); + intervals->intervals_goal = NULL; + return err; + } + intervals->intervals_goal = goal; + return 0; +} + +static void damon_sysfs_intervals_rm_dirs(struct damon_sysfs_intervals *intervals) +{ + kobject_put(&intervals->intervals_goal->kobj); +} + static ssize_t sample_us_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -569,6 +754,9 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs) err = kobject_init_and_add(&intervals->kobj, &damon_sysfs_intervals_ktype, &attrs->kobj, "intervals"); + if (err) + goto put_intervals_out; + err = damon_sysfs_intervals_add_dirs(intervals); if (err) goto put_intervals_out; attrs->intervals = intervals; @@ -599,6 +787,7 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs) static void damon_sysfs_attrs_rm_dirs(struct damon_sysfs_attrs *attrs) { kobject_put(&attrs->nr_regions_range->kobj); + damon_sysfs_intervals_rm_dirs(attrs->intervals); kobject_put(&attrs->intervals->kobj); }