From patchwork Fri Feb 28 22:03:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13997210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD65C282C5 for ; Fri, 28 Feb 2025 22:03:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1344280007; Fri, 28 Feb 2025 17:03:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9DCE280001; Fri, 28 Feb 2025 17:03:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC86D280007; Fri, 28 Feb 2025 17:03:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B16B4280001 for ; Fri, 28 Feb 2025 17:03:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5987F141361 for ; Fri, 28 Feb 2025 22:03:39 +0000 (UTC) X-FDA: 83170730958.09.44BFD45 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id B6663C0005 for ; Fri, 28 Feb 2025 22:03:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZyUvQ5RC; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740780217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wecWayJya7F4S/L3tq2SIKHIfTBd/Rti4Uu+Pf2IOVE=; b=KctJrR6TRjFA9AwhY3uFHyt6vE9+A4ztJpPHy4IFuGEzbY9+7Xj1Hm5fCQf/iFa4Wuhv2c R7XD/2InMiN3APixSPwbQvKGjHALqX56mN7xFkTAa3kaPfBVV0VfThtUESg9tv3Pw8o/Rs n4zDtfuEGT5k7E+0Fwr7omB+5Im6ymU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZyUvQ5RC; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740780217; a=rsa-sha256; cv=none; b=LPZt1C5FEEij66MzcLqPxd7id7HO5JW3oltBrZfMT+kkXzIMZVyaXp9/YrUPGuH9CF+hpw Qukcv9blnT/bjdfI76sH4k7Jz5jLzXT5jH9wxwfbZFQJU8Mj9VqJ66w2e2Oz48WRZyAZyY hP30ORC4lajwf6GBEHqmV14idIN5TzE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A24065C69FE; Fri, 28 Feb 2025 22:01:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26C68C4CEE5; Fri, 28 Feb 2025 22:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740780217; bh=LSjpeMzXWVkQm84u7Pg3DRD/aAE+XvDLQxgeGEMx2JU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZyUvQ5RCMFQwflA+TMO8dM7S8jYiryk86Led7r9AWzRFl7xTVycCaRQSn1iJo6WYv jztKcAwB8eAZ0Mkw/Tp1l2SfKnkW5IgmEZjQsG+pC3+R0t2eFqcLFn+SkJW2s+YPgT Fq8ncuwkI7PWynynSVOXwUSMbMxEipKUZXQRZI8ClmQP3EewaVcrxLoybZrBGiWNHa W6EPURqnOVVydku6UCehBFEThJRRLqGY0/9ZDtcGz2xiVRznycPdk/dAcUNjQjaDIb ryk+5js4ai70mv6qkGpCl6Fa1PEi/gHMcPPqChg0z3KCjS8gloBVy2iDJXgealPOjR 0cOIV0q2sQX0Q== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 5/8] mm/damon/sysfs: implement a command to update auto-tuned monitoring intervals Date: Fri, 28 Feb 2025 14:03:25 -0800 Message-Id: <20250228220328.49438-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250228220328.49438-1-sj@kernel.org> References: <20250228220328.49438-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: qgda31t5bb38bwr88uxegqj3objxeggx X-Rspamd-Queue-Id: B6663C0005 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740780217-54638 X-HE-Meta: U2FsdGVkX19HeM5egVVyWC1K/MIghuRWsqj3pPdv9zSJ7pINVZno6l5XkUX6RRR23V9wsWpmNppeecMeAdla3UEOVZqTeWKDMIC6BmEFU8DrNfBKpzti+C77FrITvWuCWdzzIuLGF8RGlrmBt4fXQtO/Hr0EYRHyx2OXqCHzJdSmzaQ2TiBFRSxDarCBtUqfQaUSHKXyvo3T/YtTmklLXbibrgJ1h1YU/IVEmP0YnqvtSAIyovcqszc0QoF/HdgeS5F/L81Y4GkAojBI9jyvYkMp54puUHdetN7zOyDSmog/sjfq7nubuKmjgz2tTV8kKnmqKVTyfCTRb6+OCYSOUkRDTqAQaFoSbFIY9rLEO31p4U8ZQ3wgSu41vOuvhOGQ/zQXujZHDizM83i5hok2fOS3fYgTQME5rpvKnXmHwEaj/028fBdkCgcxTk249uEvCNs9yPDI4E2IBrU8cX1zEkXtdjtrgaXEgBoaT4orIC6E1+xLphpMlkIK6ssAMaTGNwDLkSae9xZHQHgrmBKOHCoVUtLjDLYMdbbRQI2Ni6t7MCXePaxbmPpy47ZBLiGxVDv0gvxG7Io7l4pv7JYw2f6x4lwVVDwmWBgCHEVwPCi8tytPlKqmz9lgIfG3ZXj7IbaCuA/hYj0tUPyqF1yyd9cMwspsOvqXBF9i3i73ZxBESYJnA1KEm9JF2uLnEsaTaAGOLH+TGBr+MAvQdIbuT+wmRUT1A2vgkc89keMC1cJjbI/+hG35OUcs9sst3xm/OiH3WF9wDaqiSwuxw1z6YduGTgt/09oSnrGUazJHQcPDcV3RTvUq+veIdsr/0pBcEuEZC3QFMYHMjgx8O1EBphc2SjdPZ+hm27N8WG/h8vzkg5sDxux0lfqQsQUzNdUyr1VYf2nOIpsNXg3W5yaPeabRC3OitOGpc/9zUz7zdKP4Y6PascMTU8sG0D1da4gSPgOR4lm2/pkoZ6LXGo/ WIGtMjFl Im2WUdfMNnnx9fLCRMFrSqnl7od4YmMHvvdKQjb30gMHkHZFwekYm3Q+4GDRftQmblvbMTB63S6mf0L6L4cYWmaDA87zYvr+l+CL9gLSfp4x7TUSx/ACJHbea4xlllT0vcY+j4r0OroqfXeSAvs7xBX+Z4WVlV5qI9yPZTMtFD/ZhVAntoSLn35ekpkJ+mAb1tw/YgvulX3SQSBYtDez4vfjq3vEP8lfyclUyUQxmsew17oA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON kernel API callers can show auto-tuned sampling and aggregation intervals from the monmitoring attributes data structure. That can be useful for debugging or tuning of the feature. DAMON user-space ABI users has no way to see that, though. Implement a new DAMON sysfs interface command, namely 'update_tuned_intervals', for the purpose. If the command is written to the kdamond state file, the tuned sampling and aggregation intervals will be updated to the corresponding sysfs interface files. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index fa5f004f0670..ccd435d234b9 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1213,6 +1213,11 @@ enum damon_sysfs_cmd { * effective size quota of the scheme in bytes. */ DAMON_SYSFS_CMD_UPDATE_SCHEMES_EFFECTIVE_QUOTAS, + /* + * @DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: Update the tuned monitoring + * intevals. + */ + DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS, /* * @NR_DAMON_SYSFS_CMDS: Total number of DAMON sysfs commands. */ @@ -1230,6 +1235,7 @@ static const char * const damon_sysfs_cmd_strs[] = { "update_schemes_tried_regions", "clear_schemes_tried_regions", "update_schemes_effective_quotas", + "update_tuned_intervals", }; /* @@ -1502,6 +1508,17 @@ static int damon_sysfs_upd_schemes_effective_quotas(void *data) return 0; } +static int damon_sysfs_upd_tuned_intervals(void *data) +{ + struct damon_sysfs_kdamond *kdamond = data; + struct damon_ctx *ctx = kdamond->damon_ctx; + + kdamond->contexts->contexts_arr[0]->attrs->intervals->sample_us = + ctx->attrs.sample_interval; + kdamond->contexts->contexts_arr[0]->attrs->intervals->aggr_us = + ctx->attrs.aggr_interval; + return 0; +} /* * damon_sysfs_cmd_request_callback() - DAMON callback for handling requests. @@ -1723,6 +1740,9 @@ static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, return damon_sysfs_damon_call( damon_sysfs_upd_schemes_effective_quotas, kdamond); + case DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: + return damon_sysfs_damon_call( + damon_sysfs_upd_tuned_intervals, kdamond); default: break; }