From patchwork Sun Mar 2 14:55:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13997841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA745C282C6 for ; Sun, 2 Mar 2025 14:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A9826B0085; Sun, 2 Mar 2025 09:56:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 656C46B0089; Sun, 2 Mar 2025 09:56:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A88E6B008A; Sun, 2 Mar 2025 09:56:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 20A036B0085 for ; Sun, 2 Mar 2025 09:56:19 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B39CDA0544 for ; Sun, 2 Mar 2025 14:56:18 +0000 (UTC) X-FDA: 83176911636.26.CB4A847 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 33C98C0007 for ; Sun, 2 Mar 2025 14:56:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740927377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8kbQWSaKFrksnWfVluuiwipXha1RHiU10Qk+MDjMsn4=; b=ybbjQN7RkqgyYbPlcaf6mBVvf8jZ9bwn+BaYMclkZA6Jvy4cH9k8sOs2O2XXbh1ZphDCRC aPN5x9i5bS32yRcjXqeOumstEuR6n9vWhuxvfXxPJBWrSCtqonveKKcY2WJ5Yn4KxFxHjo /g9dakETI9rSKRY7d3B0L9bBSp/eRhg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740927377; a=rsa-sha256; cv=none; b=dgiD2nM9zBasT2j9uhD88SUhgJo7CNIOHXbN8TQTJeJOJeunCJAUTzjK1oHosCW5aZYk7P j8NM5GjTv6gevasDFgNNWPdoPuJwhIsDPnVDnI6D94BYt7D05W3G9LavXIHZ8mLmcaedgr jCJbdeVdtk0tJwiO5fp6lpuo0flcKXs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC74816F3; Sun, 2 Mar 2025 06:56:30 -0800 (PST) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 291D73F5A1; Sun, 2 Mar 2025 06:56:14 -0800 (PST) From: Ryan Roberts To: Andrew Morton , "David S. Miller" , Andreas Larsson , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Matthew Wilcox (Oracle)" , Catalin Marinas Cc: Ryan Roberts , linux-mm@kvack.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/4] sparc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes Date: Sun, 2 Mar 2025 14:55:53 +0000 Message-ID: <20250302145555.3236789-4-ryan.roberts@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250302145555.3236789-1-ryan.roberts@arm.com> References: <20250302145555.3236789-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 33C98C0007 X-Rspamd-Server: rspam09 X-Stat-Signature: 85ry8mzm8x4y8thnwds1rg6xcuk191ia X-HE-Tag: 1740927377-121607 X-HE-Meta: U2FsdGVkX18x0nh8Qcmm4bnw0+7LQeFl1aJkpGwyjYTMlboR6TKCbN/HMfUEGqy09fxM7gZD83wJeHBrSD2xH4YW4n1UB2vEdINoM/ojUZPAN6nWszyyffB+SPRX57/EdOzkWWTmOkhqB0aJ6gLRliWr43wwWRaUqge9hH+owrAz2wI5UEhVCGH7QCq2eseotLUb+apIVpp4WjcDvLKRiCMapi3saqBwmjfNUbRZ/p24fzgnuu8lAERLiF+EEsKm1DKiPI0qPOtKNqS+jBME92jghSDWxJqGe/VZnIbPeZKCQDtIxQwiHoR6sRWq3qylmozPHfta5Lrx/bgIOOYXhm/Ed0Z0E7N4INsQV4d7u8duiqBQIk2LfVelaa/ozb3F0QKi5FnFgokuQpYw9jTfem+OJuBCstgkMCs+MnlmtyE4znxFEFMQAxUjHWeVaPhGjex0NXfyW/o4tNdT9RxdBlTFNB2wsIiCOQUwe19Ede3TIYBFZnNzOMyYoV6akfOmsFORNx3rX8+vVSW6q4J/0OD7q8m/p08pDzmxfdCs30fFvlkJJ0ia1jjEBtQlszdK81NER3MdvXjC2YycLwH9enAlFz4aP0kDbZv0PDfUqPu9mq0OuiYcwiQCrKNLruiyEpj8y0WCGw895UQ2Gv+eVSu+PhAXPX9/Bl13XoL7BLWW4T+3+nMLT80zVaqvYBAr5aOiIVyVMChUkRWWELWrzctnbBjyoncNMjHXXVYPwnla3oJhrRnoAbRu1hVrBA/hXv5naMUgFDi6x/ect1oovp0ELDrTQVkaSL5XKt+CW7+BHq4Q9kIzHFfo0LTRxaTh7sYEquBvJwtXOyl6fo5J3A2wQiru5X0MKmx2utlo2VFHcPqGi8+kbzMP1hI/3P4mHFurU8Mn5RQ4APmJ9dkAYV1BmbFP0zWC8OJv3ujVV+B2l7b0bxim2tp/jwmCaTeMy8U7JcOAzwL9CK24FUl CH6J+ECF hz2rbiWmfILO77DywK1ckNX6vtWfr/bFQBZfSwp6VGCoS3Tu5XRAnkw7Ls+1SgYRq+biU79oT9gWELvPTb3GQeB2uiA+c7aMPLWwgMYMEB2fvR9Kptnl22SocWL+C2H++iu2VQ06k7nJHP6cqXNYmHocUs48EYNYOya8zJMv4SL7hpDWON8N8rty3lm0N5CiSlmjaOJtCC49kK8w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With commit 1a10a44dfc1d ("sparc64: implement the new page table range API") set_ptes was added to the sparc architecture. The implementation included calling arch_enter/leave_lazy_mmu() calls. The patch removes the usage of arch_enter/leave_lazy_mmu() since this implies nesting of lazy mmu regions which is not supported. Without this fix, lazy mmu mode is effectively disabled because we exit the mode after the first set_ptes: remap_pte_range() -> arch_enter_lazy_mmu() -> set_ptes() -> arch_enter_lazy_mmu() -> arch_leave_lazy_mmu() -> arch_leave_lazy_mmu() Powerpc suffered the same problem and fixed it in a corresponding way with commit 47b8def9358c ("powerpc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes"). Fixes: 1a10a44dfc1d ("sparc64: implement the new page table range API") Signed-off-by: Ryan Roberts Acked-by: David Hildenbrand Acked-by: Andreas Larsson --- arch/sparc/include/asm/pgtable_64.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 2b7f358762c1..dc28f2c4eee3 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -936,7 +936,6 @@ static inline void __set_pte_at(struct mm_struct *mm, unsigned long addr, static inline void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte, unsigned int nr) { - arch_enter_lazy_mmu_mode(); for (;;) { __set_pte_at(mm, addr, ptep, pte, 0); if (--nr == 0) @@ -945,7 +944,6 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, pte_val(pte) += PAGE_SIZE; addr += PAGE_SIZE; } - arch_leave_lazy_mmu_mode(); } #define set_ptes set_ptes