From patchwork Mon Mar 3 08:47:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sridhar, Kanchana P" X-Patchwork-Id: 13998348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8255BC282C6 for ; Mon, 3 Mar 2025 08:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AEC06B008C; Mon, 3 Mar 2025 03:47:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 935B76B0092; Mon, 3 Mar 2025 03:47:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AFC56B0093; Mon, 3 Mar 2025 03:47:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A43D6B008C for ; Mon, 3 Mar 2025 03:47:36 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0E7E9A2A20 for ; Mon, 3 Mar 2025 08:47:36 +0000 (UTC) X-FDA: 83179611312.15.C8091B0 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf18.hostedemail.com (Postfix) with ESMTP id E4ABA1C0006 for ; Mon, 3 Mar 2025 08:47:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Di9dYeH8; spf=pass (imf18.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740991654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7zn2qvfvOLCDp2F8MXE3i6nl8YZve4VX5u9OSi+jXs=; b=UScHGM458eJlYT2RUNLYSEbYLW/SWOPCEtjVRCY6aiLiPMg2+oe0dekQLtZcIm6Wa7MRLY ukQDxfqqHjuYdFCmi/zbPBoBrxCulB1glZ4JTkeLigbxbC37DVwktqShNcSjBcJXdj8PAZ bLgvEcDVPmfKMuJxFxNiHntH6zkRfpI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740991654; a=rsa-sha256; cv=none; b=cZIoFSIN7h8MFW/2Cl93fLzJB2u4DvDMJ1CgfSoMr6iOdxMA8Ybxu25g8WQjEyKB5yYpB0 gEFsaqo9MBsu4DV742UtChBqEaSwrx0arYz9XiOHl1dupRkSVLrMvznn94LtcW6ym1s/Mx iNPERxRP3Fewk+DyG/xD7OHeSCMUAeY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Di9dYeH8; spf=pass (imf18.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740991654; x=1772527654; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8AO2hJSnLaCRd/8HtMcdHOYwB/zSpBOSifH5FW9w0Ms=; b=Di9dYeH8YClOCFztIjlDl3+yijlM5TKzTCcvI2WN+QCZygFkSf6Ktde3 FkN2Ej5eaBX331lY+Af+XlrJOsBncvBNTTt9+jxvLYUizSdBgXRPcZOy6 5qjkiRZJGc/ezEQe0w5+0gLF1slKqvZlmPJrmb+CL0hjrecxVD2LC77Rc IJk+WMAu+J7Z2K6pVc7EVAoQSxyqHlUZpHFMAzMfh640i1MhGepBVNzy/ ulwpA5SWsOxY8Fvo+6GHADVYyxKOJsA8KZvSxb1EFN9TMVzlso6kV0pLY u3SAHpt00h/xk8+HY3E1dILs+5TlB/8/23cFgs5Rb/Cz3ib7Csn4v8WJD w==; X-CSE-ConnectionGUID: 2Z6+nF+JRPe+N4LqG5QkTA== X-CSE-MsgGUID: qXQc6ZXPSEasItVbBrIh0g== X-IronPort-AV: E=McAfee;i="6700,10204,11361"; a="42111885" X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="42111885" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 00:47:29 -0800 X-CSE-ConnectionGUID: SLQFcck9SfqnDM3/EV2iXg== X-CSE-MsgGUID: STpS0GyCTU2r/TCFjJpTcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="118426771" Received: from jf5300-b11a338t.jf.intel.com ([10.242.51.115]) by fmviesa010.fm.intel.com with ESMTP; 03 Mar 2025 00:47:27 -0800 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v8 03/14] crypto: iaa - Add an acomp_req flag CRYPTO_ACOMP_REQ_POLL to enable async mode. Date: Mon, 3 Mar 2025 00:47:13 -0800 Message-Id: <20250303084724.6490-4-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250303084724.6490-1-kanchana.p.sridhar@intel.com> References: <20250303084724.6490-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 X-Stat-Signature: yc8ahk31hijoc3x5r7kfafimi9ryrbw9 X-Rspamd-Queue-Id: E4ABA1C0006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740991653-392084 X-HE-Meta: U2FsdGVkX1/oKh5M90J1mue7pld+r9w5noQZzA9Rg0Bf6lWCV+xzOBkGxwGvkP0zX4QIZGpjgoGeVOicMQ7LfzVyqG4op36e4qrPsayMAwFV0iArNJQ/oKVY1dW4NNo26JhrxcNnIne26cBv1PNoRFJ6VkdKDtsmWYOEmltSWRURk0lxVyVAO9SwNpdGvDOHaOjqFzqBXSakziKaM+0SgUGU+II/w5ePvfeP8l+8pwlFFQN1sqb+FvON3+Vq60FJDQG7k/v+eeWV4Q1aagric+RRjTKp29H9Xgf7KmKryDP6pIprTPll1k3szvf22mqXeoILeqajqd0DRiq5TRRoFd5iIl+RDCzLKd57TiFwe98MjUhJ4SxF27a5xg7Sdi5QjX1mf/ZX0y/YrZ7rjzbGQyrFJXOqBG4tE02Xe/tOKdEMrvg+3OYir/AurunZmmvMy5Wzaldyefq+R7fKWhFUXSlwSYZF7j6Yz6Zsc/fheOtFoMfCOFHLzWVZUUXCJi3zvP4YokWxA3TpQQ09H4ZRtUFEvqlBXhD+4ABKyAGZKSTWsMdwWrVttUF4TSlJRiEwLHisLEUJUc64tUshVlrIPXoaQIcbrf9O/pJUQjocnzxVGCso24OwzqFHlZa9QysqGZbRnBKIOdSvqL8n9jpQYjnMsygfztiQuXFFZ5hTFDYGlm8WLwtKmtzJM7HiTB+Kz1nvxjJR7edqoIl6VL1tnvoC+1As/ssezvGMt0dCAtRgUjFbUqoaWOgGmSwYDHbb6+4o0h7mwsdJSuqiIOGWp2FIwPCaudEw1DhiSbpaYB0NmknN3wbCNzB5dfu9g0yY6XLOMl/GBs+P1NLRxCv6bO0bK1no1UHwl4edb7PX0RFPwTM1ZcH9C94B/XpwfUzTGv9EODZ6IvotU22xcXVDFFQeFLso1UZifBFB9jYrpZpshgJESjWYWJKGonSCcPExs46bbkXs/CYTWfcjaIz QWgG3XHH bZGdMEQw/b+oQkVSm2dvTkCULg6bcpEjYKVpYK26bel6NW1kI9PKiizjiVe58glt05HHvuA9qx55mMdMKultv56BoZ0tGtEdFaSMjgRfjhLhtYLFhLes4yiTEwgwCdeIbDmzsq5ZtcEXD8okpNMgNmsQhcuF+ugBlZ3Mkl9z5n0MDeUoYlJXx11X+BuWdc0pN0+srDzZMlg6aqx739rBDqKg+gIk8gL14rUs8mjPxB5KMFgpggE5MUEfD5mCgkZkYo6LeafC4AxxBQP+rQVf/5INEYhl5LyzqhGCw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If the iaa_crypto driver has async_mode set to true, and use_irq set to false, it can still be forced to use synchronous mode by turning off the CRYPTO_ACOMP_REQ_POLL flag in req->flags. In other words, all three of the following need to be true for a request to be processed in fully async poll mode: 1) async_mode should be "true" 2) use_irq should be "false" 3) req->flags & CRYPTO_ACOMP_REQ_POLL should be "true" Suggested-by: Herbert Xu Signed-off-by: Kanchana P Sridhar --- drivers/crypto/intel/iaa/iaa_crypto_main.c | 11 ++++++++++- include/crypto/acompress.h | 5 +++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c index c3776b0de51d..d7983ab3c34a 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c @@ -1520,6 +1520,10 @@ static int iaa_comp_acompress(struct acomp_req *req) return -EINVAL; } + /* If the caller has requested no polling, disable async. */ + if (!(req->flags & CRYPTO_ACOMP_REQ_POLL)) + disable_async = true; + cpu = get_cpu(); wq = wq_table_next_wq(cpu); put_cpu(); @@ -1712,6 +1716,7 @@ static int iaa_comp_adecompress(struct acomp_req *req) { struct crypto_tfm *tfm = req->base.tfm; dma_addr_t src_addr, dst_addr; + bool disable_async = false; int nr_sgs, cpu, ret = 0; struct iaa_wq *iaa_wq; struct device *dev; @@ -1727,6 +1732,10 @@ static int iaa_comp_adecompress(struct acomp_req *req) return -EINVAL; } + /* If the caller has requested no polling, disable async. */ + if (!(req->flags & CRYPTO_ACOMP_REQ_POLL)) + disable_async = true; + if (!req->dst) return iaa_comp_adecompress_alloc_dest(req); @@ -1775,7 +1784,7 @@ static int iaa_comp_adecompress(struct acomp_req *req) req->dst, req->dlen, sg_dma_len(req->dst)); ret = iaa_decompress(tfm, req, wq, src_addr, req->slen, - dst_addr, &req->dlen, false); + dst_addr, &req->dlen, disable_async); if (ret == -EINPROGRESS) return ret; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index 147f184b6bea..afadf84f236d 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -14,6 +14,11 @@ #include #define CRYPTO_ACOMP_ALLOC_OUTPUT 0x00000001 +/* + * If set, the driver must have a way to submit the req, then + * poll its completion status for success/error. + */ +#define CRYPTO_ACOMP_REQ_POLL 0x00000002 #define CRYPTO_ACOMP_DST_MAX 131072 /**