From patchwork Mon Mar 3 09:44:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 13998442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01BEFC282C6 for ; Mon, 3 Mar 2025 09:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EADB280005; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69C53280007; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53B0B280005; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F856280007 for ; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AA2BF8055F for ; Mon, 3 Mar 2025 09:44:27 +0000 (UTC) X-FDA: 83179754574.09.4419DC0 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf08.hostedemail.com (Postfix) with ESMTP id 64DE016000E for ; Mon, 3 Mar 2025 09:44:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xu3XcT/q3ZUKEZJzSAlmr1efgsUu5/7thCXncPjozCE=; b=VHRAeAK/BBwoSOlL6a5tAbFXUs0WilQn7s20XnnGaEtX7yXMr8csH8kmdxEM9e5frv4n7V miarKYlCQErierodgC5z3GDdoa6oBH6M5Lppxbu1A1lbAAVs6ZlYaT8zUD2gD/5aLoOane 7TBQ06CGCHwVPrdrbtqhSdUANwTsXb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995065; a=rsa-sha256; cv=none; b=PhhyuBOvgduEmLHIngm1q0FXL88sQQRl4i7Bdp5kE36n9eaYqrWIii1WfmtE8crEb5u/4s z21Kr6zXhpnGHL856haHMMPPEz+cnvSVxvEjPpgtwg8rL9MmRHgqxamSG9In1h1WG3sO3j tqWWQKIbwsxIoFXExdRWK/6XbO5YCqY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:9825fa440eeca6b013ca017a2ce8db47,BulkI D:250303172846P4IK2XY7,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1860039833; Mon, 03 Mar 2025 17:44:19 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 4/4] mm/vmalloc: Rename the variable real_align to original_align to prevent misunderstanding Date: Mon, 3 Mar 2025 17:44:10 +0800 Message-Id: <20250303094410.437985-5-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 64DE016000E X-Stat-Signature: 6y41u5hhorqrf7qhg5h9focjene1si8m X-HE-Tag: 1740995064-445477 X-HE-Meta: U2FsdGVkX1+E+69NRPJGRVIhfSZRPEp3LqJ2+Xf10ngdxgE5mtgGoy2pHFBxcsboHGJzjRK9F4ownTM1WHszw/3HCyuIpxIyEwfQPsR4DCtL88R3wSgjvxJ/nwVn5TRobb01/Gz24KR3AmuRgRdhjx/CC5Iaqy07QU9koqGMBMi3TwgPt+qlVRhnShH18hWJ0UsTH6UwspYzQXIb6btC/bdHF/Fj0eV3a6FODHGfzC9Mnf87JY+mAFHx6bI34u8fBPwcqQ6UjlYJM/Vp+cOV6ro5305IvBQQ2qigtv0zAiNWZ3znq5r0mC0kVc8CzIvoVpY+5yDLT/QsKVEcrEk28iFx7glX4sapHxv52ulzE37I1YVisXm6rTgcuAfkCOQCDMvDiuSZCAnPkgL/e3X2j2ZaQXL+6V/5cfxnZhae7ByugcDTW7YLD8NLw+lsTl2Jhq9aflYDylaU84jT+oV3ULARjmoPaW+BMpeRrHIrzqevXPWq9llT1AeZKzX79Vp/20UjZZTEpBz3z8B1iCoX9W1prEJQbmD4oeCmHjbpF9rviwHgbuW34EZajLOY85L8xAZYUOWaP9qJup0YhBQMXzNfFwRxE4nYyxEYt4lJK4ORR9Kkz9Zjqe/Ng47F4gqrb3LEmVUmeMzjFBC8gpNGwRUh44KyN791b7avsuj3rWkZ44TNwF9cOCepdft0CuH2aYIYdaVD6JJKwfRKTHeSkIoXn10VTG3thB9OP/u2U1KukzfNXEdmZ4D3/mHLcF6FnXgXKX2YQqeEjqkDR6JnnuT56X+eD00zz2OxJoH5Cw+xSHqY1pmIXGoLG1z/yP9zKyjX6rEbxpkBHQQTpbkXgJ4Uu3klp1ipkIw1GLpSJI9STTqPdXYa2yUdqzzQLXbjz0fLaZgR6LUGmYRMpIkRn97zZFum/FtQORiNmOeE8B8sBMVBJC3vnEQ3hXX+jbR1gFAKXz2Ip72RxYdJES7 XNHViLqE MBvulPCM39vUHHVosUTZd2FLkeeOUilQi1fRs2dmyoh1oRrm8UbhBssmBZhbLbJAOSi8zXkVdoD0mSJk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The real prefix is generally used to indicate the adjusted value of a parameter, but according to the code logic, it should indicate the original value, so it is recommended to rename it to original_align. Signed-off-by: Liu Ye --- mm/vmalloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b4d2010e5105..a8488452b70b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3770,7 +3770,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags = KASAN_VMALLOC_NONE; - unsigned long real_align = align; + unsigned long original_align = align; unsigned int shift = PAGE_SHIFT; if (WARN_ON_ONCE(!size)) @@ -3796,7 +3796,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, else shift = arch_vmap_pte_supported_shift(size); - align = max(real_align, 1UL << shift); + align = max(original_align, 1UL << shift); } again: @@ -3876,7 +3876,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, fail: if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; - align = real_align; + align = original_align; goto again; }