From patchwork Mon Mar 3 14:15:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13998907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749C3C282CD for ; Mon, 3 Mar 2025 14:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B2C46B007B; Mon, 3 Mar 2025 09:18:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 062BD6B0088; Mon, 3 Mar 2025 09:18:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E941A6B0092; Mon, 3 Mar 2025 09:17:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF43F6B007B for ; Mon, 3 Mar 2025 09:17:59 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8855A1A0AAD for ; Mon, 3 Mar 2025 14:17:59 +0000 (UTC) X-FDA: 83180443878.14.32AE444 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 763E812000C for ; Mon, 3 Mar 2025 14:16:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741011364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HgG5Q+nTVlAgqll+FMqbd4rs2mDD/W+Sg60IhSk4lzs=; b=uVav1qRpPaFFH/JHUgJQ9Kw57PQv9oRgIdlqYgAICLBwSVQZArCNfdkTBIQcEDBvneLnkB XvFrDXZFMPhACRaCQ8CKZZosRVMakc7zRPL5blDeeWnYtSm+k+xiS+VRMyqI6liWVtU7jx GJlmZ5dXuApphJId83Ybdqngd16aSbM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741011364; a=rsa-sha256; cv=none; b=s43Su23XpN3NHv9M4q91tpPU1I6rTiNJ5Hx5Y8sskrO8a9nM/XCnSZFyffGFJwXX62mKp+ EGV7DsfnGJcemEitRwozTxS9OJ8MgO5Jn5zjLMcKYA1g5cOyMf1UiiXlBSKCOmLu09SrLy 28IwAO/sxHss8wcWF2QLdNJdzSB1WWQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F230A1C01; Mon, 3 Mar 2025 06:16:17 -0800 (PST) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B43663F66E; Mon, 3 Mar 2025 06:16:01 -0800 (PST) From: Ryan Roberts To: Andrew Morton , "David S. Miller" , Andreas Larsson , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Matthew Wilcox (Oracle)" , Catalin Marinas Cc: Ryan Roberts , linux-mm@kvack.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Hildenbrand Subject: [PATCH v2 4/5] sparc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes Date: Mon, 3 Mar 2025 14:15:38 +0000 Message-ID: <20250303141542.3371656-5-ryan.roberts@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250303141542.3371656-1-ryan.roberts@arm.com> References: <20250303141542.3371656-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 763E812000C X-Stat-Signature: rgda9sto3d4pc3uyxypro1yggxse78ib X-HE-Tag: 1741011364-983106 X-HE-Meta: U2FsdGVkX1/OhCYvByWyoW+XVVhOyYfEu5fPvJT4odgaflBIaRlJCIAC9/sy7AOPPKEu0T2GPHPOYzcTOWEvYf6v0jMiMs9TX3XHjsp0cTibT/nPtt+i+ec8c0AV9oENBCLVl3WkKa8qjPUxKXtvniX/ySMG37tj/nsUyqQL9vYxxqcEw2CuZiRKp6/EIVucR9m4apz+T0TAlrNLx/o88LI6ZEaEJxA9gLx2Mf1MB1nzsoSpN77hg5LSX5scE91Wyz61pmtqOM73iNsnu5gJjjPKZHwqCL9BhrKdbz5OU2kO2kGnnD3yzG6Lix8PQcCtu+tKtyM/GmvmAKvlDlbWiQty2Uy4jFi7pMA3zsTBgrmyNrk315Y2Qk2uIcWb1maDts6vHnB7pWxim0rVfqE6i1hyH3b40J1WE/U3mmSsuRl4QWSf2uddysuWGaKiPP4wKV0AYu5IsoL0EJ5HfWWg+nNdrfxLx0M0cTqh0IVlLAEZE4n4w4+YI3nj6m/wUrv8nddvzs3lvjd0OqjOWqNlCVn3XbQaxl8E7BBprwJEnEJpqQ/KCWLXZ8Bdl1VdjFtvFT/RSUN0kOBpit2phq8IdwPzFpRyokqQx3h244uTKnYvQ5JUTGV6Bn5PUs39YoWqijBXuJAXcsweav7Gnq7iHzBKHviLrndxbgDOt33kw36JLnpGbjGWFZwe9lTPJC6PIpsHL+1oLoc5VbkjoqdX2AM7POW2IWce8SDQduz5Uo0IcVq96mojqaAaz90tkfm6Y2uqNBNaPK6817sbnHAJccEE4hrvfdMmgvXMytmDAFp5Rl2oAwRF0kvnC2o0Ex3XMTbtUpKmf26Oi+E1gk6K7snR/imeLbrErkfHEJzEB8rWYB7eMX01EZxNyFHuHmFKpF72Ak3ry2fIJAmF2K2M6TAjDzyYnbGGxtqQMbUDaHNqNxfyhRNNnfMB6dI4nV4qxPvGBrmouctDiRizwCg RdQVixoq 00u6NZc6FKo1VlZGg1siOpqENzS4xp5HxEcIMj5nsOOaG1yPP+m63EoRqqn5lO+SLO0T0MRjgWcnQxVr+NVDVdczUGGPFgWoVyGd1W6G0OXWhLwPC6hl2v2SVjmRK3/bdEc1VL+iAhU2Nx9MbarQQOIiKF+510l17C47vbWwTWPHNKq3zUx+wv28JLE0k+f/BpGv33Jni19vPEd3WjR0T3Efbx6iO+3B8cKgFzXRJyt47MOq/pyzEvCnJNw8Y8rnwHvmmvjAwIeuFKGrX7gYKFYPxzCHp6+4wTYyRsa7YYmFRE406Do0crgnQFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With commit 1a10a44dfc1d ("sparc64: implement the new page table range API") set_ptes was added to the sparc architecture. The implementation included calling arch_enter/leave_lazy_mmu() calls. The patch removes the usage of arch_enter/leave_lazy_mmu() since this implies nesting of lazy mmu regions which is not supported. Without this fix, lazy mmu mode is effectively disabled because we exit the mode after the first set_ptes: remap_pte_range() -> arch_enter_lazy_mmu() -> set_ptes() -> arch_enter_lazy_mmu() -> arch_leave_lazy_mmu() -> arch_leave_lazy_mmu() Powerpc suffered the same problem and fixed it in a corresponding way with commit 47b8def9358c ("powerpc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes"). Cc: Fixes: 1a10a44dfc1d ("sparc64: implement the new page table range API") Acked-by: David Hildenbrand Acked-by: Andreas Larsson Signed-off-by: Ryan Roberts --- arch/sparc/include/asm/pgtable_64.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 2b7f358762c1..dc28f2c4eee3 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -936,7 +936,6 @@ static inline void __set_pte_at(struct mm_struct *mm, unsigned long addr, static inline void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte, unsigned int nr) { - arch_enter_lazy_mmu_mode(); for (;;) { __set_pte_at(mm, addr, ptep, pte, 0); if (--nr == 0) @@ -945,7 +944,6 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, pte_val(pte) += PAGE_SIZE; addr += PAGE_SIZE; } - arch_leave_lazy_mmu_mode(); } #define set_ptes set_ptes