From patchwork Mon Mar 3 16:30:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13999206 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02952C282CD for ; Mon, 3 Mar 2025 16:31:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D47228000C; Mon, 3 Mar 2025 11:31:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 087A7280013; Mon, 3 Mar 2025 11:31:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEED428000C; Mon, 3 Mar 2025 11:31:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7AAE3280011 for ; Mon, 3 Mar 2025 11:31:05 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 91AFA80C81 for ; Mon, 3 Mar 2025 16:31:04 +0000 (UTC) X-FDA: 83180779248.14.8A2C24A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id E81A518002D for ; Mon, 3 Mar 2025 16:31:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C98sW9BJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741019462; a=rsa-sha256; cv=none; b=u3wvlXW87dxtapzh2W0T+MjwlksdPJWSEBhTeEOrAFSHamu1FOywSpTb43DgTLLnjGMggX w9sgGa2FEW6c8Gerr78NEZE3DHf+7ot3qseXL8ZclRfhP4rhPBCPXoP9biMTIwjtCvWFWe d31ZxAASaqnsw22ngEbwvk4qYAxKFzs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C98sW9BJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741019462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Ha8UZDq7Lu61upXZpfKkXckZhfouMk5cB7+X6dnx8Y=; b=WboEiokgHLaaeXihBKD3wSa6cWyjm55yzHT1VdYbPq8xt47Bx3qLzphfCnPvJ/unUp7xWv Rsa9rSzhDrhnXdDML334ZGTYVk2ITbAIUZjSI1aEmRmkUYjlKh/juRic/D38iIXi9MRgoa hE1MSt8Iw7yWyRh7GjTYFcFGuMLe4F4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741019461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Ha8UZDq7Lu61upXZpfKkXckZhfouMk5cB7+X6dnx8Y=; b=C98sW9BJyUqqx72Yo/iILcqzlDS5Zk74Q5B98Ele51F1Z5PPnj6KgHbDR9pVMSS5NBauch iBcpPIO7Go5em4kSqtq7ljeaGKMB24h5ghCPegt/hb9pkPrl58ndQ7v5c1mFevZbxuc476 IeHqa2bL1ySNa4peO4WVhQs9ZwK2iVI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-zCUIZIi0Noe-Ncw2Y0qpeA-1; Mon, 03 Mar 2025 11:31:00 -0500 X-MC-Unique: zCUIZIi0Noe-Ncw2Y0qpeA-1 X-Mimecast-MFC-AGG-ID: zCUIZIi0Noe-Ncw2Y0qpeA_1741019456 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-390f9d00750so1344834f8f.3 for ; Mon, 03 Mar 2025 08:30:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741019456; x=1741624256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Ha8UZDq7Lu61upXZpfKkXckZhfouMk5cB7+X6dnx8Y=; b=TQC/qkRrb0JVA9guQs2k+MknniqjIiCbh1k0kMZnH0aRZThfKmuE81BEpqZWja6j+4 Wx7sdKqUdLsl21EkNHbQFyxxuv2TmM08ilivi87K2r6uW2UXc0kt9xIBrkfeIamglnoY KfAqfU6ICEp5PkikTGXPklnPTkte3RRPp24DlRDqwVLFpCeSZM3/Q1lYwc3xCrQYKfkn ljgPkX9uhp1/uIH/P/6y37iStsDJ7i90rlaqS7RbXu7TDMz2TrFRYfMdSAREB9f3TZ/p 1ZZccdF0Mxr14tj9WBGLmp2UcEjZC7xp6sqyMIdZ9YxoR/d2gSdS0yWVhzzMk9+GSivD kiyw== X-Forwarded-Encrypted: i=1; AJvYcCXHbhgJ8FN/wAZUYPAYKe1PLuWr/IoFSubdccVi9oxhSBT/sBvB6RG1l8H5ITlGiYcsgBlbL1JGdQ==@kvack.org X-Gm-Message-State: AOJu0YyQkv+Zo/z45OxXFBMgaKvBs4zLA2sN9wL6W9EhqtIHWkgka0K7 7ZEGcyBSYCczc016ACQy7Q4cZNR9rZlE2iZMhaVNqPufLdJAqkYMnS6QNl/1ByVIbm/aA1o4mgg Gnj9lp6o8Pp8vFCE7c9ax6y5SLxAh3C9fz83ngq6IbFarby71 X-Gm-Gg: ASbGncs2cCq3wiRIr/RQIjWCmQd9yFmEdtYr7BVuSZ0kQjt7PGo70jJEH0kTV0B/veN es5LEjP1azKmhWKd9qncJPEjx3zeDq1nd25nk/Up01Tx3BbfZT1uRRD6MzEAzzYZmu/c9Ce9643 nAf5BAQ+uffPgxAoiC9H+1YrxPHSsfrxjhbeC5dgPSPV+ykfkPH6x8in8zx8ZTEsnxB5XVh/jl3 NnYa6Y55MklcqdAg7ILqOH+BYu6Hg3DRXWj36xfF/rejCtSTIAWmzwI9+6MlqVTrGQIEY7pnlmr tuwVeCDJkDf/BMOdZ1BAzIaTsXsTsN662BDKw8yTObxfBR5cmAfeoyvR0d5jXba71nQ21ZJyzom I X-Received: by 2002:a5d:64cf:0:b0:390:df6c:591f with SMTP id ffacd0b85a97d-390ec7cd2ddmr9512470f8f.17.1741019455923; Mon, 03 Mar 2025 08:30:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEU1cXWjWugfmabLrmr0XJAbs+GQI7107y37ij+zO9LNUtV9tqHS/ZXKWHCRmLlaLTb16eXbQ== X-Received: by 2002:a5d:64cf:0:b0:390:df6c:591f with SMTP id ffacd0b85a97d-390ec7cd2ddmr9512425f8f.17.1741019455528; Mon, 03 Mar 2025 08:30:55 -0800 (PST) Received: from localhost (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-390e485ddd1sm15052695f8f.94.2025.03.03.08.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 08:30:55 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn Subject: [PATCH v3 17/20] fs/proc/task_mmu: remove per-page mapcount dependency for PM_MMAP_EXCLUSIVE (CONFIG_NO_PAGE_MAPCOUNT) Date: Mon, 3 Mar 2025 17:30:10 +0100 Message-ID: <20250303163014.1128035-18-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250303163014.1128035-1-david@redhat.com> References: <20250303163014.1128035-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sAUTudQflFNshL2OALMn9amfHgDSZLYHOC9-dEKUnoI_1741019456 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E81A518002D X-Stat-Signature: 69sugo5skdtxmayi4kgtgtu56mzd4o79 X-Rspam-User: X-HE-Tag: 1741019461-234001 X-HE-Meta: U2FsdGVkX1+pVmHWWs4+3BavVS/z35ncTYEfGBmD8vGa17dFRQvr9KiWFft7bIC7Y37eeG7poeb1PKVKTfNJhhqYVq92mDTX7DH4SxTB1xDabxHyKpLVMaovOAKUjzXuDHZIfd12yf35D4zcDhG37rn2kfF0itHm8RcBYVQY0LutgXGkVVEj6kMvHsw2vTvV3DaT/5u9iGcuSa2/n75LS/zU/NRRPnHjVAb87ivEu2BzNq9mIftfvvZ/QP7Ssgr2DDD6Ptgm7Pn9ZJDdyGF2F6TXJEJDzZHllkaIKpLRfuVrtnWI+n23MigGss/qHjdUzJyb9+hgKR2yU68dWTh6PlETHwx60Y7X7EWt240x8TiIid9rl36WbKfNvh0Srt4qvBPxak1udJqbWhuNe7WwhN7n5wiGLpab+/WSZnjxvg9SfSxsi/uITQ/CDMAR8gcFHd5hvKnT49l3/9c9CJYRuMGOp6bwjyYyUCwhGys8iMXAe862ZAmGhI0KY6JpFzJJzjrWrpXODGz5yTVNwK0xG2m+vJ9FbqlYcICCaU45q45w8m8T/f8vxvoQSyqQ4lo8RBWdkUhPoM8dLokyoGYa0FSO1/QZaNBt3lo40le4CSyo/2GrH6mt9ALXGQXExZW5Nctstqta6iuEQ+4KrJoO1RrmHUkxAUKeQCmahouiAQJvdEqk9prv68cHecHl44xlHyeT4Yp0GB8qpdPy5rKPQq4JMDxoahct8KowRNLepleGbo9zYHJ908Fphm/S6ruLwhnxbWWlrvBxH6jkE9HKRePYstb3MC2LLjk7lsEkBqhwkkTqbs3vavO/2CyHdSs9YshjxOHAGZbZVSvNFEfv7AvnoPUhEUlH/yG7WNIeHjvYYYS3BP4b97nKmXZYZr6rgbZy62QvYY9A8RGwWHg+vJEKtax8BNsyJno0CAPIo+LVAg0EoIH1AQ805IolIEiIKSiXfvzBhDYK7h1//Zj sMnK2+0Z /098zzLubq9lL/I7SLX8Bt6vZQgAJP0MHV82yQKn5R9ru/e/GonV85RX2b6DtwegFMmqsja5DrqqR15Q1RCPRgrJoqK9gPMCxyCysegyV99eM691VUx2oeDcKsaUSKZ8ottfmuoYXAg4cqznl28OZS/f+QqOmKm99Tybr/D9hr+IvZF9NU6kx5N0VHdqhgJThpkYPYMBi2dbq3gIRBuVBi7x3bol5GcnM+IpB7/7lo1w6F0DdSgBtySRKC6cbQ6zV6n/BFcR4oOGcNHIjhVU6xqd98sQ1esFS+gEdQkZqwPWpP0vssYEPIS600+t0ycihoq+Vu4fV45UQT2a8kEInsPPNavq1nsCz2/T5zeMuprgw0vWH8QaVXf3vkymVR92DERBmClYaEaD/v9Pui/FS57evktjCapR+sfo0c74vqWnN0/ED6E8HcBWBl6bJ6e8qyS8269O/AFKuSN+qrbba/dMqTPgRJdDqm+MO3vD+UAqFx5ceB//5BciDJHS7p05tv/hFova3/TKN91h96WwdCmH2CA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's implement an alternative when per-page mapcounts in large folios are no longer maintained -- soon with CONFIG_NO_PAGE_MAPCOUNT. PM_MMAP_EXCLUSIVE will now be set if folio_likely_mapped_shared() is true -- when the folio is considered "mapped shared", including when it once was "mapped shared" but no longer is, as documented. This might result in and under-indication of "exclusively mapped", which is considered better than over-indicating it: under-estimating the USS (Unique Set Size) is better than over-estimating it. As an alternative, we could simply remove that flag with CONFIG_NO_PAGE_MAPCOUNT completely, but there might be value to it. So, let's keep it like that and document the behavior. Signed-off-by: David Hildenbrand --- Documentation/admin-guide/mm/pagemap.rst | 11 +++++++++++ fs/proc/task_mmu.c | 11 +++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst index d6647daca9122..afce291649dd6 100644 --- a/Documentation/admin-guide/mm/pagemap.rst +++ b/Documentation/admin-guide/mm/pagemap.rst @@ -38,6 +38,17 @@ There are four components to pagemap: precisely which pages are mapped (or in swap) and comparing mapped pages between processes. + Traditionally, bit 56 indicates that a page is mapped exactly once and bit + 56 is clear when a page is mapped multiple times, even when mapped in the + same process multiple times. In some kernel configurations, the semantics + for pages part of a larger allocation (e.g., THP) can differ: bit 56 is set + if all pages part of the corresponding large allocation are *certainly* + mapped in the same process, even if the page is mapped multiple times in that + process. Bit 56 is clear when any page page of the larger allocation + is *maybe* mapped in a different process. In some cases, a large allocation + might be treated as "maybe mapped by multiple processes" even though this + is no longer the case. + Efficient users of this interface will use ``/proc/pid/maps`` to determine which areas of memory are actually mapped and llseek to skip over unmapped regions. diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 1162f0e72df2e..f937c2df7b3f4 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1652,6 +1652,13 @@ static int add_to_pagemap(pagemap_entry_t *pme, struct pagemapread *pm) return 0; } +static bool __folio_page_mapped_exclusively(struct folio *folio, struct page *page) +{ + if (IS_ENABLED(CONFIG_PAGE_MAPCOUNT)) + return folio_precise_page_mapcount(folio, page) == 1; + return !folio_maybe_mapped_shared(folio); +} + static int pagemap_pte_hole(unsigned long start, unsigned long end, __always_unused int depth, struct mm_walk *walk) { @@ -1742,7 +1749,7 @@ static pagemap_entry_t pte_to_pagemap_entry(struct pagemapread *pm, if (!folio_test_anon(folio)) flags |= PM_FILE; if ((flags & PM_PRESENT) && - folio_precise_page_mapcount(folio, page) == 1) + __folio_page_mapped_exclusively(folio, page)) flags |= PM_MMAP_EXCLUSIVE; } if (vma->vm_flags & VM_SOFTDIRTY) @@ -1817,7 +1824,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end, pagemap_entry_t pme; if (folio && (flags & PM_PRESENT) && - folio_precise_page_mapcount(folio, page + idx) == 1) + __folio_page_mapped_exclusively(folio, page)) cur_flags |= PM_MMAP_EXCLUSIVE; pme = make_pme(frame, cur_flags);