From patchwork Mon Mar 3 17:10:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuad Tabba X-Patchwork-Id: 13999275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79B2C282D1 for ; Mon, 3 Mar 2025 17:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61A0728002F; Mon, 3 Mar 2025 12:10:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57B9A28002D; Mon, 3 Mar 2025 12:10:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41D9D28002F; Mon, 3 Mar 2025 12:10:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2149428002D for ; Mon, 3 Mar 2025 12:10:39 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D57AD80D2B for ; Mon, 3 Mar 2025 17:10:38 +0000 (UTC) X-FDA: 83180878956.27.144A20D Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf15.hostedemail.com (Postfix) with ESMTP id C99DFA002C for ; Mon, 3 Mar 2025 17:10:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UzzzDEjw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3iuLFZwUKCKseLMMLRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--tabba.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3iuLFZwUKCKseLMMLRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--tabba.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741021837; a=rsa-sha256; cv=none; b=osOT9waWDkwrqF2lyoHkltMLMhEJklBeLcEJh/NdrzqvMxSbxfoTBawX5Tasrggm4vfPZL zZl51kFrg1o53RisyNtEttSTnR4YM6vbZXzUy2RJwtMNhP3Ymz5hvRL4IyIIQMzsq+dJvh t2oJxCqjmgr8qyQ1DnfZTanlP5bsNbM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UzzzDEjw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3iuLFZwUKCKseLMMLRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--tabba.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3iuLFZwUKCKseLMMLRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741021837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=shxzjltmhVCSEs3XLEEf6Hj2khLkpxaqKL228sddyqU=; b=GtM5O2n+DqbBkyI6NgMblJvHG4+VjD9WvQonlQYvBRDn3+JT26txq76fuyoJc6swQlHKMI c5CIcYRP2hH9WrcAzWAfbAsni+EvyYjax+z+UGycdeFNQ6DwbGahrRpOsaTCB5uREguWro VEYkz4kbVj4ZLKxDuKmTSYBil88jMBg= Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-390e003c1easo2129365f8f.1 for ; Mon, 03 Mar 2025 09:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741021835; x=1741626635; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=shxzjltmhVCSEs3XLEEf6Hj2khLkpxaqKL228sddyqU=; b=UzzzDEjwVF6QKs8kWkQPxlmjtyEhVlYLiF+xFavUD+VAODFPz7MGUMtiRjmlO2KPpj Lv854bvZyZZhw3vnHiV14Qk+F8vd70FJzC03ssjWHFuLHS5g7+PDMXtXIUCk7DtJmuQ7 LysBbxeBX2y/k+L4s4qMQYoQy9VHQR4YZUhgdu3ZITblawDrveuwxfF9hWWyw/FPcbey QY0L8ba+Rc0Lt5Ib6jf9XqVAGc4IfVDG7/dupKgXmk1pXr6whtJ4H62qPZlTTO9p9uBz jbK2mSSeIWqX8s6yWemish3qn8hXiz4DqepPBq9+js42mTke/tZAaMblg+s05s+qg9ju FdUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741021835; x=1741626635; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=shxzjltmhVCSEs3XLEEf6Hj2khLkpxaqKL228sddyqU=; b=mO8bLOudamFVAawch7CRQwLwT1BFyDMmEgy35u/fkx5kqyOL8Akh7vZTEMNivIoh2s iRTqlwXzqGxsppGS/U1oeY9WGCPGXUuTLG2u+u4ZMqb0FywnT6T9zxSzmQZpCif+WQu8 rjhb3WmpRZ0Jjyzyc50nw6lQHQRw3nvBlFEbs7Vek+zLDNeDU2mIRPSRKsRoGphKH+PG GxsWBhXlwijuRokXOqYgKt3v0hMNwOBkubbN7FFqt/aUxUxqxs4n4g9Xibzzdcb749dJ 0tsXxdKrvAouM7mGYv7O9m9KMHTMhbxpmCj2vIX/xLv4f3b85pWq0jO8aJz6oab8JWSP uMDw== X-Forwarded-Encrypted: i=1; AJvYcCVKqzcuJOodOBHRB+9GbpyDCNQpJsYPLpVugZBtVOGcGVyzGEXiTn1pQcNx0UlSpffrWXjz53g/Ig==@kvack.org X-Gm-Message-State: AOJu0YyGbfuyl4syblirZ5fDopfaSEDTHCdKUpNMW4SIzbm+Z53IE6X8 3HV95V6ZTwHbodiER46tA8zhG7yc2HA6wvNDQCfvWAW9dxZQ2mPT6OBgq2Qf2yrBMdeQ07aUsg= = X-Google-Smtp-Source: AGHT+IFRshHAVxkzqZnB+ggYu/XSK/78X/FWHRdv+7cCRWE1mXA23VnZ9DwQ8SGznRbx9niCQ37rSqzPuA== X-Received: from wmsd10.prod.google.com ([2002:a05:600c:3aca:b0:439:7e67:ca7b]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2c7:b0:390:f0ff:2c10 with SMTP id ffacd0b85a97d-390f0ff30camr10550328f8f.19.1741021834976; Mon, 03 Mar 2025 09:10:34 -0800 (PST) Date: Mon, 3 Mar 2025 17:10:13 +0000 In-Reply-To: <20250303171013.3548775-1-tabba@google.com> Mime-Version: 1.0 References: <20250303171013.3548775-1-tabba@google.com> X-Mailer: git-send-email 2.48.1.711.g2feabab25a-goog Message-ID: <20250303171013.3548775-10-tabba@google.com> Subject: [PATCH v5 9/9] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, tabba@google.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C99DFA002C X-Stat-Signature: 5fc9q8aoz8jimkiug8dthj3d6zwjbrzf X-HE-Tag: 1741021836-680854 X-HE-Meta: U2FsdGVkX1+8tskvLeYN2GqZ2AdfgVl8GDk1HLs6z+/vwTJ0o5dfdI3p9WrXGV9Ym0a46uGRQc9NFVKc9Z7CmTuQKnMv/jKLeiQV2eeBverCRGFuJt/eUV+xzY8IWZ2iFbk47cFxnFSpK7DOeC41xsCZLsrukrTF5p0Y1vYGj7xTZlM8HogDfdf8OiYCqZqDKWvRsKF275Yl45+R7gnWPeirByn+/JsRyiaDBF/a/mmjeb3DNCa1XgQQHkas4U9lov4NTQmrEXo/8hem0NT6Z4HWn+mvQOMzzkSuMva/Ci+0xPTKUTXv7yJ9+ibKFA2xzWLcHFXLkjQtdvpo5woVxNTfbFCL8Ovi7Pc9/7aR9yPXy+MKhHlDFVsftQh10/oM1okSMhJJE/NEBSIjb+R3d2odaIyjFSQ6XyQiJZoOVbpww5tOezlFdhmwELuOYbNuxkHAuIwC30juaOdunzkgstsYEVTPBjEVeRxshDYOWUKYOMt4Of4Fj/T5jHhkGdZt6i3df4gNGCx4CJWAo49oGO79n3D5w8epv5LV7fSH49q3P4/LYzszTgIuo8xbe5XBbbGqzcQnpUROkfdftEInxWJ7bVnM8NSdWdEuagYTTxXwBMf/uxW9WNbmHfsVKZ3KkUB4AnURwkzvoogHdw92KQ/roj+s5CkSmEzhcz55fouaWlcekNMRmikNWFjwsoOeFR405nljvJ39YDyzmSEggCRu+TXSf+CwzXWtIqlJqGGCDUvxvQx66sSBO9SrkXf1c5FAMhqbwK5sg0yBjoCGP5wNtcJeO9xR8yibuMYPWsUEOgjhIf0KOdIJMSsod43Q21Hcm8RY4PMqrBCoYDhIzHXxrjDL8cd38y+Rqh+cBdAW+BSBt8JczhmAVy3nqd8jwM1PePiM5CAZBOxhoSL2Lkj59aU4RRLJ7kjUFRxmSwJfmsi4Lax461PZBGxeOZ7y1pqFRQsSIEW2SX6al5u cotKCQcN ONIdK78QYgF8CKjSas83QQZs9d4/V8iKmgVyJIAsAqqQH9VlqLu8ZlJpTxyZ923AV8GdVT/LCjQlAMVdCWnWT0NwQScd2RYkobWBEh942o4loudRhpkeAtaPYL3f03ouSTsD9EHz2dS9jPXmY6x4tTxBuEEpTC7UbVqjRJTLeNOOhgFMWdP/y/ZxiS7KzRy4+eVuuVZgoMY+EacwmCI6H4DVykyynINZM+bxYerPt1j4w/XL+8lZNSrs700yOPgPLHWIL9L5Kstlw4Q7VZPc23cVatSQzzxI4rgqBvLXY5tbKGpJwmFj/UqyOwvsutyUpb95lPWkLzzsb2Z28QoH+09GLUzLt77j7GSHZfR89cXSTQkMvluzQfVldYv4Xp9JLiLpwsYivEtvnWdC8UIbUlM4350KMsYqt30O6IZf7aRCyNQc1XdnGMLgQyElquX0IosNRAaZJqhWlWFBH1OqZlV/h/ldh6QD5yi9LcdIbzHhllEkusXjpfifcnyS/keuZH3mXjmf2Vsz8JiY0/tx/kLwaJOYJ0KXaF8FitDfQp7i0m+IsPevO/mFUSgEk5y8VBTdqLCSdR1Mnq05yaoBcP+A+HZi50QQM0bJhi1IASjSHH/pPKvkJjJVlJ3Gwn+j+x5jcRlcXTPg5uT34x0rqI8yrNkS28RZDIrLWcXM/J0Hu7TmqJeXywhWfLA8M0aUu7YZK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for aarch64. Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 4277b983cace..c9a3f30e28dd 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -160,6 +160,7 @@ TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += demand_paging_test TEST_GEN_PROGS_arm64 += dirty_log_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += guest_print_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += kvm_create_max_vcpus diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..38c501e49e0e 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t total_size) { + size_t page_size = getpagesize(); + const char val = 0xaa; + char *mem; + int ret; + int i; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t total_size) +{ + size_t page_size = getpagesize(); char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +unsigned long get_shared_type(void) { - size_t page_size; +#ifdef __x86_64__ + return KVM_X86_SW_PROTECTED_VM; +#endif + return 0; +} + +void test_vm_type(unsigned long type, bool is_shared) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(type); test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (is_shared) + test_mmap_allowed(fd, total_size); + else + test_mmap_denied(fd, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +int main(int argc, char *argv[]) +{ +#ifndef __aarch64__ + /* For now, arm64 only supports shared guest memory. */ + test_vm_type(VM_TYPE_DEFAULT, false); +#endif + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + test_vm_type(get_shared_type(), true); + + return 0; }