From patchwork Mon Mar 3 22:17:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13999545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636B5C282D0 for ; Mon, 3 Mar 2025 22:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7103E6B0083; Mon, 3 Mar 2025 17:17:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FB106B0085; Mon, 3 Mar 2025 17:17:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49C976B0088; Mon, 3 Mar 2025 17:17:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D1216B0083 for ; Mon, 3 Mar 2025 17:17:36 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CED8D14105B for ; Mon, 3 Mar 2025 22:17:35 +0000 (UTC) X-FDA: 83181652470.09.C5D794C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 3146B140009 for ; Mon, 3 Mar 2025 22:17:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=orStVIpc; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741040254; a=rsa-sha256; cv=none; b=x1+zhiXZy3ERL3QxXzHkwsrsaCyqZUa8kJax+FIJVCIZaUehrQr5tgltlR/4xqVGYXWFL8 0D+I4VNjzgW4pJMA6sgNBopd4LRlPZxPl2vHY7CrjohIB1l48WHqwe4gMZjACSt1Z+uOVm SP9FWkFOmZ1QDwGmzaf0iqbavvIjsx8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=orStVIpc; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741040254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gqGbT/b/OGBJ97ibcjSFPksNach3RFr3q1dIU+3TbLw=; b=5FmrLJpq9vtJSTlPstuylW93Gx1aM3WEyG3SiyBofiVlf81RKtYlvTnae6n57JRcEosCmF /Kz4Rd604f4Qi8mfDFwRjm0WLfIt/J/ZtsvfNsHFfqZaA0n+3abXqNqzleT1gat8zYUXUL 0bLmJr858wfgzgzpMBkrTKmFmX48C2o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6DB58A450C0; Mon, 3 Mar 2025 22:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34F0C4CED6; Mon, 3 Mar 2025 22:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741040253; bh=iSBVb6PukRtPBydpg/2aD8QyTDEBPd4vfWzy9ndeL3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=orStVIpcjoJT1F6q/41W0z31q4TLWCnp1EuAFrsPs+gh9TtHFH/XXTbQx2bhxl8ql 4tcYU6baJ/m1Eh/86PgFc44ZT6xqCDUqcKWp73qgpz1lW47mOqJ1ssHY7MzjgSP5hl cKEmNtyT5XCs8Ex54DEOpsE4J/KuAwfqlXfzldCEYOGyxcoRX138EpkuXOnrdkWhqh MLVE6+9Sx1jWwBaF8zhMiVxjSszYhKBawGweYEHRvTPy+pRhlsa678qLsyr0bduuQE e1ZBmlvS+Zw+NpnMPuQEheCovxLF129gH1ra6fGo5Jum7LER4LhNFfw5C/oq1CED8q YLt5O+Ce5GMLw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 1/8] mm/damon: add data structure for monitoring intervals auto-tuning Date: Mon, 3 Mar 2025 14:17:19 -0800 Message-Id: <20250303221726.484227-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250303221726.484227-1-sj@kernel.org> References: <20250303221726.484227-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3146B140009 X-Stat-Signature: snm5gz76c7khdencjx8xoss65tsd4zsp X-Rspam-User: X-HE-Tag: 1741040254-75657 X-HE-Meta: U2FsdGVkX19AvOevVWGETmfjXoF+oqBsplWUSCeUqgf0V3fOdJi+RF/szeockpFDVcN/NrG1/D+IDTeo8hhUVH/2MX9aqIqKbVJvIXg4KOxbnFXsJQbS13B4mlq5SaINH2G5MdCzArXZmdq5Wx81Jvw2zqlbOPTsDSRR418Jk2Kpp6QsPQ1vRluKBuZLbsb0vnxc+SEHhX3vv3K6u9benBhjNw+CT/2i/7epTC0z0rjmqwuDLXsPE+ZD5BuMHp3T40G70PW2thmyG/3kCoOOiyXOxkQj6CO0JKHWsC2f1bFsptMm+kxyfAht44uKNteQOeEStMcfLlYbRxfUoxMsCKyX2Xms/kcOHJQMxosN0ZSEAloeKgfZs67jZP5BnusKEyM8wVxWmjG3Y2xER+GASb6JBD3BNOlv6IuhJLyymEq1ao/cixr8jlTM+1tzAZ8CLrzCO5GiDPL+nIAZlwzixmdmTNtluMfeaIUS+IpJuzC5pf66qDS0u3Her6q6HGkSKSbcxWE8lkrrrr0p4XbaP2vhclbPriG/ZIJjwx7U1RZki4XJ0Ml3jfb1aLCbULu3T9ZUgYhRp0OY9DrY7rkRWGhU1Ar8q1ihV9lFu57iF7mHaSwAobArXAjufub5jWPw8fhC+PCvZUDp3lILWsN/9kqCt0wi/xb9M2U0S9e454zHtEI6X6p0GMLx3RR6uNGFZmhcQr0Xm9WhJsVMGmO87WvlNDvDHBPSsT6OyMGpiPNt1KdbmYRb/LU+F4eDcvjVQMKfWoBknhLnN8DV3+hbvfx4ajVTKlkkyguHsHEDUS1nhzCx2EZ9C6mXFUhTfanIbzRP7qu7M7zCY0eRBPRwctGapY+5nnFXnWg50E1yzVwYdU2E/jT6sWFRhFFPeW0uslvHISkVZHJ2UbQfZvK2t55rE+kSuisA+vp4VQXCevIm72QvYbdMXtkbhBpZedSKxXUejFSDRBi/6Nmjq3v lyQGqlFm lQWAL6q+5cyc5pNluuMAWNekMzEHHE7YTYqt+ywz9bjN1DjvtGV8nXmQpzHFQDiDgmV2fc0F+QZ0O3w5q10PNTVy63pnwBINJrZFP4JK5MVEVCmxE04+5bMrmOPBHFBPCz35LkHUzbCA7KSPwGfyvRsjbDXjO8Mvr3XoJULcy6fh2HLDHBuMfKoP3TL2YNlGeQIrgqiXTvz80GMECGCovwMoqJJQH93oh9/iOf4eaFAu1W0c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add data structures for DAMON sampling and aggregation intervals automatic tuning that aims specific amount of DAMON-observed access events per snapshot. In more detail, define the data structure for the tuning goal, link it to the monitoring attributes data structure so that DAMON kernel API callers can make the request, and update parameters setup DAMON function to respect the new parameter. Signed-off-by: SeongJae Park --- include/linux/damon.h | 27 +++++++++++++++++++++++++++ mm/damon/core.c | 22 ++++++++++++++++++++++ 2 files changed, 49 insertions(+) diff --git a/include/linux/damon.h b/include/linux/damon.h index 242910b190c9..5f2609f24761 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -659,12 +659,38 @@ struct damon_call_control { bool canceled; }; +/** + * struct damon_intervals_goal - Monitoring intervals auto-tuning goal. + * + * @access_bp: Access events observation ratio to achieve in bp. + * @aggrs: Number of aggregations to acheive @access_bp within. + * @min_sample_us: Minimum resulting sampling interval in microseconds. + * @max_sample_us: Maximum resulting sampling interval in microseconds. + * + * DAMON automatically tunes &damon_attrs->sample_interval and + * &damon_attrs->aggr_interval aiming the ratio in bp (1/10,000) of + * DAMON-observed access events to theoretical maximum amount within @aggrs + * aggregations be same to @access_bp. The logic increases + * &damon_attrs->aggr_interval and &damon_attrs->sampling_interval in same + * ratio if the current access events observation ratio is lower than the + * target for each @aggrs aggregations, and vice versa. + * + * If @aggrs is zero, the tuning is disabled and hence this struct is ignored. + */ +struct damon_intervals_goal { + unsigned long access_bp; + unsigned long aggrs; + unsigned long min_sample_us; + unsigned long max_sample_us; +}; + /** * struct damon_attrs - Monitoring attributes for accuracy/overhead control. * * @sample_interval: The time between access samplings. * @aggr_interval: The time between monitor results aggregations. * @ops_update_interval: The time between monitoring operations updates. + * @intervals_goal: Intervals auto-tuning goal. * @min_nr_regions: The minimum number of adaptive monitoring * regions. * @max_nr_regions: The maximum number of adaptive monitoring @@ -684,6 +710,7 @@ struct damon_attrs { unsigned long sample_interval; unsigned long aggr_interval; unsigned long ops_update_interval; + struct damon_intervals_goal intervals_goal; unsigned long min_nr_regions; unsigned long max_nr_regions; }; diff --git a/mm/damon/core.c b/mm/damon/core.c index b1ce072b56f2..ad3b5c065cb8 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -615,6 +615,25 @@ static void damon_update_monitoring_results(struct damon_ctx *ctx, r, old_attrs, new_attrs); } +/* + * damon_valid_intervals_goal() - return if the intervals goal of @attrs is + * valid. + */ +static bool damon_valid_intervals_goal(struct damon_attrs *attrs) +{ + struct damon_intervals_goal *goal = &attrs->intervals_goal; + + /* tuning is disabled */ + if (!goal->aggrs) + return true; + if (goal->min_sample_us > goal->max_sample_us) + return false; + if (attrs->sample_interval < goal->min_sample_us || + goal->max_sample_us < attrs->sample_interval) + return false; + return true; +} + /** * damon_set_attrs() - Set attributes for the monitoring. * @ctx: monitoring context @@ -635,6 +654,9 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs) attrs->sample_interval : 1; struct damos *s; + if (!damon_valid_intervals_goal(attrs)) + return -EINVAL; + if (attrs->min_nr_regions < 3) return -EINVAL; if (attrs->min_nr_regions > attrs->max_nr_regions)