From patchwork Mon Mar 3 22:17:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13999549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A03EC282D2 for ; Mon, 3 Mar 2025 22:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BD66280005; Mon, 3 Mar 2025 17:17:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 560A2280001; Mon, 3 Mar 2025 17:17:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B229280005; Mon, 3 Mar 2025 17:17:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1DA98280001 for ; Mon, 3 Mar 2025 17:17:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CFC7E1C96C9 for ; Mon, 3 Mar 2025 22:17:39 +0000 (UTC) X-FDA: 83181652638.22.F1A751F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 3F0D9140003 for ; Mon, 3 Mar 2025 22:17:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K3yMVWuR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741040258; a=rsa-sha256; cv=none; b=YfYyCxOYl9cx4jHkza/hr1sxB0zW+jBbZezRQ+X0ukq8RWin7hV9gNX+hE/149LIF/euHK OE+Xaxo4rthyG4iqLl8GAvtobwFlgaKiaGYNrpP4+dv960oYQgSNJmFoRtbGCyuSyqcaKA M4NLf9hn4Y5wjK6xp6hw38Xj3UVuGlQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=K3yMVWuR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741040258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wecWayJya7F4S/L3tq2SIKHIfTBd/Rti4Uu+Pf2IOVE=; b=CUuEbFxkcPaxcZx2V6TdA6S7slPOFAyX6WnpIJDak+mhhmxu8mn2Q4vbj/Az1gR5IyDNhi sHjOoSUnxdMAyIJwIvvKwNdlShp5R6QCY+IviQiYpCdoX2O2Ytu06pXghN7uq4AE1i4gFJ xg/W/6tZhVb+Qb4jHOkuvEElMRrh3Y8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 278CF5C4922; Mon, 3 Mar 2025 22:15:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92DF7C4CEE5; Mon, 3 Mar 2025 22:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741040257; bh=LSjpeMzXWVkQm84u7Pg3DRD/aAE+XvDLQxgeGEMx2JU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K3yMVWuRfTjd+OyCEQ1rThotSmYg5rgYu57djwTjR90VhkqveAnxODI3I0Pj4atbc j3HFSGmVorGtEjAkBwVCQqmyVl658yX+bMgKswz48VI1lXTx42RxuJ2g4SgDYWPFZy yvILiydHL10R9iiy+aARh+LsJ/oIfEOJyrnGyN2OKhsLLfqYlXRs9iJ0jiEAkKZXt+ vcG0ed+tEQ/o2YcJKlB9E+1A48j8Yw8lKAQZyiydaRBTPwNbc0noFrAs1fXFyzqVQU q6O0BUlIqc3ns5CY4NALEzVr+EUdusKWYmRzW4MgM1hF2U+Q8AAaDjRVw8hsGz0w+o e1nfPi6+CEJjg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 5/8] mm/damon/sysfs: implement a command to update auto-tuned monitoring intervals Date: Mon, 3 Mar 2025 14:17:23 -0800 Message-Id: <20250303221726.484227-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250303221726.484227-1-sj@kernel.org> References: <20250303221726.484227-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 3F0D9140003 X-Stat-Signature: sbq1fggcjy9e5qcsr5ztfwgyxzrmmbua X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741040258-708021 X-HE-Meta: U2FsdGVkX19wp50tCO2efbt+rPA9hAD69DBgINHJpLOFAx+5qhqNfFV+ZKppTbUevzUH83BUgO4BL97pOsb2ifW6EgnwNXDTg7dKCChadVaqMs80/mHAXUXZ4Ma+u5rEcYlTzjLpNGSKx5wgaTOsaiJLR4MMvKBLaOi9GFbT59Fe/6wZbcNehEuA+/f6fmolO3bsMaTVArtni9pAA3wzHnJ8ntbeSGSlYsy8TTSlw+uTifG9/Zc/OJwMQg4XFzQmUWmE3T5pY/sGODpqBEJ6BFNM403bnZYYQVt1CMemLdEz0c+f79EegWwqsWaz/1EbOftCQbN5hdGcNm93eWn7k0CCPWNn2sdRDEMp6Ig1BHBf3gkc7ni4YW5xB+7knYuDNGHLqA5yalZk75rlF5ynfrj6NyLrivVmHyMBtoIfJLKX7hTmQuCZVHHAWTF2C1AZjqzOCop72/5/mujFQnYfaFpBySO4Y4jaoRJ0F9QdHYZXvd/yiwNeXRbif2zecZpEuN4xdl5e8pdynJxQMTbxkxmRK7i79X/4H9WaZK6EVqkttk0NJC9uSi+RPJWOgCfw8hJ3/TqSI6MoD4jj3RplAgi0F+eiOEyWk42sfJqO1CbVCvJxmL2NxPspz0J7PhAy06uwcXXfZFdmXB3GOnllnTiLWG3OO3wzWq96dAmtpAnU1zRA9/VHve1W0h9E9VXw2IuQV/GbhuJeWfJsUilzidHaFRJkEYsBT8sqVEeiE+BBukFyQjm3VjfzTo+/HLo4XO7yPY5vFMOUojXiTViovhT/6BsLn3Ljv1Fk/5l25gPQFSPze0bNJqEryqWxWVCEfzqUYSd6Iea48uy8uUp5STC2y+WuDOqrhFy1DupUifUltuvVhYYVj0QJ/SdbUBSarBYoAoFw6T7yJn6KW08IIz5TbP0RF6u/x35e0p6P8eS70kIGt/e2noVfvX8QNfEtAehFPGvHDsBnDYMSCFQ oOK9OedT vBLco+DwjmO+QMRUff0zu2BCg8d6WLM/J8cBq0AzfU5sCZI/Gy4TdQvVcg/irvhiRkQTSg0QxgKvtWieH/MY169uIAWk4LDaVpqaeYhpv3svRGTTJbhCkr6RgX+WH75/RGZBvmC0T1z6Iwcc0wrx0705xWFzA/JxE/gv3nq0gCqAVxxYyAqO3VFuSqKQLK/m36D0RqM9WwTM9K8lBcRNgDcG0RSY9M+T+aaI8OmrOYFO3V/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON kernel API callers can show auto-tuned sampling and aggregation intervals from the monmitoring attributes data structure. That can be useful for debugging or tuning of the feature. DAMON user-space ABI users has no way to see that, though. Implement a new DAMON sysfs interface command, namely 'update_tuned_intervals', for the purpose. If the command is written to the kdamond state file, the tuned sampling and aggregation intervals will be updated to the corresponding sysfs interface files. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index fa5f004f0670..ccd435d234b9 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1213,6 +1213,11 @@ enum damon_sysfs_cmd { * effective size quota of the scheme in bytes. */ DAMON_SYSFS_CMD_UPDATE_SCHEMES_EFFECTIVE_QUOTAS, + /* + * @DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: Update the tuned monitoring + * intevals. + */ + DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS, /* * @NR_DAMON_SYSFS_CMDS: Total number of DAMON sysfs commands. */ @@ -1230,6 +1235,7 @@ static const char * const damon_sysfs_cmd_strs[] = { "update_schemes_tried_regions", "clear_schemes_tried_regions", "update_schemes_effective_quotas", + "update_tuned_intervals", }; /* @@ -1502,6 +1508,17 @@ static int damon_sysfs_upd_schemes_effective_quotas(void *data) return 0; } +static int damon_sysfs_upd_tuned_intervals(void *data) +{ + struct damon_sysfs_kdamond *kdamond = data; + struct damon_ctx *ctx = kdamond->damon_ctx; + + kdamond->contexts->contexts_arr[0]->attrs->intervals->sample_us = + ctx->attrs.sample_interval; + kdamond->contexts->contexts_arr[0]->attrs->intervals->aggr_us = + ctx->attrs.aggr_interval; + return 0; +} /* * damon_sysfs_cmd_request_callback() - DAMON callback for handling requests. @@ -1723,6 +1740,9 @@ static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, return damon_sysfs_damon_call( damon_sysfs_upd_schemes_effective_quotas, kdamond); + case DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: + return damon_sysfs_damon_call( + damon_sysfs_upd_tuned_intervals, kdamond); default: break; }