From patchwork Tue Mar 4 01:19:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13999764 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 692CEC282D2 for ; Tue, 4 Mar 2025 01:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30A3280007; Mon, 3 Mar 2025 20:20:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2AF280006; Mon, 3 Mar 2025 20:20:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A80D6280007; Mon, 3 Mar 2025 20:20:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 85EA3280006 for ; Mon, 3 Mar 2025 20:20:45 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D14416127F for ; Tue, 4 Mar 2025 01:20:45 +0000 (UTC) X-FDA: 83182114050.18.C476EA2 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf17.hostedemail.com (Postfix) with ESMTP id 2127440012 for ; Tue, 4 Mar 2025 01:20:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cuMSNs0+; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741051243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=QLyYd0jtlk1HnOzrX8doBxkNkczXZFYHZmixERUQcYo=; b=DfTeaLprScGjPcFFJMD2kPeRTaVOpBQ2Z2Bh3DwOH9vNz1Q2bGAoAgV+4v4ZfZYmDlQCg1 335cZyXZlttVyXQngcGiFjKHtQVZNy9P0PUABUWl/p3Bta9aZEqS+edkeYGMEMrt5Ohgop EZfFUhi0IHEzvVBqtv0qvqMeP2mTVfk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cuMSNs0+; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741051243; a=rsa-sha256; cv=none; b=K9OOAloX7yOcjlLSSvg1zn4aYMo+W4v8dSWovxrpBgRpH2ehuOf/4Psvhs0YvcKTmh2/p8 FcMhHnzWck78Qrb5zXyhm01Z+80lJ4TmtZLdIiHgfhAozEeOvtt4PEeyxXLjpMwtLj62T0 R4MFo8YeIPcQF8cUF2oNbeoohy1X4B8= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5e04064af07so9427137a12.0 for ; Mon, 03 Mar 2025 17:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741051242; x=1741656042; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=QLyYd0jtlk1HnOzrX8doBxkNkczXZFYHZmixERUQcYo=; b=cuMSNs0+xaFuxH02Gw5uMfzUB+wJt0PrIiqmauDrCPuEXfoK/lJwW7Ojx3lP0BV0zT 5O658W8Zr2YLw6q6XnfLC1nt+UYoWdmx9ZhvHKOzDPG4mSatn4j2lH0gTkB33o9tHVw4 /0FRaAx2ZnoWHoK5RVg1QTra5VmzsnAxc68Sgk0SKU6eeJhGGkkfWVopIOlKJwunBI9I gRCKZQaxccphCVoDKDa44WPIoJALzhcUOnfuUAW/ML2aCNQmcL5sjox9qtmP6OqS5p/h zLeCYeRf5jsbIJvLfDdnSlCb7P4zpWSVkywKQFBCqUsE6O4XSrGlzlE2X0n7MU8u4ahs 7TIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741051242; x=1741656042; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QLyYd0jtlk1HnOzrX8doBxkNkczXZFYHZmixERUQcYo=; b=lvYkSUsXT8ooeQ/ScnKu4EVni8Zp44kTfm35PxYlVof8SlClnZNW2K+VdrS1o5vRC3 1U1GhWg8pm64G2ocFK6/6KPyFURzQHSIAAqIJ1LZelcOYWdv4Q6QP3R5cB34Mp/om/D/ enD58i4/HuqBAZOj1EGb8FcUyNRwPC9JEsnmCdd3G8Wz9iBe09M7DErFSO8pTZZJk0rm P+AOQucMkp+lPBdUNWV9YGEkeuZXsM2QRg49xYSS648LjesPsrm0mImx593BbvmNvGoo XgBrkaeTKdy/M7VinwNCQEEwcrqWB21YVIrDiMekmWAafPyf40gpBVDbOOpTTwdihXIx fJ0Q== X-Forwarded-Encrypted: i=1; AJvYcCX05uB/x4AeuLnykMF1pYL3P/WfiyQzKbfkELqnZFhPqezasSryoHTAtaDHpB8DFQcRJ/yxLOKxNQ==@kvack.org X-Gm-Message-State: AOJu0YyR2PC6YWbyLcYxwy05QLgN40RwEh0puWIbhx5QRnt5Ezr/TpQ4 VYURG/BqUYgIc01weHYDMimzN873mW3RpAZFpZ2YozOU5N7zF/60 X-Gm-Gg: ASbGncsj+8eGb6AIhzFwcxETgVE8t79TI7qx+PVSwRmCMFMCcyXzFq8gw4xWbYnvPsG I6vYgH1H0UwrHffWtHh0SkQGiQ+PerXmxTnF9508oF3GG5YYgyUtpWjwBrub2LcmQSI462ztBXP CR1TWLFWU5a1g4egcSGGUu7q19UhzFgb0h2K1W0YEUNb9pX5VFeH1Mvpb1knzoV0UEOJji5fkgl vV/zvdvGBY9gMwR6m7Z/5iUTuZf/WgFUxX9hLvcal8iklGOgwS8dm1wQ4Q+LuHsdRk1o2qvY393 pcybCWlTyawXjc4CPwJfmzEARO42hq0/l3zP6tBOsGrq X-Google-Smtp-Source: AGHT+IHfu97NcNusYw3g8BLyQrOgz+GVvwBiG5QdVj9J3HFWmQdVRVX4XUa31juJj9w1rszwc92wgQ== X-Received: by 2002:a05:6402:2114:b0:5e4:9a0e:38a3 with SMTP id 4fb4d7f45d1cf-5e4d6b18ec0mr16374441a12.17.1741051241398; Mon, 03 Mar 2025 17:20:41 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3b6ce0csm7604958a12.24.2025.03.03.17.20.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Mar 2025 17:20:40 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org Cc: willy@infradead.org, michel@lespinasse.org, linux-mm@kvack.org, Wei Yang Subject: [PATCH 6/7] lib/interval_tree: skip the check before go to the right subtree Date: Tue, 4 Mar 2025 01:19:51 +0000 Message-Id: <20250304011952.29182-7-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250304011952.29182-1-richard.weiyang@gmail.com> References: <20250304011952.29182-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 2127440012 X-Rspamd-Server: rspam09 X-Stat-Signature: o8c3tjasu8m5p44rna4faj86skmza4id X-HE-Tag: 1741051242-309073 X-HE-Meta: U2FsdGVkX19vJroRbMA2AlymDplcHrYjGQZvvLMS3L9M69eSdwy3exNgKEfqBkEr3x0h36SUiNrijfuJ+NS/bieQJ+Te+F5u2+WJSky11YDHPQK9ColxmOWFXIzA5UfdtL5YLZHeNKJ3aUjTskOqhTPfpViMioBdX3j/F0geOuEcHcC6zKd22nQ8h8iP6uYodr221oPNk9MfCxV2mQPvR1jLR8iM8gYeM7E0QrLye5A0u+ut+jufwvRhmjeJf69ILpAm8SsFdyq9uxJfUQiJVjxj8jrWGwmUnJcgIQ1dMYyfdZTsD7oq2y1/OWODNwFQvZ0awiLI6qMa5gzgK8czkPex1hUp6UX48wng5Nfc3oURHfV9Pbt0BiiMJuwhQF50ez1qNTZl8Os+blRf+1xyWpVHajTqdElxQLsYaCLEjbUHjkkYz6K6orXFaZwG7Qt2SNWDW7N6ws/xbBiDjXkAO4WYgxxx1L3VSf2Q8XRT48Jk9doCrGwCUcsJeHH1vyUrXJH3fUVJ5RJtl4vV2jNtTINb+/jD+8GHKSNNIizqcAL6Zm7ayZTM50WWG/cec+G1ceOGVHA/iAQVrfFe1ZzVoyQd2EBhvUpkOP9mIPI6boJaVU1kcj9GpLs4e33dr3qhQjFrP+TZFWL/CaI/jg1/0zr31hfe5jWmyPZXExdfyRjgmoew9Ues1HZSGpU8I16imHiKRuBagZ0Jsic7F2VfsCYmVkH+4yx4qJiTTOwItiwFO6JQjY6q8gWVx0kR1n9maJwAZY34YKNWu57pEGVih+TxqZCSVINRVjvs3w0iZ1l9DSXfIjy1aa1GT5+rf7MKmJdNnQNSuPU2FjtGaBO5C1Y/6pjDwU3zvJDKIgmeZVciYC1iZBKrRMWQa6W17bpsXeQLNyHW4fB3KAfVSAx7K50kV+qoRiZcY9wDdXHGlnb+7MFwbv4maZ5RW0hEs95XZqwjL2vSo6yxeWq7fip 9YUG7ZjV 94vMQNSV+XbemWHF6ACgFy5ogYWYkV4Ao012hFDlyHuJ2L6GoFlP49hD0CwXRJI8UGSf6ngnWYC7+B4IwG5cTDXXi2Prs6ujvZ7a+fVFKnZnom53L55TWmlCzJxQuwFAJkn3XZicO2OF44zG2V960hGXeElRWlqq+MXYaT4GmTLQSixbB24A3JOEI2r88yQC13G+2aJPmvpWAw7mFfa9l2IVn8HbAN8zCcNIWYDAp2xPUVTGlDfIMeKCYh2XxlNDaCD9NUMegxGjNejh/Jh+o6CfWQujVXITF9CNn6QBflq4CpYholGExlwy4QOEwkcE601AI+EqZvdaia9gnLA6OGUrOTaP9IJAXnC2xVtxNShBFaKa3Kke9CLm8FdM3fqHJ81qIJEXbzhqWZZaF3EQFQCAHMrl5iDOM1OiXNix0V4MgYZxyiE27io1pzziQEGOemm0MtDgVQSU9YOTQ2+jpyJ4vWnYZxNsvZFDxoIJxdhnvGBO8YhUW7ku3yWeog2HnBpbCvqmTbbuHcag5ff1nwL0WyiZ953THXyFgHBNzwpMdOJNH9nnfdzG2/fKJNDDWokfczxMVyXHmXQpTD4k7okUnsvjz6ot2HaC7i6FZQrbLJupFBW/d5RkcXi+dlkVx2FhyevdV8FJ/TZtpVy7p2Y+6Ljf9m5BabVBI/HAGuLfPn1o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The interval_tree_subtree_search() holds the loop invariant: start <= node->ITSUBTREE Let's say we have a following tree: node / \ left right So we know node->ITSUBTREE is contributed by one of the following: * left->ITSUBTREE * ITLAST(node) * right->ITSUBTREE When we come to the right node, we are sure the first two don't contribute to node->ITSUBTREE and it must be the right node does the job. So skip the check before go to the right subtree. Signed-off-by: Wei Yang CC: Matthew Wilcox CC: Michel Lespinasse --- include/linux/interval_tree_generic.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/interval_tree_generic.h b/include/linux/interval_tree_generic.h index aaa8a0767aa3..1b400f26f63d 100644 --- a/include/linux/interval_tree_generic.h +++ b/include/linux/interval_tree_generic.h @@ -104,12 +104,8 @@ ITPREFIX ## _subtree_search(ITSTRUCT *node, ITTYPE start, ITTYPE last) \ if (ITSTART(node) <= last) { /* Cond1 */ \ if (start <= ITLAST(node)) /* Cond2 */ \ return node; /* node is leftmost match */ \ - if (node->ITRB.rb_right) { \ - node = rb_entry(node->ITRB.rb_right, \ - ITSTRUCT, ITRB); \ - if (start <= node->ITSUBTREE) \ - continue; \ - } \ + node = rb_entry(node->ITRB.rb_right, ITSTRUCT, ITRB); \ + continue; \ } \ return NULL; /* No match */ \ } \