From patchwork Tue Mar 4 01:19:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13999765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C54BC282D1 for ; Tue, 4 Mar 2025 01:20:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57AE0280008; Mon, 3 Mar 2025 20:20:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 502A2280006; Mon, 3 Mar 2025 20:20:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3318E280008; Mon, 3 Mar 2025 20:20:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0DFFC280006 for ; Mon, 3 Mar 2025 20:20:47 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8EC74C120A for ; Tue, 4 Mar 2025 01:20:46 +0000 (UTC) X-FDA: 83182114092.01.968DA57 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf29.hostedemail.com (Postfix) with ESMTP id 8A4C612000A for ; Tue, 4 Mar 2025 01:20:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PzFh09rE; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741051244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=ATqc+DAUm+d+/s9GFa3o3jhhrYw2scideXwKT6/5kXo=; b=0DonHkfLY8g3uuUkTCBF2iWoRrbN1BJCODLyiGIlib9hgQx0huXNyGAvWnYX+DHTjXvZf3 a2AEnVF7DUxy22ZzbVJvMWQWIbYMETaii1Z+zLHSh/it+63vd/TWCrIDsW7MhN1Eugt7zm gI4rSk/yUfyaN/MU4MXjSDdju2SEGZc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PzFh09rE; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741051244; a=rsa-sha256; cv=none; b=WpvP/BkBJFoOPu6mBDwe2zcjPOOLE3hswidI0VGhzBAGooVCEbwk8cEkIa7+XgzAhSEATZ 2UohH+DRcK7OZaGUG2qTuBF90uju3XKopTpdFUOmYAA+4UYYhfHfxFFiJb9MMt/VPVRi2q wVWdkWgCaVjy0IhKALSuhinHG4C2OmI= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e50de0b5easo3781427a12.3 for ; Mon, 03 Mar 2025 17:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741051243; x=1741656043; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ATqc+DAUm+d+/s9GFa3o3jhhrYw2scideXwKT6/5kXo=; b=PzFh09rE+OmUOvMnRd0cdZhpNYaGSsPiuD8f8b/y9yzQsqc3if9xYDLw3TPGHLVaZm X1/tMuzSluQLaticbD00jHVWvkuVqS6NeqHvgTK3rXkqsWxCspjtwmOElNhi2a/M0Ik0 sgj/Zblwa4DLInQtXaKyxpAZocjqdnLS7c4VZqFGwvlD4tZE4Qr30rCwTm0vdLH/UYbJ xuE9ETJUZVmrt1m/HsoMbpF50IUdBozE8ZjOkKD8QS2lsjGdxmcnrLq+7Txpx8vgBY/Y qd0xx5+cA1exZi3mfNcE5pQLz+0jZEekClWTDF83SQBzOqJRy8zHG5FdTXqA0QzDGPlz 2I6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741051243; x=1741656043; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ATqc+DAUm+d+/s9GFa3o3jhhrYw2scideXwKT6/5kXo=; b=Y7FaBQIliIBH6IjVdGklOwduYDHvTImRgOBEFSqHtvYnCeftljLvBFsfMbAdpxq1dv WZKTSEPVKW2Y4QueQNxmw5dBg7K6w9/73dieRD8//g3DNAZmnMUC78SqGUMnn1RyJ+FT 4FgIMlmIjcZQLy9tV24ZH4Y9hEWWD+f9lUrxcLsmbZYIeIpIN/WbK5eD4XqzzwdepLUS 9GvY8+9R3LO6zDrEc+0BUpRGSeoVHi+wqVTRrvJKoZxC8yEnDrKZB/2SpIHC2ZyCUUsq x9cx8Z9qQ3Yib6OXXS8fJauza1Z7Oc64Ne7iJ9L237rOdAljCRDJ1n6yvyEcz+UYMZPc aKEg== X-Forwarded-Encrypted: i=1; AJvYcCV/k6snOcO+GT7BdaPbr8ws8m8Ue9Cp5Pu9RwvDCduo61nDiBsv3MhEaD+8YEdqPb3g5mXCXEn+3w==@kvack.org X-Gm-Message-State: AOJu0YwmnXNAr84EizcOctcTqF/6E9/pJsTTlWWZ6RXkLXlKPfXhHGvp K4GpXS4qV7RGvZ89mhVbwnho20qgodCiXmwB0z3r8U7SzhdfYXUL X-Gm-Gg: ASbGncv5xUwO8+1BkBbuy0I4NSE6fC707ppIL3Koxl1mGV1DfyzgFBtBC246dzGIMU5 4Czg1wEuTd1qvMrgTb18eJwEeyC4ekP+49s6CjHQkpXpxRt93YPlIGMssuf2EQimQ38/HZaWbUx 1ZRhpRQkWWCluEn76WDv0cZJF21oCs+/zFPmfJ97vu5SHdKDJ937afN3eXVR2K6GWANujyfgVRU tDDDTS9MUcBUC3Dgf3Nppagl0YXibp/Tsnoa1YL8r27eWGfO4z2oJWIEApjLNXHn9vQfBlJwzoM xfmhAUE5BW1tsDN+pP1z0Bhg3kQil+DnaBNiQjitF2ZT X-Google-Smtp-Source: AGHT+IFSx4tTAX2ZNo/MD0KGk+9mggif5cFyor4J7uayXZIbClcnX1Z9srog7uMKoxzNgggtrbrgYw== X-Received: by 2002:a17:906:fd86:b0:ab7:8d23:1fef with SMTP id a640c23a62f3a-abf261fae62mr1975663566b.9.1741051242840; Mon, 03 Mar 2025 17:20:42 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf5e916ad1sm444672466b.75.2025.03.03.17.20.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Mar 2025 17:20:42 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org Cc: willy@infradead.org, michel@lespinasse.org, linux-mm@kvack.org, Wei Yang , Jason Gunthorpe Subject: [PATCH 7/7] lib/interval_tree: fix the comment of interval_tree_span_iter_next_gap() Date: Tue, 4 Mar 2025 01:19:52 +0000 Message-Id: <20250304011952.29182-8-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250304011952.29182-1-richard.weiyang@gmail.com> References: <20250304011952.29182-1-richard.weiyang@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8A4C612000A X-Stat-Signature: doena3oemo3s4k3spyhe558bqqdzxgij X-HE-Tag: 1741051244-364495 X-HE-Meta: U2FsdGVkX19Y2rTaUUpwlJEh2pjtewSjA0YZXWC5RZ3YatuCsWhyG4EXa+5iMbRWvt9tCH/98YgDgLsWts80ab4SQxyC7I1FGcyPrLXn3U/Ar+jocxLidsfKlw7HB7O2PmAfgfZA/sK8jl9V2qqOTbSgeDnkWMXPDnrpsVBaWZn0w9NyeKsd9e3O92sbOJlCBgErZyT6UUxVqe5CcnaFD3HyqftQQWTKnZiuMQ5qXED+dACuUuY7oQ/TJtg0eEkzpWC3Q3fnHY9//+lz/tWDKjDYvKrKA7S5leTpDCgINHLkY+2yXNJMmSlNyQyXbvlFWd+4VtVC5n8uFmYuUtCO4iU+MvFRyafjs2sUcetfcVJ1BqSWOc5YKNPJoNQOES1HgRS5S8QbnTyXCqwb/JGT0zLJ8N3/iiTsIDueVpX27er8RJvOcvZcRrKfCXjKsg44p5iMbBMgXIFJ220XbPFuDYOPFBHFrc5RIfPDH0EXIWFyaUwJaXHKUujInkcL4O4uQTT3u8KOUdd1qpT3IsRrZ4ibaaCrJKhxcpsn54ys87yN9cFEEq/bJFzH5Qbeyb5M14hXVpHcPn8AOKFmdI5HvD6obImizeHyuWNCbfDta+BG0Xh8Ngu9rJLNJpTXJkbF0RMpmD5tOfyCScZy+z2ngWOhCA4bz4YR3FAqTz1XFHHJGJrfZ2jA3AjS7KWZ631PhJHpOefeHDTZbFK9ryk4jsP4F6H7Ei2ueZcNswaXA+zXA/KrEwuJx1oB+4+Om2ulREX6zdkN86NH7tbZyqa+LVxN98PuENXGhOFX/hF9ilx+28FfPNMPq8YshL3Sa9aGr7HF4pQqztQjqDmQJMsKtk0siGOFbP9FNW/Y1C2vqb35CQZ+orEsTZxhr7GRKbPACVmJkbS8BJkTZc8gguWuUwZK1y2L+bXvNrQUBkKdkgflnSphSpkLTK9XYKADDPKGrMyLviTlXA1TUS++xDH FVKaExds +GOwUrXXbM/CnStAAWPPmx3cF+ignYolxsnbA/3wYxr9xPmWsjLhjoeEDknE62ld0OZSlo6u2qzD7ZqboyH9IwNEB30+5x/kG24tqwj/m9t+kqwpALOVz4VlvKsroON6uGBcRkrIf8IOYQUhX0hKMofE2Rgru7vRw+2xCnLSzqcA1jgqwz22V6Rmt9QN80M0OOMa6NySrxFIKYSRdvKu0PG2UQaUBhXwnY5LsLoipdG9PZyuCM6Eg1ZDKMNYo+EVESN31PARWAcO4hW4dENB/ZILNsDHlEFYSQlReCIYWw7pjhRu7EceJ/L5C+OVuj9duhFrN0AxuPpvoVGASuXV4VpekYzElQIoYmYK+bbzY1vYrxeuGcTd6bYc4qa2ILtAK2fG6IhJ1g31BV0ODxY3HEtx3Ix4MT9BcuCNYTAcEudzgjUt/jB+z/MrmYBP/npIteznvXk8fZ/esR6loUCUoYpaTJ6WHhaouzULDoNS0g0s//9njbw9ZEbo88fbWvP6OLYptwyfv66R9wdMryr7n4aKVe/I+kIWhLKEBsAyblG+MaeAUO8F728QvUZ6IvzwLFow3hMNLAgdgqPH3Dir+c8X/M+wurPowhrzPHUm3g38bSpq17AXYddZB7GrJhTdt6PpnY2PrYQL4gTjCW/EVFsT67DspUIavAArjpVB6Kib9q3G96Pk1vNAZGMGCfyQ7Y/HIMSvpzYQ7TFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment of interval_tree_span_iter_next_gap() is not exact, nodes[1] is not always !NULL. There are threes cases here. If there is an interior hole, the statement is correct. If there is a tailing hole or the contiguous used range span to the end, nodes[1] is NULL. Signed-off-by: Wei Yang CC: Matthew Wilcox CC: Michel Lespinasse CC: Jason Gunthorpe --- lib/interval_tree.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/interval_tree.c b/lib/interval_tree.c index 3412737ff365..87bcdd387d1a 100644 --- a/lib/interval_tree.c +++ b/lib/interval_tree.c @@ -20,9 +20,15 @@ EXPORT_SYMBOL_GPL(interval_tree_iter_next); /* * Roll nodes[1] into nodes[0] by advancing nodes[1] to the end of a contiguous * span of nodes. This makes nodes[0]->last the end of that contiguous used span - * indexes that started at the original nodes[1]->start. nodes[1] is now the - * first node starting the next used span. A hole span is between nodes[0]->last - * and nodes[1]->start. nodes[1] must be !NULL. + * indexes that started at the original nodes[1]->start. + * + * If there is an interior hole, nodes[1] is now the first node starting the + * next used span. A hole span is between nodes[0]->last and nodes[1]->start. + * + * If there is a tailing hole, nodes[1] is now NULL. A hole span is between + * nodes[0]->last and last_index. + * + * If the contiguous used range span to last_index, nodes[1] is set to NULL. */ static void interval_tree_span_iter_next_gap(struct interval_tree_span_iter *state)