From patchwork Thu Mar 6 11:39:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: K Prateek Nayak X-Patchwork-Id: 14004336 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B219C282D1 for ; Thu, 6 Mar 2025 11:40:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B875280004; Thu, 6 Mar 2025 06:40:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36906280001; Thu, 6 Mar 2025 06:40:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 209C2280004; Thu, 6 Mar 2025 06:40:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 02912280001 for ; Thu, 6 Mar 2025 06:40:16 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4F22656C5C for ; Thu, 6 Mar 2025 11:40:17 +0000 (UTC) X-FDA: 83190932874.11.78B9DC1 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2048.outbound.protection.outlook.com [40.107.223.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 5CBDA16000F for ; Thu, 6 Mar 2025 11:40:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=us2hlPIc; spf=pass (imf08.hostedemail.com: domain of KPrateek.Nayak@amd.com designates 40.107.223.48 as permitted sender) smtp.mailfrom=KPrateek.Nayak@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741261214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hOpN0zEc8cInHConMJIJjTGl0oV1Z8GIpP/kTvr5DRw=; b=iv6xzUdgLv8iqJAocSF9HK8Perc87AQN5eSjjNCiIG9S3oP6tJ4lEtTl/ililvERr/1HWh KTxoFJEEk3d5Xg9oPI8mavQK3CvB6k42Z6J9/vCcpyTi4WTMC+ykfV3qZKDOttilB3V4s3 MRDIcHjpWxxrEt95UEIo+bN10f1ueYI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741261214; a=rsa-sha256; cv=pass; b=i15aYJ99litNegps9YC7NPAFTISZ/5H9mMyKKMsNwNxdFYeqjYoPfyfDY/1fre8Pkzo40R DZAMqAjHYeZ/vwwk01fXEQe7106ryd7flKOmumSFSh49WfxY4YKrPwljf2GeOd9Iz+WNh3 kbyZ4alPuLo4bDig259qO3VGfOx1Hq4= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=us2hlPIc; spf=pass (imf08.hostedemail.com: domain of KPrateek.Nayak@amd.com designates 40.107.223.48 as permitted sender) smtp.mailfrom=KPrateek.Nayak@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YNFjfC4ziE8ui5LOWhxAIyOiB0Xcv+dsDBC9pc8T+MWhc87V44OPO8D69vwa1fJQxDyQFnSQnYuEJRDVKo1/7JBa3sD/MjscCGkRPrPbR+JCj7Ysi8rzx3bIucVqPHXQJTpb6yjhiOZy9vZHSgiU944/UXy2++FLIn7sPRi9t1FP6pr1gYMtZ50xXBSkQNFX/Bno5BVTOSnapooTfAbt3LKD8RIDsMcQg/uHY2Ei3SnyxHubdxIXjHdIEHBRQqhXPAPrKKSmNwvivachDoFh8q7R37WHUrgXfExfZWzKeiAiHHB2GIdNv5AZdMQmPOQsrnjvuWRWy+Kf9FgUe/0ATw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hOpN0zEc8cInHConMJIJjTGl0oV1Z8GIpP/kTvr5DRw=; b=qT9xm26XZ9rAadinxBhq0GZNDAFW12ZiDIVc2RmH1eWOBKMYhosbha+hacZEK5tJ8FFqRQhccYWvWD7tdspvjxkBBuADMlURwWJwsQtdz06JGQxCFkr8w4x+fNJz8KwHRxE+tNX+mMR7ynlC5Zgdz8PG4olZ6WcTmLminP5Z/GKWxYKuHibb1NIB5g9oiVL3PEzxeG5ARdb7vE0U0mHCUxJmDE0XR+qt6mm+j3mIpVnvErzx1+OMcLh5ElhFrbxI0Gq3lO7ERpxZZpdJchORtLJzHd5+97KttJDNrSOWGEmmMDtTOcU011OxuFvyT685mc1FPXfCbqXDw++bcyE+Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hOpN0zEc8cInHConMJIJjTGl0oV1Z8GIpP/kTvr5DRw=; b=us2hlPIcWDjpgaU8mKJHi7JjlfFgXVqZo8QOfNHQDrjZdF3cs3LjzSj14AWVCxom8Ux+dUdaZ0BAewS3i+h0fVlY25RArbMWwxeLaYzCweof/WWDYSvsnTDTQk6pauwaL8oANqQsASf2JE9BLOEixBHjO0seOHxIyN+uxg+MkN4= Received: from DS0PR17CA0017.namprd17.prod.outlook.com (2603:10b6:8:191::28) by MW6PR12MB8707.namprd12.prod.outlook.com (2603:10b6:303:241::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 11:40:06 +0000 Received: from CY4PEPF0000E9DC.namprd05.prod.outlook.com (2603:10b6:8:191:cafe::5) by DS0PR17CA0017.outlook.office365.com (2603:10b6:8:191::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.17 via Frontend Transport; Thu, 6 Mar 2025 11:40:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9DC.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 11:40:06 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 05:39:59 -0600 From: K Prateek Nayak To: Linus Torvalds , Oleg Nesterov , Miklos Szeredi , Alexander Viro , Christian Brauner , "Andrew Morton" , Hugh Dickins , , , CC: Jan Kara , "Matthew Wilcox (Oracle)" , Mateusz Guzik , "Gautham R. Shenoy" , Rasmus Villemoes , , , Swapnil Sapkal , K Prateek Nayak Subject: [RFC PATCH 1/3] fs/pipe: Limit the slots in pipe_resize_ring() Date: Thu, 6 Mar 2025 11:39:22 +0000 Message-ID: <20250306113924.20004-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250306113924.20004-1-kprateek.nayak@amd.com> References: <20250306113924.20004-1-kprateek.nayak@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DC:EE_|MW6PR12MB8707:EE_ X-MS-Office365-Filtering-Correlation-Id: a0e95e4b-797a-41b0-d0f3-08dd5ca3a449 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|7416014|376014|82310400026|921020; X-Microsoft-Antispam-Message-Info: 0yM9AQMpbAR9/CONQ4MBXeTAcnB1zzZL/UNd4grn/8CEQhkzwjjvNvyga14XprcGJVtEPpHlLU8ejPlaW16MnmeZ2y8Rb5e2AmOB/ZZJBOoNnU58Axe4IecoCrZuTpfxOdDT0xdD+eO7pBBq2T7o06Kwn5bw50WIkMyLa6u1U8IJpEl7X8BI44HsUpNWGv0d7QuHSaIeO7nOFKRYg8vxUgqymfdqy9YPb/NeO3PkWelN+pRqk2AFEl6bfh7m4GhBh46v1zrioGCGnSVXkRWO+sQcQCS+97KOkeMRrpHitMqnFrCUXfkDtkFK8YTregz26O1RjJ8noWv7bza0KbE7JzvHR/4p4aPUnrMhM75n0j7/4KVlHk1Cx+sCQuL/s5lNWQzJ1v4Pufrqd+ltLyZ2TTfhruj5lca1dmUaxNPS4PcFlOR1TDQHNApij1X9GxMR5wEfJWfxKf+rzq9eaRHDjojppBLB/PsAb/2i1J9ubtwXWDFxVCeaSUpOil8TOBDb09gl/oQ0MRLfuE4BlFxN9eFRJjV5B9Aj2YNrTFKub3iBePCxoiSW3f8ejM73etYdLJq/Q9ascjhe5sDPKv2RrRCANtzqkvLbHXtpQ2CBvjlbBCPl9sn9ALeNTSvAQk4DcNwQ6k+wMJkTtoksyygYISF31nD9tR3Kq9/kHgQKeaTYWJpbPJH7ScTdzvJ1YO2kJfSGQs+KMyqAmX6IU8B6k6g9e1kmc7Aer+O+b185NOGwM4TVdETvsPkQB36yrvXaXRrjmC10FjSxCM0qCNAmT4PPfB2e7KA0qD9zA+TSgcdEzqUH/i04OWSFExcD7ClKuNMNblISj46FAx+iAO6TldWbEbLIucGx8JFMKurWPyWVxqzrhdEYMJMm1XOXImSan0QGF+kqMvuN7JTb/x5e4+PqaQa/OMkGfUHkw/N6efTDbDARww7/PsplS3rGAB6u9LmskymzxICIZt943ukq5wuIf91/6nGeqpSqlRU33dwWElB1dnrubh9XnVpuEFq37cOp/87ch0ehpvpKs66bPH7FagHZHMNLqlDtyrVvAQQ30EGqOPp8lK7Qa+w3o7CGJDHIkopN5B8XvrMPvb/JU2fGk2bvCL/Wx0Ivkn+GEa0+/Hy3FgCQRLCUSXeyoNp4bDHddxtOrM1X7t3nMmCjdcp6sI8fquGt3idtUjs0RyXMkZHOGSi6hMogt/kD2Lw3+aT42ODGi7qFOPLRvC9wghAJIGFDwNhJ8LBpm3LzI7VJd75iFL6N6EV6JLwx1+j4EfJp7WQ8AtMOWrs5lt5KMczo4xSdIsLWrqSo+7+TuDtKaTPgm0kvYJNGoJwgA20EaSKvrJdjr+ei1fvIrtcKP7q+HrhKmTv2X7uZbPCRXRLCVvfnZcgGjvDg4eXawIRLYhOGt0tjWFCUXoY0AbJnURZd0JWV9A6T3clhIL0lF4EUwaxiXatOqP7QJh6wDt4jPkqd/qO04ifQpBVne5CG6w8iyqbIRrtN7m1+nk1ZV79f1DJUn5aHcogEncfVAuiM X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(7416014)(376014)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 11:40:06.0329 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0e95e4b-797a-41b0-d0f3-08dd5ca3a449 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8707 X-Stat-Signature: qz8utpojat4fx584amza9fy9un8tccpf X-Rspamd-Queue-Id: 5CBDA16000F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741261214-202132 X-HE-Meta: U2FsdGVkX19OEMYtwPJkoI3/Gg525xHnVUEhZ7pvwIvOTClAAaUOltN87RjNuYSop7ESMfW0jQZVrUnIp+GDjkdSJHS0B4RSDv3Z7po/0O27TdKGc9qZqzSC5Gz4mEOOIa+aLdSPD/d0O+Psb+FfLD+V9g7hrRE93AR+oa4GiDnygyxyv87umF7YRGTdqt+H5PKdvPd0j7akUJJk0i02jgaBhlkmF4nLkyEcW9rmHNnhjmskjcrNR3O70XjTTiblOJ7IaIRX55FerCuVRGTqnsFiJBlBfqy4Sw6BvMdMuSDFXxlW3VT4fXfqLJA+Vj2P9mvlHlWA/W4T/1os6XtslPts8N8spRgsYHWYsXJPiDdc/OXtKvyA4pgQzE3A/bFfdqqnci7XtujEus4gjI8mOf0kqUVcMFhOemVm7YA+3bSmG9IHSbZOgwvG2qKQYb/VWTjinEMkRwrM+NuOiLE0RzO9CaoMoqBXb0b+LwFlrrkJJy2PuX4UDrSDblG/zEUoo6qZVoZwQa5UCOjBpMpHBu4edrPSRHkfpd6pDJk5VHlz4gF6TDd3vhuk/Ywp3bDeNjhHYLb1vLZmbajhB4Y/fLa7jvaBFLNN+DNsmMXfU1gTRKMmbAraUEMFx6/37i9SkXBiv4chFRx/zAI/pwb6ywmsjCx+FMH0H3mHG/DBpZ+r+bQOf+/qLL1TSulqXLVVCF3+jaXGoGrWtqfArwU0WEqDC0b4OiSnrvPgKMdQEeZjH94D7/lBzmZ7cesO6oEUCke0hYB1JZ1ejt2kGE6Kko6YWyB2INCdwVSvn7DN63sbghEdu4hhUFZcDpXgKBCfnngtAyvhBtD8zHZGMO+piPGVFCUKWte1a+o+piKGo9JhkYjpB2fvzVTeoklIklPimO/ZuEsjPdpzxFL1foHQyBPcZTU2+L39bZ0hgFCftALUudYB/VdFc/kyd0xtu2DnfEXC1WWikyrbSBBOqoo 7MYxlaT1 FmwvHeBHEQ2pCdcE4B6WNkno4xJwBCccZsdjDeblrOlCFJeHvJD2sOs3SAuQnRVa/YG621IqfBPyVe7VMk3/zIuK8mqJOPQW7VBji0R0CGpiGCOgjdcUMJSBY2pEVRA+JTqW9NAb4EbJ7ptJ3ZvHcSZaAcYKiPAgwjoFzD8thhc9wONQFK5NuueIKNwySLw6qH8AT/7L401yXvATSuO5UJ6uBdw11epSujNuW3Ouj0UQDY1Ecolal86uiu7F5Q5b/6wdanEtAb3m/R5CF9XduRv+J72lSg8Xx0Mg0rXDnxdWrcx5A9aiwSC/PDejPbb4MFKW9ypbLTasWhI3KrHuqVZwqDwMrWw5ctDTSCL9uhyDD/xvWLeBeIBin85cVHFubNt6i7thfrQIlpmXd5Hy9bOksCpx0ihHHhDj/igdG7m0C2KsFY5m0ADFuyNe9RzE9QLTz29S5qM/LAVAGefdPtEebS9pQzTl+xFfycQZII7pc24QWoAOO3LHTpBcUXKVp5ZSlhbXmffLmhMpj/JmMNAtB6ysijEXRKTnH8s+SaxkzuKk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Limit the number of slots in pipe_resize_ring() to the maximum value representable by pipe->{head,tail}. Values beyond the max limit can lead to incorrect pipe_occupancy() calculations where the pipe will never appear full. Since nr_slots is always a power of 2 and the maximum size of pipe_index_t is 32 bits, BIT() is sufficient to represent the maximum value possible for nr_slots. Signed-off-by: K Prateek Nayak --- fs/pipe.c | 4 ++++ 1 file changed, 4 insertions(+) base-commit: 848e076317446f9c663771ddec142d7c2eb4cb43 diff --git a/fs/pipe.c b/fs/pipe.c index e8e6698f3698..3ca3103e1de7 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -1272,6 +1272,10 @@ int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots) struct pipe_buffer *bufs; unsigned int head, tail, mask, n; + /* nr_slots larger than limits of pipe->{head,tail} */ + if (unlikely(nr_slots > BIT(BITS_PER_TYPE(pipe_index_t) - 1))) + return -EINVAL; + bufs = kcalloc(nr_slots, sizeof(*bufs), GFP_KERNEL_ACCOUNT | __GFP_NOWARN); if (unlikely(!bufs))