Message ID | 20250306175908.66300-3-sj@kernel.org (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3C9C28B24 for <linux-mm@archiver.kernel.org>; Thu, 6 Mar 2025 17:59:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD623280004; Thu, 6 Mar 2025 12:59:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5F93280003; Thu, 6 Mar 2025 12:59:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDAC2280004; Thu, 6 Mar 2025 12:59:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D6CB280003 for <linux-mm@kvack.org>; Thu, 6 Mar 2025 12:59:17 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 85E29A95EB for <linux-mm@kvack.org>; Thu, 6 Mar 2025 17:59:17 +0000 (UTC) X-FDA: 83191887954.25.F045AFA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id E17FD120003 for <linux-mm@kvack.org>; Thu, 6 Mar 2025 17:59:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IcOdR4Zg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741283956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dCfnsqS6jzBkHSZyCxebsSCUXQnWSuuSl7leVJQE7ss=; b=wZvkhkKLtwKuMVsguSfMhNj9YAYq5Cc8V70qqgENCk2Zdtx553k2M6meC1srwLXG6/MDD+ Q4ZFNc/k91IOAwEPdOyJAalJlTMJOQwuO/DN2uVoi2rFaCG0xjXBAt9+yQ0zmd5JMlXbNC /vlPp3j6PLO4O8PZIuqMZauUtrRQw6Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IcOdR4Zg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741283956; a=rsa-sha256; cv=none; b=xdPexVkTRUpsUQgm7qVQpOKc6l2R4Mzi1MdFTZPJW+dbMmdkTokZFQW4G2+DvSihof60SF 2ATjFD8pmDV5Q+k8Bc5c5MscFJOOB9KOy626HjdZYIy4MMEudSX6k9i5y+diqqBES4rAJw JyBEnoA3vM52TeEpTpoEbLfszOb314k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5CD065C599E; Thu, 6 Mar 2025 17:56:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEA6DC4CEED; Thu, 6 Mar 2025 17:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741283954; bh=6yhiLeZVnkzlh7XNHP1rZ66eAWt0hQYEE7Tzfoyu2CA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IcOdR4ZgX3pF0zydkdFYbvcNF8I6BWC4h0hLsZ4eAATAfrwMOQ8iPaGtVgc2B78JK ndPixVzJSQS3l48cnI+td3Sz0FbmKXrIUocmqDhFloYJIoyUliNhCM4MKvVov0a9u+ yOc7JlG8NHMx1bE7fl73nGp5PkU5AY/BblnWeivpN4h8qlrhha5n8LS2Gh9+U0xqI0 RxsI/AxsEpEIBZjnWOTsgdv9pik+TtS7FumTIOnWaCUTo5rL2PmROIPb18mbZAdSNl w9Vy+uFxq+f3VfdpjXtjZVCUlBS0J8dOBwGtsIdEnFk6d+EftvapsfFgk5EVOLq+QV aw5oOYQqHKVdQ== From: SeongJae Park <sj@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 02/13] mm/damon/core: invoke kdamond_call() after merging is done if possible Date: Thu, 6 Mar 2025 09:58:57 -0800 Message-Id: <20250306175908.66300-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306175908.66300-1-sj@kernel.org> References: <20250306175908.66300-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E17FD120003 X-Rspam-User: X-Stat-Signature: 6sck84qwaukpobrgirzzto3qd9ahanrm X-HE-Tag: 1741283955-327700 X-HE-Meta: U2FsdGVkX19pnrEb2dQjiW3iqE1WBoQ6SVd9lDkOFOb/RhtSD2VBlv0wBmCbHUidLoZr7adrvAnfRYt+BNVgHaayJz8sLhfoVgmUGUeaZKO1ZZuXbF4Hegl6I23+XK2NbzgFmxPDSxaWtRqRHLWXvcm4sETquVt8p9FwOdMYK+EMDeda3aMXCnflTJUB+2Y8V/juWwn8EbIlQS1Xyk42ZjUJNrv3LLqPeEw7Y/d/xoL1a38abitHJCgJAgKt706rs6/kHoZ0cTDj7y93Trl8pG54V4RX3WjNzdl9zLAWToZNRa/ZlXc3AhTmRg291H5nmKa47KBCO9hZZ4opoRaxWbSlrteo+wHV16Dhq1AcY3GKNdlS6x5RdHkrr7X8Bm+emjyciOm6n8rB9EA8NKmbr1hkZMYjBgCD9kX3s+uuQLGpT1EouuxeKagsYNXPrPD5SBOzHLKDWkrQEmcE+bFSxCO9rRMHU6YE8SAvRlUM8PAZfqyzLe8gs5LDfOfd6ffg+5BpJ6XnYAJnmYwa05UDROagIUlKDaD+++QZa6BMO0Uq3JqSFRBublZUoeIE/Fkh8XWYE5HxDL0NmAYHKrVD8bJUfzpmWvkFDdl3Uph8m986ZrdR2Wf8zYXbdbNLpYSnZ5bFOV3RW2rvtSdBckQ5sGhp/AC+Vh9XFY8VGRukJlje36YZ6hd19uyaFdvQ+qML0eHD3G8XwVJVxIJ3wJCumrpwKbORhjsJKyBYJa0YfSRV1L9c/g34/HWJqY00E8oqJESyF1bpymOsVkS1/DuKfD22ItHMEQpzTjGrMpo17Da1lxBkUtDR97mRUh3hXAglaV7fsbheO3Gyjq/re/hsgVySQe/1jCPPFaI4UTVlIS9GLVoSSREYkCzFb1ALk24B7w4eoUKFz7dYKi41A6n92hfF4M3YvkoNxXJ/geezwvCKhC44D7XEauN5zK/NkiIKRGXVc4JlkvUh8in4LX+ 2vQ/P84x Um9toCJU6PERLKkcOnianfm0rR/ljf9XKEdRmNcM3NiZPm5G9Kw+pDTUQ1/gpLW8oo6koCS68L8C2WFAVHSo8WsyZNIeIuP1KKzy0ejXpjUHX8nG6p9MNacXZQBZK/uLuy4XOwPTOIpFry3g/d7jO+SQevWRPGW6zW13LJSQT3oTNEoz6Gy8gX8+5KhtgpWxjkPkZC00VS//g+jglJtCd9fDmhDqnjgRLhknBvJ+eV3KBTmlswipTafsBWDR8RbWAxLaEuYcqo7I7GBj9WppnhkpijA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/damon/sysfs: commit parameters online via damon_call()
|
expand
|
diff --git a/mm/damon/core.c b/mm/damon/core.c index d4fc2c907cfc..0f359b4ebf1a 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2420,7 +2420,6 @@ static int kdamond_fn(void *data) if (ctx->callback.after_sampling && ctx->callback.after_sampling(ctx)) break; - kdamond_call(ctx, false); kdamond_usleep(sample_interval); ctx->passed_sample_intervals++; @@ -2438,9 +2437,10 @@ static int kdamond_fn(void *data) } /* - * do kdamond_apply_schemes() after kdamond_merge_regions() if - * possible, to reduce overhead + * do kdamond_call() and kdamond_apply_schemes() after + * kdamond_merge_regions() if possible, to reduce overhead */ + kdamond_call(ctx, false); if (!list_empty(&ctx->schemes)) kdamond_apply_schemes(ctx); else
kdamond_call() callers may iterate the regions, so better to call it when the number of regions is as small as possible. It is when kdamond_merge_regions() is finished. Invoke it on the point. This change is also aimed to make future changes for carrying online parameters commit with damon_call() easier. The commit operation should be able to make sequence between other aggregation interval based operations including regioins merging and aggregation reset. Placing damon_call() invocation after the regions merging makes the sequence handling simpler. Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)