From patchwork Thu Mar 6 17:59:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14005063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C00C282D1 for ; Thu, 6 Mar 2025 17:59:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E2A1280007; Thu, 6 Mar 2025 12:59:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 499E4280003; Thu, 6 Mar 2025 12:59:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309F9280007; Thu, 6 Mar 2025 12:59:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B5D9280003 for ; Thu, 6 Mar 2025 12:59:21 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 277B358A70 for ; Thu, 6 Mar 2025 17:59:21 +0000 (UTC) X-FDA: 83191888122.02.270FB35 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 6D4C980004 for ; Thu, 6 Mar 2025 17:59:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U92VK0EN; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741283959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yrt4fz+9Y7lzTTHW9ChCyqes11AgbM5Ey9NkwTXZ6pE=; b=Rodha2yIIvWq4JY2h6VUeRRrg1gHkqTD6EX9su85EpRgxdNrPOiBiKvgysfwZRAqT6yBPc aQBVLYMx1/IunGO2xAVhAnPLF2rQvzECd2Lh4YFIK7FEmIR4MCDGwXHEsQ59Kqbm7gaC/x eyOS4ZucLhe6UdGDrv31AktMn/cSQEA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=U92VK0EN; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741283959; a=rsa-sha256; cv=none; b=MvCdqmSbmWVapugxGb/SDMHa7oqsKevwcX0rxXTIaJ7MbRuCHQn2Q0sFlmb4q0rdFeyebN k9L0S5E/96RhTg5o0+4epYYbILuHlpJrYOfY9h9ZjXZqyVD0935CAuBmxhxlt5HyL/iUBi //bHwWEEn+K08Sl7WkhdIZJWIEHU5vs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CD3115C59AC; Thu, 6 Mar 2025 17:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B34BC4CEEA; Thu, 6 Mar 2025 17:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741283958; bh=g+YGDmMK4WZf3RuQVlcd3/9Gf6V3dNg6yLBZ2nBENG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U92VK0ENbWqUUQoPbn23XTVjzA2f3hQRg686NR8ALpfRhCiiFF2CE4pPZe18I36rV OKJL6pEqlDm81rvi2XhwTgYQjQS7uJFF5l/uXzrBV8deKBVUNjzmjXQ45h4O3zjSdR laRIc/fAq3x3hZiv0f/V9hT3jSVbCQTYPeOnph9DnsuW1jiJI2K9cEasacTM2TQBd4 pem2cXI9CUhEp38yhj+98a4t25rQ1WqWEf8PMlbRozNhz8dCH35JqdUDkUWJszIq7A FxucxW7LQ76j0isDQpQZ1BgxDxHAERvhBFUWsAxe4M02PEX4a3mkuGu+/jmfR7kPAX kLrrLXQJlZkpA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 05/13] mm/damon/sysfs: remove damon_sysfs_cmd_request code from damon_sysfs_handle_cmd() Date: Thu, 6 Mar 2025 09:59:00 -0800 Message-Id: <20250306175908.66300-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306175908.66300-1-sj@kernel.org> References: <20250306175908.66300-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 569p45q4khaeyyurna5pw6zgtttj4km5 X-Rspamd-Queue-Id: 6D4C980004 X-Rspamd-Server: rspam07 X-HE-Tag: 1741283959-829988 X-HE-Meta: U2FsdGVkX19KXriwfcVuGOQAtYkytN50JF4lJ9Ie1xhDALIeV5QqUdym1xUgg+qI8k4ATJC8/yHhrFBrmo3yopRsNcHR3btBxrIGNqQXILU4Ptsk0TMhkp7FWawu1hS5o6GMg2jWhONPwlTapL40Ls5V4s3DA58rosYhyU9188qU7xlG59dIIiRby4Q4iIEMdzRM0I4crYNPWIpYblKu9C5QQW0anmmRObiB2wS0mRQLezAFzzW9cuXsNZVpff2venEFSxbpAEECRhfitdMoQFKj+5JvWEjiZBzcd/iaNym1GQVdMRhiOuZNZ3lE46SfWRm01NGcyoyCDKHUildSS2xims8A9xN/Hrn4rNq2jZA9ryRXZgD0Zcwqxtbfco4DXCOelT4jE1J4FbeXNZw2F4aNEw933G6RvTFuW/GqgyqYKPj+a8tXMCsWj45w6lq/64VnKbv1bVDlv+n/MTFMMWWjFC2BG+2JBH3jPETYU14pYjJG8kiaaqW/3o5c25wPHWJ7pa1UjW2Xj4MOdtU0nE9IDG/uxQ0ScfhaKWd/gqTCT4uzcpSiBwV6UcrdC7t9H1QEst0vh4EyRAstlW4EEcSoUMKKlD4/Yx6o7V4XlB/C/n6Nne3hwD4GGxHTqg8X4YA6BzMs3wycFwcW8oPRsX7ZZ2s7IwZhUCiNTdYhXnKWnXNTP6MCyeoFuaXI9qXx/LDdPcjLWrptNvhVAgmCDs6Fj4kXC3XNfjBYnU20DQgFb5Zlz3DCDC4lz74hUHfvPakQrAcTe5sakGgVAVXdb9yNN3rtyBqrYzsAP7GoCMgXBhGUR3nfFkNpajW0leq8QOUmMGOmWs8QwX5zsWgTDvjO9ffGv1bWdj25AfCGYaeVr53hzQEJh8OnS222SZ9BxVSQDUiPksOWA59UYS0o2b8xNYmAok4Ix3ZStVRMrlfGs3ZO72IijqoUJcULArFNG1QDBSFr1g2h+9Wnw1G G+l9DtAr 0iroIvWABFdO4hCADQui6nd8w+n3ib+I/LFRZgY9B8PgneMP9YEn5SE/6V8ji2ZZuIfGjVoKzhffPoj9wk/prxgeWkoWL+QT+2jhmvLrT1pWrzS7eP9UQsKloAprh+3ijB2/54w3G6eImsy6CY7epIIe6KVkZYKejLqzu22if1q/BxHXdY3g/ar6xdy9zAkT7Eylswu9xodyAtKpYhgLMm63TPrA2gpITog+4DJkgqD+XtxpT/s4K1/dRrye4U5h4emnLS5FM6AE3RdNEKP7YJVjWJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_sysfs_handle_cmd() handles user requests that it can directly handle on its own. For requests that need to be handled from damon_callback hooks, it uses DAMON sysfs interface's own synchronous damon_callback hooks management mechanism, namely damon_sysfs_cmd_request. Now all user requests are handled without damon_callback hooks, so damon_sysfs_cmd_request client code in damon_sysfs_andle_cmd() does nothing in real. Remove the unnecessary code. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index c55a2cee4b74..166161f12c26 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1715,8 +1715,6 @@ static int damon_sysfs_update_schemes_tried_regions( static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, struct damon_sysfs_kdamond *kdamond) { - bool need_wait = true; - switch (cmd) { case DAMON_SYSFS_CMD_ON: return damon_sysfs_turn_damon_on(kdamond); @@ -1747,38 +1745,8 @@ static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, return damon_sysfs_damon_call( damon_sysfs_upd_tuned_intervals, kdamond); default: - break; - } - - /* Pass the command to DAMON callback for safe DAMON context access */ - if (damon_sysfs_cmd_request.kdamond) - return -EBUSY; - if (!damon_sysfs_kdamond_running(kdamond)) return -EINVAL; - damon_sysfs_cmd_request.cmd = cmd; - damon_sysfs_cmd_request.kdamond = kdamond; - - /* - * wait until damon_sysfs_cmd_request_callback() handles the request - * from kdamond context - */ - mutex_unlock(&damon_sysfs_lock); - while (need_wait) { - schedule_timeout_idle(msecs_to_jiffies(100)); - if (!mutex_trylock(&damon_sysfs_lock)) - continue; - if (!damon_sysfs_cmd_request.kdamond) { - /* damon_sysfs_cmd_request_callback() handled */ - need_wait = false; - } else if (!damon_sysfs_kdamond_running(kdamond)) { - /* kdamond has already finished */ - need_wait = false; - damon_sysfs_cmd_request.kdamond = NULL; - } - mutex_unlock(&damon_sysfs_lock); } - mutex_lock(&damon_sysfs_lock); - return 0; } static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr,