From patchwork Thu Mar 6 22:24:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 14005433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DD9C282EC for ; Thu, 6 Mar 2025 22:24:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F62F280004; Thu, 6 Mar 2025 17:24:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37CEC280003; Thu, 6 Mar 2025 17:24:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F755280004; Thu, 6 Mar 2025 17:24:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F25B0280003 for ; Thu, 6 Mar 2025 17:24:55 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A13401405A0 for ; Thu, 6 Mar 2025 22:24:56 +0000 (UTC) X-FDA: 83192557392.29.3846C47 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf19.hostedemail.com (Postfix) with ESMTP id BFC351A0004 for ; Thu, 6 Mar 2025 22:24:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="awf+Mwu/"; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741299894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wwYSJPsyrD20DkRJnKjiCAODhSwgzKxjJiAbTnSnk30=; b=yryaB2sNQzLNzbuXqh43FkYvaUomWPsGa3H17DF+ID+Al1dxPj34VErrw0pa298TdKZbkL 4I4CtKyTyVCu9GJvbcHTMgrMae0vhvak/mVNkbp7FdI3kChOKegxVqeEHonCCUn/F47gF9 vRB60XWWSorF5FnvqGWMO5lAgVUucOg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="awf+Mwu/"; spf=pass (imf19.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741299894; a=rsa-sha256; cv=none; b=kYPNLKeULqkjDEGvKYNFR1GXduDx2jKUREuYXUVN371HkHrMD+Pc5FZNTA8sJsIpI8vFPy 70x8hY+dRqCAHMtjstTK+2ES8URAwhWksjtbhDw2IqKsnGL6f0+aa2ru15/JahZGf5zrFR 2PwTU6vzmbAwHUWuf3BFAXZEFZqGjGY= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6f9625c0fccso11945387b3.1 for ; Thu, 06 Mar 2025 14:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741299894; x=1741904694; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wwYSJPsyrD20DkRJnKjiCAODhSwgzKxjJiAbTnSnk30=; b=awf+Mwu/974kqusCdyeoMYuerYWIEgzDdvYSBtx3p86xgBzDtrnYFmdCBxtYYjh9Vw FZQkl5sxMjd3YaIkqdVajtW/VG7SRGwdm6yWclKpwHF6WCZFMfE3aH+ubgwl6P5BU7f6 86Oc/ywl7ffmVQYMRVA5ga9UKUjrFsEKn4OATO65vrjCeQbz5sC2Mj5pb91j2tJ/lsbC luC6OhUKe0NqDeZfk1d4SGkOcVtg0lZ+w3TKno1JidC18EixQ+ooEPprhHcoD3A4MiPU NLuvr/KQeTJvMwr4lhY/eVOWR8hc96lUM0sbkn4Re4RZ+efoUCw2w/++TcNFce8DRIdh dngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741299894; x=1741904694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wwYSJPsyrD20DkRJnKjiCAODhSwgzKxjJiAbTnSnk30=; b=XxHxP0i8hr2M0/vwWATAJSLvUAClrx5vJV5+HWMvY975hLmwxOGwTDCus3+MAMFs17 MWgm/beUW/JOeWAvUd+RC1bXu6fL5RbUHkbA3QgVR2/jUiZv2uo70igMyClW6mH/WuVQ FhrSW9qW8s70ff3dJ83kS9kgOs01TQsbNXc+vSsX5STNHfISxi5gWyf3PyHvJDWSvD+c 2TRfsiymLGl9OsvJxasZh7eSNAAU+gUd/eLjGGOcHWxUXRtLQkAFRTnU483qWiYYMENu 4vmspLvpghunronJHWOaYJTUq3EgdG2LX1GP64XhkOu5J9U3iJFs5VHxzj4IQfLU2l6p FxaQ== X-Forwarded-Encrypted: i=1; AJvYcCW9l9jY+KQnZdNlZRD5arIcBF+AglKrb03IY2Q0DnTbaHNOP3DxAWl1P/bP8VzrE92lnaSAke02xQ==@kvack.org X-Gm-Message-State: AOJu0YzVxOxziSQAbrO8FG0AM2/q3Erj7RdumRD06y7sIR+tFgTQVi3s zdiU+rkAI7ox3zmZPVr3bRcByUCyRjii9Ue4yk8hzdms/IXxSbjn X-Gm-Gg: ASbGnct6Mms6qlzcmywznnky2eI4YQByzRkH3BFYWFbSVTB5Z0+UDGK67xW+mevhSoq Ad8ghjsxzmrmPLhEYLdD5YJcjn4pshU8As81TKnVKg54in4x3+50A9qIBIeA2SO+om0PVY1mDfn IBMs4bV0It4yrF1pi6AoCp2Bb8hg5BvGYbK6ZYbCGnyGRFAo3xJzQrhRPObml0J8szZAf9Behp1 BPSw9/kfUlxobQd8d1+zNYbncSK4vXQmi2AfxFSJZiSZXsLqK/pCxsskBhvHMXPjUlgpvB+SnZ1 d+6amwZbnnJL6+kHM+ns6Crh/9ZCozqQ X-Google-Smtp-Source: AGHT+IFv/8eB92arxR7N1UEnJIDSpj+Nqmy4EyPANzg3uHZJgkct9j+inzCIr3rTZcbHezFPSyaVrQ== X-Received: by 2002:a05:690c:6813:b0:6f9:af1f:53a4 with SMTP id 00721157ae682-6febf3ae047mr19663667b3.32.1741299893589; Thu, 06 Mar 2025 14:24:53 -0800 (PST) Received: from localhost ([2a03:2880:25ff::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6feb2c4674bsm4625687b3.110.2025.03.06.14.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 14:24:53 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, yosryahmed@google.com, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: [PATCH v4] page_io: zswap: do not crash the kernel on decompression failure (fix) Date: Thu, 6 Mar 2025 14:24:53 -0800 Message-ID: <20250306222453.1269456-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250306205011.784787-1-nphamcs@gmail.com> References: <20250306205011.784787-1-nphamcs@gmail.com> MIME-Version: 1.0 X-Stat-Signature: 7pyaxnjrtmdt4gasfeasnkhtrmr1a8hw X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BFC351A0004 X-Rspam-User: X-HE-Tag: 1741299894-376916 X-HE-Meta: U2FsdGVkX19Q6hbYu6KcXfxSuskaJnZ3KGyWu0ut6ZleZUXygXmRKoW6gJ2946iAYqEnD2WKunP2RGRe/a27JrTyBIazTx4vvME58Y51YDerDW1z5xkYpEdBsyaoUnasHXjOUW7y1YCmW2PwfCVYPfcRdspVafgf2yC1X9GFPetxMKo42OwJqVXoTiq7YSiVNVK0OXfK9RuqJvA64f0z7vtqICIVKY+1pmRp3i4fyWNE58hsjUIT8FnRFdmxyVu/g8mqkepNXlJE0n2eZGKQ2y/w+6XgEGxdsUGj1rGyeZaaq18R8mHp3hDAZykZ4bBmqdVG83F/PIbGeIoutRoTFMfKJr3QayVdAuWAhBF3mp7M90mOfcngxTztrkN6exwuovm4tr6m/iQuvoXsBTDomDso45IJiGQG7+tPPqiZMsZ3InhYzWiMxH5ZIqJFlpE9fIT2jHKcIwIbDSJkF/TF2lBmtkZNmgZvvhvPvhhrn2LgLZNvHPx+cxYBHENK1A3OTjrsg9Zt/VgmGyiSxraRHAyU/n+7ZgRuftWBNvI3A69uPw37uDZYcNNHVDUWL1Eq4ITKbEur/tJNmAyGAaNXHFyzJTGtR8IqGS/YpG5nyKNjs+AkXAaiGm0evKhBPwWmgMv11zqWvKnDY4Rgf9yi2by1m2KvpOR9g01XhqGkMCK5brvGt2PGvHdvxeXmyB247FqiWsvWc4YJwDWQ4SvLAjXp1PvRSSfiJmawIQIaa+17fFlaCB+TWOc87RkMFxsmHfGc/xyi0r0yz1NSXo9WknQCPmrDFOoNgPr4qvZ5mh+gGpyUoYD0EGeBHixQHUFbLnnYtzx4Rvfz5tqTyICDN2RadgxY55kpTE/lKTRSIW5FT2oUkpvyqnLY7CRF90E51PhP7Hy0zo7mU4Jxoi5KpWEtZU05gmqQCPNtIoXSOi9w7PNnmtnwK462I0QX1PaIGw3klvbjfI4IJp0ugvb ldEUjYnD DbYZXVtjgGTP+mhPt11Cr29Nn26W5FrGW3J+7FzVCYNF1joCPrsjI8gMKZ5u/gzY3QuFgNupHgmELd6+WU6rmkCYEy2qXOVGKUUUuskKUWX3MK8sz5Xa7BJCY76cvCiWZkoBpC6wSTbou756jVTyeK7mzcJCD/rxOyaWzXJsy2/eyYw6M58YUP7UTLcrTRYiC1WvJQPvvqX8RFrQPFCfPKG5lSUv+lTAK8ey4TsSUJxIigjW4WxaeWiyQnj4pg3eVS/shrRQsNE9PDUb1LDdBREgfzJ0zJzCyhuPHYnNVDWWw2Ovx4rSlPjYue4WTy+5mYkpL7gfg684PZ4HpFs7WYF8wQl0dYT+43Bvx9X7qAHM7+yuZNjk8UTJ2oChu4oRk/h8fOXOZcQ0Opdok6vnvIymxlKx+zP3v82FbwNab4HS9axQhgnMxXA0p8Y2WqnLRbpv1i54N7ts6V9Y/qTx0rh2Ysw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fix the documentation of zswap_load() - should say load a folio (rather than a page), and should be explicit that the folio is unlocked and marked up-to-date in the success case. Suggested-by: Yosry Ahmed Signed-off-by: Nhat Pham --- mm/zswap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 799b22c19b5e..c470073c17cc 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1629,10 +1629,11 @@ bool zswap_store(struct folio *folio) } /** - * zswap_load() - load a page from zswap + * zswap_load() - load a folio from zswap * @folio: folio to load * - * Return: 0 on success, or one of the following error codes: + * Return: 0 on success, with the folio unlocked and marked up-to-date, or one + * of the following error codes: * * -EIO: if the swapped out content was in zswap, but could not be loaded * into the page due to a decompression failure. The folio is unlocked, but