From patchwork Fri Mar 7 13:54:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 14006511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E98C28B23 for ; Fri, 7 Mar 2025 13:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46E856B008C; Fri, 7 Mar 2025 08:54:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41083280001; Fri, 7 Mar 2025 08:54:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FC136B008C; Fri, 7 Mar 2025 08:54:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 10B1B6B0083 for ; Fri, 7 Mar 2025 08:54:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2883A8DCF for ; Fri, 7 Mar 2025 13:54:19 +0000 (UTC) X-FDA: 83194899438.18.CF45364 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id D96A540012 for ; Fri, 7 Mar 2025 13:54:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=P+fhR0DJ; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741355658; a=rsa-sha256; cv=none; b=jiMvJQfA/ZgfikCalVduUkIqb6UCB6IfRIoZXwGCi6NcHCPufh0j6+f8f+ksfzg6Q7ixnt jiWVWms16I7WQQHbj063Tl1EcK0s3OT3SCxTK4CS4Ggh54zaTN1rHFytKXpm1nWeJ/rZx5 OrPvHIvPT1zWA/4Ui2wekmCACuIIR0g= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=P+fhR0DJ; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741355658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BT6OjbtDCOFHHAijJpjMRbh4BDIQM0uytaFHqbNbas4=; b=a5SRvo3Qyo1Aq/Q5fbDGJfsBWC9gkFm5EhPI4bN7DMBhK8KTBX/3SZ4NtrIoNTwwhDkRte yWo5WDdYZZWaXzK3YNOjcLVdd53UuXIBaKRML7SFnkSBwPX9fQbQwbYHMSMkG6bhidDTqR F6bTFlGPKSqF0px1Qq25cNgskczUSis= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=BT6OjbtDCOFHHAijJpjMRbh4BDIQM0uytaFHqbNbas4=; b=P+fhR0DJRyfUD/uNdzZFl7spFN s9WEWvyhYKjqMt2ZkZIw8P2H8WA9PRUelUHbNbUHUAD74hf7doJwzbkO5RVpwh1XkHE/3eWl4EgAR LByuBb7d7QakRILNQYu2zosdstSG2OVQKc8zyUTjASsG/6/FG2aKG5MZ1QnmEiNzxNlLdogOTcFpU rgdT+FGNEqYgWAyLW+dRtDMkhZXF+9s+H8tMynfWyjchQ7zGjOtAB+i5XJHklJ9mPx1w8iYJ0xBRJ KXvnFMlFbIF1YTpxibbA24zR/zRAq8aVvFNXIby2MHWPnxKh1O0U9YKiSqA0bIUCw55fMQWF4gEki y7yrID1w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tqY9Y-0000000CXG8-0H5t; Fri, 07 Mar 2025 13:54:16 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 04/11] f2fs: Remove f2fs_write_node_page() Date: Fri, 7 Mar 2025 13:54:04 +0000 Message-ID: <20250307135414.2987755-5-willy@infradead.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250307135414.2987755-1-willy@infradead.org> References: <20250307135414.2987755-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D96A540012 X-Stat-Signature: 5iee5guaaruesjp7z4zgbmtiqkiwmdpq X-Rspam-User: X-HE-Tag: 1741355657-580548 X-HE-Meta: U2FsdGVkX19kmLtKDdLhH4y0XIYyQuhfUFv+AXCvdqRTSK+yOPF7A0dZDP7DfXNmWEBRBSrVoq56UkchiJwI0VXusyaHW2JmSx+Vv7l6TlBKdiZL2RfwlDInx98CiCBSrpkzwprd8CSz6q2ujF4jm/gPp+9BfvYGjuF1hio3akuWE9JuqXHezjpWJ/CJVTO44hqEsy4tIVX3v3zsipEHc5bWu0bFuXn6hGzFnggyT1tjrF/5S3ZYHAzzm0p7D9r/oaJtB6xdnpBw+7wLIdZmcs7E14lY6rs7Jw6BAjcdKuVYEHFH9poWqGmup8iubabXiLeNPRbaCjhrYokOtjZAGwWjTO/eT535UYcbhRnvox89dHrpUH0Ba35IcjEXPDEz2LKjvhucLK8J1na0zcY1NAotnnjfFMLs/gTmrd8674uvZLK+mqDIzXrlmdpzcH7pB/K7A4imZcRv0xLKxMxpqioISPlXANcpk/8G4dZYCBfU2RYljuPWYspLqPinsmjeF0Ci6jw5zOwWOZvn/l8bY2V46qB5AqfIGCym0Eu9jt+Wa27aRRV5p1Mm6kV2If4rOGGw2tZkbudEpNZsYBQ7TOTXrY0jWD3sTwo5bHDCwzamDPqZsNakWfYNlOOei679d7rTigjhLCP76ks1w34nzBEsGbynNn9unEj6M3rcOtmdbhykQBF28b08MGAtrFwWSc6dk5eEz8c2lxgtjL54zMU3t+sgSyU3C6cwStIc4qViCpt2Ocy6pa2M+/mXxy88Ttv4XuKjLiirRwYF/Iot3/sRS14v/PBXrEPuOJlLjuZr8KD1ETx5m5z1K4JpL8NrnaIdftmefHTdDUaZ0B2GJKaNuETQ4cNTHThCcD0t/pBm3FI3+XZPFBz55ebexRwLRDy2K8d1wMEKHaYqL3nojgZd5eMXSyCnn8zel3KCt4BVji0d/bLHrNP9X9YaPpVX0R8IJSwuCeU2V8eBcPr 5yBHNToE +zyDnrRqtTdWoBKvi3YAnGll9KI+ALOF7RUe2e89iRQI3mZM4YEkCTz9cReSJdWKrDK/7sbNLCMYHmltaKVZWHzovPtr1zmHwkdQ2f4sngbX3GA1GeTASEFNH2HEWibOyJC246rPgzyHeWg1A2iElVlH9PND4RqLY9Q9CEnCP5HEDMxCWUC/IqyOOzCikhlDASE32mtetYHGtMQ7W5cjAg4dHVNVIp8fNvmbDR7lhMncA5iAaZvwD4mvfO5YCYLBF9ljMworkdDpdnqX2aVrGwXmW1xuNTbHbzXTi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mappings which implement writepages should not implement writepage as it can only harm writeback patterns. Signed-off-by: Matthew Wilcox (Oracle) --- fs/f2fs/node.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 36614a1c2590..b78c1f95bc04 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1784,13 +1784,6 @@ int f2fs_move_node_page(struct page *node_page, int gc_type) return err; } -static int f2fs_write_node_page(struct page *page, - struct writeback_control *wbc) -{ - return __write_node_page(page, false, NULL, wbc, false, - FS_NODE_IO, NULL); -} - int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, struct writeback_control *wbc, bool atomic, unsigned int *seq_id) @@ -2217,7 +2210,6 @@ static bool f2fs_dirty_node_folio(struct address_space *mapping, * Structure of the f2fs node operations */ const struct address_space_operations f2fs_node_aops = { - .writepage = f2fs_write_node_page, .writepages = f2fs_write_node_pages, .dirty_folio = f2fs_dirty_node_folio, .invalidate_folio = f2fs_invalidate_folio,