From patchwork Tue Mar 11 02:37:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyan Yang X-Patchwork-Id: 14010964 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 728EAC282DE for ; Tue, 11 Mar 2025 02:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C82280002; Mon, 10 Mar 2025 22:37:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE3F2280001; Mon, 10 Mar 2025 22:37:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAAA4280002; Mon, 10 Mar 2025 22:37:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A8E1C280001 for ; Mon, 10 Mar 2025 22:37:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3FC9FAA821 for ; Tue, 11 Mar 2025 02:37:53 +0000 (UTC) X-FDA: 83207710026.13.A92D1C6 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 71F1940007 for ; Tue, 11 Mar 2025 02:37:51 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=TUPLnU8k; spf=pass (imf17.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741660671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=1EJIiSH26iW36iQ0AY70VtFe7J14wVFHIbN5UzXmWNM=; b=noUe675HcU44dGDMfZgFYux9HofWMYeEQq3FJyWDLs2dr0aSeBGY/aMrkjGnkSsg72yxoF anNxSPkS+M3wtvVg/LO50rgy9hLFudnK76Dpa6xuIci8/TUk8YKNaVpz8usCZSTe9lyLKS Ztfenhz6qY0A6OFiUEhs+UFd6+O5qa8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741660671; a=rsa-sha256; cv=none; b=uTrflgt7i1UrBa+9unP8s3evjgR8VV3y31tC1U4qsICMUzyIEeqVoPMPy1r52nNlV5UUbC 7L0HryCYtTrsOTwDOpcXQesbSLB2q1mS/bMYCa3O1jmi0QjBrhu1pbsak4DoeYWNQ1FCPr 5ZQL8WEaeHeD2KXhBD6rt/bslUjCarw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=TUPLnU8k; spf=pass (imf17.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2239aa5da08so79061565ad.3 for ; Mon, 10 Mar 2025 19:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1741660670; x=1742265470; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1EJIiSH26iW36iQ0AY70VtFe7J14wVFHIbN5UzXmWNM=; b=TUPLnU8kUH4d+ZsHY5PSN16HokygWwJhmP3k3Bpk7L2WbsiivgX1PQx/osnRf/xxv5 W5RziFAJTRG5zDqhyZpeB2GEt4VNXSnUGhrNxCJNGq8kml85cp7bNhwBN1ybl9DNs1SG i0+Njj4A8rL2O7hmPndvM+eS2HuA+vxTErhUZrEeHgHSKVK4yF7oLEubf3AeSdcHN2BV DgAUm7g+R+pg57HOMP4d58mRvHnQOxuVyIJlyGTigHoa5GaFS/4CR1wIbLbkjXoNDgZa JVemRzm1h3AYI1Pql6XocK+v6SZzMeD7hkrttrB9OwUqg56NRd6fDQirl6QJHYtj1ACM FfJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741660670; x=1742265470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1EJIiSH26iW36iQ0AY70VtFe7J14wVFHIbN5UzXmWNM=; b=HyRpMhBnswM3WI0cd5Oo6HLBUvUWzGZ67a4UyFvcCiY3vGmjgQ+2HSxVp8GD3eWGp4 DYI8NgHeB9Y5rWaDq2Suw+ZLXe24DMsutrymqWKKaWPFD1OCKj+f2oqSizsnDaL0Tjl4 IfS5Bntv+0rnU3WXtPQnnVAt5cdx/hyATqWbBkkxyXBxH4k/CkTIkmnz7Nsg5Z7Gf0Yf NMeXxWNEyADUTte9z9ut/sGUvX6CE8f540ksWlhvzjqkvMMvyb8EyYdaTSOYKk91TZ9G yzsurVdtVmii0E6UXJN2BZeh9SV4zAfVr1D9bS2MljN6VORweZp5sOVXtdIj/18fKYOe mZWQ== X-Gm-Message-State: AOJu0YwuP0xK6BjmvpZZvZFFMwPYAPk4Jt0vC9SUDjmh6HPNVaPLnQ81 mwkx+Ay5CmWXkZ7rml0PyBTZvwWKSNSLxVAvOnc6xb9nL7zowetqw2/JNXyPyRQ= X-Gm-Gg: ASbGncuk9uJvMCyf2EKmrJWnT/xWK7E9XoswrsgXLaSB3yDAHj3gYulgUgQHVvPNGWh t73ob1Oly/EJproQjsn2Mv0OkKLtRRUZdpeHddwF+Ku0OvtZl+CgUHvI1efRTXL3/9zGZQbP1Rc 7MkVFFRpwrzv/X9rtOFGkS656CEfCnHGM4M2BM7EmC/Wcz2JkdsJ56z4AGx93eY5I6PiBjepDaI oZvfNJYp+FIB4qHmCXicbnHZCt0IRG7eR5XqW8QNS3938taHddDhvnexysokhPboCfFLdH0OA4X tlonvpP6tuYCpUAdzSl1Qdd6OCSLwsIXXlcDI/0AP55DWjDvpJcOFr4BdqhsVbShbyxtJq94Ghj O8Yby X-Google-Smtp-Source: AGHT+IGqOQCr1tOk5CkVd1S+i7SxypBwbxwvlNPK+GIp3D5+3dsq4NswgC6lEGNZin82dMDVWEMT1Q== X-Received: by 2002:a17:902:e88d:b0:21f:768:cced with SMTP id d9443c01a7336-22428886828mr219614335ad.8.1741660670288; Mon, 10 Mar 2025 19:37:50 -0700 (PDT) Received: from cyan-mbp.internal.sifive.com ([136.226.240.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410aa4a79sm85850615ad.214.2025.03.10.19.37.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 10 Mar 2025 19:37:49 -0700 (PDT) From: Cyan Yang To: akpm@linux-foundation.org, shuah@kernel.org, david@redhat.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Cyan Yang Subject: [PATCH] selftests/mm/cow: Fix the incorrect error handling Date: Tue, 11 Mar 2025 10:37:30 +0800 Message-Id: <20250311023730.56658-1-cyan.yang@sifive.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspam-User: X-Rspamd-Queue-Id: 71F1940007 X-Stat-Signature: 4h83f1mntj8ekhcc7co8w58baq4nt88m X-HE-Tag: 1741660671-802865 X-HE-Meta: U2FsdGVkX1/w59SFqI4up9/IrQmPSthFKWE1mSMWr6hgQfP7vqU2jSr2kOfetS6d/Vaa7sEzoQlCfH+Tnk4/XHmO9vqKPtAK13HCVeSwvMJakAix+TEvTMuN/2GImulsM0OSGUQ0Gg+VejHT1ZVMMSoYrl14LGHuZ7RlTZx9Fd3SNO/kcPHgcVxl74OLA6iStvSJFOihL7qpv0Nm4TEu5jSpAADdgm9rSBqXzO+UkxyH2IOEDpqRZ1fx0xE3/aoHALqO6i+bd0TBVsRIMphxPRJIL1/4tPM9Tls3jf4k0IM3OjGw19NOdSWJclYyKNCFRH0EpuGcEmYNO+ayQT0KoWn/mqNW0Jk8iypYWlq9FiRtj0YdgY2Fk1hhaVwnPuhGQC8gcxgJu1+seVmDJiBhkVHOIeAtFd95lg2l2CePV3IG3JGLCC/IVv6tJwe1xj5FznrIGrteW6MAyULkEEbFFyrsVPuUAeA3ZHCHk1PSZ3y9Fg+lKj2joQKHqF8vqXkkTF7Itw36koKMS1resWifrDB+4Raa+fUdCOLsPtv50ZVuK8JfWO0PxIKBuauFIk6jFfnLWHy0KQZvyxxpCv/d9hEZ42CjxYSzF3j2JcJtw8s+qVwLvS+168vj7IukJNin3uWtlVhirSIwryL8Z9Wqb2jY8PzKNc62ZMNF3hkEimn8DfRIfwL31lXHPl9OfTfPHxK4vcoRVxgtRIcL3ddWt1ORbF2sfAyyug6kiEiSc94mxMO5vnoJE/gIn/WV542iqumsZioZ+DBVWy1KsV+kcGcm9RquwZq3cLPV27xAmxfBbZVoo7iM4QGLaQQI1osc6VWKEceABmZ/Af2PNiF9N2RyQaOj7bacDiYopmZhid8lfntykCErQ1pcDjGxZx2Bdmt0vXFAffdv82WK6N+9IjXNFZ7Ho61k5yoYJd4CGD1vwoXXu4dxqmfnfQ3YOV0QiNHDe5J1DpMyTq/hdn7 XIPkgmqv WaPjgP33oUbNiZAZy2QDuNtF9+Hda3QqpGLDaiCAhOqif7r0x+D6XBVy472d9ZMOplsY1QgD530SmUilxsS2RvH7pumC2ePGALlDq9K3liP9mDevqvogrdLd84yoVMcTnAyr05OjIjqrdGuMok5skBDOf8U9C5YsKbsG0jPhvqeCF1yUZYeTDtTehPalVFe+DMr9Qijzr+tdJ5XjAtCL1rFUTKYnAxxJQ1RbZNaLffc4BfeWpNK2uaQlUwcieVi83i6m+7veqoHImsNzCE5Mo4n1umMJD4fPnhOSkkaG0bkGLFWbxjfXsc9Hsn3DD7dFZP2QAM+2USKsRI54= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There are two error handlings did not check the correct return value. This patch will fix them. Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") Signed-off-by: Cyan Yang --- tools/testing/selftests/mm/cow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c index 9446673645eb..16fcadc090a4 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) mremap_size = thpsize / 2; mremap_mem = mmap(NULL, mremap_size, PROT_NONE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); - if (mem == MAP_FAILED) { + if (mremap_mem == MAP_FAILED) { ksft_test_result_fail("mmap() failed\n"); goto munmap; } tmp = mremap(mem + mremap_size, mremap_size, mremap_size, MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); - if (tmp != mremap_mem) { + if (tmp == MAP_FAILED) { ksft_test_result_fail("mremap() failed\n"); goto munmap; }