From patchwork Tue Mar 11 12:36:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14011764 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB21C28B2E for ; Tue, 11 Mar 2025 12:37:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4388F280009; Tue, 11 Mar 2025 08:37:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E890280002; Tue, 11 Mar 2025 08:37:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B1EA280009; Tue, 11 Mar 2025 08:37:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0D4DD280002 for ; Tue, 11 Mar 2025 08:37:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A8AB1CD204 for ; Tue, 11 Mar 2025 12:37:08 +0000 (UTC) X-FDA: 83209220136.28.71A61E7 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf02.hostedemail.com (Postfix) with ESMTP id 3C69680004 for ; Tue, 11 Mar 2025 12:37:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=KeMvdVzk; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741696626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XzWC6pSc3pyPRb1xLnLmWP9XGPQURz0PKrv7Tm61llY=; b=vbeu+P72hosvV7JcblBsqEbs6LF0uFMYGhez4f+cT3BX7Z87rxDgmgk4Z9Nki5ELwz784N xCzV4cDrx7CGb53fJmuu5F4uJw6Oz0lfWHoH0KcqwyXGCwU6Xww+BwoFtC4uYFQXWh4yVr e7E5pAbLFbTrDVRsgcy8nwaLZ4XXgBY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=KeMvdVzk; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741696626; a=rsa-sha256; cv=none; b=1wl8FmteTdHBnMqg8+IF1KV+XdS++TZPVXK57FAkzB7TFT3dIc9/OSp7MpUh/e1+IN78I3 4xXTc7PEuB/MjTIhQhAB7zXNpVINbpzJa+rpqWMgPpbiZmEq13e+C4vk3MV3Hzx319joc7 eQYIQ1Kp/hyYrwWZwx184YW57BWwiLI= Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-43cf680d351so12936635e9.0 for ; Tue, 11 Mar 2025 05:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741696625; x=1742301425; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XzWC6pSc3pyPRb1xLnLmWP9XGPQURz0PKrv7Tm61llY=; b=KeMvdVzkhimO1OyaYHeHuLk54mp5KWeaJgwYF9l4AsHP80phwU7pIT1t9/wyo2WkJR MHhmAYy/eEAuQo1ZhDW2zQaETEKjx/g3rlrlx3j/AyngTS1Pa96IKmvzRBA55Z5dPfRS hn6tX1oI8ipxoQoDdwEz/ZWjIX9xSLt4/VvcGsq2RGt76g2gUQZuZrRGSaySaqZm1T42 1Rqg+tjT5t6PSHR161GZvFaxVepDPcNDdsswdjkF7A5BSdsI3eJjqUZiUcM6qOPcClU0 Aa2z0NgW8DRRMtiqLP7CfvRiks9LzVx8pEvr/2LOeICvzdMPEJJgjGWFxQQ+/gfStYZZ 2ClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741696625; x=1742301425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XzWC6pSc3pyPRb1xLnLmWP9XGPQURz0PKrv7Tm61llY=; b=A27oVat8Y3rA77w3DJ8HnaCyFQpe/uQ2DUV+CLM3xy6UwEZV1e0l08Q0Cy01PU0iwx DtCfWBVw7gNH+Xop4wUDfRWIcCaimqPGz+gSYeBN8+aBpMLJsgnHhltfxVXHbI/XUHgy PJx7bs2rGDnnW+d9qe/w0ZuFOIlidUlcqa7i3BlNWciwGALcG+h5M/FQ/DBlV7NsyOOZ +PLC1hZalQA5JyDJBEMEQd0+c8se6zVO9R9DyLeMy2xGOI8651JTiv6UGx7n5Ra4pndA WsiPtMSO4wTQMrzODuGbZwSTPhsBTH37Bx0hEe9yg5XNgEJ6lH5C/QdunsQ+GmYcskSd hZTg== X-Forwarded-Encrypted: i=1; AJvYcCUOMwYuBbJhLWfBKwBh+uU9+Q5aud5KZSN2ZdysNEbAwO1T1B/7v0txD7QAnuGKgGdpkxjWgr1Vqg==@kvack.org X-Gm-Message-State: AOJu0YxF63aRRsFtaIALFbrgw2pUgkeTbXxzZaDyd6tWCWmB+v6eTEDj 3KeK5vwuKuJsbLOlKShdLSUjAI9U3mW9lYiR9YqHie3vj8YE1i6NZX9Rcpd8N9g= X-Gm-Gg: ASbGnctOFn0/pQawHmGEOy/kB6QguVJwE/Kc40ZtSlNCYbZ9YSi9uRizsBAByoHReXs KtWZmfneqIZ45XfXXaaXouqp/iBv6HvloM3GRND66KiF2WZIRCKQgJIEUGzugd3vE75idajb2wG F1ZBEDy+n+Lcn34rXtgCLEd6iVlaoe9Z4AQRLVoQnFjKmi0lDnZ1ao4w42mkmICrdX0gQGziWKr 4SDCbT6851eGByYUYpO8Awu0gsnz443ajVTiaHX95ek/AHtkgpmey+kQqzsl/avXfOs+hH4Ov8p 4bSGTZrn1YsQ0+XbxB4/DOgXVJRNrYNoD4C9kgMU8h1Js20= X-Google-Smtp-Source: AGHT+IHjGGtwlqaOo23AVRgIZZjsnb2eS9q9J1v0DCucwlPhaecePxi66A9LjOaMhcu9jnvCUdaHIA== X-Received: by 2002:a5d:6487:0:b0:390:e9e0:5cc6 with SMTP id ffacd0b85a97d-3926bdf5c18mr4141501f8f.1.1741696623166; Tue, 11 Mar 2025 05:37:03 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d04004240sm9742265e9.3.2025.03.11.05.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 05:37:02 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: =?utf-8?q?Michal_Koutn=C3=BD?= , Tejun Heo , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton Subject: [PATCH v2 08/11] mm: Add transformation message for per-memcg swappiness Date: Tue, 11 Mar 2025 13:36:25 +0100 Message-ID: <20250311123640.530377-9-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250311123640.530377-1-mkoutny@suse.com> References: <20250311123640.530377-1-mkoutny@suse.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3C69680004 X-Stat-Signature: 4uxzxz4n4ceu5n6d5o3rnzq4rtwhk8i9 X-Rspam-User: X-HE-Tag: 1741696625-601586 X-HE-Meta: U2FsdGVkX1+Vjjn40c10MzaWWqkvHS+jmJhlvQu3ep+bFq9+Eg6i1ZzpVUSvG0Sro5s+neZO8kftFXtzb+CWCNsvX4Eiu6FmbfCUg1TRPUjGEMXyE8WziGaRUbg1u8O66k2mBfNZq1HVRoqhbIrkHFc/sJNGqM1CSH+yMrMwX4GX1bCk+IQt1/bAqyDu6zbDLGm9rQCPwideDGDzXzLIBv8SrHUP4llk8mvY86dvb+zAvVYW8oHffzT//fpIte2EYotS2uxZg9CIKZ01QN3rWsmh2gblKAu07Do+ts156x3inWWBvNjnNUsm+/Dca5EhXqGX8m1lCijtwZldbh7SYaVpvKT8xUwfgjsEwWxUqm22duNdijpOUaZFM/HzKZ0TR1vaMqUy86bofgIrn2SLsGuF5tb+MwB/9RrXkF56LWAS5myQeIYkuwZg3PE2h+pt3tle3yXemk1U+2lQT9c5meATQ2elV154TgmuPkDgYVtw9XQsvq8Ry5OE1lIE9WbrYrRJlJzrB+rL68pt7BZ8puvU0B+SKn3qXxecBqsKlbPEiczucrwV0Fh0R74nA/ZFy/XBpC3KxgRgNaPrCOOni9/6h3oAlr3o6pbJRc87h5tHkW+Kpu9SAxHfFrM8+JbW6qCc4a2OamwTbhcIJehDHVLp9RYgqr8nHl5O/wdALTP80SnnFIRDCT2rQ9YcGtFQSDarMAjt80Gepl6w43tp0n3Q4ebehy8i6taWrULGe88aLDu96PI1CSIQdBpfZA7Pt4udD5FVzqLN3riwHPQQ0ScRheLWWQcN1XixBFpoY0qAjVTL4M+hlWxa7JloUmVw1dK5K+CoGXElhXQB/qGPGw3GUJLtGqPQaxEUwWwPEVoxRCE6ndEeEYu+P5C5QbC4jDcM7Af9EdNJeY1sdU0MhZupcIPLxTzYxCndKQVPhjW8quFrxvpB/0GXvVei0oE212n/mQeYqza1zB9cbhl vH+noWVJ bGZJFDvc27s7nf1X9DOvTzWJ+uWdaVv25qlqU7Rrd1k6wXXPpfi/Jd8MLm6wuJTAuTDVJRUHRYjVM39td44SsnBPws9v7jnbXUFtP6p4mmdkOD/mdy5Ekq3h65LSdVihbepsbEiaz+yzUHVBpu+90+4m7eyDTMdn7v8APcoVpY0VHhebZD+EjS0a8Y2mYsjHSRcCirAmGlaUN1QJCtQv3KxJ74DYeJRqJ29Hz+c6nRs5DY+O/ThY9YrT5FU5ddi4xw8wPgwvJiHZFMGWCi73MWVQj4QFpIMoPiMpj7QWCJUyGMBODdH16tyUF543xwwmsVQoptLDSqRoQ7Z9fdKN031nM4G9HhfYN7z6ykCaiB0+qSWNbZSPpfGexTUEphjgbNNooLw4RwFD1P/hSnv7fnuVPn8WSSAiQ5DSaWt6uedrrQduE1IKQEj2KCjMsi8bI0e+JeXPVZ0ixptswDZg67wwtbfk2bTSAQztaB94zoNi1CpDRTzn26QLj60C9Ka6UVG8v5Uv7GqDleqU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The concept of per-memcg swappiness has never landed well in memcg for cgroup v2. Add a message to users who use it on v1 hierarchy. Decreased swappiness transforms to memory.swap.max=0 whereas increased swappiness transforms into active memory.reclaim operation. Link: https://lore.kernel.org/r/1577252208-32419-1-git-send-email-teawater@gmail.com/ Signed-off-by: Michal Koutný --- Documentation/admin-guide/cgroup-v1/memory.rst | 1 + mm/memcontrol-v1.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst index 286d16fc22ebb..02b8206a35941 100644 --- a/Documentation/admin-guide/cgroup-v1/memory.rst +++ b/Documentation/admin-guide/cgroup-v1/memory.rst @@ -90,6 +90,7 @@ Brief summary of control files. used. memory.swappiness set/show swappiness parameter of vmscan (See sysctl's vm.swappiness) + Per memcg knob does not exist in cgroup v2. memory.move_charge_at_immigrate This knob is deprecated. memory.oom_control set/show oom controls. This knob is deprecated and shouldn't be diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c index 2be6b9112808c..29ca6489b4ff7 100644 --- a/mm/memcontrol-v1.c +++ b/mm/memcontrol-v1.c @@ -1855,9 +1855,11 @@ static int mem_cgroup_swappiness_write(struct cgroup_subsys_state *css, if (val > MAX_SWAPPINESS) return -EINVAL; - if (!mem_cgroup_is_root(memcg)) + if (!mem_cgroup_is_root(memcg)) { + pr_info_once("Per memcg swappiness does not exist in cgroup v2. " + "See memory.reclaim or memory.swap.max there\n ") WRITE_ONCE(memcg->swappiness, val); - else + } else WRITE_ONCE(vm_swappiness, val); return 0;