From patchwork Wed Mar 12 00:21:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Xu X-Patchwork-Id: 14012788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807C2C28B30 for ; Wed, 12 Mar 2025 00:21:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58C4280006; Tue, 11 Mar 2025 20:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6C6280002; Tue, 11 Mar 2025 20:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90C34280006; Tue, 11 Mar 2025 20:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 772B6280002 for ; Tue, 11 Mar 2025 20:21:26 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4586AA8537 for ; Wed, 12 Mar 2025 00:21:28 +0000 (UTC) X-FDA: 83210995056.28.8B646DE Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf24.hostedemail.com (Postfix) with ESMTP id 3E615180007 for ; Wed, 12 Mar 2025 00:21:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gPJDFOHM; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741738886; a=rsa-sha256; cv=none; b=q+JI/0TpmyC30MMZXJipr8gxsJkwD0ywIxk2Uk9I1mOSgs9jQ4OQlIyHHqsi35JKLbYxN2 dAgdBosH3/TPFNOVtBQArIhH/eW1cH5m/i+SysKHNLY+R+pfeGakdwWL001vwrczOue1tg cbQoBYjLgy3skioy/DNun7j6rsFiHps= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gPJDFOHM; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741738886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=miJIXyGYG3FDRWUe/NKY/2IA/SM1dTsr2zjDOOHuDTo=; b=PvVhMu2XNJ7DbGGQPZbNsiGbNM7u94UG23PJKoVcScjN7bFjR5FIInOQ/3rhEvY07t1FOP rlzDiqCu3ABvAALx3zOls5wE4GKJpVLt7nQZ3ATuVTW22YF4xvv/jyg5b1ukEUSW4LCd2v jHQ8RMMkZqgfs2mQSbtvH4wU+VYP+lE= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e5ea062471so946954a12.2 for ; Tue, 11 Mar 2025 17:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741738885; x=1742343685; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=miJIXyGYG3FDRWUe/NKY/2IA/SM1dTsr2zjDOOHuDTo=; b=gPJDFOHMqbJr3jedTF0lP+NfF35ISz+rIqlfh7cA59FcaUdK/By+Cwm1eVADFJNMds Ak6enciJ6pqR8dtsJlzDG3APfdq1hNfmq3b5iOLlolrEQGWoinVevx3PsO4FZuZ7c7ew c6d2bSaMRqckvgzlehCnigZI8GrdP2tMIvCBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741738885; x=1742343685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miJIXyGYG3FDRWUe/NKY/2IA/SM1dTsr2zjDOOHuDTo=; b=tEAEJvBLWV1p3GtCWVEQFoqABd0EKAoEhLJHqBu+szQuKt5Pf/RG7+u18nX9PtA4hp ZBAW6ynNP0KGiokVdYvDg30AF+AmsPjiw6g7Dt/F8sDujbZ2W94BQzrrfM3Kb2h1h1Xq H/sP9Duhm09ROkrTCSrGwilyJNDwtgOhFMlKc7KimdzX/3BoyOgLQB8UQ4Lkcqn7+Qe1 XEPcrdzpDrKht3Sczxrjx3x4d2GttIacDxqkHSADtK1Bvlzerv3gYWNtNJcQArF6MgKn xeRzsFUmXbDiftt99JM7sGQQPoSDgpq3iRAu2mYcwKRQlr+gUOK+u3NfumymQwSGQwmo wK2Q== X-Forwarded-Encrypted: i=1; AJvYcCUeSf2No9mNViN0iL/EBU0vuDI/4ve4f4FNDyWYodICOaMrGGWbRr7raY2A/z5Kl9jBkPz+Wb/aCA==@kvack.org X-Gm-Message-State: AOJu0YzZ9EBa6pDmKZvDoVOAJEh4yFzKJsNSwRQ9jTSLmf8qRGSKUFuQ o++lbFJJClKcj8R7CXtCq3W5j4K0EEk+4uBg1yIKhCGDIQiSGa7Wh/vEkpNtcw== X-Gm-Gg: ASbGncvRtsvfx0DiEFtgk7tZUVHpiKcLLkCHU/XJkaNhA0GE+OuoLQgaz7Y73bmn44J BwAOxXF8sZF9RBoKjFjK7O02qKDnDs2vk6qpC052Uu8cTFcIIWr+pDOMAQaC+JM2nWqG+7XD7b1 SXgOhGrCuA+sOiPkqqftsfu26BaSqeeEg0I3V0+VM5EZuK59vXcwC9ruUpwRyuv95MZ6KFBf4DL nsDZPSau0fSvguiBGSzcG/ByZ331ta8UrRnVstTQj+Jq2BxwfYGDCkisS7Eq0k7A/2QXh/cBUdD eU1gXsUUjauETfglBWV4IhyGoy+wZHK7oG0hgKuepElhDcGyNTekB+58XM1jDCGmlb7C4N3XvXn q X-Google-Smtp-Source: AGHT+IG2RY8KyPk79cZ65JQw4p98XAf1wvRrztHIEplkXwrKzzh8fZlWbd9JzkmEqA3hVmaYTTf1Tg== X-Received: by 2002:a05:6402:35c6:b0:5e5:e17f:22fc with SMTP id 4fb4d7f45d1cf-5e617f919d5mr7379042a12.2.1741738884777; Tue, 11 Mar 2025 17:21:24 -0700 (PDT) Received: from cfish.c.googlers.com.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e5c7669fd0sm8846503a12.51.2025.03.11.17.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 17:21:23 -0700 (PDT) From: jeffxu@chromium.org To: akpm@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com, broonie@kernel.org, skhan@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org, jannh@google.com, Jeff Xu Subject: [RFC PATCH v1 1/2] selftests/mm: mseal_test: avoid using no-op mprotect Date: Wed, 12 Mar 2025 00:21:16 +0000 Message-ID: <20250312002117.2556240-2-jeffxu@google.com> X-Mailer: git-send-email 2.49.0.rc0.332.g42c0ae87b1-goog In-Reply-To: <20250312002117.2556240-1-jeffxu@google.com> References: <20250312002117.2556240-1-jeffxu@google.com> MIME-Version: 1.0 X-Stat-Signature: m5oyxuia4hgdtfgdqy9u4iaec41th6uf X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3E615180007 X-Rspam-User: X-HE-Tag: 1741738885-574204 X-HE-Meta: U2FsdGVkX1+Myen5rPPSRryYc+K0XFZd92vafmmbLGtxV/iuorhh0k1AW+keewKL+/eLv8xKL7wCn1Wc7TJ2D+tVYGNFj5yJk6emtY5XxVhEZ5BoIMCe5OqJXE+P0QW9u5VmzBwaFjtn+b2XTqGECEk3NoYrcuylV1Q7O2/vY2QHo/mctR71GQnQKsAIJoRHxZsO/PRHsno6PB1ls85BV6NT5G53u2xcEilLhmT6Vsc1VwyUVbMVfi4o0WQW7Z9UddSt7G+Ibog0I/eowv5m8MgU7dng+fLWP+4d0Ue8MKx/Z/g3xlXclfpYaftF9HnCEf1YhJmktwenoIaOvkvsoPoH+laiGvVWwlYxn3DDsiIfA8HOOmocbrJ5rtGKo0xzcixzpMIZNsfcZeQ6PZNj7e6djOitriZWiAGzzCmdMhj58lXHAv6IkvwEg3mNISgLoBH0rDkpc3FGEYLGtIgIFbKbY9LgWWMCf3vpelIikgHGIfWFI0zSl6HqnrN6KgzhyvKRMn/tyWwnQe2CdTqcO1CIZRuUIiohWwWXOg9yIUvXWCc8UBXwYGZPqKcNERjFLxMYYNrfpRssFAS5ZM/kXF5HvW2HWFXICIhF/LYK2zZibIoJFqbtIjFFb7+qG4ZaPQ8p0ofbEOcP4kkMZq59thjcb9KdiTiSGjkNVz5k18rCv6Ix3BD2VpWo5B3dRdoFSZZ7CQPit31JurZTWxYHvEYTxUTO0aQOpxsX2WNWQl2qvnEGdqzBC5/gBtjp9MXSL46rwZE3ufyaXg3Zd/05st5CqYfeNQITfSev2nFY7c71JRAMe0ri7ohaFwVm8PsaxWtXSU327RE/f1zJLpvlZ2Rf5skGNdYCqdSXzRynhJJuUcm1PqbH/cOMHzIwIogc9Ro4CZVkvblPG66AA1AIbd+AcUf7AUrkkg0tWXHcE82NqrVprzPal9cH7KFWWtxRHgL51QVIlkR/1vty+dK qVcJq2Qv ATDIbLJEq6bTjNZfuGxUfNLdInLb2NcIusLudYN1Z356UKIKmzEScwmgmf8Bb/cO6lPWWJgFtK/YjV7y/WD5pLZAu/mTnU8aLaLayfeJx4OUvQKaXvHwA99NyAGBTMp6stnrfB1VKA5fOktpPcmgTnvPvykuVynu9kx0aXTLrEdL2F151xu1yyMXwGWqTt7v2LDs4W/pUC2EjYZqJR3gGlBIoixIFHrBpdKmYMJFiXH51FyBOKtFZMunideL43II39uqn8kcLWv1QEq5htuI9o8JoBeu8wUaTsWIj2n+Fpx4zYjn1QEJiicJ42Vmro7BGgkiuHELk37rhUusIlakRw5AE3257Ui0s0zmij+KUSx7aqy7uhWqzzNc8tYerGlviW1uW+HrPLAdCOv30rJcq1UOkUhme4eleQpIm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Jeff Xu Modify mseal_tests to avoid using no-op mprotect. The no-op mprotect shall be allowed. Signed-off-by: Jeff Xu Fixes: 4a2dd02b0916 ("mm/mprotect: replace can_modify_mm with can_modify_vma") --- tools/testing/selftests/mm/mseal_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c index ad17005521a8..0d4e5d8aeefb 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -677,7 +677,7 @@ static void test_seal_mprotect_two_vma(bool seal) FAIL_TEST_IF_FALSE(!ret); } - ret = sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE); + ret = sys_mprotect(ptr, page_size * 2, PROT_READ); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else @@ -718,7 +718,7 @@ static void test_seal_mprotect_two_vma_with_split(bool seal) FAIL_TEST_IF_FALSE(!ret); /* the second page is sealed. */ - ret = sys_mprotect(ptr + page_size, page_size, PROT_READ | PROT_WRITE); + ret = sys_mprotect(ptr + page_size, page_size, PROT_READ); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else @@ -873,7 +873,7 @@ static void test_seal_mprotect_split(bool seal) FAIL_TEST_IF_FALSE(!ret); - ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_READ); + ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_WRITE); if (seal) FAIL_TEST_IF_FALSE(ret < 0); else