From patchwork Wed Mar 12 04:38:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cyan Yang X-Patchwork-Id: 14012861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E5AC28B28 for ; Wed, 12 Mar 2025 04:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2061D280002; Wed, 12 Mar 2025 00:47:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B7B5280001; Wed, 12 Mar 2025 00:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E4B280002; Wed, 12 Mar 2025 00:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DEE1E280001 for ; Wed, 12 Mar 2025 00:47:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2E7A0B7556 for ; Wed, 12 Mar 2025 04:47:07 +0000 (UTC) X-FDA: 83211664494.06.8F7C0C4 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 6200D140008 for ; Wed, 12 Mar 2025 04:47:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=KL57riac; spf=pass (imf09.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741754825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=xwa33pPskkPQ/NBZ1X9elFhYdOgnrg8vQ/GWrL0WjB8=; b=wA/mlLeAOb4M6zPWYl/yn7EM9BmzVYtyX7Kw3xzE+cLvFEjxLL+ZztudkxnYInXrnHq+Nw JqdZXA1wv/+WzFz18akfFEE+y4VE15EqW8ji4pNSpXj1wqAZxJnX0c70EPo8caNgcH71It ZfXAWAaXBZ3vOfF6Pu/pdHc6Ng8jmHQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741754825; a=rsa-sha256; cv=none; b=bfUDiBrGfLXbyxMNdbJqAR5uwYgp4UqZAkZbaxPDB2evMRncGFl+m/CHXXq8X4NSDrMuzM 9T2tHHLCIfPyseOGvPXNbsRrjKKVgLP/vlHBUH6AYGgl0Y2OcccfNbJ5+cubVCDPku4qjS e3RQoglhAgXlk2C3yFe9fTr4jgLOc4E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=KL57riac; spf=pass (imf09.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-224191d92e4so109900765ad.3 for ; Tue, 11 Mar 2025 21:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1741754824; x=1742359624; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xwa33pPskkPQ/NBZ1X9elFhYdOgnrg8vQ/GWrL0WjB8=; b=KL57riacsL4r/mH/fVBRvag1QdPCYGbm0dHyGME4rfG91pYT89NGn7m2BTj4aEs84R BvRBWVtRRUvW7DycbjECv5x8XuiXIZm8MYrpu/+3T5Mzevig4m7+bFFEfHJb+QGnZ6XT k+W5LEEvk7XG2OdW0Hw1+g1N8f4HNGWhE6ndtu6a7XHejb0Ihj2L0Psaxw5G9mD4odwk gDk5EDEzC9QA3B48YEmt+6hzDUb5G6yG9XUI7Fw+e0MJhW0QBZqK7EDGjJVgkDQYbkmL JgtBgwEjQVkX5YF6put9+UbDyQpPu5gtsttxE6Fo+KGekvz9I4RSVe3W3xoQlBSPCadi E+kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741754824; x=1742359624; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xwa33pPskkPQ/NBZ1X9elFhYdOgnrg8vQ/GWrL0WjB8=; b=IwPzGIvaVylilhlZjz50xMi6b9Iyf8Cs2R5yilSlzt9/3/gHhFd8LZqEGVL+XQZQwZ URI1Kugu0IZHFzb65QwJpc92vMd/0Io2QoKH5KsLWNvN4vQEHEyphpVK+xN3Lmnsz8e2 eSqF0X+TKmPnxSJNhjwiSIKrmq2J2myjorkyA9OMd2FaaMPYqN2SGIM6NovedoUPvkvx a4J4kL6SRdCWbHnaUEqAOBiVKRN9rNUYJ+RK5TMPlKlsb46Of6clkzFikfVdbqEseFmw A91wScbdppwEkv/IY8VKY6IzonTtRd4gyI02PAC/Fq3gbOice5QKvfggPpom7VQ5+3rE S54A== X-Gm-Message-State: AOJu0Yy9tVUA+jMrocvADYKrUxm/RN9eMe9n89n3t/rkWLn286StfMVV yPJjwZo7OcAr2efqIfjrwWgA4zrO1oH7l1HC5/9CD5c56wAIKWc5p1UH6qvRNL0= X-Gm-Gg: ASbGnctAazWf7Tm4ufBnZw53DRjOFIP0qnPCqaZBdlKKLKN85/714N9UQaqRPbLrQxa 14sMzRfBrGILHGmJfiKpiYJWil19JrzxHRTAQ/kyi9ku23k5t18lxCgsE3MRou36LH7L1AFrO5G kewSC9KDKIPUD1yOF1Km1awkYo47JZOuPkqwt/ynrogp1QI+QQMhIVdBdyvrGcs6j/ACtRRvAuQ MUGd1doqSRd1APUQSwWSaX9UtfxoIPDC4ye4SLVYl7WVIZhXSkiuMh/driqiiIbH2QukeCxIvb9 fRi+8vpjOQBcRhxLzs4a4PKJYbuzl0fjPX4VP3+FhdDufrX/RMu5zOqY+s0FpaTq7WCdC+gfeEZ KEZz5 X-Google-Smtp-Source: AGHT+IF3ZBeGX2GfMM873P0fcWHOC3RzkGYeWIUjoqHWJC+KJVsYNJNwu8mnTlo5rpp3HjcIEAPL+w== X-Received: by 2002:a17:903:40cb:b0:224:584:6eef with SMTP id d9443c01a7336-22428c057a6mr340406095ad.41.1741754824241; Tue, 11 Mar 2025 21:47:04 -0700 (PDT) Received: from cyan-mbp.internal.sifive.com ([136.226.240.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22410a7f7d6sm106476065ad.107.2025.03.11.21.47.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Mar 2025 21:47:03 -0700 (PDT) From: Cyan Yang To: akpm@linux-foundation.org, shuah@kernel.org, david@redhat.com Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Cyan Yang Subject: [PATCH v2] selftests/mm/cow: Fix the incorrect error handling Date: Wed, 12 Mar 2025 12:38:40 +0800 Message-Id: <20250312043840.71799-1-cyan.yang@sifive.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6200D140008 X-Stat-Signature: 5arkdgfo3qs6fd3wyj4cm7yzhwgaq98s X-HE-Tag: 1741754825-688687 X-HE-Meta: U2FsdGVkX19Sv36OFpyzam+0270lu2JRBtti5rsz/KoIN0aD7bmm7d680tOwKuUKx9JdPNU85p4/u3GAofnsMEbfiMD9r1zkKHRMUix+cK1hWuPlcnbnT35HEzcsr6eS1L7nvYlo+k3npMQIwfmUJIlPX9U+oRR3thCgkuCy5UrrKkM+tlTP3DkkQG57NKt4Y7ObyP641W6l+i49q7hTJwBZThyXJXIpRhyC2Ar6mWU5wY48JrLcCMPABP0RDknjlgdyI/j0cjkicyxKAFeEhU8j3zT4sXiLBjYTAzOTqP+0khY+jGMLEE19BaWPq/+26oOUlHLmAxcesBFpmNPov7XXoqvbcpGJcF55H5azkNB0Y6J97utMme5s064nHsLbC+uJFYN1V1p5rDHKzCQTAbAV1KlcBWQjUmhIVYFwc5uNwwvkvnDNNFql/GaENyzZDYMlbA2WgbL/F2Z88W99r4ieFvpqQDSi2+f0t/BQzOsxCTP/zlXuFJ7ncxq9PVokSeoBGAKbzbj2ZIJZjf95uITKwCs6PPN7az6vVIRbFBtku+rBCSt+sWMS6AWKVkswwyeBvwtJ4zBt8UerkxX+OX7Ylp/asvnTwDGO4gxP1ska4QVr6WVP164+Tojqgs2Eqp1CHKOrCiSrYfNJZj7A/mXCm3dEHB9Sz3fjxGJwB+3XsWbIxrcbEFn636hlouwHXEp80WZSH64m0lFXtNtaB4SHOopQt+2lUzILg86+cmLFU9Ok6x9O4mm6jW2DAILEVmNBoBRhopsUFIY/78IJJOcIMRiuH7lMeH6N3jCSHEquXVIjALL9Vv8dtND18HGMD5YSZFyaNh/uXMF/4YOpG74tXzQP7IY30URobVxqVR8s09m8Rjaa/W0XKuIkQNe/4bSauyzGIt8li7IvwY8OIxwrbOdM75x5wTCxYj8PaIK2qlFFFxxecYPsgFUmd4R8MaVEh5snh5h+1So/FkF XYhRFSar 5MnF5hsd0+truvrwLHccrK7Nz2BWETAcBgX8hlMVYXVhinfudsqvAKgONGbPGjU32Usw6mzodcgvjfGAjkuXQm5fYMiWKRnKXGN1ripoJipmFyuOztKeFGxXv1yjagtUTAvraGABUahfdlomhVPVhUJ2xH487OmkbUYLTfTZzQkFpZUnFDsZyNIlzlgjlhXABKIy1wA863OU/AmD4PtFNjeg20KRKqNQg3OnTsYgtTn+3nvrXG/DRnMINpsnMur6WlreyU0zSStPsGN/QoHT6FVq6TcGHIES6eatdeLtGMpL1Si8BAWM91lkV597HvBhTEwDPE5BJ96Mq4Vg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is an error handling did not check the correct return value. This patch will fix it. Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") Signed-off-by: Cyan Yang Reviewed-by: Dev Jain --- tools/testing/selftests/mm/cow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c index 9446673645eb..f0cb14ea8608 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -876,7 +876,7 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) mremap_size = thpsize / 2; mremap_mem = mmap(NULL, mremap_size, PROT_NONE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); - if (mem == MAP_FAILED) { + if (mremap_mem == MAP_FAILED) { ksft_test_result_fail("mmap() failed\n"); goto munmap; }