From patchwork Wed Mar 12 11:28:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 14013387 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9CDC28B2F for ; Wed, 12 Mar 2025 11:29:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9458C280005; Wed, 12 Mar 2025 07:29:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F8B5280001; Wed, 12 Mar 2025 07:29:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77198280005; Wed, 12 Mar 2025 07:29:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A619280001 for ; Wed, 12 Mar 2025 07:29:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5AE31140F87 for ; Wed, 12 Mar 2025 11:29:04 +0000 (UTC) X-FDA: 83212677408.05.A1B367A Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf17.hostedemail.com (Postfix) with ESMTP id 4401040002 for ; Wed, 12 Mar 2025 11:29:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l+osHe5E; spf=pass (imf17.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741778942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4Y2pmrTYmO5bH57hWQGBotlkwzT7/jOJNJhq77FZVM=; b=r5lgg2QoMGobm3Vyf2n6+NaZdj94Ml0IQnrVPY436ELgi6n3lP6rqRsRc+bei0kFMgyexC Q5at7uJ9F794lvu0aBO2EjSiJMFEeVdQq4NV8yR1+Bl6dpzPZwGXEWxtVg8InsRDZ5Sdx4 QWg3nS6hQa0ubqxy5hfJICxxicqhKPE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=l+osHe5E; spf=pass (imf17.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741778942; a=rsa-sha256; cv=none; b=HDs5uYjKQKdC0LBr9QRl0otGSavDpBAf4pxlOSsD3ySlCbsUg3/vt9gXG4hrze84WNHy+E nsnpHFE2XlIn5d/XKZTG0ou0bKws/9EQ1ykczNIE/eynDCs8UCoB9LAV790M53YbUSr3my lrXDVp4rLEB1E33vpGLQOGkrA2a/r+E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741778937; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=R4Y2pmrTYmO5bH57hWQGBotlkwzT7/jOJNJhq77FZVM=; b=l+osHe5E+0x5kCoyi8YGZ0mXf1/uREkuaJcqA2kJcZ5Ho4EG/+9mToEviln35roYuyOtXNX14tzoodWdO0KLWOIacPW1zbAj9E0clrUZO08pV6DRXtMKOLPQpO7QV0xsYjV4VnA2Kjpf0DEPs3qVJytouyUCre3xXii1wz9tsr4= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WRCdv1i_1741778935 cluster:ay36) by smtp.aliyun-inc.com; Wed, 12 Mar 2025 19:28:56 +0800 From: Shuai Xue To: akpm@linux-foundation.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com Cc: tony.luck@intel.com, bp@alien8.de, peterz@infradead.org, catalin.marinas@arm.com, yazen.ghannam@amd.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com, xueshuai@linux.alibaba.com Subject: [PATCH v4 3/3] mm: memory-failure: Enhance comments for return value of memory_failure() Date: Wed, 12 Mar 2025 19:28:52 +0800 Message-ID: <20250312112852.82415-4-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250312112852.82415-1-xueshuai@linux.alibaba.com> References: <20250312112852.82415-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 4401040002 X-Rspamd-Server: rspam03 X-Stat-Signature: gn5wxq4nqi47m5zxcq7363qscmadssdz X-HE-Tag: 1741778941-90141 X-HE-Meta: U2FsdGVkX1+Fh6Cs6/U/UzuOaWxTGgYLL6zsnQ1gpmc28ggMDWQFjfNbMeXl7w9Ze4/z1NhdXkPgbwPNbcWdyVtPp0CXB7b9PgJRzMQsUanX4kHKKSHRcMeb3nLZYd86Ry9YYRMwajAmuMrMg0Fn3WoLRh+jjOe8Yzq/lDsis052+0w6x0Fhax9fglnI/XNJug5yxHMOEW97UD+aT7z9yuP9FGQ+K247ljXhI1vXdosrqHnUXKLkesNP/0n0GQQh82SfNGIAQebRypPXhRA8v6S0ZTjDA0lqv4CHM6+fqXE7iRzDvYygc3jf6NuCucNgAn8W0Oypi3i9FjRW9oroFS5DdlcFa09laolNjPTLdc15gAS9qfQZuGUZcNdeueimt3uSht73dy/HkULTHGvJnXHeecTkKUHL+/DqNfJDJYCKD11BV6LPyqXOe9gPNo8dwLccHlSZJeipeCGz/kSYDrVz46nEtWOltfV/URe4Ef/0oOFJc/SWNy/eXLf4Ua/hFRRDuJN/2/5h7ZMS/LH6/qdRM6F2QY/ouP+w9CT/eI2SHar+VrKP2Qj5SmA06NaLQZjScYcO1yAsi0l9gcGXJ57RkZTQIFNL/dVkYNf6fffN3smA7hFYSl+Fjd9PPvNF+Yq4LaPWS7AKsYjUpNwqW2mxRsXXRL63vkRGX5XvyeSDpEGna8mm1nommGL4nk6xeVPKEetqNRrhR/wIdrnw+S4SKaMFY7YJ6ASNyOPZEPEtyEVgQtoyK6Br2lQj6Kcd4WkkAZVr5kRiYdd6XmdwW9OnhNxchSVsAK+/ZQuifvndYpscOE9JkiRC4vU7Me3rb2cuv4SqLQ2ybxDcb0lfH/QgBe3gddZ4Q4euO+fI2Tl+Jdk7ZCXqhDjZt/LSyiXdmCQmu93ioQcbitXJL1Kek9XDZYw2pebXwwm8O/h8aMYfvvNNtwsgE7pTG3/nBskpBcmI2OgCjn8N0ew4RMf WarKYQy3 K0m+ookZKJtfCmYW8tCJDUC0d7kdG6lg88ZAhjT3XSw7Y9dZN/GT/X1glc27K13q96BrQBiBxMA2oXlI9xlKJPPr38PqptF6YHu62kJFHGxtr3D02UgVl+h5Q/GA78Y5NP3FufDuWtUo83Uy3EksxML41Bz7qsNU9y5HPu/8Fc5LdpCweTTIa/7oCU0tQgxqnuGt14OomZP3qTmBtizOH18KpZiB2+VuDyBdsEXUxfzBw1hQFvcjj8zP2j5FlfDd7/ATKR4tUVDo7+jCp3L0NykSO3adA/ANHnzhGwMbrR82fJdT0ouahnLEMgARDh75IvEw8/45mPQtW5XZVwpn13+YI5yPmY7uuEI4Du93qgeusu/s7eQv9kHfzXcq6o3vJIF8eaIoQ+EO004fQ80l1o/yZBiamDLcyymbq1wnj+3ePUYaiD1n5hC2VoACyJQT4AaGzrDU6GhqG8vWoq1tTYQGolw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comments for the return value of memory_failure are not complete, supplement the comments. Signed-off-by: Shuai Xue Reviewed-by: Jarkko Sakkinen Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam Reviewed-by: Jane Chu Acked-by: Miaohe Lin Tested-by: Tony Luck --- mm/memory-failure.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b037952565be..8649849bcdb4 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2216,9 +2216,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, * Must run in process context (e.g. a work queue) with interrupts * enabled and no spinlocks held. * - * Return: 0 for successfully handled the memory error, - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, - * < 0(except -EOPNOTSUPP) on failure. + * Return: + * 0 - success, + * -ENXIO - memory not managed by the kernel + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, + * -EHWPOISON - the page was already poisoned, potentially + * kill process, + * other negative values - failure. */ int memory_failure(unsigned long pfn, int flags) {