From patchwork Fri Mar 14 06:15:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 14016301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C992C28B2F for ; Fri, 14 Mar 2025 06:15:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD35C280004; Fri, 14 Mar 2025 02:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B82D8280003; Fri, 14 Mar 2025 02:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4C25280004; Fri, 14 Mar 2025 02:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 86841280001 for ; Fri, 14 Mar 2025 02:15:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 41CA91A0ADA for ; Fri, 14 Mar 2025 06:15:32 +0000 (UTC) X-FDA: 83219144904.22.B8A2029 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 70154160002 for ; Fri, 14 Mar 2025 06:15:30 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IFAk3ny3; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741932930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cmS5hv6xwjGOhhAkz0IaR50zSoZuuoSBRO/S5eqp4mA=; b=Nd4/DkL0XI39AgJojJfG5le6pVqCl/Qy7wS4MNhymiEYdwub/A5IC4HXFI3gG+/96yKZDM zjVumJp0m1icNXI8NVMhOe36x/fzoskYeUF4qhPy230BcvhrHcFsu7cZWhExgKbwX/1C1r +q4kO7UCVsvryPkNho8lta9jhaDqkd4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741932930; a=rsa-sha256; cv=none; b=Hk2c9+uciVxAhPpF6qOR8I6prIcTSpyq4NqZv9WcQ/MfNwUQ13beUJii9DZyQkFnrztF96 Oze1GfGLfOQ0gOFZu3C1FC6Du34awuUCbJpnDPvrlSdhadiVV4WYB/ogKaDq8SGP0eG6Ti iQh8Q05MC1ayLqUDr2S87e+d4BCy9Hs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IFAk3ny3; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741932928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cmS5hv6xwjGOhhAkz0IaR50zSoZuuoSBRO/S5eqp4mA=; b=IFAk3ny3UqE/iQCJa7lOm0f18gE7d5o7rhlz8Rsi6NYU4Rbjj03rJ/JizQmPAY0O6BVqup yEGTkuAJggm5Z9B13K0mwm3oUigTkR+xQtR8TVgwbpmnqyYUpzzkXSWkBOkqt3KwZEJQDf A6ZNhSvExzpbiw9PsZYYi1jj0cgmXsA= From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: [RFC PATCH 01/10] memcg: remove root memcg check from refill_stock Date: Thu, 13 Mar 2025 23:15:02 -0700 Message-ID: <20250314061511.1308152-2-shakeel.butt@linux.dev> In-Reply-To: <20250314061511.1308152-1-shakeel.butt@linux.dev> References: <20250314061511.1308152-1-shakeel.butt@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 70154160002 X-Stat-Signature: bnbuxtj6tzx7yuwnjkc4m7exni63c6rx X-HE-Tag: 1741932930-58923 X-HE-Meta: U2FsdGVkX1+qP/W4/utC/i6AUDuHnSLbTon6KC9D9hWoynPGjjdwL/77j159cyBcnntqHPYLkaflk1Wljo1kOwSTNGaXoX1r745EJ9Lw3SmvuT0M4stj9aM6LlQBfBEI0I+Qdi4MvsgyYopYYKg4fjdP0ws1BH3iiJTeatQ23c6MewMcMiXwVA+odByDlUkzIHsdTz6GC5un6PZjez0XfJS1ex861F+5iEjgApIb1L/ldIBr3qkQkr5SMS6zSfk9OYElPa8/U1fPxqceD5H0SN3exVX2jXlnswVj56vaGMWruCugzj5pyGiVob1g5BYQNzyi3CUTk2YpzweV5RtmOBobpamUeep84BKeJmSxVPbe/L70RR/snncY4N7H9G4OPL9mAOVyuQ1TQElWJ5Z98Kox24DrHYnzG8s9+sBUpJjUhEsF4yGHRfT/s6pX0IElUzvLcYTj5J0LP3DW9mGAJJYYTTKSgDZAp0kJ25qDiQdjUvLLuTzyiHJvPBYK0/ns+diNtDj959VdLw7Dujc0J/bFHUicOyRsjdOKCASABiIjgZIsXJfAd585qw4DOdzuwqn6dK17VHyNQwK39Ki555Sowo0V11O/PzRFC7+nUtNTb/zk7dJA2dUF/2DSMbY8Egu67hpGPKmzbb4KNBqtZ2B+S0hMA8YX+1EvBXN856xZigr5C4MEG7EGw9dnA7i4OJjWKK5SROFdPh4BMo3tvd5BBDHk/YFGLs7RuGY0AVpNzAmrmqtRdK51ErzeiQTDDyW0YwkFda6h3+rBlck3QwNhRzKFxiwON/eV2Jn5+66WynHb+8KVVWxZJi/Eh1PV4liuPPPz4W5fbY7XTnDfT+XT09jARgHME3JB8pVquk1nyeBoXfmg6EWlLDgb5THG2ax8YEnVtnzbtV/32smlROdmr0l6llOLPK9xuWAnv1S/DkVMXj6LQ8/ld9nO3PuK4AtKwyqk3t45rOrs3IW T3Y75546 G/6pL+EyIUCUxeMA0TIkUyB49M9bagcV3Ow0lbgrf07uVOKmECbFtd4iTIGjaa6CgcRJVwSPBtaD57ueGHsL/ywxynQD1C5gFGMwuOWG9r8TI7GI/4zIx1l0vQhfao0lD7LI4lNUc3T1nfoSA32ZL/gB0HqNgTbhblNipEAdajag9NiGfXJ7xsrARPwO73inFoxRoFMiShw0FmhCTArNumgkdJL7cuuXbyp5o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: refill_stock can not be called with root memcg, so there is no need to check it. Signed-off-by: Shakeel Butt --- mm/memcontrol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index b29433eb17fa..c09a32e93d39 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1883,6 +1883,7 @@ static void __refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) drain_stock(stock); } +/* Should never be called with root_mem_cgroup. */ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) { unsigned long flags; @@ -1892,8 +1893,6 @@ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) * In case of unlikely failure to lock percpu stock_lock * uncharge memcg directly. */ - if (mem_cgroup_is_root(memcg)) - return; page_counter_uncharge(&memcg->memory, nr_pages); if (do_memsw_account()) page_counter_uncharge(&memcg->memsw, nr_pages);