From patchwork Tue Mar 18 13:53:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhongkun He X-Patchwork-Id: 14021053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F3DC282EC for ; Tue, 18 Mar 2025 13:53:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 572AA280002; Tue, 18 Mar 2025 09:53:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5206B280001; Tue, 18 Mar 2025 09:53:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E912280002; Tue, 18 Mar 2025 09:53:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20609280001 for ; Tue, 18 Mar 2025 09:53:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6A3EC81295 for ; Tue, 18 Mar 2025 13:53:44 +0000 (UTC) X-FDA: 83234814768.23.5DFCAEF Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf11.hostedemail.com (Postfix) with ESMTP id EF55F40002 for ; Tue, 18 Mar 2025 13:53:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IeMWr2h8; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742306022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=N5HtI8PjPi7diwCw/mXwfk4KHB1o+8i1IdLEDe1XssI=; b=UwaOFYj8cykz1Fo8UgJP2hAJSLNUgwcQP+YC77FlxmebK7VirQW3EyC+YZBLgWHr5CPs57 8TitbQT1vMccUxbQUS6qdoLUj7OZ0nzySJbnYCpEg09JDOlkUMT7mGHpNqsrk0+lcntSNP Hzl3qEsoTIFuHkK0eamHblh5DuHTwTY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742306022; a=rsa-sha256; cv=none; b=t4pkFWHks282kngVMFdOAj3XiTBOIsQS3eD9MnKc16C0ipUrBUsTqJREYAinSYZuitiF3L igWm1+1r5FFk3EGWikgd31Wc2tYsrgnV+SFgKXtPNCo9N4hIYJ7xlLP95bzGFJsCfvdynY vWfNAlFVph1Umx9zQE8gMP+ZdFl5A2k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IeMWr2h8; spf=pass (imf11.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-224191d92e4so107632275ad.3 for ; Tue, 18 Mar 2025 06:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1742306020; x=1742910820; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N5HtI8PjPi7diwCw/mXwfk4KHB1o+8i1IdLEDe1XssI=; b=IeMWr2h8IhdZ3qxVECVA75gciHZBTiGrpWAuPyrVXvDyos3tkn3KhIxYz1y+seqrLm aRqs8s3DUDox6jXjfMskLG1ftTUVnppeBwoSsbizuQ7U5pJiI1kcUs1r43FlIM0q00yj 9zGPQZ7Yda6m5xeZ1zktCLZ+RYoBnbL0GUMJztN2a11WVXn/7u/68+/aIPITQR63226v l0DpjlFK2gWO7GzShU2A3NWwOikU6sVYLtHo2JQxggswxYWv+Y3o1X/4/f4+z2xtbD9M nYnAqdrwC2qeZ2m+jUpnO1l9pe0pKCBJiNGpH20ivDDR/UALPqh62PDL4PTpNeRP4l/k qk4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742306020; x=1742910820; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N5HtI8PjPi7diwCw/mXwfk4KHB1o+8i1IdLEDe1XssI=; b=FGZvAKBqsR9SWIWqynAMSqQ1W8EKTcKa+3hPyrmaC/Zrz/andsnACLHey0Y1VeGxfi L1qi2cVToiUKqP1VftWkuix9ERswMJxWVtYoSBVur4ucVl8JJ3/leW6WptGx/C6x3zSQ 1qmOU+TaVwfnCOo+JwkxRBdCG9++vcnXpCVb9NVkbMxr9KGwi5gX2mc4+rfQjAbZ5Hbb BEMjwy6kuYKS+U9E/kJJRgkeR+Zqm9P5SqBRbiWWi9UK4gmV+pX2dzL5k9gNcdn9kyoY 4ntTVIh/top2+KrDVACV4hKXsBC0lFTX8dL7Q332DTVtExhKr+Lwdg59pg7XwBQ1TUbk RTzA== X-Forwarded-Encrypted: i=1; AJvYcCXsLrNuH2J/5SgGOVdl1GCIs3oMgMWVzDVXCci+5UidL7GYdQzahGyFZv5uniQtUpp+r2AWUiLBBQ==@kvack.org X-Gm-Message-State: AOJu0YxVAy6PuVIt82o5vch3jE+QhD2q7+qy0thbaBCBQuxDDCZoWLr/ gbYiTI1DP7708UMril1OiwVyev/RsvTP4QhcfZOrcyF+P7OIc2kDHItZK8YTGuE= X-Gm-Gg: ASbGncurs/zjrnOSR6Z2IqpHPXHigyQ8M/wCq4rm17TfrE9vj5nvU4in7OwHBMJGYi4 Cd2tzcSdAZGMRePx1EuGBIk+zC7HHMi9djCwHl3EUpjxVTwXDwT/5KCJLsqLupgQ7lXMqoX44lc 4orV0+RMx3mMv+jzbhEu8N6vX6A3fwFe8M2cce0a75fDC3IWpqrlH2ZPvQNDoWPCL1XTReL4bre n6EDA3Ucx2p3ExOCJYbGp2S+3ow3gvWzCXq+eWP/Ra6tMcmfQtS2e1vzce2AU8Abb391ZhMg1mD zwWd9Bv7hHyXW5vortrvlQjkKXKi/q+vU2Cn6uc83orzdxGQhfdDJWiy8pN2L5j/OvFt5aexLk5 Nf/ZU X-Google-Smtp-Source: AGHT+IFCJpsyTzvEK8x1goSypoUHMCPpoJCEBdCHWwjyQorzUNgYtOP1dk4bOaTLNY40mECVsbKFRQ== X-Received: by 2002:a17:902:db04:b0:224:8bd:a482 with SMTP id d9443c01a7336-225e0aa7e06mr169975625ad.25.1742306020577; Tue, 18 Mar 2025 06:53:40 -0700 (PDT) Received: from n37-069-081.byted.org ([115.190.40.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbe905sm94166945ad.190.2025.03.18.06.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 06:53:39 -0700 (PDT) From: Zhongkun He To: akpm@linux-foundation.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, yuzhao@google.com Cc: mhocko@suse.com, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhongkun He Subject: [PATCH] mm: add swappiness=max arg to memory.reclaim for only anon reclaim Date: Tue, 18 Mar 2025 21:53:30 +0800 Message-Id: <20250318135330.3358345-1-hezhongkun.hzk@bytedance.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EF55F40002 X-Stat-Signature: mt4bnizbs3esr8ojodk16sfzd1tocjyy X-HE-Tag: 1742306021-296547 X-HE-Meta: U2FsdGVkX1+AVWGuK6KBckfdAGoqkcNbuDbREPwTvLTem0juMXGbVoX0GUqfw5NQhwjH9WzKxb+gq6VowCIBd5WO+FUyOt8zi7GalRGCrYgoFoGPzeYFFfMuNWknWctpxZ3F+kHFOiN4X70q0QLwYrXRYqTGCBGlXWa3rvE9ukqJopk62fNn8MWBn8Y9C6crXxWX32hmOZTXQpH/NOU1fd0bizviGQecc8gjI4vqWEXuN8tg+lP8klm7b8QHRdodgyirO5huRn8cCC5+tHPGp+DRTf6RO09azgGxJddN2KrPXDezJtywRKiWlWWMb/dq7g6weaUpqmr7flhrO/Um3rPQ5oJPQWYvow2MWW5cl5DxqRO79kEJA/QbauvAc2Y/qSJw8u09LUMCkGZ0xZPeYVHbP4o1Hfwt7YIxJcY4p7G9nVtacaG+jbG+H2gAO+DmRTvu3JjtBjPMdQNoq3okLIWW5abm38jbd4/NOqCqhA7icECgfOZGd4tORipjJ4X+lRAJHQY+79jVxEN2WDFufCAKUU92lZbJwKiKJQ1hajaFzHvHxhAeqBOeRzgaDnj4DCojHiEYjefGOtHB2U+lNHSy31ISVeZaEUq6hakZ9mYksqDOObXFDjext39UY0z2EFQXQiQmnihiH3KBS4eKodmAm1FnxdjsJEoc9l8Z7UzSyRUmg8i2sOifgGBpQSt4B4+A4roBSO9SXj7KRorgAyqbQnZ6/6fqvs1j3q5q2RIYsi6vZxLkEIn9XlnBQ/O5hHx3qs6IK5xHeprzsL0J6ju4vLnAG6n4rtFL1EX0NEn9bveaHdUwUqGm5YlQY6QdpgK46w4zl7tVcC7c/AKeTU4PSK3s4vphB0ceP4jaO5a7lMFUU2WuRA96zI5u1+QmmXuRyNEvM8F8RRIgYuVI7piLv78FsCbUUPUk1zQ/Qydtr0X60I2NdB9dxWWAWOrCHJQ/YoDYIi2dw3UZKdW 67G97Pc+ pQBJiWMyGtmkbnVy6RKuN258RtUhG9VhxXvbI+vGapcnpryVG12dCTkGorFBgR69QOsaZlTf9ELTXNw2i3uZZSi8zxmYNf1Qh6taHTnxcjzWhSt/CPlcZaD6y9zj0g28g+B/OURGJy+ToRHZi2BjuyWmUJlkAtv23KotSU1fSOoBdqoQYsKLtCWH3+eI48X1Aj+BU+Oo6JQG/dnLcY6AFr9J5vJIQfvNhbTJg+1JxYbx+/lkr5hYkJT7c/zjbH8iKRO6UmMqOYP+yQZ0CyMq5jNGj9bxgoSnIt4Nddq/Q29reB0F8wbN3PsmRXCxNzJmezaOmCPQa3IsEby4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With this patch 'commit <68cd9050d871> ("mm: add swappiness= arg to memory.reclaim")', we can submit an additional swappiness= argument to memory.reclaim. It is very useful because we can dynamically adjust the reclamation ratio based on the anonymous folios and file folios of each cgroup. For example,when swappiness is set to 0, we only reclaim from file folios. However,we have also encountered a new issue: when swappiness is set to the MAX_SWAPPINESS, it may still only reclaim file folios. So, we hope to add a new arg 'swappiness=max' in memory.reclaim where proactive memory reclaim only reclaims from anonymous folios when swappiness is set to max. The swappiness semantics from a user perspective remain unchanged. For example, something like this: echo "2M swappiness=max" > /sys/fs/cgroup/memory.reclaim will perform reclaim on the rootcg with a swappiness setting of 'max' (a new mode) regardless of the file folios. Users have a more comprehensive view of the application's memory distribution because there are many metrics available. For example, if we find that a certain cgroup has a large number of inactive anon folios, we can reclaim only those and skip file folios, because with the zram/zswap, the IO tradeoff that cache_trim_mode or other file first logic is making doesn't hold - file refaults will cause IO, whereas anon decompression will not. With this patch, the swappiness argument of memory.reclaim has a new mode 'max', means reclaiming just from anonymous folios both in traditional LRU and MGLRU. Here is the previous discussion: https://lore.kernel.org/all/20250314033350.1156370-1-hezhongkun.hzk@bytedance.com/ https://lore.kernel.org/all/20250312094337.2296278-1-hezhongkun.hzk@bytedance.com/ Suggested-by: Yosry Ahmed Signed-off-by: Zhongkun He --- Documentation/admin-guide/cgroup-v2.rst | 4 ++++ include/linux/swap.h | 4 ++++ mm/memcontrol.c | 5 +++++ mm/vmscan.c | 10 ++++++++++ 4 files changed, 23 insertions(+) diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst index cb1b4e759b7e..c39ef4314499 100644 --- a/Documentation/admin-guide/cgroup-v2.rst +++ b/Documentation/admin-guide/cgroup-v2.rst @@ -1343,6 +1343,10 @@ The following nested keys are defined. same semantics as vm.swappiness applied to memcg reclaim with all the existing limitations and potential future extensions. + If set swappiness=max, memory reclamation will exclusively + target the anonymous folio list for both traditional LRU and + MGLRU reclamation algorithms. + memory.peak A read-write single value file which exists on non-root cgroups. diff --git a/include/linux/swap.h b/include/linux/swap.h index b13b72645db3..a94efac10fe5 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -419,6 +419,10 @@ extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, #define MEMCG_RECLAIM_PROACTIVE (1 << 2) #define MIN_SWAPPINESS 0 #define MAX_SWAPPINESS 200 + +/* Just recliam from anon folios in proactive memory reclaim */ +#define ONLY_ANON_RECLAIM_MODE (MAX_SWAPPINESS + 1) + extern unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, unsigned long nr_pages, gfp_t gfp_mask, diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4de6acb9b8ec..0d0400f141d1 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4291,11 +4291,13 @@ static ssize_t memory_oom_group_write(struct kernfs_open_file *of, enum { MEMORY_RECLAIM_SWAPPINESS = 0, + MEMORY_RECLAIM_ONLY_ANON_MODE, MEMORY_RECLAIM_NULL, }; static const match_table_t tokens = { { MEMORY_RECLAIM_SWAPPINESS, "swappiness=%d"}, + { MEMORY_RECLAIM_ONLY_ANON_MODE, "swappiness=max"}, { MEMORY_RECLAIM_NULL, NULL }, }; @@ -4329,6 +4331,9 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, if (swappiness < MIN_SWAPPINESS || swappiness > MAX_SWAPPINESS) return -EINVAL; break; + case MEMORY_RECLAIM_ONLY_ANON_MODE: + swappiness = ONLY_ANON_RECLAIM_MODE; + break; default: return -EINVAL; } diff --git a/mm/vmscan.c b/mm/vmscan.c index c767d71c43d7..779a9a3cf715 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2438,6 +2438,16 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, goto out; } + /* + * Do not bother scanning file folios if the memory reclaim + * invoked by userspace through memory.reclaim and set + * 'swappiness=max'. + */ + if (sc->proactive && (swappiness == ONLY_ANON_RECLAIM_MODE)) { + scan_balance = SCAN_ANON; + goto out; + } + /* * Do not apply any pressure balancing cleverness when the * system is close to OOM, scan both anon and file equally