From patchwork Tue Mar 18 16:18:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuad Tabba X-Patchwork-Id: 14021243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818E1C35FF3 for ; Tue, 18 Mar 2025 16:18:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 737D628000F; Tue, 18 Mar 2025 12:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E93B28000B; Tue, 18 Mar 2025 12:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5125928000F; Tue, 18 Mar 2025 12:18:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E19F28000B for ; Tue, 18 Mar 2025 12:18:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C655C141C for ; Tue, 18 Mar 2025 16:18:46 +0000 (UTC) X-FDA: 83235180252.19.4D756E4 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf30.hostedemail.com (Postfix) with ESMTP id 6688D8001E for ; Tue, 18 Mar 2025 16:18:44 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="J4+C/Dmh"; spf=pass (imf30.hostedemail.com: domain of 345zZZwUKCMg7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=345zZZwUKCMg7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742314724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YWV37Fu+tJoPMYhPX//LQY4FHmLdXa7vPP9UtI4St3c=; b=xS8tL6uWizjRPqs4JX07N8ccLQJcYd3vcPrcgf+8v38V8AUtOPCT8k2MlizkaCWcwu3947 pTWd/UMNlWrVfdvLN5uBksPkhycPHUs3IxysUvGuLf7u5K8eW3WXzxDc3KUzBi8K+agGFa 9vfUl+hga2Bp2w8KeYB6DAZywlI8xTs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="J4+C/Dmh"; spf=pass (imf30.hostedemail.com: domain of 345zZZwUKCMg7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=345zZZwUKCMg7oppou22uzs.q20zw18B-00y9oqy.25u@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742314724; a=rsa-sha256; cv=none; b=d1/UdRBXBNYKJP3Gf6HJUXoicM/p8T6Q9bxZAceaMXcKuFsOwu+jysMvB5mwZ3oNf0g2KX mXWeTTrkokaGlkHtF5gfp+R9wgcbKkWBJC6/cJ7D8QzBEZYDQqmHjUuVs/IfTSr3nlgS/W MsBn06JnuznxI+zSoBk4Z3GV20kDIh4= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so30679415e9.3 for ; Tue, 18 Mar 2025 09:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742314723; x=1742919523; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YWV37Fu+tJoPMYhPX//LQY4FHmLdXa7vPP9UtI4St3c=; b=J4+C/DmhJ/UtVqtI4FkurSbzENr1mtXu6rA5/pqy6vKn1ZemgcdU1tK6hgTlnH+6lD UDsOU3cRDm7JDyVoRufUVApgRmwORhByiZ/kGb4r3PDxrSsmg0H8RqzKMIXTvr3UDk53 T8gQQHa3p4ne2VO9gL/mREXQxyG9xcu0IkhT4QW6EOtQqGqBQ3q2Q/+lZF+2EGvCkFRG FAayrTvmtJuSA71NY/4BtkUaABd7clJoOhLw/sXbrLocci+oAeyAbYXt14/RXue0JkLF k5kD9fSIS/WgViJz/fHvuUvfwp5LZ20HE7FZaCrtGmhR93u8y5KYMiBQ+pli/0SCF/BR zU6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742314723; x=1742919523; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YWV37Fu+tJoPMYhPX//LQY4FHmLdXa7vPP9UtI4St3c=; b=FrwFnCWKPbBNJhPTop0HW5fCdlcLphyuZMC5E/bVQ8YnMLRlRwjUi7RW8kACzYgT3n icBW7y7BKPbNqFwpl9cPg1fQxhALfpgA7NvLutD44iHHNg2l73y83EJ8EQsDEhSJA1Dv CUCyP0VV/yQcjyBb+sA9dedi6dmJzzm34m2MZuSMzacl+tdegthKF1STveywkxqi2YV3 f1jWbUxElQJkvgt803m2PSsdZzGg/FJC4WD2FWUqv3chk6zQJdIfWaax5KVU6pEUgBMg TB05Vn0IKcFNrWDk8OQ+/ZmYKt40rb/lfXSOU+bdBlj3bnYuMzT4ot+fCkNash8YcV4t /yaQ== X-Forwarded-Encrypted: i=1; AJvYcCVepeezrpke6V+J1w+zaSE8VnYjV9Bn3BOY8x0NWyz1tThCHsDQAzc0pfJv4amRAmP3YFaP5SG2/w==@kvack.org X-Gm-Message-State: AOJu0YxnN5J573wcJkYE62PhaKN+UxZH8wM4tcWrph6Wchj4ZlJQuINw i8o1EzvVFWchNS76rv1KW+h0nrO84oYfIVcEpkihSKRwfLjBpA44wX/Y81o9BKNVQ1AG0zegUQ= = X-Google-Smtp-Source: AGHT+IGRTYPnfa8CqiXnFH9ZNBBgKbN/7IfwN+GVa+iyNbSKldeysOLwqVRPA45JgaTBntykYDM/9tDKvA== X-Received: from wmbez8.prod.google.com ([2002:a05:600c:83c8:b0:43c:fce2:1db2]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1909:b0:439:9a40:aa0b with SMTP id 5b1f17b1804b1-43d40ec6496mr3290515e9.25.1742314723020; Tue, 18 Mar 2025 09:18:43 -0700 (PDT) Date: Tue, 18 Mar 2025 16:18:23 +0000 In-Reply-To: <20250318161823.4005529-1-tabba@google.com> Mime-Version: 1.0 References: <20250318161823.4005529-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.rc1.451.g8f38331e32-goog Message-ID: <20250318161823.4005529-10-tabba@google.com> Subject: [PATCH v7 9/9] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, tabba@google.com X-Rspam-User: X-Rspamd-Queue-Id: 6688D8001E X-Rspamd-Server: rspam08 X-Stat-Signature: aueodiothbe8ywx3ojrgbaiwfq7wxczg X-HE-Tag: 1742314724-206540 X-HE-Meta: U2FsdGVkX1/+a/HUfSsc5P4FquexXTts635o8qV/FVQ4jMB8W4zzUCi+8SjPiPE7M3KQIxKOYr1ePYGGXTRznm9nQiY+e86KS5urGSKevkxELFKWeDHJjY1CpPG/g1PlqHcEMvNKhYLbysDyQT2gmeZOFZF3mfx1Uh7Pew/GbgXCvpCyY0PQH9dUjacsDitr7SlmgzD327D86UDj8ogr58w5bZzyFZaJAAl9mIvcZwQEzbJ+WCj17gl6VS82rUR20wgonJJeMj8jisUKJZhxTBssvlJlbTf4dKq3zKuhyNAEzuWiJH/IL6nD/AJtOduKsI9r14Dq4+KQPtDfbHTC+ZdbUaaTM6USXmRqZrRjtFZWfNBmNGoKP5KGiqzNuH5bxI3Hwy882k6DiVpMkECMMrARPJGy6AzemhDNz2xxYVld6fmer5XNbqm/Q7Mj/VwMeVpQMbu9zgEjJchKGEPC2ncyoGDAAwwt8iOnuSS79FUI2rNlPgVeBCXC46YN+z+DwEesdsVGq9yBE507AxYBk0PyRQ5iqzw+f7jqC3YOEK+CjV6x2suJ50FMIk+SojZyzQmBUv20bExxAg5PU368lIwFB/cMtvd50I4NKDF+FVWj0lO2PeaBC3iHEZof8oc2v9vGokqGgijzfiqbJPouvXcEIlddRjUxdGud+X+W5UOfujbJG0F3+wx6IDPSTw/lfF7S52a16D458+5R9g5YY6U20rPCS9VKyFdBizAS34nDCYqpqfZSBHGekLKBuONg/QQDxLHrBp4uPEyIWWr2xehY5yTM0x87HYPQKaIhJ9QGmYNl0TC+RIwlHS+e3pu47dUkxoiPX+liuCHMot45JlFZrivcXAewDG9U+9M1Wmv4QU0iZ500ksQMQH1Sz8yVerHS1ghf7OUoBUHbYc2LMmk4ZZ+X5T37yx2l/w5buu1jY+Y2iFNopdGzgAwYTrWI5DgJE0Ry4zOv2RAXwgg A1j6vQb6 2H3viDpG7hkIVafVpWWljJmDaq55wyancu9u1mRTXffsq1EZl6k0BnoEYWRQ3u/iX1+OPLRyG2oSV1RA8crRFtH+d/b3MYcjZYVmT7twVaCZJBeML42Rqy/WSDVUu4tQoO1bnt9dXlpZr37ogd023e3zb6AYLnxEMs8QDEUlpgl1k/MRgMpqFbyp71kXVY1Ofr2zcaz4Bzx8G9grsUXSBpVJgvlgDK23ufuW8vm5UTjcaygozObdfQbN3ww2PV9cr/JaKUdJQqCbA1JMrQZ7mXtgXO07STn7koUUZD37FdC3UIcjYY2r7Oci3Oz7NTUCxeC9LKEJgoK97t/XMiXeeI8YBnnQMWNqFysDe11ObCup7weJwbEJVpsGU2cdqDg+MDFOYFfaJv7FglszyOWT8d0PnjbNqu9AqkD7pRlqpHkWIo5IIEn8w93UoFlQBXiQhMNZ+fBPnLA06DPglSznt6B8JOy3QacYIpKBHuYzPtfpiqq94RCpAtLw6r75h12oepG9U+0uEQjSpaGyNnjRQM3ARpFHcoxtRasgPE7GUrae/eea09lK3Hv0CCgYNGn0h+CFc9fnxxZm9oHcPZJSyPPiqHAAFsPwO9aZ6mJZoHIklqEgKikBmdvIkT/ouv/Ftm9Hc0h0HKqZbWLwlQ7smbXxCzI2MzGWTxJZZQuNAZQ7bOlG69h5yIuqHS83HqDhp9+fF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for arm64. Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 4277b983cace..c9a3f30e28dd 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -160,6 +160,7 @@ TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += demand_paging_test TEST_GEN_PROGS_arm64 += dirty_log_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += guest_print_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += kvm_create_max_vcpus diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..38c501e49e0e 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t total_size) { + size_t page_size = getpagesize(); + const char val = 0xaa; + char *mem; + int ret; + int i; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t total_size) +{ + size_t page_size = getpagesize(); char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +unsigned long get_shared_type(void) { - size_t page_size; +#ifdef __x86_64__ + return KVM_X86_SW_PROTECTED_VM; +#endif + return 0; +} + +void test_vm_type(unsigned long type, bool is_shared) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(type); test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (is_shared) + test_mmap_allowed(fd, total_size); + else + test_mmap_denied(fd, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +int main(int argc, char *argv[]) +{ +#ifndef __aarch64__ + /* For now, arm64 only supports shared guest memory. */ + test_vm_type(VM_TYPE_DEFAULT, false); +#endif + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + test_vm_type(get_shared_type(), true); + + return 0; }