From patchwork Wed Mar 19 19:22:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 14023043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA824C35FFA for ; Wed, 19 Mar 2025 19:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F009828000E; Wed, 19 Mar 2025 15:24:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED78C280001; Wed, 19 Mar 2025 15:24:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D535528000E; Wed, 19 Mar 2025 15:24:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B836C280001 for ; Wed, 19 Mar 2025 15:24:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0126D14072A for ; Wed, 19 Mar 2025 19:24:31 +0000 (UTC) X-FDA: 83239277184.26.32EB004 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2077.outbound.protection.outlook.com [40.107.94.77]) by imf07.hostedemail.com (Postfix) with ESMTP id 10A944000F for ; Wed, 19 Mar 2025 19:24:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=pSL+Qafx; spf=pass (imf07.hostedemail.com: domain of shivankg@amd.com designates 40.107.94.77 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742412269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c8P+xOLNadTEZ5L2TBrKUW55HXRM6KmjsOy9cLgaKdE=; b=pRpsHs36ca8wkk7cWx7t9crZ8lKUEqM6kVWJoyDrNnFrR6Z0K/DpkSykEJmei7bN9IXu/B 07KnGFed0gP5Y9XaOQwOYahUhKiotzbGPrFMqNLv68gEhT/kLB/TJICJUGcQJGZs4iVM1N 8NBucNqhLXyfMrN3Dq1m5+aq3URp9d0= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=pSL+Qafx; spf=pass (imf07.hostedemail.com: domain of shivankg@amd.com designates 40.107.94.77 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1742412269; a=rsa-sha256; cv=pass; b=5neLQkrsKFqKSOM/fi6QHSuAw75+BzUWcx6zvDbmbEEMAEv+Xk/GF0ayZfsKdIGpOHNRix OowcLzLkgaQz3PelBtvykwX2061QhmFuLU2w8j1oBzsTpjxB0HfYXOkeMVv7MYmylsQ3aJ ODRwhcZMYus5f9tZMG8T6R/4h9GXqGc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nQriWq3ZXlUSxGN5mClOuyTuKJs+tFeNJP1FAOXrL9IIdT8K7Ll/vgxUqNq8K+T4NtNZO7EFFvTuZNQspcFg71iw4q6mu/IYDwrr/65BLHTOVHI6dchw2UxP0QTIzqHOCgVoL654h8D0zAcSXBy2G3b5y0HtajDUEChiZY/qsUVogpf3wlevtD3xMcYD8cNXGBnYNfH5PZbWN6wnYexsa02b7HJe3tm8uotzK8uRNF/uLLxvNl5HkryL2janmh+6TlxmfkqI0YTB0N20dvQPtFTaStT18oMWC0QNYTz7+BFyuMkVkF8fIHWDMGj/nCHvdngjr2buk2OxuSX0/xdCyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8P+xOLNadTEZ5L2TBrKUW55HXRM6KmjsOy9cLgaKdE=; b=IPYtHdfe3hSXcZ6uJU7Ga5DgIB8zFXak0nffgG60ApzPCN/P17O4LkwjOzIBYlj5wfePX+imc0GxgGLx4oSmGWecIbKs8S5esI3tjePRQey1hR+Sl2Y6/JGrHinMbG7KJlzPiPqB1E1xbkFuiV1e+9M7eejnDICYwwkCCrynzzK65rJE3cDjmMPlfIRYO5PUFq0EGn6K+8Knl1OIzyv0/3pS0aFCzycC2yqqdyRxvNwmY5j+HUX01EQlqmmCAlPDXLKYTMQdXgnjWcH3PxhiMnUNk1+m1Kt7eeQeh2ljxji68h5XaIX0PLZOmv7fGGX+CJoA1UqVex963lbMLI3/Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8P+xOLNadTEZ5L2TBrKUW55HXRM6KmjsOy9cLgaKdE=; b=pSL+QafxoE77gAYvKVjOIo28l49ybnj3kTIfqekB0W6EODp2JmbGnDdPW5pOPjTWnEfviVSh1h4psoSGTSU2NZEydTea8nbeBgHPz+nKsnCVhkzPMESunmXwt3xu9r46BKEWwxh+iX3pbbf9n17+W04F/yP+jSoNxdht4Ke3Za0= Received: from CH2PR10CA0015.namprd10.prod.outlook.com (2603:10b6:610:4c::25) by CH3PR12MB8331.namprd12.prod.outlook.com (2603:10b6:610:12f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Wed, 19 Mar 2025 19:24:25 +0000 Received: from CH1PEPF0000AD78.namprd04.prod.outlook.com (2603:10b6:610:4c:cafe::f9) by CH2PR10CA0015.outlook.office365.com (2603:10b6:610:4c::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.34 via Frontend Transport; Wed, 19 Mar 2025 19:24:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000AD78.mail.protection.outlook.com (10.167.244.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Wed, 19 Mar 2025 19:24:25 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Mar 2025 14:24:14 -0500 From: Shivank Garg To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V2 9/9] mtcopy: spread threads across die for testing Date: Wed, 19 Mar 2025 19:22:12 +0000 Message-ID: <20250319192211.10092-10-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250319192211.10092-1-shivankg@amd.com> References: <20250319192211.10092-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD78:EE_|CH3PR12MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: 79fb7930-f6ad-44f3-293e-08dd671ba8ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: V6niP53U8rM7xPccJMkBaqVBh8LIChEV0FEUf1bYsp+egNW7sxbH7/GapdCyTmBgzqxOS210W+IYR5LkQHSp+EDHDqae/WD4MpZ+4eZOY08VlA3R1GPOOc2+bWUmozKS2KAjflFTRvW8D532aTEH4OYysjWDd5t8429QKl5XPRZUlbPTkWWRWwnvzxs+GRDgrBZAmB+hp73EDEDrVhNYajX7b3FGnWYHLfLF/kW1AftFaDp88E7L+q7mrdkj7u4Uw/mc/aKBBQGiEPlI53CUNdV4VmX5jRttjDvR7YqztNtF3vq48wG5n6lUXT7xO2eK/ddIhPnn8L+SxA7oqeJPHfcG7Sl3e3TzMEpLfe1xjZE2K9rL6KCeiEYGNfI6OGI5WfjeVwgL/K8eSvUkuVbU3qHk6TERQOX0ZKda/AmzRj5v0N63gAdf4IgaJJEBwvqeZ3IbL+yFrlfPd66oHf8b3T0Jv3KDpBdIL+f1AtZcohLHRVAKOi0Ud0orsWIOY8XHOjKlnQHRG9E5ZUa8R06MHpF163Zon/LoJvJZAb2euBxVJihiOyh6sKu381Z3KMR8sQMql7AT2IPzyDqxAizoO45q64g0avJzXu+maDHIZ+M42RZ3HlpuvyVeQ7kwsGU06wLsqp93LyoDxJgT153pM2LjUJGBGlXk30okcNTkeRB0glo4SBkgG6nbcLYyO9hUlF3e4/SF2La+4tNm64LWElBCBgPdbSpY+gMDyfRXwuXi5l6BkHQ577MVQUplVfX9tvt4XEkEQ8E16y2SX/bzdDW+eq48mZ95TioyLvfaiE+ay8KHq6fGynhjm05Odub9o7Z/gAJrz4f0vbubfVQvyVkujrSijNQCFunj53uaR2bUiaMeB/Q2wkOiRidUtx2LKmKAKeA87ljO7pLgpz/JKMSAJ4Urqw8DAeRdSI5eTH/kQb5d/DUeyhmOdvEhoVp5TWNGl5cmpLHcPjRCK4VhuJfqm3Yf6URIrYiQHnAbDmLGzE7nAHSOnVEkc4GkbWeKgfDLZ3mSmSTXMlf17jMpzbzpKwkknsoVuX/5c4g0BFLUfQI4LPqrsznXqWCxcJoJPSgPAMvqv0W74dLHvi36QI5Q6EZJgv77cCH1W0axJrrzQs8jtK0RYhXZUe3ao6EKaGHJ0L9E2IF2fxY7tr+CpMWp+xNcTOf7DFbrvHBojm9aE9ZzxEUqnbUtg06cc6xYG8bdsi3FMR1EIuSLBdHKflYUMKCZf8hv68mKk/1QV7rj07AAGJWP1O0O9GFRjQnPfeLzbDL87yJbRUN94mCE5xGHODHwmC8NwSpnZq69yEd7lsOE5q3wPIXPDwHLPdtz+do/UHAcWAM1B+ZBQ4M2iSUvBJm99esk6Bs1Cg2aFWAECwexaBreZs6M+EqIZ22K6hwfGKAiR/l0661YiEKx0tnXh+NpFOE3z6OZ8iIc0lQm6QnazT8PnLjsoGSJkK3gdPhToiTichdLD2Wyq4mIsXE899/Z0t3rgnbAlG7uoXs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2025 19:24:25.1655 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79fb7930-f6ad-44f3-293e-08dd671ba8ee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD78.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8331 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 10A944000F X-Stat-Signature: ghii56rtfk4xj9qt4ry3bzmshrsoyot7 X-HE-Tag: 1742412268-16050 X-HE-Meta: U2FsdGVkX19dVrer1CLFpeVI49QvA0Cn4IiJ2DoN2GakESGwsqVUAXF06CelbmLqrKUTnN9xiPpzHovj3ZRJ2S0Ppq1DqwgjNuLoYnAYxRnyxPG80aO9baT2RC7oqAOy8YYMMzbCBex0Tsrdt+XQS0WclShBL6CSHPKUNNn1X0jkhIALAk1yoKB+k1z+buUTu6My5iLlqr5S7c7shzm6Pc6AMLFauUzjMQsfbXTbRWNdE5fbarqlt+TzHlM2MWaafwMCc0MBPMwaaLY8o9htdGWDR9r/+xHfPLVnX+bqiBKoISSbAno3nPNGh0x9SfUjPvB6hiWmyqkovYs31Zct8y0HD5KlRWBfBwcK4DpEViZ1pF+VTOqlZghx2lWNJwCgpE3BGWL46QZsLMkBmhk9fgYGLCtWDGSUuSnCLFKn3TA7ErC6e8JpFaC3PO0eyOOz8SBXBwyTOOjnL3gFBOgTpLDkO1pUmdG9stDg7KUWmBZRF5GPE/x0psjUYv6yZ796L+Bp7rDh3nMT8qNIyrOu784kGwuJLiOfloIiLRJxJ8KrzvwKqF9kA3lpFvQ9nV6at5H4tUjWw28aXliXFPNNJkVokwIIBmKP7Tjtq727lYIMBK84+iuL1HXkj7y3B+dxvTvwoOnOQ7rsbeKHMnI1tWjB3e4HkPrPSG8fa4EnLM66SI4uiN6Zk+JWpSd2Ybo7L9svLOCy4rCnsw4NIHSB2lPent/ErtnthCYrfGGA36XtLsQF74nSMfoyKTAlgJsjqx6KSuTyjT59F9zBfsFCFD/0qSS+ZQm3kgi68zJKEmVVg0TBnf7UJKhOSprVlDUfKit+F0W33XmTb0QR9TdHETw/hGlZkHJKlrUK49S26qvGt4DlfTqCnv6hza+8KLzymWaErSwuYt0Qqkue15kvVayuxKSgc8cov30Un067WHDoPJ2FaG78R8Es0tJv61imHwCYVgOXtcp2Zzmsm0a HRdOZoWp 6vx0Exh/8f6/Z5HR/X2iWVAtvSXosfpSIhawcmcnVS3Eyj7gWbCTCfb2LJDK+JbVUmttnraCXsYtm5iQ1mtA8I9dGEBy4Faay3VVp0L332rouIVo6pBLI4IJNvOtPiwl17mi+TTJwr1rpICqr172hzc42TeifEk3RqMkhRfofWHbaoP5CbttGFPmkgWnvc107KhOEpNG9HPpl2roagiZIRNYZyNY3h7Jz6qHhB5lw+MwP8lJJ4jUisM3dLazeqr0Lqyo4hN8Evd0BKSDHRbruq+f8GI0CWQAcJnVHcRQVQTG2y3YsTAEXifkg/YpbqAG6p03firRmYZ1oJGTygBSJO6v2uL7kVUnknLMXBAAqcxGNdWJ4j4Nz75dTmJGP61hKSPNImZO7ATx8k+lm0Q8v9jev2+k2+noU2DUkLqNMMrPpyeLBbIc2YP+m0LKtO20M1LvpTX1+qv68uypzMwAkfwzlwSdGTQSSbbBZq9VDhohzHFUnZoexBfeXnkZxwMOx4ZwGQns7xRVIblnzq0J70meXTHin9A1YUdp2RUcuCpo5UK4T/xSb8RNCRbiDJ28JjTE0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Select CPUs using sysfs For testing purpose only. Signed-off-by: Shivank Garg --- drivers/migoffcopy/mtcopy/copy_pages.c | 77 +++++++++++++++++++++++++- 1 file changed, 74 insertions(+), 3 deletions(-) diff --git a/drivers/migoffcopy/mtcopy/copy_pages.c b/drivers/migoffcopy/mtcopy/copy_pages.c index 4c9c7d90c9fd..5178e6846890 100644 --- a/drivers/migoffcopy/mtcopy/copy_pages.c +++ b/drivers/migoffcopy/mtcopy/copy_pages.c @@ -15,11 +15,37 @@ #include #include -#define MAX_NUM_COPY_THREADS 64 +#define MAX_NUM_COPY_THREADS 32 unsigned int limit_mt_num = 4; static int is_dispatching; +static int cpuselect = 0; + +// spread across die +static const int cpu_id_list_0[] = + {0, 8, 16, 24, + 32, 40, 48, 56, + 64, 72, 80, 88, + 96, 104, 112, 120, + 128, 136, 144, 152, + 160, 168, 176, 184, + 192, 200, 208, 216, + 224, 232, 240, 248}; + +// don't spread, fill the die +static const int cpu_id_list_1[] = + {0, 1, 2, 3, + 4, 5, 6, 7, + 8, 9, 10, 11, + 12, 13, 14, 15, + 16, 17, 18, 19, + 20, 21, 22, 23, + 24, 25, 26, 27, + 28, 29, 30, 31}; + +int cpu_id_list[32] = {0}; + static int copy_page_lists_mt(struct list_head *dst_folios, struct list_head *src_folios, int nr_items); static bool can_migrate_mt(struct folio *dst, struct folio *src); @@ -143,6 +169,40 @@ static ssize_t mt_threads_show(struct kobject *kobj, return sysfs_emit(buf, "%u\n", limit_mt_num); } +static ssize_t mt_cpuselect_set(struct kobject *kobj, struct kobj_attribute *attr, + const char *buf, size_t count) +{ + int ccode; + unsigned int cpuconfig; + + ccode = kstrtouint(buf, 0, &cpuconfig); + if (ccode) { + pr_debug("(%s:) error parsing input %s\n", __func__, buf); + return ccode; + } + mutex_lock(&migratecfg_mutex); + cpuselect = cpuconfig; + switch (cpuselect) { + case 1: + memcpy(cpu_id_list, cpu_id_list_1, MAX_NUM_COPY_THREADS*sizeof(int)); + break; + default: + memcpy(cpu_id_list, cpu_id_list_0, MAX_NUM_COPY_THREADS*sizeof(int)); + break; + } + + mutex_unlock(&migratecfg_mutex); + + return count; +} + + +static ssize_t mt_cpuselect_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%u\n", cpuselect); +} + static bool can_migrate_mt(struct folio *dst, struct folio *src) { return true; @@ -218,7 +278,7 @@ int copy_page_lists_mt(struct list_head *dst_folios, } for (cpu = 0; cpu < total_mt_num; ++cpu) - queue_work(system_unbound_wq, + queue_work_on(cpu_id_list[cpu], system_unbound_wq, (struct work_struct *)work_items[cpu]); } else { int num_xfer_per_thread = nr_items / total_mt_num; @@ -255,7 +315,7 @@ int copy_page_lists_mt(struct list_head *dst_folios, dst2 = list_next_entry(dst, lru); if (per_cpu_item_idx == work_items[cpu]->num_items) { - queue_work(system_unbound_wq, + queue_work_on(cpu_id_list[cpu], system_unbound_wq, (struct work_struct *)work_items[cpu]); per_cpu_item_idx = 0; cpu++; @@ -286,6 +346,8 @@ static struct kobj_attribute mt_offloading_attribute = __ATTR(offloading, 0664, mt_offloading_show, mt_offloading_set); static struct kobj_attribute mt_threads_attribute = __ATTR(threads, 0664, mt_threads_show, mt_threads_set); +static struct kobj_attribute mt_cpuselect_attribute = __ATTR(cpuselect, 0664, + mt_cpuselect_show, mt_cpuselect_set); static int __init cpu_mt_module_init(void) { @@ -303,10 +365,18 @@ static int __init cpu_mt_module_init(void) if (ret) goto out_threads; + ret = sysfs_create_file(mt_kobj_ref, &mt_cpuselect_attribute.attr); + if (ret) + goto out_cpuselect; + + memcpy(cpu_id_list, cpu_id_list_0, MAX_NUM_COPY_THREADS*sizeof(int)); + is_dispatching = 0; return 0; +out_cpuselect: + sysfs_remove_file(mt_kobj_ref, &mt_threads_attribute.attr); out_threads: sysfs_remove_file(mt_kobj_ref, &mt_offloading_attribute.attr); out_offloading: @@ -324,6 +394,7 @@ static void __exit cpu_mt_module_exit(void) } mutex_unlock(&migratecfg_mutex); + sysfs_remove_file(mt_kobj_ref, &mt_cpuselect_attribute.attr); sysfs_remove_file(mt_kobj_ref, &mt_threads_attribute.attr); sysfs_remove_file(mt_kobj_ref, &mt_offloading_attribute.attr); kobject_put(mt_kobj_ref);