From patchwork Tue Mar 25 12:16:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo Ren X-Patchwork-Id: 14028883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C55C36005 for ; Tue, 25 Mar 2025 12:26:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53887280030; Tue, 25 Mar 2025 08:26:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C1F728002F; Tue, 25 Mar 2025 08:26:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315CA280030; Tue, 25 Mar 2025 08:26:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F0E628002F for ; Tue, 25 Mar 2025 08:26:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87D55A33C7 for ; Tue, 25 Mar 2025 12:26:58 +0000 (UTC) X-FDA: 83259997716.03.981D930 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id 023D14000F for ; Tue, 25 Mar 2025 12:26:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PSXvc+q0; spf=pass (imf01.hostedemail.com: domain of guoren@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742905617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLd1OaU5U917FpUukOpF2pP27swWzmpEM3NVmJIPS/o=; b=BoiqGiO2L2EYohUpdY/Tt7PbhlHS4IHXlJvmE8HCv4FrGNULE3Z7/mfcFpJf4/T+SP/axj P/1OPE2pQAzNlnpEE9O+jazFRYo/EvMwWSVLcshY0e1S8iWaZEUanALgyui5081rDUard8 tM9bwzqK/UP1krtDG11DLeFkT58v1z4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742905617; a=rsa-sha256; cv=none; b=H7VdYO6V+ZK5nDMsBZZn6ruoPQlB1blBEE5h2kO/ZcIUZ2N5NKA0nzl6E5rwbHb27dERxv Pa2hHN0JGDrgVHQo+vOpJ4oThE3dDK2bxcb0VDXWeemyfYvENaxw3CgwXOKFGap6L7wWPp e5k3d52VJb2SPPip+K7VIq09Qu+ZaK4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PSXvc+q0; spf=pass (imf01.hostedemail.com: domain of guoren@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3B10A6159B; Tue, 25 Mar 2025 12:26:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AD52C4CEED; Tue, 25 Mar 2025 12:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742905616; bh=9rClAibepR5410hMymY5QyjFNfu9myyrJTkBJ7yJs84=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PSXvc+q07mYxURgabvhC0EDZ07GzmsdGsbFL99gOWwWn2P5z8FZ/BlJ02MvKw0oi0 DebZmNXKJ2CXOdMnsWEWR3OoVOJMtpx5upcoqoGzimuBC7isnkYS1TqP5L1E6cxZU6 4XrYv8tJiQ/yVO+KpHHDW9WJtvg1IAC6n5lPmXBEkrmtDpQIZKAsCw9ZnEWbQ7Gm8D EFr+OQdexB1ClgCWhZJhpf6cX91lUXmdACsoE7/AQufDa2ng7DPJR1k3C71ynpd+D/ KrFEXsFArC7JDeWksZBrKc+/l/OmyTWBnHSzZmaXAgyqRcEOww2gygQgud3qZdqgXr KuA9Abd2ez09A== From: guoren@kernel.org To: arnd@arndb.de, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, oleg@redhat.com, kees@kernel.org, tglx@linutronix.de, will@kernel.org, mark.rutland@arm.com, brauner@kernel.org, akpm@linux-foundation.org, rostedt@goodmis.org, edumazet@google.com, unicorn_wang@outlook.com, inochiama@outlook.com, gaohan@iscas.ac.cn, shihua@iscas.ac.cn, jiawei@iscas.ac.cn, wuwei2016@iscas.ac.cn, drew@pdp7.com, prabhakar.mahadev-lad.rj@bp.renesas.com, ctsai390@andestech.com, wefu@redhat.com, kuba@kernel.org, pabeni@redhat.com, josef@toxicpanda.com, dsterba@suse.com, mingo@redhat.com, peterz@infradead.org, boqun.feng@gmail.com, guoren@kernel.org, xiao.w.wang@intel.com, qingfang.deng@siflower.com.cn, leobras@redhat.com, jszhang@kernel.org, conor.dooley@microchip.com, samuel.holland@sifive.com, yongxuan.wang@sifive.com, luxu.kernel@bytedance.com, david@redhat.com, ruanjinjie@huawei.com, cuiyunhui@bytedance.com, wangkefeng.wang@huawei.com, qiaozhe@iscas.ac.cn Cc: ardb@kernel.org, ast@kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, maple-tree@lists.infradead.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-btrfs@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org Subject: [RFC PATCH V3 42/43] rv64ilp32_abi: memfd: Use vm_flag_t Date: Tue, 25 Mar 2025 08:16:23 -0400 Message-Id: <20250325121624.523258-43-guoren@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250325121624.523258-1-guoren@kernel.org> References: <20250325121624.523258-1-guoren@kernel.org> MIME-Version: 1.0 X-Stat-Signature: c3h8tbx45ag1puf9baufj66bq4un8xhd X-Rspam-User: X-Rspamd-Queue-Id: 023D14000F X-Rspamd-Server: rspam08 X-HE-Tag: 1742905616-979748 X-HE-Meta: U2FsdGVkX18FxaPtdNaQds3nFN5HxG9l0cLEBlLUp5RE+tPMzirjF/W540zCpzvwkxh1BWRkYee9edKWd6cmVhLxo8Dcn1SX5iZjkgL0UnghYhXWleNTP693fKPC6GGLPFtFWBDsQg7c1RuI68XpL7F6Oqa+9Y8NQo00IeB8aGfuXVwpO3PWoE2686+Lj2G46D55vpCN6N+uABa32SikYdO9OQ+A8U31uGXt36tDNr3hH9LGMSxll81ksnqphACwuqp4X3Y9WApoyPuRPiGCMXXt3+2AjGSDhypMuCCsHbxo44sW6HHUEuZW6Hns870M1V8DHklaBhWQbiQBCmnmqojrrLp2kjcwgClIZn2zuy0YCUXs9IBJzZw+FRqWGa1Tx5+8ZM8oBjbnKVrjHoS/+1nU9/YXv6FUr9RpHviPTntJyZL5DMeoShkOIllfqmIuPi7oUbT/mSCAEmdFawkAYuBmWkraMxFovhGpG3tMyP7rccVY3tGvObt9AzVD9reBjJx44BfnZpesxNtQeDTCrzyA0Ng2InzSTieBkzre1lXvZXjemznrVvsl647Gt96imZXcqHHNyN/ZJfmVMzTO7wo8ioP0Dz+ifDutetBQCQGVENYd8YcLqdot1wck3EfeAa3VTVf3Y25F1SWlcohLquXbPD/x68gsTBaSPxUTSsn7PWbJuyVAQTXKausaIwB90izBQ0OEKW6xuKzl+hofZS3E+fUV5Nt/m4dMWuTfZjJqtoC1QM+I/i1zfv/wgCT4Sx1+JzOev4Dt/VpZ1qORnfD10MUAhCg3EdsnW8O+YXQSruMAENdZ1fVjfsGNQzwX3sfh6ORD6hFzsfzxlP0zEgiqqZTPONVfqw3+AmHfSlmk2ibeRV3k1IdRxUxWIiP3ITJIKnOknO8L7yHuTk2RNKowCpEMkRgCVCVseWRrxnAlSxDVyjp58Kw5AYFzyOdaTX+gcufMfgLCGF7F5Ro ysrHZRNg M7ei+gIrCR+o+6pnD826hKrW761DqnVpVqg4YDZpjqvzRE4TIPaVFOY2B6IcpSxMTBK5ZcK3XcOehZfxZ5yKYo6ram8NPAALwnVvFypTilAyqWfJtGbJIE7fpxeIkpiCoO2cYyh0G+ToKWa1SmDJKJDVrJ9IiwEznzaPy4H7DoXvaOL/W9l3onc2xlCxi2zogWwcgUNw53T96N6DtqHf5GUcUZ3KiO2ekQtvxtKR8Yb7JG/F6KncmNxqeYFEv50z4mxb5/q5tlSJSLtWAlPR2AxhKtJMib9+BGB/5iTAzkLvfGdTOt6P9KXks4RQshQaABMGFOw7nAYrVFevOPw9UZTQx8h/Og6UZCzI+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Guo Ren (Alibaba DAMO Academy)" RV64ILP32 ABI linux kernel is based on CONFIG_64BIT, and uses unsigned long long as vm_flags_t. Using unsigned long would break rv64ilp32 abi. The definition of vm_flag_t exists, hence its usage is preferred even if it's not essential. Signed-off-by: Guo Ren (Alibaba DAMO Academy) --- include/linux/memfd.h | 4 ++-- mm/memfd.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/memfd.h b/include/linux/memfd.h index 246daadbfde8..6f606d9573c3 100644 --- a/include/linux/memfd.h +++ b/include/linux/memfd.h @@ -14,7 +14,7 @@ struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx); * We also update VMA flags if appropriate by manipulating the VMA flags pointed * to by vm_flags_ptr. */ -int memfd_check_seals_mmap(struct file *file, unsigned long *vm_flags_ptr); +int memfd_check_seals_mmap(struct file *file, vm_flags_t *vm_flags_ptr); #else static inline long memfd_fcntl(struct file *f, unsigned int c, unsigned int a) { @@ -25,7 +25,7 @@ static inline struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) return ERR_PTR(-EINVAL); } static inline int memfd_check_seals_mmap(struct file *file, - unsigned long *vm_flags_ptr) + vm_flags_t *vm_flags_ptr) { return 0; } diff --git a/mm/memfd.c b/mm/memfd.c index 37f7be57c2f5..50dad90ffedc 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -332,10 +332,10 @@ static inline bool is_write_sealed(unsigned int seals) return seals & (F_SEAL_WRITE | F_SEAL_FUTURE_WRITE); } -static int check_write_seal(unsigned long *vm_flags_ptr) +static int check_write_seal(vm_flags_t *vm_flags_ptr) { - unsigned long vm_flags = *vm_flags_ptr; - unsigned long mask = vm_flags & (VM_SHARED | VM_WRITE); + vm_flags_t vm_flags = *vm_flags_ptr; + vm_flags_t mask = vm_flags & (VM_SHARED | VM_WRITE); /* If a private matting then writability is irrelevant. */ if (!(mask & VM_SHARED)) @@ -357,7 +357,7 @@ static int check_write_seal(unsigned long *vm_flags_ptr) return 0; } -int memfd_check_seals_mmap(struct file *file, unsigned long *vm_flags_ptr) +int memfd_check_seals_mmap(struct file *file, vm_flags_t *vm_flags_ptr) { int err = 0; unsigned int *seals_ptr = memfd_file_seals_ptr(file);