From patchwork Tue Mar 25 12:15:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guo Ren X-Patchwork-Id: 14028521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7764C35FFC for ; Tue, 25 Mar 2025 12:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923EE280007; Tue, 25 Mar 2025 08:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AAE2280001; Tue, 25 Mar 2025 08:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C99280007; Tue, 25 Mar 2025 08:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 57884280001 for ; Tue, 25 Mar 2025 08:18:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BEA8112012D for ; Tue, 25 Mar 2025 12:18:04 +0000 (UTC) X-FDA: 83259975288.14.A1D36ED Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf26.hostedemail.com (Postfix) with ESMTP id F028C14000C for ; Tue, 25 Mar 2025 12:18:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mJnrUfpQ; spf=pass (imf26.hostedemail.com: domain of guoren@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742905083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L2Asy8qvLJOy+AEsxKaVqUJJA5O7QJCCP1QwCLyxZAI=; b=awegwREalnqKtXgUzUgWLMiXZIxK5cMmD7AFR7Lvfi8BcJqt44g0QMpkGjlZUQYtdgjVhR LudE0v9p8pbCDvWFi9ExHoBSqMx523zSQ1ujWneZ1yOASGA+4AkH3O2PEANdZrufEP3+Qs 3UE8U358eKIwqDBEfp0336jDnH3tMOM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mJnrUfpQ; spf=pass (imf26.hostedemail.com: domain of guoren@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=guoren@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742905083; a=rsa-sha256; cv=none; b=p8OCu9RZmBPLxjAvuxqTkQo522Gs7NLgCbmS6+0hZqmd3FtIi/LgOv9k0ZXo4qiFuzLDKA I3xwfukkMiMc1fTZUTvJyla7StMG5QD8mnmQL/f486qGiPRR7yDdZd+mN8mXPyEkwChk+G sVC0Rx3KbQ+kht0L4iLWi9ViFBodPRA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8CCB3434D7; Tue, 25 Mar 2025 12:18:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B2FDC4CEF0; Tue, 25 Mar 2025 12:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742905081; bh=iWYi5/d3lIOrxHNI1EIVP5k9hUi9+eK2hLYPYcT89jg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJnrUfpQU3tRiz/k25gw4Uqd12Aw8TcM6cjFO/pD8K+3ShkeSS04mnHDe7BpyS9ke O8z/kOa0aXdpl9GLvZpnTK+Xx+g5W6fJjabNS4JH2Wwvd5+2wgVNE54fuiymHoC1wG 50KxnfqoOdtuha4aPxrF6rszRIRlwHFNHlIfbWoUlSci7i3a1tzNjs60WJvLsFt2CL k4uREm/BjGR8keu0URF80UT0E0VmN+e0XoVL0J9C2x4l4RFyOLnqNqNi9ALPjHGSGJ JkfPLCYVJWSPzMY2y47OjruYC0XtjptJeJQjpc7rLp5TYbe0YDu+bublV7qn3GnUev yahK8zT/PrMfQ== From: guoren@kernel.org To: arnd@arndb.de, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, oleg@redhat.com, kees@kernel.org, tglx@linutronix.de, will@kernel.org, mark.rutland@arm.com, brauner@kernel.org, akpm@linux-foundation.org, rostedt@goodmis.org, edumazet@google.com, unicorn_wang@outlook.com, inochiama@outlook.com, gaohan@iscas.ac.cn, shihua@iscas.ac.cn, jiawei@iscas.ac.cn, wuwei2016@iscas.ac.cn, drew@pdp7.com, prabhakar.mahadev-lad.rj@bp.renesas.com, ctsai390@andestech.com, wefu@redhat.com, kuba@kernel.org, pabeni@redhat.com, josef@toxicpanda.com, dsterba@suse.com, mingo@redhat.com, peterz@infradead.org, boqun.feng@gmail.com, guoren@kernel.org, xiao.w.wang@intel.com, qingfang.deng@siflower.com.cn, leobras@redhat.com, jszhang@kernel.org, conor.dooley@microchip.com, samuel.holland@sifive.com, yongxuan.wang@sifive.com, luxu.kernel@bytedance.com, david@redhat.com, ruanjinjie@huawei.com, cuiyunhui@bytedance.com, wangkefeng.wang@huawei.com, qiaozhe@iscas.ac.cn Cc: ardb@kernel.org, ast@kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org, bpf@vger.kernel.org, linux-input@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, maple-tree@lists.infradead.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-btrfs@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org Subject: [RFC PATCH V3 05/43] rv64ilp32_abi: riscv: crc32: Utilize 64-bit width to improve the performance Date: Tue, 25 Mar 2025 08:15:46 -0400 Message-Id: <20250325121624.523258-6-guoren@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250325121624.523258-1-guoren@kernel.org> References: <20250325121624.523258-1-guoren@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: F028C14000C X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: xotqtyiasosssecsf4y1hcyoz1dpz6nd X-HE-Tag: 1742905082-520273 X-HE-Meta: U2FsdGVkX1/cTILQcv+LSQeQ4snrqq+udXdwSaw/dIeNwNgK5nm1bPkF2gX5TlDHRflVtAYbj8B2aSdv3FkxKfnJDlhqno/Fj/C2CLTLsnpwJSpBZ6EbPjBGudPcQKdVX/XSsgd3mdYwR5dno6DGshNn0BoNBho3FaUUXrooAa/NwxOIdcTsH86qby0ZrzGb5couSA4777wk5cdA/U9lekpNsauptykBXVE55F68n1II/sh/VnK5q/ZstohDVb+Qrp2E/ltGp13vg9FQvVlIjDWyq2/MUUSJPlHN3DR/QYMeH1tynWUV9cyZ0ayPmEZzI23RmeC5w7DNw4ZqjOFqMTGMp9eiqtvaAm2Js2TzLYVss398Jxl3l8OEvhIXuskJEFK4bJfgLEKqC1xOLhfDRxsxN0XHaKHEpUaZlI7v9mRZLuDiRKsQ5fx0NDF5Vp0sN996SRRlBVfXsYqlKeHl/351AWbpauSdV4LU5ObTZvpTwv+uRWe0uJox9szowL4Ubm+k+nIZQ0hLq6/schRe1vBsqSbsyRlimOZH9MpcTaiJe2oys5HE7o1vGqB0CId0I9KAP2OM79kdVPvQyUT49Bg1S5r0zysRedjfuF3YhUAUT846xqHYjBXlouNHuwiZjQN0hINrKc/d3yLj6eQ7d4QCAf0RDCBMj+brk5RALYGMrENLfypSCJA4XyDWF657IH55rJ40LLJhq0hc2qDl8YEjA4J0l4VyjCgl+5mdU8/BtgkJAVWhh7iI/j0X1Ef2vAW5Pv/li/Z3yoevzL7kc67DSvqxFLI2wyv4CfEYQtQFJ95H1rBe0MKN5IAcbxr90jD4PDAFz/etG/Cz2T74Uvo+kIrTmE7z/THF6wpRuzMpD7DjeXrlntR+MfS8X0FxOmB8TV1cWMTT6nfrcLg8a/ibhV9REstH8OVONGlMeJX4QE8io/YkBegcb2uRgn8LAnedfzbujtsvqBGtB82 X/ISQlzF ItHhvb5oj54819ZACT4LDpvfMWo9HznVQt/uwuqdnXQyhEb5GqE10GMRhqpjhoicbBplOg2Q66qamJXurdz0weh8hwbmUIcInCXTviYpJfQQymrratgDaQsbh+q8QSwNWTLHLIL/WLNELYNAindrWJpBpGmRSX9pwi7LdmAwHv7Sg2q3qqt9+9TH/Hs6uHabttnHaDq6Zw6h/6xHG6MxWh6eBNSLG9r+V9rUL1BQL6WECsDWv36wi2/mQGitNONNokBxJ0k1R1EvU8GF+jJIimufWPFU8eIfdx8ofeIBzFRXl6SOe3PJ/uyy7YAveotEidvTKwuE1oqkfgvonZrLi0smu64KMdfuBGQXL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Guo Ren (Alibaba DAMO Academy)" The RV64ILP32 ABI, derived from a 64-bit ISA, uses 32-bit BITS_PER_LONG. Therefore, crc32 algorithm could utilize 64-bit width to improve the performance. Signed-off-by: Guo Ren (Alibaba DAMO Academy) --- arch/riscv/lib/crc32-riscv.c | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/arch/riscv/lib/crc32-riscv.c b/arch/riscv/lib/crc32-riscv.c index 53d56ab422c7..68dfb0565696 100644 --- a/arch/riscv/lib/crc32-riscv.c +++ b/arch/riscv/lib/crc32-riscv.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -59,12 +60,12 @@ */ # define CRC32_POLY_QT_BE 0x04d101df481b4e5a -static inline u64 crc32_le_prep(u32 crc, unsigned long const *ptr) +static inline u64 crc32_le_prep(u32 crc, u64 const *ptr) { return (u64)crc ^ (__force u64)__cpu_to_le64(*ptr); } -static inline u32 crc32_le_zbc(unsigned long s, u32 poly, unsigned long poly_qt) +static inline u32 crc32_le_zbc(u64 s, u32 poly, u64 poly_qt) { u32 crc; @@ -85,7 +86,7 @@ static inline u32 crc32_le_zbc(unsigned long s, u32 poly, unsigned long poly_qt) return crc; } -static inline u64 crc32_be_prep(u32 crc, unsigned long const *ptr) +static inline u64 crc32_be_prep(u32 crc, u64 const *ptr) { return ((u64)crc << 32) ^ (__force u64)__cpu_to_be64(*ptr); } @@ -131,7 +132,7 @@ static inline u32 crc32_be_prep(u32 crc, unsigned long const *ptr) # error "Unexpected __riscv_xlen" #endif -static inline u32 crc32_be_zbc(unsigned long s) +static inline u32 crc32_be_zbc(xlen_t s) { u32 crc; @@ -156,16 +157,16 @@ typedef u32 (*fallback)(u32 crc, unsigned char const *p, size_t len); static inline u32 crc32_le_unaligned(u32 crc, unsigned char const *p, size_t len, u32 poly, - unsigned long poly_qt) + xlen_t poly_qt) { size_t bits = len * 8; - unsigned long s = 0; + xlen_t s = 0; u32 crc_low = 0; for (int i = 0; i < len; i++) - s = ((unsigned long)*p++ << (__riscv_xlen - 8)) | (s >> 8); + s = ((xlen_t)*p++ << (__riscv_xlen - 8)) | (s >> 8); - s ^= (unsigned long)crc << (__riscv_xlen - bits); + s ^= (xlen_t)crc << (__riscv_xlen - bits); if (__riscv_xlen == 32 || len < sizeof(u32)) crc_low = crc >> bits; @@ -177,12 +178,12 @@ static inline u32 crc32_le_unaligned(u32 crc, unsigned char const *p, static inline u32 __pure crc32_le_generic(u32 crc, unsigned char const *p, size_t len, u32 poly, - unsigned long poly_qt, + xlen_t poly_qt, fallback crc_fb) { size_t offset, head_len, tail_len; - unsigned long const *p_ul; - unsigned long s; + xlen_t const *p_ul; + xlen_t s; asm goto(ALTERNATIVE("j %l[legacy]", "nop", 0, RISCV_ISA_EXT_ZBC, 1) @@ -199,7 +200,7 @@ static inline u32 __pure crc32_le_generic(u32 crc, unsigned char const *p, tail_len = len & OFFSET_MASK; len = len >> STEP_ORDER; - p_ul = (unsigned long const *)p; + p_ul = (xlen_t const *)p; for (int i = 0; i < len; i++) { s = crc32_le_prep(crc, p_ul); @@ -236,7 +237,7 @@ static inline u32 crc32_be_unaligned(u32 crc, unsigned char const *p, size_t len) { size_t bits = len * 8; - unsigned long s = 0; + xlen_t s = 0; u32 crc_low = 0; s = 0; @@ -247,7 +248,7 @@ static inline u32 crc32_be_unaligned(u32 crc, unsigned char const *p, s ^= crc >> (32 - bits); crc_low = crc << bits; } else { - s ^= (unsigned long)crc << (bits - 32); + s ^= (xlen_t)crc << (bits - 32); } crc = crc32_be_zbc(s); @@ -259,8 +260,8 @@ static inline u32 crc32_be_unaligned(u32 crc, unsigned char const *p, u32 __pure crc32_be_arch(u32 crc, const u8 *p, size_t len) { size_t offset, head_len, tail_len; - unsigned long const *p_ul; - unsigned long s; + xlen_t const *p_ul; + xlen_t s; asm goto(ALTERNATIVE("j %l[legacy]", "nop", 0, RISCV_ISA_EXT_ZBC, 1) @@ -277,7 +278,7 @@ u32 __pure crc32_be_arch(u32 crc, const u8 *p, size_t len) tail_len = len & OFFSET_MASK; len = len >> STEP_ORDER; - p_ul = (unsigned long const *)p; + p_ul = (xlen_t const *)p; for (int i = 0; i < len; i++) { s = crc32_be_prep(crc, p_ul);