From patchwork Tue Mar 25 18:22:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malaya Kumar Rout X-Patchwork-Id: 14029350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90ADFC36008 for ; Tue, 25 Mar 2025 18:23:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AE7F28000F; Tue, 25 Mar 2025 14:23:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C90280005; Tue, 25 Mar 2025 14:23:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FCC028000F; Tue, 25 Mar 2025 14:23:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3EC97280005 for ; Tue, 25 Mar 2025 14:23:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C8AB6160CAD for ; Tue, 25 Mar 2025 18:23:47 +0000 (UTC) X-FDA: 83260896894.16.5525EC6 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf06.hostedemail.com (Postfix) with ESMTP id F083F180014 for ; Tue, 25 Mar 2025 18:23:45 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CojGvLNh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of malayarout91@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=malayarout91@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742927026; a=rsa-sha256; cv=none; b=Pl7uzwI9z7Gz9vyjEpNDy+P7IbAoUj2IFQTki5xYWyZ0M/KvTCOiJntyGS+ImqwgjOp8YG fcwbmRaQXiNJHvaykSAKhU2uVmE3d99sCq4H6RI7ea8D602OEU5DKE2cG4bP4Zcnt6MhlG 4bwd3hM69Hif7BOKx6ETqK2jkIL8Dtc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CojGvLNh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of malayarout91@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=malayarout91@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742927026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=9vCaqNT6Z4XukVuCat8lSt865NhuPSV6jdLTRDZQ+QQ=; b=4HFRi5ei6sQtC4CvOQ3mWb0/7tungrJjxlR+1o7qM83Io560vLVWSDGled/hhiQX1//wRY F6X0fLhq7VMxP1LU6F96le8whQG0UBjnm0Pp0lJ5zO3vz7LVLXyFvT9do/gbofiE2o6V1B pL4fFUczV4XtEhjte/xBDTiw67JKJyM= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3031354f134so6940159a91.3 for ; Tue, 25 Mar 2025 11:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742927025; x=1743531825; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9vCaqNT6Z4XukVuCat8lSt865NhuPSV6jdLTRDZQ+QQ=; b=CojGvLNhhUqjAtz6S3GAwxGsF0bJK2j68+NncHK/Mhaaquf9qyBDhv3DFnlTKZhf8y 5snCDZPc36NuZtQXgjz3y7YygaV3W2PCe7tHwZFHDiNI816ZqN9m7KqQ2c3Net4cs699 DbluvXmtOOnPyz9ePWRcXiHfbJ3ZPI+2cqXhdYXh6VUceZagzapI0f4C3f3xAPzQvcej kpj/N6sgTA/4R+gzIr7WBx8AvPRh96CocIEki3ZR4Kcq3JdyksEp1Y/Hh4PvwZt+o9r6 3BEPDXYwn+YVDyq0Q8SU4n6sizUoLBWMoJvjsnq2v/S65tujhMYcgmiJNj0pepze0b3D H3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742927025; x=1743531825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9vCaqNT6Z4XukVuCat8lSt865NhuPSV6jdLTRDZQ+QQ=; b=oSI9Lg9Wk7yg7qaX83UpU/Bw7TErG00V6vET+8h2nNUty2QIktrIq/PPTg3Bqt+WGL gmYOhtzRIezsNvdNkMFKAncuLqGCU/G43gvpIncuCBossASK+dBvSon1LuEiFcN7T+Ni a65j1020BLKuC1XgSSnNc+7UNSmM1yAujFWlfs7EedW5UNpl+imGhaQPfXS2rclHR5zF P2Sd1vw4DtdldmHRrirH7sfnNVNhdKMAvGUE0gvtYFPURzEM/GJ9YtzvTwfD6kToW30V ihBX99/ykZZGkPzndjw4dL2SmhxVxbPEMuW9DLg7ESRMWMqdWMRkDvISLRGAbZYgLCTg 4BGQ== X-Forwarded-Encrypted: i=1; AJvYcCUCZAHme8eFWnuxdKL0zfk8rTc9FISQfYYXGrob/dF6WxwtG+IvaBxrNOMJzl+GM3MUJG4E1g2whg==@kvack.org X-Gm-Message-State: AOJu0Yzxv78sCon1nmsY6weqW8cpWdGvKkCxXiw8XRr/2rRVO1rh7t1w em8NSA+0XSMQnq2cXN/wNFmfa/Q1H2znuXt6l2WcJItw+NrepXwG X-Gm-Gg: ASbGncv6YZ5e9q+TH3pZnqIrBnCHVBUZW05t7H9kHNLpL6lX3GGx5arxTu920uQoLXh HFgWihOEQjNRuCA53Y8X7/nKgbmYMJduIL+TxxdyKXdPzXwxO81nz4GH9RIgwLakGfNuAGmw2Ix 8ZA94amZvbIv93J2z07n6CbBMqB8reSL9tB2ANnSI8dUN06O3WtmfvOXmE+3bbFIK6hHmQv1C9S MMyZ+1dBLYbvzMfo66PJR9/Z5xb0ICR27UBDMSvhZChLUvUNz/l4QOOVViQWq4whoHwMguQJ5om bkbjXB4bM1lqBCj241/DJ6hqe3R/us1Ylq2JZeOMAwtoeJVLOkkoEJ0hcfdfmPqCY7KUzHEVlc7 kkSPS+LizuVkl4bOr3iRpGupBNyM= X-Google-Smtp-Source: AGHT+IEuRRdtDJ7J706QxzLdO+4/epryr3zMKq0ApySo1GrbkiLWxZVJJTSujlolia+qBaD3KpAWrg== X-Received: by 2002:a17:90b:3950:b0:2ee:cded:9ac7 with SMTP id 98e67ed59e1d1-3030fe988c3mr26901615a91.20.1742927024329; Tue, 25 Mar 2025 11:23:44 -0700 (PDT) Received: from malayaVM.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3030f7ea12bsm10646401a91.33.2025.03.25.11.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 11:23:43 -0700 (PDT) From: Malaya Kumar Rout To: malayarout91@gmail.com Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] selftests/mm/cow: fix minor memory leak in child_vmsplice_memcmp_fn() Date: Tue, 25 Mar 2025 23:52:55 +0530 Message-ID: <20250325182319.29352-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F083F180014 X-Stat-Signature: tmfr34s1hgfu74gk33uy1j8hp9baizs3 X-Rspam-User: X-HE-Tag: 1742927025-609300 X-HE-Meta: U2FsdGVkX1/anQbJaXIYWR1BdTgy6eSLtkb/H6HVpdkZG4qozFWDLE7BpDY0d5svp7vLwkOUcb0QsW8YE+NuzFANMuGvjbMPLhMydO98BjVg/DHrvt8DpTBsXo+baHmC1uPucKmOFN6e+wepavgbxyvs/wUmefQLfhUHHR38LmbNWKJhVToDZRtPlmaHBICpI1ChIqDjZJMiO8Q7omMc4QoulrjbZdnGGi5o2UT3BBC/UPdCzXssmT/oIWfe1xa6pPG683/rp6KyEtg4P7+xQXzFsEg/62zvhwp+oiJvs8Ms5ZCyfrSpSanhwcLNAuZVV4+MUn9rMF7ElnHRpLMI+tvG3m8uEGfrHjtI9Vk1xcUyS7ol0hIaA6zUJikTWAtEzSGNzFC14SthB9OTVb88dEnx2VududlijjMXMNAtvGHAZsBtw3m/yO+5nTQMwgWorjjtbm2OKwoWvscrR5v9H/uxfUyQ19/rydL13+qUDPM2RZP9gXqRzqMNz8xBxYA+iMh0T3OTh1Dflrb8S+XvutrA8n4z/U4WtE1I8+AebqXVqBzobBSnFAlsHt9OnV0drjTagGRIyq/HmvowNQwcD7FkGJSrMA9/HbvyhjH8QimVH1yWN/HciUTsj+kwkt9+eq1CyC/AarKeCh188aEdL0eniRJvwr8Wtx4nQOore/GKj8Lansg/Qbz1KF8Qr3uFi6TtYU8eO+o1ra5FcfF2tJd5CiZEwSeGgnf/gZhWSfDbHdES7O5RrSzkZkiA+zBINueeHIshLOoIfqiwlsb4j2zF/gcXkUf7KGHUjVY2dPXzzeLn05eh3CRVS49ysZ7oTxhxvkBcVRFWQMTENnpydPwkeBHLPwkPcg8aEUjLN8GL2kpUyBHeV/hBcAmNIopV188/FI04IcVDEWWmPjZ+sKVgs7S5H/qBoupSme8S9rWZY5BQ7z1Ud9Se4BpL1DrBWYjsSBv8tmVls84TM6Y lkxKx5Yu 4qZDFeql2hq5Ew0NkjySd1sB4d5cXRYSFst4G/dvOX999CQT+eaA0ucD4JfoK4ZECCj3ZnjVEiNyhzmc6ZSE/P5QdIeig3UXNpEZvNfLNI2IpZyJ/LCY/uiggygJ0vqSlWBdP+jPcTQlN0aVGlNxFMPu5zp8bT8ts0FlwWyfobUac1yD4/6d10aO5dagaRgGT8j88XnHbV5v25Raxt3Kp3v0I3YlTo1c1G9YDFiL3HW8kLTL7IHY9qBPV8ZcDBWK2oigcr+cllncgRQK91lzsoNzlenX1WbjKnrKXQR3xBNonYFha5Qc91Zr2BDNyHaQoujJtQ5N3RaJqOBbILjGXPPPiGl0PzC1lMFTfeXjHz/AwyBrVP8swH55wQTataNd11wXNUKGs2HU0GQ6Y33ovXNSSC4NQ0W1NlI42 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Static Analyis for cow.c: error Exception branch exits without releasing memory 'old' and 'new' fix the issue by releasing the allocated memory. Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/mm/cow.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c index 9446673645eb..fdee42850548 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -168,18 +168,18 @@ static int child_vmsplice_memcmp_fn(char *mem, size_t size, memcpy(old, mem, size); if (pipe(fds) < 0) - return -errno; + goto out; /* Trigger a read-only pin. */ transferred = vmsplice(fds[1], &iov, 1, 0); if (transferred < 0) - return -errno; + goto out; if (transferred == 0) return -EINVAL; /* Unmap it from our page tables. */ if (munmap(mem, size) < 0) - return -errno; + goto out; /* Wait until the parent modified it. */ write(comm_pipes->child_ready[1], "0", 1); @@ -190,10 +190,15 @@ static int child_vmsplice_memcmp_fn(char *mem, size_t size, for (total = 0; total < transferred; total += cur) { cur = read(fds[0], new + total, transferred - total); if (cur < 0) - return -errno; + goto out; } return memcmp(old, new, transferred); + +out: + free(old); + free(new); + return -errno; } typedef int (*child_fn)(char *mem, size_t size, struct comm_pipes *comm_pipes);