From patchwork Wed Mar 26 08:18:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 14029863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E54AC36008 for ; Wed, 26 Mar 2025 08:19:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66DAC280064; Wed, 26 Mar 2025 04:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F22B280056; Wed, 26 Mar 2025 04:19:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44597280064; Wed, 26 Mar 2025 04:19:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1B7BF280056 for ; Wed, 26 Mar 2025 04:19:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7CB5016196F for ; Wed, 26 Mar 2025 08:19:05 +0000 (UTC) X-FDA: 83263001850.26.0C4D2E6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 3191FC000D for ; Wed, 26 Mar 2025 08:19:03 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pk2Em1ci; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742977143; a=rsa-sha256; cv=none; b=7IpwczxP1EUlb1DSoHzfRW5bpY/OeZc7C+sSSVs6P4sqFCdqDdngFOJ89+aznAH6AVufWB lbkIx/8GAsCKhip4Ysh6j8+r+UzeCd+lW/azDPqzAKv7QPmllSxihvDYTLke8hJ2TpiawW H4rGIbAdBNUp+5GX0NoPD5az9Abr7NE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pk2Em1ci; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742977143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pOTdxZD/uqiBEKSTfpgx9RU52PQylymJns53moyygZc=; b=TFd4ebOqwv6pkSegZrspSe2ybE/SNM9oGeUo1v5BPI2oKUzr+NiQdD2lRjVX4v9XHdnnKz LBKkyXCSoMfsNqCKwpgL0DtwY8LAoo9XlZJQs1rhTtTDBnJmdcQzVTLgGuDeftAzI60b/x aWiuMnuWobXknml+vXdr+YN8M2+PYeQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742977142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pOTdxZD/uqiBEKSTfpgx9RU52PQylymJns53moyygZc=; b=Pk2Em1cimMDkpGzjnLgEyQZDBsJf3peZ7Pmz6ojyoQaTVrNtHK/qzN1FOI160jEmK/rOqD j1RV/+vF7Jjbdn2Vf2n2s2UPGCWKtX4FaAmCkg18v83YqasSPCaAZr7148bwKcsSmeDYmw vL1Xvz31nzufmKubMY84vQ91SYArrqo= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-2gTLhc-tO2S4uLR93kP9jg-1; Wed, 26 Mar 2025 04:18:59 -0400 X-MC-Unique: 2gTLhc-tO2S4uLR93kP9jg-1 X-Mimecast-MFC-AGG-ID: 2gTLhc-tO2S4uLR93kP9jg_1742977138 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5e6c14c0a95so4858949a12.0 for ; Wed, 26 Mar 2025 01:18:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742977138; x=1743581938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pOTdxZD/uqiBEKSTfpgx9RU52PQylymJns53moyygZc=; b=P2j3UuBdky27TP3BuOjGP9uU17qa8JFfTUcN53mb9Zmt9AwB9+btAX2+AAGZQ/hRbe SpiXAGNZVDWxVR0SVKM6UsyVFKrcZ3aZIhaDCBsRgrVLUz+8/fuF1po8jTY0BrMIbTny ZlCV+sOtVpE2+wweRFIq4sspw5PTtwwfgHKn8fLTTfytN4RpNjs20wC2Kg3MKH3VD8HK 9P5dYevgBwVum9mN3JA/l0Mp5FBaBvO8AxB64kqTLouarnTUMTUOTtU/Z67ILu+W0Qwa KsiQNRZtbweBhfmpXuR55fpYin5UbZLK4ki4bP3lLDouTeGlTnjJ97Vsr2RQ+kcxfuPz HULA== X-Forwarded-Encrypted: i=1; AJvYcCWowG2U7DO7ohMNPBnT9DK4qYyARUI56IYU1SBF/sO+8saudpNvA0a4W34kFKRj/6dn32soUcpJlg==@kvack.org X-Gm-Message-State: AOJu0Yye+JZHn/Nry2AXqNCoQqCRDvJQTHQ+KdrXQf/3WgtC7IvaJZjD GLNfYNFbKWS7EOfuJ/JbfA2fpSlnpQjIadhPiZ9lgpLNJmUea2KXfivNjQR7eNKgtJgQQ5Q1zIz FGYMrrxhO+sFw073q4Y6DgucF+1htexWBQn2IPazPSeiGPXDF X-Gm-Gg: ASbGncvMBw8Nr7WbaD5NejfgH7XVba96uo0bQD4DPJW06bkTOu5fmhuGzvrZ9a5D+KU q8Rdj/IJtXGKrms9NVkR7pZSDLTWS4PZI8P7pgkID2uQsgWUpfPF8AJLx63EFIbd/p1e6jTFN5t VXoRY27Hlvh67nngiDSXO4jGGEzm3fCLbq4X8Vwr0OjXpEEZ7PmOoRTh1zxRkQRd5ccTVD7V6kj sXNNtSIfRZMhxYiJ1kdMCmW6/1r8zbOhzwZvSnypntTQ/nPAi4z5PsLoqNvP4sQjp/oHMoeWhji DtuqTVE5w7n4jh1jo5sAToXkH9U5jVCRsIBCggTQ X-Received: by 2002:a05:6402:2345:b0:5ed:1909:d422 with SMTP id 4fb4d7f45d1cf-5ed1909d5d6mr4532643a12.2.1742977137790; Wed, 26 Mar 2025 01:18:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbdeo79z8qV2b7AKSc5yQktiHryMqsZHBcfBd1BlUWJgmAJ39Ce+nU2q92PUFekHQpyPfq7Q== X-Received: by 2002:a05:6402:2345:b0:5ed:1909:d422 with SMTP id 4fb4d7f45d1cf-5ed1909d5d6mr4532610a12.2.1742977137314; Wed, 26 Mar 2025 01:18:57 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebccfae189sm8870097a12.37.2025.03.26.01.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 01:18:56 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 5291A18FC9CE; Wed, 26 Mar 2025 09:18:54 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Date: Wed, 26 Mar 2025 09:18:39 +0100 Subject: [PATCH net-next v3 2/3] page_pool: Turn dma_sync into a full-width bool field MIME-Version: 1.0 Message-Id: <20250326-page-pool-track-dma-v3-2-8e464016e0ac@redhat.com> References: <20250326-page-pool-track-dma-v3-0-8e464016e0ac@redhat.com> In-Reply-To: <20250326-page-pool-track-dma-v3-0-8e464016e0ac@redhat.com> To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: su-YSxIbKat03HG0nn_T3T1RlZ_GTIhQzunZF_et21o_1742977138 X-Mimecast-Originator: redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3191FC000D X-Stat-Signature: 9epn81xyef94ri3s9ogjnrdfrqzrr91u X-Rspam-User: X-HE-Tag: 1742977143-389096 X-HE-Meta: U2FsdGVkX18V6PH7tkhRtuIM8htFj/SXQ58XrlZJG3nuCyHcf2Gn3YykA6H9w8oMT6EWD2cqty9Aekge+udraOlMAPhutO0wU7cEeULfMucFO265moRJEHTbmYnYUEnDrtc2juvTVpErRzm9Bjm2yJ9h/M2OUMX9XtMr+Pcsl8PkvYA8hPWYDsOqVOo3MBtnveI35yQkpid7H/D4vBjF87PX8vsUedQayp++GD6UH1jDgkZInklyj2vJuJqSFf6+4oCMLf6uyggfh7hiEtppA5Cv5gz8ou68gEdJz1dVReEq0ZkKEWIgRUtGQKRL9Ia9JBr5QBAOw3mT2W6gHvu5p2l6ezbygbISvE065mF0td/PLfDSW/pDGzB3oeR4oTTnRiU728SB89Jud+j6nAX67zYhtSlUdnn6qyH+vinkrIif4bOJsvdR5XZxxZxF4chH7scz6ypYEBl/gxxI8c65yh4CDgqHMlNXr2C47j6ngka44EC94mOUGHt2rRzU/aZ+ZCW7hokzALtNGejLdX83Z6Paakd+/ae/clbDS0ppOwF2NJu+d4rsEYdTvNRd/eX8q149c2ScRSd2nhOr1V0GguN/d9MpU47mLjFKIpfzT/otw4N1w1JwhB2aRlVQErIbCzZ5wpIHjxwFLW46Q3uUtpvZ0UUgOYyWJfCS8I+JSnPeQO/F0EfeT2vjO/kE3thzpoPA1G21yZeutdFqNhxe8bXnUlJvkk/BPe1pJjrewk94Kl34MnNQYEST1uBy9fu2WoJd67pCXW76fe7SXKeMfb3xJVW/koCJ5LRte3Hj50hmiE67NlW/Vzej/05BAbcwtJWJp4yebEnGL6jUIh0eryx7Su+4OQ659LHfNeXC1sNoOHDU22xWxHv5HhocGAtZRMLBdx6hXLQ7oaFSUSGC1gnqmeDR7bM56mzgW4GWBoYZzRoNbk8mk7xx2KVG4WyDMD80gh/7CSTZwEWfDbu ind2zWlv xT+F9LKsIsxAhcrK4Q6MGJdGOMVM6wO103LmsEg/hPCPZmpZ9imlc/y25uyFsQvj867dw/hMlScH0G6qndYFbz8CPwbeEjEKR9XzXYdl88eM3uMUd3mTk6iXYWmN7UtK53LnlrU2FwOISk2ioNr+U4jhoyFjGsJtuDyLsI8MuqheTgpy5NJhlZlmJJr7lZb3nmgxx9Fc6VN/2lSfUscbCpA9nAh7+fPSsBMCpNt2ME5YsA33V/lOGHlAVfZ7XXqtfuQ30IH9t3yHq+gS6SsjHwDx2Hq/xaGTeFgxEl0t4qX3FNNnBe6/duUOTLpXHTfLuEPWQTLK3Lnvy+XSWIQFXamKeRyv1Oes/jQ9mSUSr/+1yudv4sO30gtSBIvRJZkk1dZ02pNatwGkrHe4SFCuhFq5wEcwgDhf+DzdBbPK1GHAWaFA8CrYTHxAW9YBLx3r/3iVi8SnXnaDFLqr8p8GaLE8x6jCkvtuuiHEsxrfhUNBC1HFynZ4EVuZU2MsqiFsD8moGxN7JPHwFBgFEZUHhhDas6bvwb2kO7J5o24iIzJVcoRcl9o83KTdjB2rww++5VnfBXeoz8wXYuAJgpTy2q6BH5D7dzzC+rh+yoS+A+ZKH+iElLn6nazjRdH9YNXAsSrMvadxqnVdJdMg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Change the single-bit boolean for dma_sync into a full-width bool, so we can read it as volatile with READ_ONCE(). A subsequent patch will add writing with WRITE_ONCE() on teardown. Reviewed-by: Mina Almasry Tested-by: Yonglong Liu Signed-off-by: Toke Høiland-Jørgensen Acked-by: Jesper Dangaard Brouer --- include/net/page_pool/types.h | 6 +++--- net/core/page_pool.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h index df0d3c1608929605224feb26173135ff37951ef8..d6c93150384fbc4579bb0d0afb357ebb26c564a3 100644 --- a/include/net/page_pool/types.h +++ b/include/net/page_pool/types.h @@ -173,10 +173,10 @@ struct page_pool { int cpuid; u32 pages_state_hold_cnt; - bool has_init_callback:1; /* slow::init_callback is set */ + bool dma_sync; /* Perform DMA sync for device */ + bool dma_sync_for_cpu:1; /* Perform DMA sync for cpu */ bool dma_map:1; /* Perform DMA mapping */ - bool dma_sync:1; /* Perform DMA sync for device */ - bool dma_sync_for_cpu:1; /* Perform DMA sync for cpu */ + bool has_init_callback:1; /* slow::init_callback is set */ #ifdef CONFIG_PAGE_POOL_STATS bool system:1; /* This is a global percpu pool */ #endif diff --git a/net/core/page_pool.c b/net/core/page_pool.c index acef1fcd8ddcfd1853a6f2055c1f1820ab248e8d..fb32768a97765aacc7f1103bfee38000c988b0de 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -466,7 +466,7 @@ page_pool_dma_sync_for_device(const struct page_pool *pool, netmem_ref netmem, u32 dma_sync_size) { - if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) + if (READ_ONCE(pool->dma_sync) && dma_dev_need_sync(pool->p.dev)) __page_pool_dma_sync_for_device(pool, netmem, dma_sync_size); }