From patchwork Wed Mar 26 01:24:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14029668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17999C36005 for ; Wed, 26 Mar 2025 01:25:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D873E28004F; Tue, 25 Mar 2025 21:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D382A280048; Tue, 25 Mar 2025 21:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C262428004F; Tue, 25 Mar 2025 21:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A4B74280048 for ; Tue, 25 Mar 2025 21:25:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EFEF01414F6 for ; Wed, 26 Mar 2025 01:25:12 +0000 (UTC) X-FDA: 83261958864.17.1E341F6 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 44472140003 for ; Wed, 26 Mar 2025 01:25:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O4CKZNso; spf=pass (imf23.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742952311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=T6GKle7+93Rexc24wMdk57QxfcApkMBPUwEhlyUOIQA=; b=0s2FELMa4X4wB0NoD8cfQxJsSg4QvKPNSuAQqGjubtxMbAbqA3Uk+GhWa0MnTfNuPsIu8V G8owzSPkGcmZMwqY9Lsl67LNIWQs1FKbQTemk1cuZHiaVUs0KFqgDDW1qj2eidCYxoBKy+ yQRPi5iDzkokI2xOEufqB1zFdxEd8z8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=O4CKZNso; spf=pass (imf23.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742952311; a=rsa-sha256; cv=none; b=RiOSI8Ayx0EOuBfaylSIDQh+xxhvmHbKEeTzORarawFVW9EmkWA3eozoMKN/jyvKZcOM0i x+9BTd5EtlgZPPYzTMSGKl2NT6vJc1Fn81Gp3LWQjxTWqA8ErH6wbsARaOXH3AkHjz2UO6 EQEipzVzthy48OrdXoqA26vH4Dn3Q90= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742952309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T6GKle7+93Rexc24wMdk57QxfcApkMBPUwEhlyUOIQA=; b=O4CKZNsoRjPFpJ9iUX0D77KR/YbD2iznc1Hzq0nhFsiJ3SqWyh47DtnalnueJEvB3nfN66 +ImI/dNFPNC492w0c57lJaBLIj80jNwA70jPCG+C4q7f+P8TraQJlubRZol2QN2JnVCmEQ 1lhIEbTr0z7mETqRJik29mnVenoi6AA= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, Ye Liu Subject: [PATCH v3] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report Date: Wed, 26 Mar 2025 09:24:34 +0800 Message-Id: <20250326012434.918844-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 44472140003 X-Stat-Signature: sr1t583akqd6snxnwfzgju4mzaqc1chc X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742952311-664476 X-HE-Meta: U2FsdGVkX19dSXGmhgzaQhT1+eHPatyLigWRsy5tOhVvw1zWU9FxwJWmTqJiGHnF8GdJyHl1fg9Tvl/QJsZiIfDcRXG1bNT3isdTcbEGf2uHswKd+1xtuMZyxwchgagwTtiiM5lNNeypZnu7S4XHUO5MRgF4QVqkJc54soNez9kU8ShSophBsmjBJSyzgT3+kCF0RKdIHatjyr3cO7I6N+ulYPJ+S6Ygl5p4SyOJEpfraVSWqLQBywG2n4boNRq4USGGkVXVZaQvDyYBGFtKJSnbfQAiuxPeij/iCvMqk8eyF1aO4tK8tYq87HwOfhRqxey/TmqCH92s9HUSpRmB4erThCJFI/3Lngmc6DHhzj4Be+siJ/R5CIPo8YxvCTHtDhqcXmTY3MvoFUbj7QM8HxbytIyx3VbdVjCENdgj0uL8+u7Gs0Zy9J4RJTeoVWqKCdrmFXVjSAYCLWEeDAfOlvhwE8OsEEmfhbADoWysHk2c1C4gnS8xUTWn9UmrMARa63O5JEqLPRS1KOCO9PrtbfepR8KVL8yYfSPXvHt0XMg4E86tFlXUBcfI0mxPAUFOAjMdlSIl4x1LyeN3bVf8s1Nu7FfV9pyv2+VrYv90iiMWScpfgpgkfgKj5gedevArMbucIVRUNUI2YePxq1IKMxdFl9swupTF+XyhwGSR+aL5eQOV5kTKdGbI74eUiGPaqHToOpRVMrAghVtLmkCgGo2bMJ5E03g1PanuBw55eS4e7G35hXiYyl32xTYwSS25+kgZhdnh+5tI7bkwnbeThEWlGNoTwlUvG+5xE5JuXarJXTeOOLirHrQhFvLOExQMOFxinEpOBQelnrUXl7ANb90DYrzKrKpbYG4Abm048SIWqQ/lMyo0fSPXXIDSTAzt/NBr1kiFL2Dj4As9gFtqwCxHfMHo12zr3p0OObAc4/lSn1z5dFhtsXvn9ZTfG2eNF+rYzwK2rr7GE065w1q 4widYXs/ TcFL7XL41U6iQQ/OlV93uLZI82CGyc0b60mBAwSZMwFwEFDGJnLsZ58rJ06aXiAaf+QLPZ5kRf1Col2WjTh1gD2lns0YDYNmdPLsR9mAPG7f97LsaS+MfQdFLnPR/+cWKgnN2x+oJ8k4k9PbAMm7HZhYr6OntwyRb+oWlHU092EYGNaudTqsHUh4sjd2F5yKvFQqa6DqY7oH7GEtM4bxyXUiYJICuTSoK+gYmI4fG9JW5/trvWXbbAgBfkQfJR7sqFtHfKVNfAV7CFFyB8fMjONNIDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu Refactors the free_page_is_bad function by directly calling bad_page() instead of using the intermediary function free_page_is_bad_report(). The removal of free_page_is_bad_report() reduces unnecessary indirection, making the code cleaner and easier to read. The functionality remains the same, as free_page_is_bad_report() was merely a wrapper for the bad_page() call. The patch also improves maintainability by reducing the function call depth. Signed-off-by: Ye Liu Reviewed-by: Anshuman Khandual Reviewed-by: Oscar Salvador --- V3: Delete 'This patch'. V2: Simplify the code by removing unnecessary line breaks. --- --- mm/page_alloc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 61d6a3b1b286..60c54ba78a11 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -933,19 +933,13 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) return bad_reason; } -static void free_page_is_bad_report(struct page *page) -{ - bad_page(page, - page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); -} - static inline bool free_page_is_bad(struct page *page) { if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE))) return false; /* Something has gone sideways, find it */ - free_page_is_bad_report(page); + bad_page(page, page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); return true; }