From patchwork Fri Mar 28 22:00:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddarth G X-Patchwork-Id: 14032475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C40C28B20 for ; Fri, 28 Mar 2025 22:01:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF6F128016A; Fri, 28 Mar 2025 18:01:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA730280165; Fri, 28 Mar 2025 18:01:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 921CF28016A; Fri, 28 Mar 2025 18:01:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6630E280165 for ; Fri, 28 Mar 2025 18:01:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 040A756621 for ; Fri, 28 Mar 2025 22:01:46 +0000 (UTC) X-FDA: 83272332654.27.2D7757B Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf13.hostedemail.com (Postfix) with ESMTP id 1759D20006 for ; Fri, 28 Mar 2025 22:01:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RrJbNghM; spf=pass (imf13.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743199305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=/IVrZIj5NwvolOp7P5/XK/Tk+P2OhfakRiW9sxSIYFs=; b=DFb1GszYQftLBgUE/7QRaVqhQmvYi5dSRrS07bchTAouuaZZYhOzr/hGvsqTTIsOWh5dft 44XX3K5c9DTRxXAtVdVxg5K6YQbmPziwGaXRxnYqYqLy/7afuuo3dEGoUYeorwgJzN/T4O G3nPM7L/BUARgDbY5wtNrlRdesXdaGw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RrJbNghM; spf=pass (imf13.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743199305; a=rsa-sha256; cv=none; b=nOjlCIaLI7fDE82LAHH73uCEESTdeODqfteGgJQvkvKNoo3OdEY93awdlKQlIY6nlLrkU1 BM/rB7Sif5CiwdCUd7xnokPLypQ/u9flzaBrFtL4aFUL3s8elj/+cjmPwh7j/9YmxCeZ5C ZSZow9p4uzSdcfSnHZP0bDqs0J60R6M= Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-227aaa82fafso56925485ad.2 for ; Fri, 28 Mar 2025 15:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743199303; x=1743804103; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/IVrZIj5NwvolOp7P5/XK/Tk+P2OhfakRiW9sxSIYFs=; b=RrJbNghM6DH14t5LNj1aRNJNOC1vkV75+WVnNG2/qg7JKPaPUNYrwvPfoGQdoJDY8h wYDDoU1vKGwIqgDKKYfLDC+jiLDfdrCmjXZQJBvUodfIh+xn+9/IPdADGmxvv4tgpv7b xav2iqtetr2+JnV/IlsRUHits9nEmc8tSwZ8lO4HUI3Fhm4vPi6Hy3VkPgEulzhjb9ex GXtlOr9B7qJ9hGD0W7zztvwu+K6WsKy/1RSDOUVY3+oDWg7kkPBZFe8brTkjdEBAJnCF rGlG3BhirBpAnnB54p22o9O2HqzJUfSFAUkVVv0RCLJVmILXEgxG1UVtvY2t1ZuLQFle fUGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743199303; x=1743804103; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/IVrZIj5NwvolOp7P5/XK/Tk+P2OhfakRiW9sxSIYFs=; b=rD/rACrGmK53d06Sjc2/2Dt9y2423tasmUE/0W8GHBNFQFWaA+UzfeGrWEA0VBVLQ9 Y+QaT70BNsFK+AGJxFLWl6OF6lBxhH4UswDjEqOua3EvZrYY/0/TNH2zXyM/Zj29dYDU tdfwgUPuxJ0/VKefDb2Vp0RUrhATkk5622CC0yPcQ1AXArVgl9Tt9VmVfz61h9YOR/yi sac0pbETaQs3V5ve+7fjhgJaofcsBhAegXjlYNGEfy5m9SX/AKaCgueTVW7NzOlcCAiT ITCj68u26LDrWGKW3jL/kVpHbRV4i12zxMW8rDNs7jZAGiFiFH2opAuXD3//2WDQOwMO fFxQ== X-Forwarded-Encrypted: i=1; AJvYcCW+0mm3AZKGFnNRYd0qM79okUsWrvtH9kOemGPRr8m652eisBxrZrtcI8er7SRtY3ueBVZdc8rmwQ==@kvack.org X-Gm-Message-State: AOJu0YxQAZoSeotR0GiKY0dvfalNb8eaQ/oyxsiZjWq9UG8L4obNbPsn vEtllojtLYmJ9E5Nd7ymt4OMK5U8inF/p7szGlOArSoe/LEk1HHp3E/XjZWT X-Gm-Gg: ASbGnctzxSin9IupwYzX7hWWr72UD1ZyOYytmuuAmZ36GbygwIYTAUozvkRDUlh5YvQ 3HnCWdgBJ6fpS90C3mQdInH931GR1BCmUiCldmTx6udafOcbk9KiU8eL3D6x/48VFC7Up5JjOiQ vWqkzmneT8NH2UV4Ese3rTP0EWBP7gS1qdXKrlOCx2YYytyj9z+q9cdiSWSc716DMXDcGTk+J/f 39zsLGrBKdWLdx0Qc7BlQiILybuk9HYtW0L9OtkVrc4R1s3BY9NnInTKPf8OSWK3L735GHPP2Y9 dWyYbQS3pShRny/cWRwdpBuTejQ1KTQNR2NLKYmC7uPxbH04gYxB+CEwDsuDxwqG X-Google-Smtp-Source: AGHT+IGJyrofPtYjcdwJFJMViyQI/JadXUdxW2feSLnMyP0HVI8yOQ2zIl58vUTrfxBzH7KUhYJ53Q== X-Received: by 2002:a05:6a00:1784:b0:736:8c0f:7758 with SMTP id d2e1a72fcca58-7398038028cmr1140094b3a.10.1743199303271; Fri, 28 Mar 2025 15:01:43 -0700 (PDT) Received: from sid-Inspiron-15-3525.. ([106.222.231.129]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739710d4761sm2318154b3a.167.2025.03.28.15.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 15:01:42 -0700 (PDT) From: Siddarth G To: shuah@kernel.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Siddarth G , David Binderman Subject: [PATCH] selftests/mm: Fix loss of information warnings Date: Sat, 29 Mar 2025 03:30:37 +0530 Message-ID: <20250328220037.149763-1-siddarthsgml@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 1759D20006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zqkx6f1etzmkmc9h78jgy68md73x14ym X-HE-Tag: 1743199304-764090 X-HE-Meta: U2FsdGVkX1+HuKD8yZZu+WPA6AXTXwzYy4iD3VmqNcAIV08/3BxjYjzzXnRQOfHv3Hsc4NqOX12xCBg7hK4Q/9rbIHi2siCxQ9DUZnoaOr+Fai1pkbCa4wq5tkWm483YXbUCywk2UaXysOkvQbqR2Br6RriEBCK/lBl5ThIVrZrN8o4ylPeZLWWLfBeO344CEYOCJ6f6jtCvk7Fxxn3c2FAAghL5PnELIE8TWkWhJKAy6odhId6xUQDlhnEFp/Se9LHCQKz+sJ9AyIH/HHDglA8hc3Np/gFUK3wdCs0YdFg5daSPxTDlWAh/JghBeWBs6rVkQFtOZeB/VQBVsczAycYvD43huY54+V7bJcs+UJcDiC+wMTrLxkbh7j8atQvNykeuiclcWz6t6xFOb/L6AcdS8wmWY1A6HYsYBBlQJ1/KeuvDfD8qB/P8Be1Lr08W1KaTSLOPlnvRtXbAvPWtdtHzt9NQFK2rD4rfkDwWzZkhpDhPX7fEJau9audX9xFVK9tiUPGnjWUdo4rz2RMcnqrES2yuySZI5nrgxqITWcLLjtxkP52doSZJCnQ+P9R1xnYsZ84b9VbsU2gmAqjk2tgTwjXmWuPwIAKvKVzRonlRse5K8mtlvdVv8eoaAbphnYiHsF+lGotaKpDj6a52s9XToms5bkDIfobseOB7y/eYEfhfCBjSzmBSqoXQYAMm9afogdiklw/A/hfsL3hqr2RiRkyQGxhxOIWC1aSnLOSYxM6hT+9rTBoEP0FLUqJ7SeBIgTgLk4XapEFLPmu02+grYXCR9fmfk3Melbp0Uyk9KNIg2vG+9ByuCZxKDx9VG4Izkztr6fEJ8EHy50X2BKvlp8OuZRQgTAX2u6uNzZNFmP+cuHgu3y94SURrF5bjhE/bMGUycTpdhU49xUX3smFMcOzC2eMSjN4r3/5hld7F+K+tmmHBE7I3rxD7PDHHtYQLQMirKK85qWRyvbq ZdT0pD2X HqT+DjDI7UYPW64vwc4kWRh43llhDs2P0v8FMYdyOoZJ0BZ8B0u0iTEvW8bdbluArhDBaatVdsVru2UY9WhZHrJcguxNQpRx/KlkuJmgK8W8haWGomvxfuN9RslhcwQ1jV006O9GrZ2bb2yQFEfQXF2WJS45fc522SUGn3fESFBQK3pejHrk3t47j37B/dZHjn5ouY7FhpCDKAz38BW8r7k5a4MSPS67KjCC7KRQwHE5UtS1ea0hXY4yzuqGIyrvwYL9ML/GklETItNQWQbBM8OxzCLmwIbluDmMpby2BDqaYJRh3X9SxX8w6h0AFiVY3xrz0YlqvfyyUPlDzXg7AJQ/3yvVJFnJ0areSfqHlWqNwhXgxOW3SIUMw2JCWdeC+mSTQzN1vcPiU99oVKaM1/q89Sb7ewIbWCf2qs4F/llc3rHvLIhCfETqEUgSbbdE+NnJoQ1oUBpG93g5ksIbcfRii/0c5els42pBNElUnfsKOiCYF7RKq0iGZl5kst8cykVpWm+FObmJnNtWWRJMNniQWzpQS41YONmmkkImTzrvscx4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cppcheck reported a style warning: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. Changing the type of page_size from 'unsigned int' to 'unsigned long long' was considered. But that might cause new conversion issues in other parts of the code where calculations involving 'page_size' are assigned to int variables. So we approach by appending ULL suffixes Reported-by: David Binderman Closes: https://lore.kernel.org/all/AS8PR02MB10217315060BBFDB21F19643E9CA62@AS8PR02MB10217.eurprd02.prod.outlook.com/ Signed-off-by: Siddarth G --- tools/testing/selftests/mm/pagemap_ioctl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c index 57b4bba2b45f..f3b12402ca89 100644 --- a/tools/testing/selftests/mm/pagemap_ioctl.c +++ b/tools/testing/selftests/mm/pagemap_ioctl.c @@ -244,7 +244,7 @@ int sanity_tests_sd(void) long walk_end; vec_size = num_pages/2; - mem_size = num_pages * page_size; + mem_size = num_pages * (long long)page_size; vec = malloc(sizeof(struct page_region) * vec_size); if (!vec) @@ -432,7 +432,7 @@ int sanity_tests_sd(void) free(vec2); /* 8. Smaller vec */ - mem_size = 1050 * page_size; + mem_size = 1050ULL * page_size; vec_size = mem_size/(page_size*2); vec = malloc(sizeof(struct page_region) * vec_size); @@ -487,7 +487,7 @@ int sanity_tests_sd(void) total_pages = 0; /* 9. Smaller vec */ - mem_size = 10000 * page_size; + mem_size = 10000ULL * page_size; vec_size = 50; vec = malloc(sizeof(struct page_region) * vec_size); @@ -1058,7 +1058,7 @@ int sanity_tests(void) char *tmp_buf; /* 1. wrong operation */ - mem_size = 10 * page_size; + mem_size = 10ULL * page_size; vec_size = mem_size / page_size; vec = malloc(sizeof(struct page_region) * vec_size); @@ -1507,7 +1507,7 @@ int main(int __attribute__((unused)) argc, char *argv[]) sanity_tests_sd(); /* 2. Normal page testing */ - mem_size = 10 * page_size; + mem_size = 10ULL * page_size; mem = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0); if (mem == MAP_FAILED) ksft_exit_fail_msg("error nomem\n"); @@ -1520,7 +1520,7 @@ int main(int __attribute__((unused)) argc, char *argv[]) munmap(mem, mem_size); /* 3. Large page testing */ - mem_size = 512 * 10 * page_size; + mem_size = 512ULL * 10 * page_size; mem = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0); if (mem == MAP_FAILED) ksft_exit_fail_msg("error nomem\n");