From patchwork Wed Apr 2 20:18:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 14036433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44786C36018 for ; Wed, 2 Apr 2025 20:19:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8539280005; Wed, 2 Apr 2025 16:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97BC280003; Wed, 2 Apr 2025 16:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9724C280005; Wed, 2 Apr 2025 16:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6E8F2280003 for ; Wed, 2 Apr 2025 16:18:59 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E7F5C075B for ; Wed, 2 Apr 2025 20:18:59 +0000 (UTC) X-FDA: 83290217598.28.6DDA642 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf23.hostedemail.com (Postfix) with ESMTP id 9935E140010 for ; Wed, 2 Apr 2025 20:18:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=gtFyQjWR; spf=none (imf23.hostedemail.com: domain of BATV+e93bdb537aa03e43b1bc+7892+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+e93bdb537aa03e43b1bc+7892+infradead.org+dwmw2@desiato.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743625137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FBnAFdxWx0BAktV4ZqJguBsjZizAzyvP0/mFoBjOOso=; b=ZSamBmN+ol79TosgAJ2l3XKVMe7pQcvjSBAcUnKJOFx6dTks4dW4k6sZosJKTYXaDMw+KF SODOBO1rqqsAupTdk4DtOwmZqC//EODG6y7yR9QhaiwZBukYkWL4sWy3uWt3OroCpksnMm vIlQmDQ1NZfCUeE/llSmQPofGmUP6Ow= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=gtFyQjWR; spf=none (imf23.hostedemail.com: domain of BATV+e93bdb537aa03e43b1bc+7892+infradead.org+dwmw2@desiato.srs.infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=BATV+e93bdb537aa03e43b1bc+7892+infradead.org+dwmw2@desiato.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743625137; a=rsa-sha256; cv=none; b=WVvfXW5S4Y8cqYnIGaUEeV6KM5VfegB0Ya5aGM2a6le8MWPXRN1ioSWWrovSRg+uFolGv3 cbd6Jkv/YGq44rM6+cdKX166oANl91Tm6lK4jakyOU1lCTtV5MIL8CC85Ie7RRTllYECZN rgo8yZCIosIDBAc8JjKTim2ht4wVPU0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description; bh=FBnAFdxWx0BAktV4ZqJguBsjZizAzyvP0/mFoBjOOso=; b=gtFyQjWRzw0RQoEIZ/eyYEm3uN GjONx8SwV6r+jxzwlr2NKI/vfHrTv3UTFeYMbcN7UJszuGE+oPUFapQDyf/WBNSv5Jgo6OUkXoMD8 5JkbvROq4TNwqh8IcUpqW/IkdSTQP+VYW44V3dz6q+F3gK0jtySUlCsoFS/n6C+DagNTn8PM0BPx+ 4oTiaiJP9QiVRwRe5h6Cy9JAqJoFK5XqWkK+Bx5RAvRjzrt/A/gklDZe9OTZ+WY/GjcBlz5iVMeO8 cLptprHxCVTOjPMFKnCHOPGFPWzsjXwHVSbk4URxlJKdxfR6luVVw3hM8TFvPEqLdjKawD/D9BVTT ZxOHhw5g==; Received: from [2001:8b0:10b:1::ebe] (helo=i7.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.98.1 #2 (Red Hat Linux)) id 1u04Xr-0000000759m-0Rof; Wed, 02 Apr 2025 20:18:43 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u04Xp-0000000DcH1-2TfR; Wed, 02 Apr 2025 21:18:41 +0100 From: David Woodhouse To: Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 1/3] mm: Introduce for_each_valid_pfn() and use it from reserve_bootmem_region() Date: Wed, 2 Apr 2025 21:18:39 +0100 Message-ID: <20250402201841.3245371-1-dwmw2@infradead.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by desiato.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9935E140010 X-Stat-Signature: miroo5jpqwdue34xfipgihwcwcjp9xqc X-HE-Tag: 1743625137-383515 X-HE-Meta: U2FsdGVkX1/pKOvgFCuVzmUsDYpHa5QJ6GaVQuLSsOia2t42LvXAPTrQRe/A+11vZ/c1gEgrBhg3a2nE9m5wQYyoupWsyyQJJ45x41BUifFQRGm3fMRz9AIyDTHnC5Y4GU+ArP/04LmuZYSooEXLafh3/Zdx5JTyz4MWbq49cQac1x0P2K+CTTodL0O7N9xzdTFREqGCuy89szXkpqg1U6B2/OLnPVj5bixkMo9ezyP37nCmKdJ7Jak3Tbw7eF6Zp+Ga6kshy1H9vhFbRkdZa4hk6D/b/Sfvu0tYzX2DVZYZMutFk0wChYPn5mLxiZV6kj84zoje9wHd3bNXsGGpx6D6Nms92MWSCm0NTwL0FW1St3mTxXPm3UBFT8bxWEK3yX9D4zwe1LFTIqX2gM0u8mmaO7b1f8c7aSUcTWLBYY9HMrX266p+e5WDIuomJ4/y4WsFulOkAU7Nta2AWqPawXLCXVq7GimsX0lDjvN3p3jhZj4dZZLwJKsHyz5bJWRGpAtbPBgmOvyiBaquSXv8d4Z1dUt9lgpxD60mE+59qmoewt6bmURIV1cKoDlNSuPG+WA8soqGac0Vx4Kzi0nTck8M+zC4zk/HTIinTUdQZrvYe5UnHYQhJF0LW1Z5/ilMAzqFjvS1Os4ZiMRp+kZxtt0EoUgYhef8EsjiMpZnQ94OScVBGWcBVOYXDrJ+056II3dtug3BuqS7LKJx/+Yk0zIw4dVMf1hAG5NyM5xMmwz+BVhV5ZbEqIDHMjVJftA8Tn6QW3mu7LbF2bH8cOwjy3eL/UAh9xyPNX4eHOLa9j7VwPC2bNFJiBrjOPvpVzqUSAjyuaSQ6XbtyvYM+pRYImvfoILID7lQZKUQ3eCY5zyTvVzP3cxx2MmafOloNcHIGwFoWwe006NZShN9Vf61JgQqaa1C4IOPcVaga6Xxl0CGRKEtnvHBeJwK4drWG4BRcRXkneT6GvX4PM/+zI1 3dJ4GGUM FPq9ZQR9PQQSWLxSNMlBhJBSeF1pLoBQUU6crtVdBRKpTmOhj3Djg40mAEWp0mdvEP5fJ2uSH0a2QkBocYpSeU9QBUwBbTjd8ruH5L1hfyXoj2oevO7V8UptocjDZZW86UJLzZNgCFSp1MMVH/mGo+8rT7+TnBELfjCU8l9jdKC1zOwIwiTINGc5IFqA2ciLeDg6RikokDATjvOhKS0Zw6UzgWW5v5Bs/49YpTe2mC8seQty5sGgGe2qRVtmk8KltDTdEePyJtK71GHx8KB1Pfag/YyM5D0ijJGhduz3KAmI+WEho7KuwHE0Xkou8sgHDqOzdz/0K28KaM2EgDWaqykiOT5FkUYKetsThZKa+8VdWo++4Je9Ituon7SSdMrrCJAQqgZm1JbbecrXsbmdc1w5nTL2alnOztW0/gsYheyoUIY4pE95pL0nK/zo6LqNsaUik94+qM5O4nkkZDmiTnbDb92n2/Zlu6KO0InYXLWaCWVUEgCMiM1RMz2Ic/vlNT+45JxrFkclcHcCeRTA+cL8CvmQZ4vbZsMpANpXm9uFGATcoMvFqc5gsc4liJMLgBX9LATPw1LehJfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Woodhouse Especially since commit 9092d4f7a1f8 ("memblock: update initialization of reserved pages"), the reserve_bootmem_region() function can spend a significant amount of time iterating over every 4KiB PFN in a range, calling pfn_valid() on each one, and ultimately doing absolutely nothing. On a platform used for virtualization, with large NOMAP regions that eventually get used for guest RAM, this leads to a significant increase in steal time experienced during kexec for a live update. Introduce for_each_valid_pfn() and use it from reserve_bootmem_region(). This implementation is precisely the same naïve loop that the function used to have, but subsequent commits will provide optimised versions for FLATMEM and SPARSEMEM, and this version will remain for those architectures which provide their own pfn_valid() implementation, until/unless they also provide a matching for_each_valid_pfn(). Signed-off-by: David Woodhouse Reviewed-by: Mike Rapoport (Microsoft) --- include/linux/mmzone.h | 10 ++++++++++ mm/mm_init.c | 23 ++++++++++------------- 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 25e80b2ca7f4..32ecb5cadbaf 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -2176,6 +2176,16 @@ void sparse_init(void); #define subsection_map_init(_pfn, _nr_pages) do {} while (0) #endif /* CONFIG_SPARSEMEM */ +/* + * Fallback case for when the architecture provides its own pfn_valid() but + * not a corresponding for_each_valid_pfn(). + */ +#ifndef for_each_valid_pfn +#define for_each_valid_pfn(_pfn, _start_pfn, _end_pfn) \ + for ((_pfn) = (_start_pfn); (_pfn) < (_end_pfn); (_pfn)++) \ + if (pfn_valid(_pfn)) +#endif + #endif /* !__GENERATING_BOUNDS.H */ #endif /* !__ASSEMBLY__ */ #endif /* _LINUX_MMZONE_H */ diff --git a/mm/mm_init.c b/mm/mm_init.c index a38a1909b407..7c699bad42ad 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -777,22 +777,19 @@ static inline void init_deferred_page(unsigned long pfn, int nid) void __meminit reserve_bootmem_region(phys_addr_t start, phys_addr_t end, int nid) { - unsigned long start_pfn = PFN_DOWN(start); - unsigned long end_pfn = PFN_UP(end); + unsigned long pfn; - for (; start_pfn < end_pfn; start_pfn++) { - if (pfn_valid(start_pfn)) { - struct page *page = pfn_to_page(start_pfn); + for_each_valid_pfn (pfn, PFN_DOWN(start), PFN_UP(end)) { + struct page *page = pfn_to_page(pfn); - init_deferred_page(start_pfn, nid); + init_deferred_page(pfn, nid); - /* - * no need for atomic set_bit because the struct - * page is not visible yet so nobody should - * access it yet. - */ - __SetPageReserved(page); - } + /* + * no need for atomic set_bit because the struct + * page is not visible yet so nobody should + * access it yet. + */ + __SetPageReserved(page); } }