From patchwork Thu Apr 3 10:13:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddarth G X-Patchwork-Id: 14036758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54ACC3600C for ; Thu, 3 Apr 2025 10:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61F94280003; Thu, 3 Apr 2025 06:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58087280001; Thu, 3 Apr 2025 06:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA00280003; Thu, 3 Apr 2025 06:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1E7CB280001 for ; Thu, 3 Apr 2025 06:14:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 552F41201AD for ; Thu, 3 Apr 2025 10:14:02 +0000 (UTC) X-FDA: 83292321924.18.FA7466A Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf24.hostedemail.com (Postfix) with ESMTP id 89B21180003 for ; Thu, 3 Apr 2025 10:14:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WkFLF7kX; spf=pass (imf24.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743675240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=i1jcYIDsgwV0QbwwcIaFrUZpYunSVhU3f2VZkEk3KyA=; b=CKJj7V8nEi/wgrTYUhAE6+moFV0Y+FxitackkcJeWFds7NuTOZZX5FXaBkrFKpy7EsXEa2 djBPNvZoimQB7G4A70trlIuvrCKPMLQDZjltB7JdY5XhFs72FzqLVFKKOqYRPmXDO0kJ4i qklZYTZUz6RLRFPOeV2EoZNW3UPTfq8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WkFLF7kX; spf=pass (imf24.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743675240; a=rsa-sha256; cv=none; b=q1AdrTUk33Y1Z+jt6V5awij/ScgNfNdM73y5sqbt/H9CvGxYhWr0hhUFNq1a3lE4tnD38A JoIpVZlc6UvIfwDeNZe9+KMiOneVkjedq8r/bGd8KWhdq3quNaf9AJJDwvbY/T92zGPCWI HRhTIKzuCR3Zb8siy9QMrBqP7FBPKKY= Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-224171d6826so9353165ad.3 for ; Thu, 03 Apr 2025 03:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743675239; x=1744280039; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i1jcYIDsgwV0QbwwcIaFrUZpYunSVhU3f2VZkEk3KyA=; b=WkFLF7kXCKsbkh2wEIKBUFCFHlWNtlAK3y82hFDG7fAudE8VsxkM0bQfYyyHtO4n7y isBuxtJz5KyaqkrjZHwkcG92LoFnlAQYqohouDx7KwY3SjUI7cypmjoGdWFDtBb9WUdh rcpEr82AkRQId9o9SrSjbz/T911pO280RuQyhOPXs9pC2DR8DHf7PmvV2U/xvB/Eg9BQ lrG410E7QaWUcoeg++p/Yr6pA6Wu3T4530ntqLcQLhLPEQurTd9k+lkKd6/QXoQuFiaC BINKuONdHH9aQdtjflyb5jk/mjVNMA8tDpVy1+un9je4VxkuN8OnXCZl80ztZjCINqet vkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743675239; x=1744280039; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i1jcYIDsgwV0QbwwcIaFrUZpYunSVhU3f2VZkEk3KyA=; b=Bt6GDNictg2vawsAhGM7hoA9MLhwgSYAqxXxivfrQMxZG91WBj4yR/L7kRITAdHkG0 J0drBhqKO2wWhPJcXWrXJ35BB+SF1Uv6GyG7fRq2IenhACEkxnMpVFCWgeRrZEkvaRfV mdQKnt8BbVO8j/d1qlJANk/efb8TxvjhxcZro3oDg8xGJqoVI5papeotbtOq0MNrCTgS mtlzed6bpoJS4i0QuW4g95zbSzPfpRwNC6ysETAM+2kjJm8fNkamotE1VhBu0846YLJN p4T+gs870NbtXl39fVTaQVqD7E3UwIWjJVcL1HEEtcMdOPw0fqCjpYPVAATWF8ZP/jdj 0XOQ== X-Forwarded-Encrypted: i=1; AJvYcCVS9lFuTCvvs8tR1sXEmuimDLkn+MN/uXx4cgYXceP+p4DfzQfGAhvAZEsY5sFjEBiKW4SASUdEzQ==@kvack.org X-Gm-Message-State: AOJu0Yx7lBmq3G0IPx13JR20RfBC5RZdWVeC4GpnL42qb6CIcG1NdWTo zWxJDW7xccMLko76XizgnHHG6lUMTWAH55MVStGY7z0KbBfOb0s1HSrMgFyy X-Gm-Gg: ASbGnctKeZiP22ZbZLpkyf5m3Bc1nQI/NLkhP3lrYtuQW6FZUvQSIi5ZweFe0oQEUac ZOoPE7GFNGvyjTwKQjD6tGBfvEdTcA45hbjX5vP+TXnt/0YMdjs2OALz+czKIChkltaVQxZKM7E pTxfTV2/x2QBkYzttpia9k1k662kFRlLQMxFkzw31V/w4gMDpGo4Boc082Yz9iu9ywePdItvfRv ejhqZRRWV2ilCdf9x8kdZhVsZTFw2zVo0ohoSJjUCpSJdMJ/w2jNQ9AsPPPv/UC/kcJ71J69OEI fJowyZJ+MFANY+lM67+HQVPk48YCR7ptaRg5c264ekt9HTpbjKF83ykQrLpRQ5Vag+I= X-Google-Smtp-Source: AGHT+IHBEgySem7ZYEyvmalH7tBoil+1mmF1NNG09oSI2oZk3fzOSaRWrhjHXMxCEepBrEitJNny1g== X-Received: by 2002:a17:902:ebc3:b0:224:1579:5e91 with SMTP id d9443c01a7336-22977dfe34dmr28809205ad.47.1743675239264; Thu, 03 Apr 2025 03:13:59 -0700 (PDT) Received: from sid-Inspiron-15-3525.. ([2401:4900:5084:2815:d682:e65a:7ee2:33e1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30562c6d29dsm2773042a91.2.2025.04.03.03.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 03:13:58 -0700 (PDT) From: Siddarth G To: shuah@kernel.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Siddarth G , David Binderman Subject: [PATCH v3] selftests/mm: Convert page_size to unsigned long Date: Thu, 3 Apr 2025 15:43:45 +0530 Message-ID: <20250403101345.29226-1-siddarthsgml@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 89B21180003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: woigqmrkw911hueoazauajkgcc84s4jp X-HE-Tag: 1743675240-66723 X-HE-Meta: U2FsdGVkX1/rxjMB3/FnP9+8x99FKja/tXXyvESrJ1+8h7WR/rgM3omW0Fpr8NIz27en5SbJLi6KO7m5Z5pCNmKUE3S1KK8UFnatYIfoaWo0d/C3ZcnthtDkvxWLYinz6J7VxoGUWzs1gfMrkTQqPxAjFPWLNLrXqFILFPZndXPdOi4VUaGsOTzOKxeamVh+rFbLL6RTQHk2OOe4jxmCANSFL3ayZ0tPINurwgVpLm09ZDIjBWRm05xKRJ3kDY6FLePAtczlqH1MSYEAbvZqZ/DrAD7Nz3GvPaLMfWWA3T1vfQCuvGg3sa2XkbLQY6vVfHEdUZ3QgVaCaLqLxEs29C1pX1QghGKOTo1xyO8adY8fIwVfCp6C4EBtj+ZvgBGHVfjawz2etPlTRAYSk8vChcTpdtqBpATnxmBw/80CBIkfwwAkQUMN9zeeE/W//v8LMFyWbwT+rnW2bAwLiC748VGQjMzhtN7id3vOR1lOQGHz/Rd1t9jmzc/fnJI6rDFM3Sq6UlXqfZWmzT6VyqWvNN/m9kaGXg4FaizA5eCSSVrzd+6RBHB97zcB9+Yi4Qwsy5VMoMe7zF/74tFZYoVGAYv197O1HxiDwx6JVRndHvX+cGRZ1eAw3HqTQ4ixR7HKCkxihhGieYKJBBY30kdBwCG8G7l8x/zajgRfmsaJ9+WhR2fUdml+kHxDqShBKMvaBB5IlVN7o8rSpjU9483KufcdyEB8UFGmir9ut52/s0INa1cqWxQKypk16qUcnPSRyvIcxaWk97cjGpED/X/BdX6o8qUqYNW+65Fyn5hMRySNpB4du2mjYzIsIplT9bejOY/2pTyCnzTuSgM9cyZ9MXcTx3QNdugOcpRF2OI8l0IlLfn2DSuC+hy0awyxjUgfe9JvwZzmAwtF/BgUNvguJ69M2kGEK4EULu+tn+hdIoU+09RU4Ku+3Updud7CmcADLeX0ZgFKDapQ9yvd3jS +RUU8+AU lZNygQadFy1YwROXlZhlcsHiJpaETmWusCSRKc4Lt55eeYMnpLPOycOeVV0+3fsrdUPCisOSKaWztX9Jfg+/CT8aqXnbL5UtyjuM5oCwejDJEsgJ+06vxW63QQXEr8XdSSXHkT8h4wFSBaK91NiuMb63sNcHpf3IoCFUIofTO5Nk5PdQVrABjWCpEVdXbqVdJlZUN+pGteALPvi6RtRwBk638wo1uIrbWi6tHJEmlPDp0xoGR1QtoMIUNoNwygineZ5Y16dXer6EYnSu4dOqwmxIIe+NeHCD82QdyZOvJY77OMTKWZ5PGbuJNkAAgTNTG6hiOTfKb0Jmc38ELfS6+/Rd8t5PpMoV9yS8Fb2+5P8mbvb//Lc94xliopt/VG21bpNWpUzWkO4lpAA5sOdw6YwD+crWsJFGlYn+G9S1JjKzV0lEfpfLusCKdf7d1l6sG9P+SKxauqYtAGafzBHkCvY5tyNY51aoZ3SVDa+GSU+Ajyhb8DUoMWC2ywaZ+LYR6LT0P7y9eRJo7H5Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cppcheck warning: int result is assigned to long long variable. If the variable is long long to avoid loss of information, then you have loss of information. This patch changes the type of page_size from 'unsigned int' to 'unsigned long' instead of using ULL suffixes. Changing hpage_size to 'unsigned long' was considered, but since gethugepage() expects an int, this change was avoided. Reported-by: David Binderman Closes: https://lore.kernel.org/all/AS8PR02MB10217315060BBFDB21F19643E9CA62@AS8PR02MB10217.eurprd02.prod.outlook.com/ Signed-off-by: Siddarth G --- Changes since v2: - v2 had conflict with current mainline, so this is a fresh patch tools/testing/selftests/mm/pagemap_ioctl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c index 57b4bba2b45f..fe5ae8b25ff6 100644 --- a/tools/testing/selftests/mm/pagemap_ioctl.c +++ b/tools/testing/selftests/mm/pagemap_ioctl.c @@ -34,7 +34,7 @@ #define PAGEMAP "/proc/self/pagemap" int pagemap_fd; int uffd; -unsigned int page_size; +unsigned long page_size; unsigned int hpage_size; const char *progname; @@ -184,7 +184,7 @@ void *gethugetlb_mem(int size, int *shmid) int userfaultfd_tests(void) { - int mem_size, vec_size, written, num_pages = 16; + long mem_size, vec_size, written, num_pages = 16; char *mem, *vec; mem_size = num_pages * page_size; @@ -213,7 +213,7 @@ int userfaultfd_tests(void) written = pagemap_ioctl(mem, mem_size, vec, 1, PM_SCAN_WP_MATCHING | PM_SCAN_CHECK_WPASYNC, vec_size - 2, PAGE_IS_WRITTEN, 0, 0, PAGE_IS_WRITTEN); if (written < 0) - ksft_exit_fail_msg("error %d %d %s\n", written, errno, strerror(errno)); + ksft_exit_fail_msg("error %ld %d %s\n", written, errno, strerror(errno)); ksft_test_result(written == 0, "%s all new pages must not be written (dirty)\n", __func__); @@ -995,7 +995,7 @@ int unmapped_region_tests(void) { void *start = (void *)0x10000000; int written, len = 0x00040000; - int vec_size = len / page_size; + long vec_size = len / page_size; struct page_region *vec = malloc(sizeof(struct page_region) * vec_size); /* 1. Get written pages */ @@ -1051,7 +1051,7 @@ static void test_simple(void) int sanity_tests(void) { unsigned long long mem_size, vec_size; - int ret, fd, i, buf_size; + long ret, fd, i, buf_size; struct page_region *vec; char *mem, *fmem; struct stat sbuf; @@ -1160,7 +1160,7 @@ int sanity_tests(void) ret = stat(progname, &sbuf); if (ret < 0) - ksft_exit_fail_msg("error %d %d %s\n", ret, errno, strerror(errno)); + ksft_exit_fail_msg("error %ld %d %s\n", ret, errno, strerror(errno)); fmem = mmap(NULL, sbuf.st_size, PROT_READ, MAP_PRIVATE, fd, 0); if (fmem == MAP_FAILED)