From patchwork Thu Apr 10 00:00:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14045658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6514C369A2 for ; Thu, 10 Apr 2025 00:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F7186B015D; Wed, 9 Apr 2025 20:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5782F6B015F; Wed, 9 Apr 2025 20:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37DDD6B0161; Wed, 9 Apr 2025 20:00:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1982D6B015D for ; Wed, 9 Apr 2025 20:00:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D6A6712162A for ; Thu, 10 Apr 2025 00:00:48 +0000 (UTC) X-FDA: 83316178176.08.FFB9763 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 1F042180016 for ; Thu, 10 Apr 2025 00:00:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XVCCyujV; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744243247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o7zBYRfvkjUIg32avt0DAwnMUG4oJBLUKAxDAS4YKLw=; b=PtmqUYUEkosaC/xxfWvFauf0h/jS0yPYPe+rSRbMzfID2MEDvJn4Ho5Ok1n6ZC4sU8cGwV lbvhfiJlW3UIbPOXYjsyUzIX+HZEvQNXYzjteapVX2M/wPimoSOrUaVLU4mR5bRiSNcBaI 7UqllsNBqPiurAylW/hsruL6WpoJYsU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XVCCyujV; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744243247; a=rsa-sha256; cv=none; b=aFCNjfLOPyRlJjZfohG8S6Tsy35rVfgFqCaPSesOTm8+t5JPU+ThS6eYSDwDKoomcqTRTg EJrDfb+sZxWlg9O6sTxp/v5lIpCHUuymKDainjvgjprw411Aw5gy6wpUY1GPMAhl89u0PQ xMOeispJCNxfMzyVLysR+aRNzWdj3D4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CAD0E5C4AE7; Wed, 9 Apr 2025 23:58:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D9BEC4CEE2; Thu, 10 Apr 2025 00:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744243245; bh=dkT2xHQjKC605c81qGII2JAGaeNQ/xG5ym+UekI2lR8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XVCCyujVyhZO/6pZC6zQJ8ACzYqibNmVtsKHhsxECVQir4MCa5NxyDzEA3buXH9sq T1bxafDXAjcsepzIcZ5rk4/LbsMa/E9DQ2fOgJ4iU5Lwu1Ju6gO/IObVbOqj9My6ij GCgWZiNBm7zdRH2YMCUB1+LBE4LX+WHA07OhorwmzjxHWSNSWIdSCmzUn9pjQCg492 7DzRbIG0rmangBqkPo4NtTI8gsy6wPweAHqwFywW2Zq+ev09CexT7dLdwnoPq6jHnh ErQ4hx+2CY1/izeEfR/V8vp5+2OP+Rp52t3fNdqfJXdE7ZJZE71A+3YyTY4+eHCDLv aTTzaygJw3kgg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R.Howlett" , David Hildenbrand , Lorenzo Stoakes , Rik van Riel , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 2/4] mm/madvise: batch tlb flushes for MADV_FREE Date: Wed, 9 Apr 2025 17:00:20 -0700 Message-Id: <20250410000022.1901-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410000022.1901-1-sj@kernel.org> References: <20250410000022.1901-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1F042180016 X-Stat-Signature: fmz8319f9aqwxehse55hgbhh13pgrtjq X-HE-Tag: 1744243246-460660 X-HE-Meta: U2FsdGVkX19hQsEr+xBNAixxm6g/ru0qnzNqep521u3hRW+Umh588wRT+yP0ri56lHLvgKEWOhC9ThMCGIAwXmtjzcRLw7ehonoMYHhs6hv0FS4vv1XJ3t1IqSKLAPBVeyNh6I/KlKpKkQ4bvxNfPayhIxeYdOCL8EUI8neWTCjKzwzfEAQS/vFCqort8/7rDWsL388BSWcl+LLuopz/CpVjiMEacp9X8hnMBOvSxmBGP3gGfYUwuCZHpdHHc7Njgl6ZAjV6aLLWwtUxvjVnWZYDuyiJFI0lqm0SUeZ5pDtO03sh2Y5EchBRSOembW3ICxi65FSOeWwigEOpfDGGbhd7N4EfzqVaX44BAeQNLNqxUClQvslxw05+5lhOg7HMDMH5ycTkXCL3Sh/4Z9n0UC8cb/nO8aBpMmjneIHaxve8BnYn7+JBRjCAOVf0EoNnWUDyfgtFTbtTuK+jNkMLyE17dTdrWhFuQ/Lpt1UTzqMmcpFmICC5WoBLh2/nVEQ6ZK0w/PAdo9eCEhtWPuCunaZypDME1VAhqFUh4osyuaS5/Q0wej+wy74V3l/i4rHyxNd3J+xpjXbhttqVSdjFyWHtI3u8eB3Yu5Iaigz2d8KFnb1bywjFhNpvgukNzlXbVKd7dzjS/1/u3HLNbQYl8IG5oQE3aqaMafB8aAUUiEPHKcYt7NZYHDfK36QSKEGPocBC0H22vBG74VYxEFewh3mGvdoOVGBmBBKYH5/lzwUSxhOCqFoG4vPNk/0JwHkLoghpxRz1mDI0zJekR0E7bgZ8aWH1AVBODXwacOxwQGkz5s1bs01zA1bMktSpRJgX/beiXgbqQdqpkZeN5orCDU3fZd2y4KDRzhRnFHacr+yUh7NZEauRIa6Q7FDM5FAZYVW+Ba+gGX5d0IFRFjodkBMy/naJloz8SZZrB7YrpwtQW6V2s137e+1ZNOfH9DImadw5zV6TCjlTjmj2imQ Ri9A06jo 2jCgnZ93oTgWFnCPQ06Insk+JX5tmbE3dQBDxNlF5sn1K29OFf4SLchUk+jXXU92cJywZZAgUIqyMo6h2Yuh5RWFn5VflRwJGqizKyRsOSMk48nt0lS5zRWnOCDRP8h2rBmeqrpFDEZ3xt7H2IfFkjmM1mVHtV2lcNsFjALsyc5Ed2JcTrpCc3QVXFVw1u9fJXC8mS5AR8QmR1tvkd0l/YgXnwNJtmoVkWnkivdM11E6CK+WkTUJ+chHldMegxacA4E6Hwf8HB9uCSiAFFV7981f1EfXVjKT0+HzQqKsvTseCjAmPO056aHiDFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: MADV_FREE handling for [process_]madvise() flushes tlb for each vma of each address range. Update the logic to do tlb flushes in a batched way. Initialize an mmu_gather object from do_madvise() and vector_madvise(), which are the entry level functions for [process_]madvise(), respectively. And pass those objects to the function for per-vma work, via madvise_behavior struct. Make the per-vma logic not flushes tlb on their own but just saves the tlb entries to the received mmu_gather object. Finally, the entry level functions flush the tlb entries that gathered for the entire user request, at once. Reviewed-by: Lorenzo Stoakes Signed-off-by: SeongJae Park --- mm/madvise.c | 57 ++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 26fa868b41af..951038a9f36f 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -799,12 +799,13 @@ static const struct mm_walk_ops madvise_free_walk_ops = { .walk_lock = PGWALK_RDLOCK, }; -static int madvise_free_single_vma(struct vm_area_struct *vma, +static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, + struct vm_area_struct *vma, unsigned long start_addr, unsigned long end_addr) { struct mm_struct *mm = vma->vm_mm; struct mmu_notifier_range range; - struct mmu_gather tlb; + struct mmu_gather *tlb = madv_behavior->tlb; /* MADV_FREE works for only anon vma at the moment */ if (!vma_is_anonymous(vma)) @@ -820,17 +821,14 @@ static int madvise_free_single_vma(struct vm_area_struct *vma, range.start, range.end); lru_add_drain(); - tlb_gather_mmu(&tlb, mm); update_hiwater_rss(mm); mmu_notifier_invalidate_range_start(&range); - tlb_start_vma(&tlb, vma); + tlb_start_vma(tlb, vma); walk_page_range(vma->vm_mm, range.start, range.end, - &madvise_free_walk_ops, &tlb); - tlb_end_vma(&tlb, vma); + &madvise_free_walk_ops, tlb); + tlb_end_vma(tlb, vma); mmu_notifier_invalidate_range_end(&range); - tlb_finish_mmu(&tlb); - return 0; } @@ -954,7 +952,7 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, if (behavior == MADV_DONTNEED || behavior == MADV_DONTNEED_LOCKED) return madvise_dontneed_single_vma(vma, start, end); else if (behavior == MADV_FREE) - return madvise_free_single_vma(vma, start, end); + return madvise_free_single_vma(madv_behavior, vma, start, end); else return -EINVAL; } @@ -1627,6 +1625,29 @@ static void madvise_unlock(struct mm_struct *mm, int behavior) mmap_read_unlock(mm); } +static bool madvise_batch_tlb_flush(int behavior) +{ + switch (behavior) { + case MADV_FREE: + return true; + default: + return false; + } +} + +static void madvise_init_tlb(struct madvise_behavior *madv_behavior, + struct mm_struct *mm) +{ + if (madvise_batch_tlb_flush(madv_behavior->behavior)) + tlb_gather_mmu(madv_behavior->tlb, mm); +} + +static void madvise_finish_tlb(struct madvise_behavior *madv_behavior) +{ + if (madvise_batch_tlb_flush(madv_behavior->behavior)) + tlb_finish_mmu(madv_behavior->tlb); +} + static bool is_valid_madvise(unsigned long start, size_t len_in, int behavior) { size_t len; @@ -1783,14 +1804,20 @@ static int madvise_do_behavior(struct mm_struct *mm, int do_madvise(struct mm_struct *mm, unsigned long start, size_t len_in, int behavior) { int error; - struct madvise_behavior madv_behavior = {.behavior = behavior}; + struct mmu_gather tlb; + struct madvise_behavior madv_behavior = { + .behavior = behavior, + .tlb = &tlb, + }; if (madvise_should_skip(start, len_in, behavior, &error)) return error; error = madvise_lock(mm, behavior); if (error) return error; + madvise_init_tlb(&madv_behavior, mm); error = madvise_do_behavior(mm, start, len_in, &madv_behavior); + madvise_finish_tlb(&madv_behavior); madvise_unlock(mm, behavior); return error; @@ -1807,13 +1834,18 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, { ssize_t ret = 0; size_t total_len; - struct madvise_behavior madv_behavior = {.behavior = behavior}; + struct mmu_gather tlb; + struct madvise_behavior madv_behavior = { + .behavior = behavior, + .tlb = &tlb, + }; total_len = iov_iter_count(iter); ret = madvise_lock(mm, behavior); if (ret) return ret; + madvise_init_tlb(&madv_behavior, mm); while (iov_iter_count(iter)) { unsigned long start = (unsigned long)iter_iov_addr(iter); @@ -1842,14 +1874,17 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, } /* Drop and reacquire lock to unwind race. */ + madvise_finish_tlb(&madv_behavior); madvise_unlock(mm, behavior); madvise_lock(mm, behavior); + madvise_init_tlb(&madv_behavior, mm); continue; } if (ret < 0) break; iov_iter_advance(iter, iter_iov_len(iter)); } + madvise_finish_tlb(&madv_behavior); madvise_unlock(mm, behavior); ret = (total_len - iov_iter_count(iter)) ? : ret;