From patchwork Thu Apr 10 00:00:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14045660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB5BC369A6 for ; Thu, 10 Apr 2025 00:00:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 868FD6B0167; Wed, 9 Apr 2025 20:00:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CAC028005F; Wed, 9 Apr 2025 20:00:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 559BB6B016B; Wed, 9 Apr 2025 20:00:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 302216B0167 for ; Wed, 9 Apr 2025 20:00:50 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 02F995BAFB for ; Thu, 10 Apr 2025 00:00:50 +0000 (UTC) X-FDA: 83316178302.11.650BF89 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf16.hostedemail.com (Postfix) with ESMTP id 330B718000B for ; Thu, 10 Apr 2025 00:00:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p5ZwDjtQ; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744243249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z71nXh+vlXk3+nWqMzsmDIHIo1Pz1iomfXEf+3JDGsw=; b=sCk7fTWZ3E1ef7rcFoKQOQx4bQxfsBGDFNkwGwkcioQ7YymEXqdaTkMOGupkciVGvI0yxP iHITxrmcp3fVqpOVXccZSxk9L+rHyiAMw6lBZbQKIZu1vnioi+wsC+PPhGmZoo/BOKNkCx KAUiuDqBlRXc+nQ3TRiON0ee2l9Xy0I= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p5ZwDjtQ; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744243249; a=rsa-sha256; cv=none; b=pEJ9sBBpIUZGguuTljGGEc/YCj6kwVMZjcUO0afa2ApFRRQQgknqCOvdHk6CHq6viz2Hmi xl8o1pkULFW3XZPTdrjA2WLaz107pxm0b+L4qDnnRGHeVE0aqpltp5MeN2wimhke7pkRfa FbpiIEgi/pZycKM3Nnf4ixb2RKWTlQk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 11D9E4A36B; Thu, 10 Apr 2025 00:00:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92D35C4CEE2; Thu, 10 Apr 2025 00:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744243247; bh=IBkUpUZBg5kO3BQ+hDKIWhFYAjVEYGs2Rh96p5apXwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p5ZwDjtQl7XjSSd/tBnBXVz/IgfOj5bqgDwup5g/5OnK0V1fqHV9yeOmYqgy9veSb ZpNwByXJQujyZip8zr1DoR/ZHd+HpFty7hMsE4jMhdq3cIyC1Jt8OYGDF0bo5WGmGW ifHjdOMJ+X0M9gtLiKBJtbUM1OHY8XIOlF0qKrA2PHE2iYNkGtzInWpS6u7jyIyWSQ os3jZt8ZpgHsdvTyFx0fBR45miXYCPZztnUe8dqHlRMzbyxZkDVEp3mzFPRvVGc52H CqbeEfMTrHzUzFQINzi7d+202l1tmBjXoC89Zu7pQiKeNfZQhNBGZUhC4l3e6V+qx5 xSVaOkY+ReVHQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R.Howlett" , David Hildenbrand , Lorenzo Stoakes , Rik van Riel , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 4/4] mm/madvise: batch tlb flushes for MADV_DONTNEED[_LOCKED] Date: Wed, 9 Apr 2025 17:00:22 -0700 Message-Id: <20250410000022.1901-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410000022.1901-1-sj@kernel.org> References: <20250410000022.1901-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 330B718000B X-Stat-Signature: 869shgjidxx9jhjpzz91nxizmg61owzy X-HE-Tag: 1744243249-433380 X-HE-Meta: U2FsdGVkX18qpp8bJabMLVUMMdFxF9Gnx8kAyvW9LH/9dbhirvI9WVcr+uUzHei6kcJCYZqQ2W7FQmfOgslfuCk+jAXnQCDo/oXcJheGRkF3bpbgsa4pfFxTdwsE7KiT+yrgaZxvmOnuy4ikaT5TTVOT53mYvv/NFTHIUA2DXfKCHQV6xfvo9C/M0OJqmIO6T7oTzF4+cuBYZYizhxLHTbBwd+7C5BEMAc+9rA2WXJciGRwzjOZcI/3IJ2LLwDfe65MYtIR0pPPv6XFDsJQLXmOSZSfgAGGkaogi+MbEHiHr56ZO2hEkk9m9T6mIjQC6sLQ4fSTOh82Rk7bsQRn0XPB1+/kSP5xvbWjy9DbsyafeTUKf4X19dwQUjm+Zn8r8be+i6HPiijOhdlME+3saLZV619xEkkfexlLsljaLp6Z5aboPtHDSFCET3+tBjlVeZaOF0682BUHEaiSvWv8XlLIXRUwW8XUAnQwiJSC+isw3b3QPNPtRyLcHkSrhB0f76CNoHL6z7+uNHGC+nEOnt2rz2buyJeQ9Az/W0fQXiOQm1F1AwChP9pQuW/JZwnsi5+1I20EcIpe4ATld+1/zVdz0CfpUC+Rn14Evv/cNaT/pmW+ZJc5xkSvJh52wdeJUtDecz37JZqw7X8v17iQ+50goA+wa2XazYwGa/SOnDLi2oU9ULdL+MZOBwnLY7wHIL9LPaKxxovzZsj00cqixzhYMW37cjsc/YdGBV5L0fCnQoV/8GAW/6RevOc3rnkS2rmjUFl2VYTSCgRSM59L2M/5bA8RnAJkc3wGZdUyejl+PvYPEkGkNugm/ZZ2omJCcnzDRi8CbJfwkQHOXdQn/7Uk6N0jXOZLjAKMJ5VB4pEamDrswiZgUsnxWMvwkjAsndypsXL4MxeK9qaMYZRhylCvD2FqYE/8Fj4wDkChgspOfA+D7cv6zNpM9WgVUdVJzw3LnxmZ0F/I7U56xXik xz7c9D0s YpXuuhONeafbBgZILK+2uIXsxZMRDHoIsfe2TnsmNYbCogrXE6mg6MHn2V07liEDiUEOZKxl/FCdjk1UG1BQ2Yc/fEvQcfcnlButgKZX0jxH8rMBXVH0Ypt03ln9yzM58qC5v2QHHTkv1IIaqSix13fNHyG2f+LIOfmfKP4NpX/sRfRhJkNU4jlMTf9txX14BvAj4ewmTDYjufUt3C7NA96gZ2XZKCjFGr18CiTukBGjkocAwi8FoXHV+db9sAywjlyH1ft/OH+tO/4Pp0aFNBAN8PA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: MADV_DONTNEED[_LOCKED] handling for [process_]madvise() flushes tlb for each vma of each address range. Update the logic to do tlb flushes in a batched way. Initialize an mmu_gather object from do_madvise() and vector_madvise(), which are the entry level functions for [process_]madvise(), respectively. And pass those objects to the function for per-vma work, via madvise_behavior struct. Make the per-vma logic not flushes tlb on their own but just saves the tlb entries to the received mmu_gather object. For this internal logic change, make zap_page_range_single_batched() non-static and use it directly from madvise_dontneed_single_vma(). Finally, the entry level functions flush the tlb entries that gathered for the entire user request, at once. Signed-off-by: SeongJae Park Reviewed-by: Lorenzo Stoakes --- mm/internal.h | 3 +++ mm/madvise.c | 11 ++++++++--- mm/memory.c | 4 ++-- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index ef92e88738fe..c5f9dd007215 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -435,6 +435,9 @@ void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long addr, unsigned long end, struct zap_details *details); +void zap_page_range_single_batched(struct mmu_gather *tlb, + struct vm_area_struct *vma, unsigned long addr, + unsigned long size, struct zap_details *details); int folio_unmap_invalidate(struct address_space *mapping, struct folio *folio, gfp_t gfp); diff --git a/mm/madvise.c b/mm/madvise.c index 951038a9f36f..8433ac9b27e0 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -851,7 +851,8 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, * An interface that causes the system to free clean pages and flush * dirty pages is already available as msync(MS_INVALIDATE). */ -static long madvise_dontneed_single_vma(struct vm_area_struct *vma, +static long madvise_dontneed_single_vma(struct madvise_behavior *madv_behavior, + struct vm_area_struct *vma, unsigned long start, unsigned long end) { struct zap_details details = { @@ -859,7 +860,8 @@ static long madvise_dontneed_single_vma(struct vm_area_struct *vma, .even_cows = true, }; - zap_page_range_single(vma, start, end - start, &details); + zap_page_range_single_batched( + madv_behavior->tlb, vma, start, end - start, &details); return 0; } @@ -950,7 +952,8 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, } if (behavior == MADV_DONTNEED || behavior == MADV_DONTNEED_LOCKED) - return madvise_dontneed_single_vma(vma, start, end); + return madvise_dontneed_single_vma( + madv_behavior, vma, start, end); else if (behavior == MADV_FREE) return madvise_free_single_vma(madv_behavior, vma, start, end); else @@ -1628,6 +1631,8 @@ static void madvise_unlock(struct mm_struct *mm, int behavior) static bool madvise_batch_tlb_flush(int behavior) { switch (behavior) { + case MADV_DONTNEED: + case MADV_DONTNEED_LOCKED: case MADV_FREE: return true; default: diff --git a/mm/memory.c b/mm/memory.c index 690695643dfb..559f3e194438 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1998,7 +1998,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, mmu_notifier_invalidate_range_end(&range); } -/* +/** * zap_page_range_single_batched - remove user pages in a given range * @tlb: pointer to the caller's struct mmu_gather * @vma: vm_area_struct holding the applicable pages @@ -2009,7 +2009,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, * @tlb shouldn't be NULL. The range must fit into one VMA. If @vma is for * hugetlb, @tlb is flushed and re-initialized by this function. */ -static void zap_page_range_single_batched(struct mmu_gather *tlb, +void zap_page_range_single_batched(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long address, unsigned long size, struct zap_details *details) {