From patchwork Thu Apr 10 15:23:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 14046695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4307C3601E for ; Thu, 10 Apr 2025 15:23:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FE72280110; Thu, 10 Apr 2025 11:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B28E28010C; Thu, 10 Apr 2025 11:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55005280110; Thu, 10 Apr 2025 11:23:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 326C628010C for ; Thu, 10 Apr 2025 11:23:44 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D22CE1CC8E1 for ; Thu, 10 Apr 2025 15:23:44 +0000 (UTC) X-FDA: 83318503968.05.9695E92 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf24.hostedemail.com (Postfix) with ESMTP id 2AEBF180003 for ; Thu, 10 Apr 2025 15:23:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YLFodFHu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744298623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3CZNn+OgRQU/MVIvzZqg0O/V+8sJ5zCyU/lMOcm7F28=; b=d9H210leZVIX931875XGnBPw4CN4UVpnuhGOFZAnJC3cZ7sJKYwT8vsF35XEXknjSxIcpf ykel7fiCVHxLSf1AzjQtRbZKNgBTPrFW3vvUnj6HReFkIvFhqjaN72rhDYqHW55wvcPTJb /mIIbty9azzCT+eFhBFZV09j2C0Y9M8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744298623; a=rsa-sha256; cv=none; b=0SVWSooqbY+dJPxUqwAb7/PmJO688hWNFwHVU3BRHRGjP9eNxWuj4W2DehSxBX+OWDJz3U E1CuJLxP2EoaXr/Ntghz0Hx+KXClukOizn4rNFQ+buoRueYMvdpFPo8pqcy6tnD5193PpP p/IpHkZaqQmWqAIIDuUVdpX6j1nh3yY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YLFodFHu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EE7A94A442; Thu, 10 Apr 2025 15:23:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2711FC4CEEB; Thu, 10 Apr 2025 15:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744298621; bh=ljh+x804fC62Zjq89Q+GJgD75j99Lk55WXN2zidEDas=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YLFodFHuby/VWTADh1XTREQPgLF8zm8Zsf4Qepn6NufyHBWQZcyEDchrBNZm7HdS5 VitZLkZM5ehaBZssJZ1KhFAJlU6IuBMIvKrpfnS6zaG4zzl6rU4XFAvjsZSWxY0CuN UmwcCq5htpVOfdJDAV66kmGRajrA8nK7cQ+4Y/B10AJrVJEQAONwwdG3cCATQ/RA3I dHrNP+Ykjx6IhVG9lwZyk3FiBWZiNgCiE+ofc0Pxi+YApfamUxSRWA/+fVkqyIYDef yB/Ls3829yJuQy0adG4giYgtFoWsr2fV1EqyFpJpFAMFY8tI3S32euaFPpsWP/j7Iw Jhhmi5nhfZ8KA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 2/6] sched/fair: Use task_work_queued() on numa_work Date: Thu, 10 Apr 2025 17:23:23 +0200 Message-ID: <20250410152327.24504-3-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250410152327.24504-1-frederic@kernel.org> References: <20250410152327.24504-1-frederic@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2AEBF180003 X-Stat-Signature: jeri3d7bqs6qura7d7eqb8qebrph4yhy X-Rspam-User: X-HE-Tag: 1744298622-377188 X-HE-Meta: U2FsdGVkX19eLqAfQCt3cHucZWuT4P/Hn5Sy2kCyKiFALlDtcmjXdvp/xQJSuZjVAvlQvGY6xSi1iF5XmZelmbZ7JbOdrlzwwl7gG7jBXInoYnrOSPnNUX8v2ukHKuvYsJj0PQatzeNHGfuGln59JZJG1Pgdb/3oBQk91ohVAzjRV43AjTBc+vMw4e0mZbS64fnwb9Mr3df6gs6tDuwcWqhLyFcMkdsvdorM76ovMWXlmGkl6/aRbEu+m2UGsX9Fk/oyhDNSr5JXP4SIMLNpSKfzXGdGM5bVfQS/xwhrc0yZY1M8lvwFIzI2F2TcfjanreoO/uyoLuqE/caBq7cb6wNsjw1fL+tOVazKI3dM2snfrBFzY1JZsbk7eYACs45HC/dToZE0rBtJObnU/6hw3tKWTbu6MjdnuHlX3AFJJ1BBBCtB4l7QG7q8LZ520wjg2f88N16y6e397Yl4VQ1ok/kShdx1fopVOM+TcPkMW+EwTKkFVZs7NCQNUytCPkFszFuAw95IhO/YA4mVDWIlx0XFoG/l+kTq9hmS5dZUH7/7yhetoqzQGKjtS/+K1OKjjkrWJX0CWQPOVuWEzXogPQ5gbYUK+Se22F9BI9UXbmCzXjMSoJ3S2+L33XaW84K2ZbBpQwp6iiuWKHcG46RVhUou19ryYmvr7nzFLHoYJyelxRKOHK2vc3+ms8NWlKdc+fX32kYn4CKcB/u9OXluY7Kav5Tj1rpVElWsdXwpZ5UTMdXq396MJE1hBLiQk48jn3YbirzVmPoQ6YIbu0YlwI14T/6VFARYDNq+Qg1t/jdXPd29HSRjxaWGM37my3yTsjTTg+pDct5dUcl3rwmL85klkWZQYnKa87S4rAqkQIyv+L4RaLtXKLIUBfntj1LT8RKnzLAb9bbqS2XSL2jyGqKok94eEWNcFnariY5UtVzOkkbLdHE8t97UQeEkieMow48e/+VHKWRrCDvjVyr z/QF7Q/o m5xpLu8yq0vZq6taEn3hg3wPKasHst6FYdu5xjF3/zYiV5mYcVwrB8cXEBNJu5AjNx2ogUidWPTh+YqNZl4dBCbKuK+JunIrFjCviYMMuUadbHToaizgkF3LtEx4oEE68TNiSBp2ZuiaUqDIXPmPMN5oUX4CLykEB+cYC/assw1UO9bfNTes9bf/y3Kw4LpOEtig35/bMHKh914zPY3q0n028CcgmGV/HDsOSXunC1hkh9rJbtyOIJLBZ7SZBpxlOP5HMYmlehRVkQrrIFENmJuQfNsYqeLMgpC9MJcpjPdeiddLci9KaygiEFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove the ad-hoc implementation of task_work_queued(). Reviewed-by: Oleg Nesterov Reviewed-by: Valentin Schneider Signed-off-by: Frederic Weisbecker --- kernel/sched/fair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e43993a4e580..c6ffa2fdbbd6 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3317,7 +3317,6 @@ static void task_numa_work(struct callback_head *work) WARN_ON_ONCE(p != container_of(work, struct task_struct, numa_work)); - work->next = work; /* * Who cares about NUMA placement when they're dying. * @@ -3565,8 +3564,6 @@ void init_numa_balancing(unsigned long clone_flags, struct task_struct *p) p->numa_scan_seq = mm ? mm->numa_scan_seq : 0; p->numa_scan_period = sysctl_numa_balancing_scan_delay; p->numa_migrate_retry = 0; - /* Protect against double add, see task_tick_numa and task_numa_work */ - p->numa_work.next = &p->numa_work; p->numa_faults = NULL; p->numa_pages_migrated = 0; p->total_numa_faults = 0; @@ -3607,7 +3604,7 @@ static void task_tick_numa(struct rq *rq, struct task_struct *curr) /* * We don't care about NUMA placement if we don't have memory. */ - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || work->next != work) + if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || task_work_queued(work)) return; /*