From patchwork Thu Apr 10 15:23:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 14046696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81145C3601E for ; Thu, 10 Apr 2025 15:23:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 187D6280111; Thu, 10 Apr 2025 11:23:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B1828010C; Thu, 10 Apr 2025 11:23:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF043280111; Thu, 10 Apr 2025 11:23:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CDF4128010C for ; Thu, 10 Apr 2025 11:23:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 871461CC844 for ; Thu, 10 Apr 2025 15:23:47 +0000 (UTC) X-FDA: 83318504094.15.1723FE5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id DE4CD80005 for ; Thu, 10 Apr 2025 15:23:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M211yw1l; spf=pass (imf02.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744298626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8wbVYOELbuA03Hi9arolaO2x+RRMyEjdlTDQAeUw5a4=; b=wuGsDn7+v4AplujNaeKam2eCiCoJOKearmjJVDBvwppzV7IU6gA0/ASWoTa9v3MSm59NpY XAkLv1zuilj6QtoQuJ/oCExg45TyDk6DNWQOjXwWRbK6uTqeiLmObSytANbxKSLvQYaUn3 00k/sWuyZ9kxXNC9XOGQjpz4YbjtRpo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744298626; a=rsa-sha256; cv=none; b=bs/5Mg6XqoaKIlSjl90KVqsdok3k8GsgWP3o6Qa2q/pqL0XvSDXPOhAitquBZYj9GDTTPB sgMZ+67eqyHTGjJmteIb/IeqkooOCyBtOC+fzj4wTgKvB6vLijOYFGT2B4bvudoady3RDO wSjUziRiUn/xx00lEXcZ6teQVgICUJ8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M211yw1l; spf=pass (imf02.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E3C925C5D15; Thu, 10 Apr 2025 15:21:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 153A7C4CEE8; Thu, 10 Apr 2025 15:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744298624; bh=Wjj+RxTAFtK3Vg/VxjQp1/LpNlEkwCHswxd2NjU6Evo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M211yw1ldc3Hf9hKFJ64zkqx61cUGKq0dplVDOpTKCD36p3MrbzjMq6sR/YZ6iUK+ EQ0XiCyR+Ri2pWUNqecLe++qdTdhpNMETeJOUWiz+2wqAktpm2QjYeRUzTdBsKXuPy nTOVOtPqDYTEnxcl3Mwjj2zFwLT/Pu1lqyhtMI+Z0wE547jpwKordX1cpo5s7rt1oi vvDU7kx4xJIFYohPCbHXgjkiQ/EwmroNc15hngyEU6WDaqoWll4Q2hjeJatBQvxznu XHfeXIJhHvgPtnmlK21JUENwFkLsOzHPbVY1CQzDPi+b8r/MFhXtwmbHSlOaS6psxq OtSip1JmsgTPQ== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 3/6] sched: Use task_work_queued() on cid_work Date: Thu, 10 Apr 2025 17:23:24 +0200 Message-ID: <20250410152327.24504-4-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250410152327.24504-1-frederic@kernel.org> References: <20250410152327.24504-1-frederic@kernel.org> MIME-Version: 1.0 X-Stat-Signature: 7wbhxe5iamxdnnc8hk7ssyesm6fyux4p X-Rspam-User: X-Rspamd-Queue-Id: DE4CD80005 X-Rspamd-Server: rspam08 X-HE-Tag: 1744298625-735751 X-HE-Meta: U2FsdGVkX1/cJ+zvjjcDe+NiBGptFyzbHgri7lhmqmafNyZv9qVhM3/tRhDseuEPXIeXYXopdbwDFhkZ7Nvxv2cLQDe2ym1NtpQgDYWeFRm4ogCZM+PQNc0IPlCi4UzNMTifaABh/tTm4LrSuzoABXtTsCMzNb2ryZ59hpa/h2/AgxuYZ3B7tWyPVjd92LVE8nFNMNUmmnrrYSEoC4w8d4YOaqW512ISygC9+9hksVMj9oN/o/fwvwROuYl6EXNN0aLo6GrVS1NiROIZvK75XO7IXxnhmr4lUWCXmMW/zRdvyZAIbm2yE5nAl51QjHYfN47i70+4IoRsSOt+oeeHJe7PoeAXZNiDzBkc56v4btoDO36K2hP4TH/QKP9qnwPKyTrcm3JN1PhUmBbASyVZuX0N0WD1RDQAmQWAVQTkU12N6JE/S+VHtgNMvtw/hrRn1/DZLAMABC2FK3APnGTJgA+oODtz0QSouY6Axb7xXl4Vg2vTve0XJjW3VkJKqJCw69PE8cZxLAIB3ER8B/uaPPevMAs5uT63XXdIb7JnY27Osk1wSw8xVRuuXuysHtPuZoxNMY5aam2AlJqcj6C3vEqFwvao0ck/M57rI9n9TD0vqarrvkr1kiLZ4THd0Ib9y1wh9XDbHppHKH855T8AbAED9YgiX0p2rbgFngOTwkUlBfj5rZ+ubqmNBlJR4XJmxe+ET5+HNAW1CRttMQH6grjh+r7D+UVqw4AQm7zyR03y7cUkfMxWm9oel9Y8hk0t/Itvqh0qe205xboOOiBsweamVOrbUsXy6nT0Ar9m1QEn6vO3iyoO9559grxrM+57CR2g3Rt0WFy/R5HxOIiprynHfniDWhDLFP8m010riLReTcVbjeMAHHildnoZRReVcIXTbA7ynEjgqZ9SzcHPhRY6twVAZJYFmm+bNcLqK49q04qcjGzEmYqm28GN2s2M22Z4sB3X2qraD93/vWS 2/LtLrBY FMikOwFgUlB1NlKvh60ihBbeHgv7asp+gMkP1rJB/lSovTSj44JNa4AL1zcJ9GtzGdShlFtkc8zzfiMkegtG8iD9IHPw6DUwXebVlpB2YiWjxb+/eabuzrc0bKHzEbXezPXiXL2Zbw5ahsDQeyemEDwmWtGON9dCDxOc3pESyX2aEgdyNLpWGw4zhfCQLKiZlCokF21CG7ICyjuGWUQze/oOMLWfywYuOptb/F9nOkP9R8CmmeidAt1X6z4LL9i87YxoglnoVu6h7DjGEIExUD4K/lUiSvF4svlRwbN55AB13Looqn7jCj3ngBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove the ad-hoc implementation of task_work_queued() Reviewed-by: Oleg Nesterov Signed-off-by: Frederic Weisbecker --- kernel/sched/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index cfaca3040b2f..add41254b6e5 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -10576,7 +10576,6 @@ static void task_mm_cid_work(struct callback_head *work) WARN_ON_ONCE(t != container_of(work, struct task_struct, cid_work)); - work->next = work; /* Prevent double-add */ if (t->flags & PF_EXITING) return; mm = t->mm; @@ -10620,7 +10619,6 @@ void init_sched_mm_cid(struct task_struct *t) if (mm_users == 1) mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY); } - t->cid_work.next = &t->cid_work; /* Protect against double add */ init_task_work(&t->cid_work, task_mm_cid_work); } @@ -10629,8 +10627,7 @@ void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) struct callback_head *work = &curr->cid_work; unsigned long now = jiffies; - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || - work->next != work) + if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || task_work_queued(work)) return; if (time_before(now, READ_ONCE(curr->mm->mm_cid_next_scan))) return;