From patchwork Thu Apr 10 15:23:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 14046697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97343C369A5 for ; Thu, 10 Apr 2025 15:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D53280112; Thu, 10 Apr 2025 11:23:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1411A28010C; Thu, 10 Apr 2025 11:23:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAADB280112; Thu, 10 Apr 2025 11:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C345A28010C for ; Thu, 10 Apr 2025 11:23:49 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 71053801F3 for ; Thu, 10 Apr 2025 15:23:50 +0000 (UTC) X-FDA: 83318504220.04.CA5DBE7 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id B89B7140010 for ; Thu, 10 Apr 2025 15:23:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L4Pb8QdK; spf=pass (imf09.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744298628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SC9NKGDbF3sSN+SVmw2kMT6EWmn69majOqh6AlkBd+c=; b=kjNsGC0kvDg0c4+87uT1TqKIXFUQK55cM5PJxlHQ7z69Clit0HFYgiyOaw9Bac32ZGx+lu yek//kT7XH0mdG1kfiKgbaLo4I2ztgNgqT9ayhUpC1hGev5seSRfnWjcLrIvb0dBlVL0GK gZxnTju4Tu0C1i4QfADFcsXdzaBk6dw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L4Pb8QdK; spf=pass (imf09.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744298628; a=rsa-sha256; cv=none; b=EVBjzBBFQd6MLPPLrYXkZNnpC2A43s1LhD9p84yToH2ZqI9JJWWQou65hIvL6G6h7wJlor 62zbQL2BfAyh8xTh/nl5szouGgMuziC1JiCQgASbNwwgknwdjCy62nMyBp7EorKDYmWepD E1BtqP+3IMujdlBnuTbPVJm8EH0xLkE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 08A614A443; Thu, 10 Apr 2025 15:23:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E8A9C4CEEA; Thu, 10 Apr 2025 15:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744298627; bh=l3VO6WBv+ArOF03U7NJi6+am3DCDRNiD9Zb95QE1QjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L4Pb8QdKdNYxjnWQ8Wm5pszfSbTM8zEO1gP/6yA6X78fuFlRn4lIex+ze7UlVfXA7 qFgVCuDW6Yd54isboTwax15Q2PnxUL9J0A1eI9qDHz/4vP60nxPVZ+Zka5XL/IStBp B7wk55YGzwkeFA82PqylJJIibC7Q6LcPAhzWEuTv76nAxwVhZTMGKylTh5HU6Lg+KU QquEVfV5030H3BnuGUGr1Pgr/Ttsg+6sycLunvRjNvPb7CdQi/yTAIwF0LZMf/IzU7 PKvL/MYNGGTNGqUwEHobnchX/rlOKxDr5aNU6ZpWR9QAGqJXAlrBFQ8DXEjRMPsYem 614Yh4/tzyiEg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 4/6] tick/nohz: Move nohz_full related fields out of hot task struct's places Date: Thu, 10 Apr 2025 17:23:25 +0200 Message-ID: <20250410152327.24504-5-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250410152327.24504-1-frederic@kernel.org> References: <20250410152327.24504-1-frederic@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: B89B7140010 X-Stat-Signature: c77s4aimwwaqepx356jm4apxaqd5mkfp X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744298628-949938 X-HE-Meta: U2FsdGVkX19eWZzdhXW8VJdcyF78tWjrxCAxI4O5+90b6pnYwvlVo46dTupENSzwaFBG68yx+EeNgN4FL9DDeyRy3EEYZlYQh3LA+khkwWuUrXc8bg/DnFY+Qs+T4/mKsAiRgSyd5AoQnPS0XyxpiOsLYWYvdAvrBMmno6WWCUHzASwYd4Midq6FeWGpdvASA44QVPHv6f71Q6Ux7ECEbmc8mMO/+Aler6XWHYEx5CLLyMUInvBC1fTaYc9wjToq7FwNxphK/AmE8v90E89XXBa2K4Zxf4oUhRIWcN80YLVQzRzIzdXK2o/kxpQ2x6NuhszcOF1owDweO6UOQRAZ/lrPoD6q3SoHUo0mjEUjGDnc3LBtEuklLgexNw23c5Z/o0fy7Ac2uNkGEEjrtgPwjSERbHx7mxZ/fHbgg+/TmTkK974Hxvsk0XaUuyoSaRCaepLs1zR+IisnZgIhnrs6DGWps8upVOyfLbQei7EGgWK4wv/OkcUR6sE1L8sNkhUWWwexKoIitSB981KCMOO6F+k1ULFW8h6SPMpGodIg8aMePqmf/JWjCXWPs1h9GtVcNR8ENjP7n5hLirDmPOUZLqDTHjMFlSxuOmmPCdjiB9stqxbSB2h9kEpN1N6qB6odBGUJybKpdalHWJX1Ws7a1q0Ew6FBScA8TQNTwXAF+mdz/aXhi2KldepZSZElMtVl9z4fQwRRjQqrrZrOI+59I+ONuBClSDjVLTrEpBMdSBCkTeGQ4TSiGYQ668Uh8bx8V8C+f4ymC4EiSMQJ4/5RF6CFX9EM3Fr7ER4byr97aojuQIJJ8B6Wf2wkDUUxaBU6XCFWgLoJ/0N6nYWq6NeD3c4zWecLdTuQHvtBBChCDALNEUGCFatzZ2pllRqbLRSaUuy31ceIwI7Zt8SjCDKuP/h1Az2L6ClavnKYC8PJ3ozNsD5u024WQuvJOmreO6iWRdOLyVMscyqH/Uqv2dU +SYtDsXf 9khDFC4COyhqwWKcNAhzbOhyi3sOWpO+hqZ4eMfmklNdbaByRsimWFTX7wS7cP6NH1BjS92czZGRjiwJMzIpX+bsVIhdrGp5L6ErAVv8LJZlgpMw7G7mu4bimKyQVWzSKC+IrGxp3cTXGIxks2VrrwndX5bpxR36YVXB/UIOsOudMi/DpnGLfm5zePZ8NhQ68ZvxeDKNfibzztDsumz1xAqY1TyZDR4ub5JQF4N6bRYl/WPKYj3NdNNSgM+rJfuxC/zpxFo4P0yc5jgOYbv2i/lhzkVjoFeTD1Cwq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: nohz_full is a feature that only fits into rare and very corner cases. Yet distros enable it by default and therefore the related fields are always reserved in the task struct. Those task fields are stored in the middle of cacheline hot places such as cputime accounting and context switch counting, which doesn't make any sense for a feature that is disabled most of the time. Move the nohz_full storage to colder places. Signed-off-by: Frederic Weisbecker --- include/linux/sched.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index f96ac1982893..b5ce76db6d75 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1110,13 +1110,7 @@ struct task_struct { #endif u64 gtime; struct prev_cputime prev_cputime; -#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN - struct vtime vtime; -#endif -#ifdef CONFIG_NO_HZ_FULL - atomic_t tick_dep_mask; -#endif /* Context switch counts: */ unsigned long nvcsw; unsigned long nivcsw; @@ -1438,6 +1432,14 @@ struct task_struct { struct task_delay_info *delays; #endif +#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN + struct vtime vtime; +#endif + +#ifdef CONFIG_NO_HZ_FULL + atomic_t tick_dep_mask; +#endif + #ifdef CONFIG_FAULT_INJECTION int make_it_fail; unsigned int fail_nth;