From patchwork Fri Apr 11 02:43:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enze Li X-Patchwork-Id: 14047473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628DAC3601E for ; Fri, 11 Apr 2025 02:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1815E280138; Thu, 10 Apr 2025 22:44:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13225280103; Thu, 10 Apr 2025 22:44:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39C228014C; Thu, 10 Apr 2025 22:44:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D466B280138 for ; Thu, 10 Apr 2025 22:44:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DBF4CC0258 for ; Fri, 11 Apr 2025 02:44:21 +0000 (UTC) X-FDA: 83320219122.12.8C849BA Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf10.hostedemail.com (Postfix) with ESMTP id 5E6D7C0003 for ; Fri, 11 Apr 2025 02:44:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cpr+11hL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of enze.li@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=enze.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744339460; a=rsa-sha256; cv=none; b=oQF3dlgiRIqxHkkmyK4LUO6g9qh6x4ffd/B301O5QX9fZ2Sh2uPyKaXe7A2tCRndrHLrZC vtDfdsU2tqV46dEixyLBBCMvYhkLBrDrNRIssZLFRHwlx7TJdSbYcI7xvnCjqRDDQnf6TY mu+qsSEMml4A9sZr/wThUwM4uVLoWBs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cpr+11hL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of enze.li@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=enze.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744339460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=SPIWqsTjCW4p+yM3tP7JZLgi04R4eD2wyVkEzOwtWrA=; b=UpcPxZYeHpfy+6US+TU0CF7KNU5p/uSZQj+9DI5yN23EjeO8kfyk3BDehf8J+bMTiy8LGA bb82yOCl2Bi+aWV3apM7rU7hh5bCj8JbeYq07v9iuuTyqnULWcvi3GsN+E5u0BoGClOBeb rrrkebRCnWQhJXbk3EqCic5VmQXSjM8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744339458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SPIWqsTjCW4p+yM3tP7JZLgi04R4eD2wyVkEzOwtWrA=; b=Cpr+11hLqt/ykMVq5FCsaSsF18GozjBmXH3ICxUtgNsF4GyuLKY3WWAIw573JU7PxxJXWX HF11BRUYBGWYkjk5wi3jYYeiX/boZN2y4h+elL0DyIKYaTVuGIVol22n45E22Krk7fQRp8 ngulYARc0RKMkCQcK1XgDMBWArnr9fg= From: Enze Li To: sj@kernel.org, shuah@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, enze.li@linux.dev, Enze Li Subject: [PATCH] selftests/damon: Remove the remaining test scripts for DAMON debugfs interface Date: Fri, 11 Apr 2025 10:43:32 +0800 Message-ID: <20250411024332.1373861-1-enze.li@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 5E6D7C0003 X-Stat-Signature: 3mtokzq7kkgsmefpaxkmnxggke9r1car X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744339460-339040 X-HE-Meta: U2FsdGVkX1/AtVXdaYWpSN5jLLAYTY7cNlfOjnJ7ldDW/aeOVtRMqGN1zXifWCkL7XeDD+TKSxTQlqZuk5JeKYIvLg9TbFH9z0QkEzS/FUN/W7qjFkXYEl9dNmEVQOLaqyYKLyWWalSwjpUNOvKFFzbts812s+dx2l3b3B7NVmA6DX33K3iqNZ6Aa4yHVRLeGb+gG6dMeMVGbughpiWmKUJtz/Mt7ItZ/mAG9ia79jg+mxgpcwRyIbHsQqNRiFBr2s+aL9NH5EXUnuceIc3IozCXwaW6REkB/NDrHdlD3djRiXUG2zUIkB+/k9lm+Ler4Wda415FQGeN1KX6aefgtCf5DQjsfOT0Djpff2OzeW18v38xOx59v9wehQ1MHmCxqFFahX4pNdekQ4ZecYdq7pehBqy7adUFN8Yro7UX5XI0Jpp/VYPMJBy2G+JAJSsZj1KVO8jnWbU160TaYyu+zIrBzVaceX9adpcfP+pYXtB2I+tIAT4J73ibs6O9WEeaesP+UPyWC8nKE/XCLjfg1mjggzfevDxOXex58gMAp+GMqGsyZRnv6LXrFC3UY8XxCg37N3FP0G8aJywwZ7p4qsC5Y6RDAeSbt1jPswkOv1FttDjdrC07+1cAaPpDE0vVyE7/rYRU6fcs7tN3+M036OPvMeZ5mOYMbYnFBTzvepbvQErkVxmSekRHUFLZ/3ctqAhDG8rsSjHSl/fraUEEYrs2+xcekdJJ5VJWNm4AYqsDruVrEQGmqtBNlbIPtfiyeDT84BOSvK0aX+3QAwnYYm+ZOMWZ2nyWn0sGUnSovYN2TJLuYTmXqMzxWatisnsM/5sA/JUsKz2BKFwyMJ8bo19DnWOT2bddu3Q4x0HnlCyNmdyaTQ8Qf2yU/LR74K2e9f8u3ecMcEIcQZ/dq34X5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006575, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Enze Li DAMON has dropped debugfs support; therefore, remove these unused scripts. Fixes: 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") Signed-off-by: Enze Li Reviewed-by: SeongJae Park --- tools/testing/selftests/damon/Makefile | 2 +- .../selftests/damon/_chk_dependency.sh | 52 --------------- .../selftests/damon/_debugfs_common.sh | 64 ------------------- 3 files changed, 1 insertion(+), 117 deletions(-) delete mode 100644 tools/testing/selftests/damon/_chk_dependency.sh delete mode 100644 tools/testing/selftests/damon/_debugfs_common.sh base-commit: 3b07108ada81a8ebcebf1fe61367b4e436c895bd diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile index ecbf07afc6dd..ff21524be458 100644 --- a/tools/testing/selftests/damon/Makefile +++ b/tools/testing/selftests/damon/Makefile @@ -3,7 +3,7 @@ TEST_GEN_FILES += access_memory access_memory_even -TEST_FILES = _chk_dependency.sh _damon_sysfs.py +TEST_FILES = _damon_sysfs.py # functionality tests TEST_PROGS += sysfs.sh diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh deleted file mode 100644 index dda3a87dc00a..000000000000 --- a/tools/testing/selftests/damon/_chk_dependency.sh +++ /dev/null @@ -1,52 +0,0 @@ -#!/bin/bash -# SPDX-License-Identifier: GPL-2.0 - -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - -DBGFS=$(grep debugfs /proc/mounts --max-count 1 | awk '{print $2}') -if [ "$DBGFS" = "" ] -then - echo "debugfs not mounted" - exit $ksft_skip -fi - -DBGFS+="/damon" - -if [ $EUID -ne 0 ]; -then - echo "Run as root" - exit $ksft_skip -fi - -if [ ! -d "$DBGFS" ] -then - echo "$DBGFS not found" - exit $ksft_skip -fi - -if [ -f "$DBGFS/monitor_on_DEPRECATED" ] -then - monitor_on_file="monitor_on_DEPRECATED" -else - monitor_on_file="monitor_on" -fi - -for f in attrs target_ids "$monitor_on_file" -do - if [ ! -f "$DBGFS/$f" ] - then - echo "$f not found" - exit 1 - fi -done - -permission_error="Operation not permitted" -for f in attrs target_ids "$monitor_on_file" -do - status=$( cat "$DBGFS/$f" 2>&1 ) - if [ "${status#*$permission_error}" != "$status" ]; then - echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" - exit $ksft_skip - fi -done diff --git a/tools/testing/selftests/damon/_debugfs_common.sh b/tools/testing/selftests/damon/_debugfs_common.sh deleted file mode 100644 index 54d45791b0d9..000000000000 --- a/tools/testing/selftests/damon/_debugfs_common.sh +++ /dev/null @@ -1,64 +0,0 @@ -#!/bin/bash -# SPDX-License-Identifier: GPL-2.0 - -test_write_result() { - file=$1 - content=$2 - orig_content=$3 - expect_reason=$4 - expected=$5 - - if [ "$expected" = "0" ] - then - echo "$content" > "$file" - else - echo "$content" > "$file" 2> /dev/null - fi - if [ $? -ne "$expected" ] - then - echo "writing $content to $file doesn't return $expected" - echo "expected because: $expect_reason" - echo "$orig_content" > "$file" - exit 1 - fi -} - -test_write_succ() { - test_write_result "$1" "$2" "$3" "$4" 0 -} - -test_write_fail() { - test_write_result "$1" "$2" "$3" "$4" 1 -} - -test_content() { - file=$1 - orig_content=$2 - expected=$3 - expect_reason=$4 - - content=$(cat "$file") - if [ "$content" != "$expected" ] - then - echo "reading $file expected $expected but $content" - echo "expected because: $expect_reason" - echo "$orig_content" > "$file" - exit 1 - fi -} - -source ./_chk_dependency.sh - -damon_onoff="$DBGFS/monitor_on" -if [ -f "$DBGFS/monitor_on_DEPRECATED" ] -then - damon_onoff="$DBGFS/monitor_on_DEPRECATED" -else - damon_onoff="$DBGFS/monitor_on" -fi - -if [ $(cat "$damon_onoff") = "on" ] -then - echo "monitoring is on" - exit $ksft_skip -fi