From patchwork Tue Apr 15 02:39:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 14051348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3C8C369B8 for ; Tue, 15 Apr 2025 02:40:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7390E280085; Mon, 14 Apr 2025 22:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E993280075; Mon, 14 Apr 2025 22:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58A56280085; Mon, 14 Apr 2025 22:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 364B5280075 for ; Mon, 14 Apr 2025 22:40:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 774B7C0AE0 for ; Tue, 15 Apr 2025 02:40:08 +0000 (UTC) X-FDA: 83334723696.28.FF03CD6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id B1367140006 for ; Tue, 15 Apr 2025 02:40:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QsYyQx4j; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744684806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=abWHD7HGRJypdiZsKpqwwuf0n8E4BGzV2LjQF8XVdqk=; b=AGeQfzktHM6gfvkXUHx+mfQBkf2c6HkOVEDtMvbkUGmBBet3VfJkXCm4jQcsMoGboERmY7 Y8jLgDZPV1QZ9LdYrKPT4OnVoi7ZyMT+LURvK77jrEe3Sl1/3VWFeUduNgidhFpmtYOn05 4UkHfHMYbsO8mtv2FmgVZJwu5HwsuYM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744684806; a=rsa-sha256; cv=none; b=ZQbPbCbqXpRQ99auZAPweX6u0OwfvVi0TvqmPcBwfSfw4oRzuLoEfADfUfodlvhzeFGydo fyZ64fpW40zLuonKWTcwAcF079GsFEKrte6gNnqLng8/c/9nmponoWfPXK8rDuGSgt0Hbo +X34Msr7ILecO/PTbHJ4RxtMi3u6YVk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QsYyQx4j; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744684806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abWHD7HGRJypdiZsKpqwwuf0n8E4BGzV2LjQF8XVdqk=; b=QsYyQx4jFBqvq9hzIEWJWxCoH64pDFXFhAalVm+DAdb+4sgfyJISs0X7nYW7IM5BQF8Y3B haRC8dAo60VV/XILjfTYjnbnaxeN6rFBXdGNYtl2sq6L36485qiQbX9SEzoUwY0lDeaP6P V6kGof912pkm1erFfK/0FRE33AuvqSk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-O-XFv-pgMZmdIzugaGbJaA-1; Mon, 14 Apr 2025 22:40:04 -0400 X-MC-Unique: O-XFv-pgMZmdIzugaGbJaA-1 X-Mimecast-MFC-AGG-ID: O-XFv-pgMZmdIzugaGbJaA_1744684803 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5691219560B0; Tue, 15 Apr 2025 02:40:03 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.112.37]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 85319180B487; Tue, 15 Apr 2025 02:40:00 +0000 (UTC) From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, urezki@gmail.com, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH 1/5] mm/vmalloc.c: change purge_ndoes as local static variable Date: Tue, 15 Apr 2025 10:39:48 +0800 Message-ID: <20250415023952.27850-2-bhe@redhat.com> In-Reply-To: <20250415023952.27850-1-bhe@redhat.com> References: <20250415023952.27850-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B1367140006 X-Stat-Signature: ug91ga3ko7mr9pmn94n7fh1ocskc16y7 X-Rspam-User: X-HE-Tag: 1744684806-454128 X-HE-Meta: U2FsdGVkX19gWMA4yScui2ncBZhqdB37S+OPg8okvvFZ/vcdk2SuElDBDBIIn9I/RAAzm5j6/7SWtN5wFTTXyEjJGiwOaqufXNyLGouwk0/pl8dpIh6gDZdepIJQkctQAsp/s2R7zvwXrvNKgHRaZq1weiHvME3uA+yZBpx/Y5CGDwhIS5A/j4c8aKi0FLihtl/DcujUwy+feUijS77DW3t4IU8OWas5VVDmyUuKIQhHhfRYJkqt2cx+lV2+YOnukfeeLHDNyU86/8h5Aw48jxioY+4Gb+uwlrOBFHNhtmBRhuLJ6h+Th4ZF5d8D+bp1gncvXgmqkZuRLSkcoQ2QnbpnzN0Sq6xWGsrPRtrdNv1IBrURwkHYq3I4lUtHCasKQHhAjrJQ+hxwL88+fBh7BziasTB7EN0UmAgUyjoSHrOKvO2Zw4wz54vqN2l40ivG2SrxLtcKccEVcCAarKt67Av/cjkpm5/L8DX0yXx2UBc35VH2k96iWNNbK6o3s/oXu8zgm71+BLDdBKEU6CGNgH5ryCobRxuRGuISogL/4FlYm6G/ZQe8HQf5HsyZ2LrXzTzk7AJ8BbmZpNplORsMYfpM12GcFjaxZPxejqNrq5kF4dowtLXDLdD3NAM/r7/7/TP+ZOUjZuVhrbI/Vy7pl0kh4TI1kEkBSeLTqNfiFftKoMroTNBcFafEYQLTDBid8G7dsdhJE+0P8G1syojTYbHUjnEFJoY4neFf3X99Hr0xG03+0YdIIGEkncktT+3wVrbvhII1gYvzOoCe/wWO9LYwIkU7E2PZwjdyxbMtWhV5VMQVu7TCT9lRDy9x360xTv54C1Q9w/drUuApDAoClGktZ2itsAMhAJYdzsK9vK9ZTtpfYUwj9W6W3Nyesw7chu9BbUEXL4vKznZBDxeVqcPXgEz7enZ6H6GWY0EN2HL/et3/ewc5sOpCiIN4XTCwTmx2UImruJigJe4LPsT pyFfx9Ps T/Gh+7R9IJnzChejf3l72HJ3fQEYk6sMZ/+6D2SY687zILlTTRvKOd3bp6BaZzIaeF72LIYLIV43qjdxCBsfg6ZAzkSALbagpYx2u9zTyc+0qFGDrM+lyJFZEgwwUDVlpHOL8g+JnhANAS38bsX0Kojwp5/VX+01cJAHy2RwS4iTObKVZXgmUK1Npl+f+kwIiphWlbRD3lQzi7uk8+S4iOU54ZvcaV/cHw2uYVH3qv7xoZO9/zEArAvUN30u4ArBeLKzOdJqS/cVrcP39+DgE6q/HRmQyfHTUnhbhEu4uoqQgvh/nmVEptfIKdBEpqj1OYRCBhTo9/guX4y5oDcTj30oCL5tWSiaORlkQ4SHPWms/UUemPoCqFMnkaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Static variable 'purge_ndoes' is defined in global scope, while it's only used in function __purge_vmap_area_lazy(). It mainly serves to avoid memory allocation repeatedly, especially when NR_CPUS is big. While a local static variable can also satisfy the demand, and can improve code readibility. Hence move its definition into __purge_vmap_area_lazy(). Signed-off-by: Baoquan He Reviewed-by: Uladzislau Rezki (Sony) Reviewed-by: Shivank Garg Tested-by: Shivank Garg Reviewed-by: Vishal Moola (Oracle) --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 6ee7fc2ec986..aca1905d3397 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2128,7 +2128,6 @@ static DEFINE_MUTEX(vmap_purge_lock); /* for per-CPU blocks */ static void purge_fragmented_blocks_allcpus(void); -static cpumask_t purge_nodes; static void reclaim_list_global(struct list_head *head) @@ -2261,6 +2260,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end, { unsigned long nr_purged_areas = 0; unsigned int nr_purge_helpers; + static cpumask_t purge_nodes; unsigned int nr_purge_nodes; struct vmap_node *vn; int i;