From patchwork Wed Apr 16 09:44:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Linxuan X-Patchwork-Id: 14053577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9CAC369BD for ; Wed, 16 Apr 2025 09:45:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5B1C28010C; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6894E280106; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FCCC280110; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F0A0328010E for ; Wed, 16 Apr 2025 05:45:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 40E901A038D for ; Wed, 16 Apr 2025 09:45:04 +0000 (UTC) X-FDA: 83339423328.13.075738E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 2AE6B80005 for ; Wed, 16 Apr 2025 09:45:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TCGReCd0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796702; a=rsa-sha256; cv=none; b=bW6jbFko0m8tYPhZwpAJE75BjMD06jfsjgoZLOzj6GVHtVmoKA0f64uyEecBLCzhmcbkcZ KMscfffsnpJ9NKcoPVijafZjr0qqyI7Kz0KwDMuzsT5ev0KjASrv/mkubytWs5WuW9mHsw Da1J01lBkWkMfqEYXOgGfKgd+ev3Ks0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TCGReCd0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796702; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u/LAtqMeKnA77r5Dsc94hdGIrPMcLlDF9K9nzAbgXyA=; b=EeXKEbpEDdbJXeoKqZgGQscKYP0u/pgbYH28p8G1Kxr5Objzlf8T02ekYPBWuk2BodUqr7 68pCqU/kxK7+sxjfJWj2pRsVHfWvEdFzqA0rF2JosAWbSJ1t1AakZHZ/S9QYY2J17nFvoP wHEtDIjE6FLpcNtbHfJ/CsgIscZ2wrE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CCF774A194; Wed, 16 Apr 2025 09:44:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id A0A10C4CEEE; Wed, 16 Apr 2025 09:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744796700; bh=yYZIxP4eDVftHS+35Bjf5qEDsqvjLlou31P6uZ50WKA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TCGReCd0cEKmjkNtA7we6hJ+GgtymTTF7EuDFkMlXZKe5wQlwsumnY9tZSo8n/zc0 21ZWbI5r6KRGErwMi/dDmuJtq6LOYx5KnF6rQAkObQzUH1wnEbvHi1QdVsGZGj66Wc iY9cZAuM2Paaseb0Z1i6tZQ+1dTavp5c1wjtPZ/oqgkQnPRfMz+OnjllQ1rcVro0rM VZh5ZWbJHfGbIG4RrEM0zxtOdldbySwtzy9Ww0oal39Ur7u7wrd+xv6m+0weZFe85Y psks7hifOw+5lMCNPBDniJkrqtuqj68pw832qf0OXJZFFUQ3CdlwVaxWsWotQ1vOR1 c3GCbBPLxVB7w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D974C369C4; Wed, 16 Apr 2025 09:45:00 +0000 (UTC) Date: Wed, 16 Apr 2025 17:44:48 +0800 Subject: [PATCH RFC v2 2/5] mm: add __always_inline for page_contains_unaccepted MIME-Version: 1.0 Message-Id: <20250416-noautoinline-v2-2-e69a2717530f@uniontech.com> References: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com> In-Reply-To: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , Chen Linxuan , Changbin Du X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2614; i=chenlinxuan@uniontech.com; h=from:subject:message-id; bh=ttFdjRheVD1OZ/EkBldHAgXU1FfcO+q/qyDgNDO6xxA=; b=owEBbQKS/ZANAwAKAXYe5hQ5ma6LAcsmYgBn/3wWMkdWR1YmxGEaQM5rETmyOEwb9WgsyzPib 4h8ODg1HWCJAjMEAAEKAB0WIQTO1VElAk6xdvy0ZVp2HuYUOZmuiwUCZ/98FgAKCRB2HuYUOZmu i+cdEADNT/9txgL8kjyC/wPjKEbB4hl/RFInpiCxVodRBNIWw5wpfvJ5vsG8gnTV28kQFDiRMbh hKll+Yo1pN1WQwmBS3d0F7h/e18CCNShQvLvfLAloblN1i7M1UgnmKeKL76XXDUKRxxqrQeTHDP CUMus0UtivuKibqn8CLVq6e5fbJ1RhwPsbv7D70xVHOM74/icwjmj1dPZu6DpYDfV5l00GYGS2b RsSbfDKkS9Y3H0ZIRiS3VMyQ2uK/1lqDTRcNw69OTDtKzeRDqUXkzTmAkZ1yo+XWJbU05MQnvN9 95PO/4u9U8yOzdSEY/JzzWE8B1jzPggCyIQR3AoEtU8sfvLzO8U1ro3Jw17/wQxZ0LL4csNqfmo fMDkPLMBwX4axRH3oyhhJpWNuOne+5V4FZe7ofqs5chLYTiWmguAJff7K3CLwNjtYf9wekUajng MeEUFOGz9PS4je56fpstwRPl0osMBPmAQhMUflHy8jGVX4Ai+mMmo72HfvLkq7gg2eqgpyQBohN pVdOVMQI8YGR2JwWxAFHXkIHE7b4wdHwN4V18J30GXbYxJ/TDPKqwiiNz0eQmx1nF4kWUuws9WK FifDNoUxHM5cv3Bi8sey0k3QP5FiIx0iDAMhW+1X3ikwX72hN0Whkhv84Sn5/keiJ0X/R0RCmo5 d/FA4FSNrATMSUg== X-Developer-Key: i=chenlinxuan@uniontech.com; a=openpgp; fpr=D818ACDD385CAE92D4BAC01A6269794D24791D21 X-Endpoint-Received: by B4 Relay for chenlinxuan@uniontech.com/default with auth_id=380 X-Original-From: Chen Linxuan Reply-To: chenlinxuan@uniontech.com X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2AE6B80005 X-Stat-Signature: hox8w5z5rtc57cne3gynb6ergs7mywr9 X-Rspam-User: X-HE-Tag: 1744796701-152555 X-HE-Meta: U2FsdGVkX1/p9PaJWi5+kMEcJOdV6zd63IX0FDZ9if8p8+R9Dm0yeoJwoK7zpF4svKFeRGLwUltDP1jPHfnPxqQznIVHStHkwBfkkojXkE/Ys4tfjjMB14psp67ryXT0JCc/Ndr4c/hT6CPw7CMDnatSV767GJ/GWK1umNCTk39wgZbCEjo1KwXw/wudwOopZzNZI+DlcIBYjmOcvYc4w5OZ8ySR70qDjkkSACOrIn+cAiVLNUhi6wISF8Gpqtna7aOhrXoKaNYY5MNMMYqraIDMDpjx/uhV0pUgRqk2SakSoPybAxhOPJv+jPsBJsdgXr5ExBYkBZqKlODUtUQAQOXMO2PCawZG98LCKv8sR/wQ5UH5qaaKZCxmxmgAteNbb/xvHEpaj+H1x+nqoUUfYlPEL1VSallPDMXx10oPCV43HoCdvzttwRo5duD+2sBsIiznxpZ8+cQERKSJTKXcImN1BRKCc9m2Wvw6dWlUnaem9CN2Nl7m6a4Sm2lGXjUDY4fiVDyENE+noSBZotgD6OU4vVPUfbe+7IC6RNF/+vdns4yMUuU4etep14bCmB289jkdRFELeLwFMr2/jIvjORTW8EYqt3wDCdbSgZMtVt5D+ufxPKV/A6/ZQ4P5EYGslK7mEJJpxpmCTf2UnfcgRcJFYbFSvVx99qxC1RhRYGLUjV/PvAELF6zX4LPgvwiy/tnnkXYc2fnoQhAgKY/M0zmSDVPV6lMSUqontFcDLZTEaZ4wxCWexpT/7NHjf0YLZ0u1CN4AVRBoPSJCET+BiVIEIRp8ZFatcoxMYFWMmdJKsvpCZvRY3kzvqcsPEvD4dct4ojFrM5a1qV2z7rj/YipzI+sOkMXd9jbPaIjAkYQMgfgVi8JVkagxLjAr+QcZ7PGkmqc53HgvoJi+BLpiBZCf6Na5pAWvcd9cSwBOZc6p1qX2lqoxpYmViQxR/zIg+l+SpDo7XLOY0WgkEq/ p2CoCCFQ 3g1WgdNlIRB4LZNL9KZFFizX8vhog2Ht8m93DQHOo8hSnOnwd4DOCu1wkfGsy112FS+dp6WmTZBgshvPhtb5Rcb+wcTsQE4Vldh5RmfpPB1eJxAGOsKR7TVz7uKW0wPH1YbL6s+wDZ4tgIf+MwvSnT9SeZFrgHfDh/xhB/VgGxN1D8vDpbFkJ5b8EE7fhU0y1RGxv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chen Linxuan From: Winston Wen On x86_64 with gcc version 13.3.0, I compile mm/page_alloc.c with: make defconfig make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" \ mm/page_alloc.o Then I get a compile error: CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC mm/page_alloc.o In file included from : mm/page_alloc.c: In function '__free_unaccepted.isra': ././include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_1013' declared with attribute error: BUILD_BUG failed 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert' 538 | prefix ## suffix(); \ | ^~~~~~ ././include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert' 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ mm/page_alloc.c:7301:9: note: in expansion of macro 'BUILD_BUG' 7301 | BUILD_BUG(); | ^~~~~~~~~ Marking page_contains_unaccepted with __always_inline and let dead code elimination remove reference to __free_unaccepted() here. Co-developed-by: Chen Linxuan Signed-off-by: Chen Linxuan Signed-off-by: Winston Wen --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index fd6b865cb1abfbd3d2ebd67cdaa5f86d92a62e14..7c0934c818ddc719c2dcb813599708f47d56352c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7286,7 +7286,7 @@ static bool __free_unaccepted(struct page *page) #else -static bool page_contains_unaccepted(struct page *page, unsigned int order) +static __always_inline bool page_contains_unaccepted(struct page *page, unsigned int order) { return false; }