From patchwork Wed Apr 16 09:44:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Linxuan X-Patchwork-Id: 14053578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81796C369C4 for ; Wed, 16 Apr 2025 09:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECABF280106; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EE1A28010F; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FAA5280111; Wed, 16 Apr 2025 05:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E8DD028010C for ; Wed, 16 Apr 2025 05:45:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 358B416027C for ; Wed, 16 Apr 2025 09:45:04 +0000 (UTC) X-FDA: 83339423328.16.A614C53 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf25.hostedemail.com (Postfix) with ESMTP id 2703FA0012 for ; Wed, 16 Apr 2025 09:45:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hpeeedmw; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796702; a=rsa-sha256; cv=none; b=GQfU+uAwVsy1HubU2DfDLlGFwQAR52XrXEA8eGXHGnDe6+tTXT9tnIMDGHw4Zn1Bi2fRvB jsONhaPliVFOWDRJWuqAtlApDe21FmcEwWMv+8QPuCz5YjFn8RDGfIjps+flFJTEe4wAdo XwsFx3FiRHjsgATthF59trYWAggFeGQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hpeeedmw; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796702; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvB+keRFVzVh1DJYGIb8LucwQ+6rtbU+9S6gxZ2xZTA=; b=rViq8xi9ITyn98e7PrLpyJnUL3QvMW7F2z6LaG9HL1IGAVl8usYu5JPpcVrHT+aeydT0Bk bZ45h8kR09zBHFX1H/+lTc6VuBFPGb1Aid7cRLz51xCmqV5H9mMSPeD/am7mCgapesqUtE DxvqHaBB/RT6dU86x6KUQAatwrCkgaw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id ED4044A26E; Wed, 16 Apr 2025 09:44:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id B9C51C4AF0C; Wed, 16 Apr 2025 09:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744796700; bh=GjcjBI58OgkVj8A5MLEXwdxEl+hceaKdCujeEc2HSq8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=HpeeedmwxModiIUGwGODlYHdZ5Ouui4lrihbjt5fwrYe1597/V78+LnWA5mkeCTZR yYWR/bI5vYw5OTg+APj7OOunCrZ0+KiD1AziH2HhopWV/3/3kYz/j8VDF8mjvKZgJ0 bWS2lBz/6K8LzgX/DRzlbN7IrXUzZP+Ndnd0A6QeduGQFdXj1cRRvygc7fH46VvN6g NR8bXb9VlE1fhkapaO/1mzub3KaJ6u8Ddqeo5IQj9uHkP9HLJ0783ZMLVV4SLrHfpZ IZnt2hxhV4YuTZ0a4owR7onUEWfN2tBfeGHRAdZFAE63b3ZNNwdxv67/Yubkt0pnya ExIwjPbPhRTvg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE6AC369C5; Wed, 16 Apr 2025 09:45:00 +0000 (UTC) Date: Wed, 16 Apr 2025 17:44:49 +0800 Subject: [PATCH RFC v2 3/5] vfio/virtio: add __always_inline for virtiovf_get_device_config_size MIME-Version: 1.0 Message-Id: <20250416-noautoinline-v2-3-e69a2717530f@uniontech.com> References: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com> In-Reply-To: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , Chen Linxuan , Changbin Du X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3264; i=chenlinxuan@uniontech.com; h=from:subject:message-id; bh=PuGcJxOd8DayapVsQ7YIhWxmF6aRHfRlTC8JQBmNN9k=; b=owEBbQKS/ZANAwAKAXYe5hQ5ma6LAcsmYgBn/3wXtW1weup2hT4Z+Yi7yoKEwnZs3b7CyORfq Xvvrwno7P2JAjMEAAEKAB0WIQTO1VElAk6xdvy0ZVp2HuYUOZmuiwUCZ/98FwAKCRB2HuYUOZmu i1tpD/9a1TgfBtJrQZp06BwLsq7szJqErUQ8zTs0NqXhMPs3oGvshKi5/TpP/fH2XNZsqCCmTrz EtRpJ6f358wwfWUO6ys8nznwN7yNLcVVL8/qeEfHcZNbaRmoB1xRQ6GKvyJG7BAWR8uH4oub3GH bpSELAUuBC3xjihAlngAnlycH8/MAHxYjAXaQKGfcFsHCmx8GsshG2zAyRxH1CwrPxy5cfE4plC Zv3YiC8Ee4UmznjWnqVs31WWKs//iFnwfYHrFvo97dOU4PNCv/ZWRp+HoExOd5x863v/jYnOH9B F1c0lU4TGvUiOghX8v6ULJ1QofhSuWfJq5oYZSRc0o94MVpVjkfbuJqrfLHtF/6MgvoN0ne1h/T yx3KItyQEYvUgfT/sQ+bbN2s8pTQL4MI0qI9F/p04Tgp9N4R58vkOYKqdP6Dqet6tIhX3SdxrgX BY4XhL0HxUUfpgPjp3pykTxv03TG+ETBHlrNzbYrz5iaIFt3XUqFkDT3hCXVj16IDA4ilqjHn5R KaBpzLHTr5Q80Ao7V14YGMflufW3NFQXMu+pw22boy/8lsiFcKKmdzoM+giVIGfVUXS5ObqO3+i EktURcgQB8LRFDMgM7DfcJEzzT9XXuThlEfmJQ33+OMZ0B9S+kEvpXTSBUSiLuOA/4AtnAZNhse DjYNXNAakI/Vl6A== X-Developer-Key: i=chenlinxuan@uniontech.com; a=openpgp; fpr=D818ACDD385CAE92D4BAC01A6269794D24791D21 X-Endpoint-Received: by B4 Relay for chenlinxuan@uniontech.com/default with auth_id=380 X-Original-From: Chen Linxuan Reply-To: chenlinxuan@uniontech.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2703FA0012 X-Stat-Signature: hy8psyhijf874u674m1fugrubh8jzxos X-Rspam-User: X-HE-Tag: 1744796701-541474 X-HE-Meta: U2FsdGVkX19dOOUWfybmwo/EDxg+0AOAmtg7SS3mKLX4x6BdanNYl/OjjZ9n7j39mQ6YCU2+Wr/LSFT9MBbqXsomhZsQQvbyDzD0yMWiKM7LmQyyotURBuNZp8DV5+p7sxs1CfzSCdABM64nDI6ugMk6tHP2bBRcMiTByX3uI5Xz4/8+FdhJ/zP79yt55NvWbuArBtUxjulq+jynWBpDiGG/lx2mY/ps5QPr5S5svX5hGiC8hNNze1lICS5dqP/Subd6RqCXeqIxnxj7Y79HupQMpCrSYTZhEGJ1N67YN/E4dQ7IUV7T4qSS6RiIC8ZTt+Rxc6VOtemjEE0+TZ6TkuoQqSrEJufp1q8/LEMaYtbHz0UIQxY+cC5foQ1mv3Fy4P+s8h4SjrvFiZJ3ln9Z34YscgiNsL+DM8Ye1RdSLiUEDQM6ecWYy9D9TffvG0U6vkUZGmBTX716zZQlFbvrZyUr7gmhllL4Lhf/mJg7gulT2XkhUwGTUHY4pm5wOE7aUNbeLFDjRxdJeusnmuNZyy/whIIT2IGDDEvIiZmsh6OZeRYny+zzUQxhuRLCLOebYb0FA/pTkLxtRB1I9ZqGN7+c+50dZCWr1NleM9QmLxJ5ga+rtpqPjpoFtB7DHUPkMO3XYWX7aEsXRUnfIgBOc58MjYQGIvFvvsnhGJkDqy/UPC5sbfr7ZFr/irZ4BYMHkxsdPxlsu9R9tiUnUU7jYJH4eDWY1/QqwcqJy5bib3QyskWt5Qg664AjFvKyjkPhT/Go+UExY845YFhE0Pq1XW3kD/GFdaL2YUMVe/emb6Ut/QjJOY9svqt5CgyqDILdrD5R5pTY+OdLAP3Fe1ZZuZrwAIweN+n5YqJAdjOtS7zm89F1QCOWocCEcxzLR17wx9ZpA1Kv2VLUunj+urSyYxwXJOvlO4igE1I5XPuENH0sPRbsvrGkcsRuflN3qFHnBcZ/9leqkMEzL4xpm97 zW3upBUk EW5MTW7ubuCBwMVcQVjBGvqZK8bdwcUqIjU1pXrQ6jxdS2qUxhOa7+yWn36gRtLrbTzT42T2pU6BiTwg3q5vQPsuA91vsK0peaCqnvA+y6ReMzhXJZfYUta6PrTrbANeDmnNtaettAWxVAv1iUd/k5h2FgYwzfw+rWLUsLzycTv8m2fVDUbhxGXhcssGwUxFHPYEipCz0YPXy+o0OBUsWkH4OeqTPCrTX5cjSA+InyBc6O14KZh4QvtfzzljKBpoUW6pgVdPHu0WCMw0BH9rbxjdHyikVtix3rO7YxIwQ56ED6+5AP2YsN3sd6kQ+QdwSz333OV3b0TGAKbb+QSifdhNGzw41iFj4LnjzsgTl72gQOaX/pXAC4HK5yN3NKgA8eMxxJ1R1ByhvBUzkGCkQLPvFjrzd2pgLnelcqB8DbJpFBel8WmSn2Yd/nDNdglrBkOVxr1h4QExpbwDznYvtUD6Nm/p6fTeDknnN7W1XXBGcKiXi+ZGMXX/P2Vyq55mzeSVggTmZ7BXuQPG3Ey7qxNeDZv1wzir5SsejqB2J3GXQAvM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chen Linxuan From: Winston Wen Presume that kernel is compiled for x86_64 with gcc version 13.3.0: make defconfig ./scripts/kconfig/merge_config.sh .config <( echo CONFIG_VFIO=m echo CONFIG_VIRTIO_PCI=y echo CONFIG_VIRTIO_PCI_LIB_LEGACY=y echo CONFIG_VIRTIO_VFIO_PCI=m echo CONFIG_VIRTIO_VFIO_PCI_ADMIN_LEGACY=y ) make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" \ drivers/vfio/pci/virtio/legacy_io.o This results a compile error: CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC drivers/vfio/pci/virtio/legacy_io.o In file included from : drivers/vfio/pci/virtio/legacy_io.c: In function 'virtiovf_init_legacy_io': ././include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_889' declared with attribute error: BUILD_BUG_ON failed: !is_power_of_2(virtvdev->bar0_virtual_buf_size) 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert' 538 | prefix ## suffix(); \ | ^~~~~~ ././include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert' 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ drivers/vfio/pci/virtio/legacy_io.c:401:9: note: in expansion of macro 'BUILD_BUG_ON' 401 | BUILD_BUG_ON(!is_power_of_2(virtvdev->bar0_virtual_buf_size)); | ^~~~~~~~~~~~ BUILD_BUG_ON needs virtvdev->bar0_virtual_buf_size to be computed at compile time. So we should mark virtiovf_get_device_config_size() with __always_inline here. Co-developed-by: Chen Linxuan Signed-off-by: Chen Linxuan Signed-off-by: Winston Wen --- drivers/vfio/pci/virtio/legacy_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/virtio/legacy_io.c b/drivers/vfio/pci/virtio/legacy_io.c index 832af5ba267c49a079009cfe0fa93c15ba7a490f..b6871d50b9f9e278ef3c49a9cb2baf474b8271c6 100644 --- a/drivers/vfio/pci/virtio/legacy_io.c +++ b/drivers/vfio/pci/virtio/legacy_io.c @@ -350,7 +350,7 @@ int virtiovf_open_legacy_io(struct virtiovf_pci_core_device *virtvdev) return virtiovf_set_notify_addr(virtvdev); } -static int virtiovf_get_device_config_size(unsigned short device) +static __always_inline int virtiovf_get_device_config_size(unsigned short device) { /* Network card */ return offsetofend(struct virtio_net_config, status);