From patchwork Thu Apr 17 00:18:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nico Pache X-Patchwork-Id: 14054662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD33C369BD for ; Thu, 17 Apr 2025 00:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABE3728013A; Wed, 16 Apr 2025 20:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6DA628001A; Wed, 16 Apr 2025 20:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F8028013A; Wed, 16 Apr 2025 20:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 681B328001A for ; Wed, 16 Apr 2025 20:19:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6109F121051 for ; Thu, 17 Apr 2025 00:19:59 +0000 (UTC) X-FDA: 83341628118.18.6C9E2BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id A9C971C0009 for ; Thu, 17 Apr 2025 00:19:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WQkwKPnX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744849197; a=rsa-sha256; cv=none; b=y7FrBA/3zSVrTl8i+ghif0pZzs174i6E0CcZJkNu4qP8UZUsJheR3wIGEoAvAZv7yC72O0 XpweeG7oahy69mjZnnswLZ8k7SmvSzXnh/0bAshzVkEAUAbqNuXkvfYm2s6/0lWqxXwtOw qOgqLoMPq49dTXQqprL4Afrk9SOyMXE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WQkwKPnX; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744849197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TogelAChT0Lle1lPUcX0qAHNME6QhHVdPZc+FHgLuX8=; b=uPbuZfiqOyL3QCaH90cA43LD695i0AtUNHKD4jxJGkFJYF+rLG5kDL1exIL2wllh5tsgQD uTjVO0wHpNSyahNTmvIfUslTmFU/C/RGqEZL1G/Oy7MCMIa/26I6yDMzFiV9rnBNzXXXAj tBprCSZh5jrLoXZVtwaGpyZgl/RpCFg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744849197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TogelAChT0Lle1lPUcX0qAHNME6QhHVdPZc+FHgLuX8=; b=WQkwKPnX1RETDYsTwYlKAQ2bNj7WRjZo8CVlA9wP2R8Wti5q9hRo88rd0rQGs09bBzjrCN QNLGtcUmNCcb9GT4VTH1IYhw9X6/fp1jh4HmZHfh26J8H/bijGUnO8fTeRBAvkkLIx2Whb 95Fkukb5Te6gjUJLtwD3i8Al8ilPXCo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-gkc1jhT1M-iRXEJasmR8WA-1; Wed, 16 Apr 2025 20:19:52 -0400 X-MC-Unique: gkc1jhT1M-iRXEJasmR8WA-1 X-Mimecast-MFC-AGG-ID: gkc1jhT1M-iRXEJasmR8WA_1744849188 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A88101956087; Thu, 17 Apr 2025 00:19:47 +0000 (UTC) Received: from h1.redhat.com (unknown [10.22.88.34]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2E1A619560B8; Thu, 17 Apr 2025 00:19:38 +0000 (UTC) From: Nico Pache To: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, shuah@kernel.org, ziy@nvidia.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org Subject: [PATCH v4 1/4] mm: defer THP insertion to khugepaged Date: Wed, 16 Apr 2025 18:18:43 -0600 Message-ID: <20250417001846.81480-2-npache@redhat.com> In-Reply-To: <20250417001846.81480-1-npache@redhat.com> References: <20250417001846.81480-1-npache@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A9C971C0009 X-Stat-Signature: z981odcyrpx48h7347kiomkeoygudxeh X-Rspam-User: X-HE-Tag: 1744849197-521525 X-HE-Meta: U2FsdGVkX18kpzondc76a4P24fMx+nrVvAgNi09L/fpHwMt+L1ydwvbBOuPDVSlVnsG/KuKZgNd/RxE1lYA1UhN4jULmoSxGQNnTRvSQ/wy4StYYp4AObnf/h97EOS8RxqFK5SQJALr0km3LUo3nJgyjIp8mxaBaoL8xsQZ1vbtjHEv4GbdGHDwhCHFuyyzxXgjhObboRnOkV8ugK2cDbXHqKkKkP2ttbvcZ78fau4o0SP9rZx5TAKCBZR44RVcCPnTKzlsWnoS0FJ6Wbaejkw/fZq2MeGSKwqTVwil0gj790b9erpjZRqjjZmZNzUScx599IUavKKT7RnUc6+iVGLIkadNfPKyRPpv0KwaF1RqYQhaQKUGQSrbrF0P3n+C5Bo0h49QA6W85ubyru8z1QDIivkBdci6eKMEv9J+BneLx1VfX1uHTAnLIqS4ruAVqXgrYn56WUAev6/25Tyl0m8gruY+UOvZzq804OE56AR0Rmy20i1pD2vWgCXmSKwDm+/cLlvhisn+Ls6toPcmoKHk2vYZfgqsYWgTyG0xHUztfi7yGZSPfTbjnpiCLgUQ/OnnYRljfNm+nqRzZ3Npofctw3znMOWE82uS0GH4BS80NAFJQ2uq4O+Yx9t2Rhn0bjwztUNcrkF3DxrbgzCLHrPr1e3XAomwbn5Gqtgk5xf+mJvoIrrNTzGTvmlph5itlEF9fvEjBoWABDVFMS+YOQlSN/pjeZ5XA5Lo0zwyaY1H+Dk82a6W8vdFiiAv83RxW9kcNNwWzWkrfrAn3D2llCHQsfLFcaJpaHXPShepbFmTrISUhmdjp43+ZDdbYApHQTFzM5c7nbne7eJnmauX3BNgGinPTg9l5NRHnY6X4qFHeech6RPWqkX/KWVYPedYY9SF/FaH8THKwaXStCIcLRcozxK3Y2sS0wQK64GwC9SBnfmv7cLw72dKmn2MXLS9+XyNVET2i3YQ1SRxQuzv HSyomd2h aiY36WC+deO3y65jWVSOehQDVLEPyFj023JuwDSFFdY22SqWcS0H5oqhotUtd7CJ5+Qzy24WbNF6wXKZ02h+FTFroIf44iFExdTCEbcyhCKHWAr2U7vUKNJ/YRtmkypCHthhgnqMiIX/SkDpPSlwUG3vpVYWm6/PJtHaAp6q20Ozf7Gp+olIG849c4htcYdf+SH7DP+nfJaQKhMVaOS3Fzxlx+j6FeXMh7wMmuM0kIyHD96x0q/4EQ4HE4LHSws0mqB7LAALRcAcHpA3DSaOFh6zi87Nbm8A9NKMOKDb0TGkpq69fDhyfUTfL8GnaOoDz/aXSGl+DjUS7Xkv+koqURFDrHRUURkAKMnKHK++DMvEiglzptG0yMWfQ1FCi2UnDgt2gAPYwglGz6lKNPZlUzhxIkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: setting /transparent_hugepages/enabled=always allows applications to benefit from THPs without having to madvise. However, the pf handler takes very few considerations to decide weather or not to actually use a THP. This can lead to a lot of wasted memory. khugepaged only operates on memory that was either allocated with enabled=always or MADV_HUGEPAGE. Introduce the ability to set enabled=defer, which will prevent THPs from being allocated by the page fault handler unless madvise is set, leaving it up to khugepaged to decide which allocations will collapse to a THP. This should allow applications to benefits from THPs, while curbing some of the memory waste. Co-developed-by: Rafael Aquini Signed-off-by: Rafael Aquini Signed-off-by: Nico Pache --- include/linux/huge_mm.h | 15 +++++++++++++-- mm/huge_memory.c | 31 +++++++++++++++++++++++++++---- 2 files changed, 40 insertions(+), 6 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 782d3a7854b4..b88cc3154ec0 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -48,6 +48,7 @@ enum transparent_hugepage_flag { TRANSPARENT_HUGEPAGE_UNSUPPORTED, TRANSPARENT_HUGEPAGE_FLAG, TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + TRANSPARENT_HUGEPAGE_DEFER_PF_INST_FLAG, TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, TRANSPARENT_HUGEPAGE_DEFRAG_KSWAPD_FLAG, TRANSPARENT_HUGEPAGE_DEFRAG_KSWAPD_OR_MADV_FLAG, @@ -186,6 +187,7 @@ static inline bool hugepage_global_enabled(void) { return transparent_hugepage_flags & ((1<